Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep backup size guidance consistent with the live chart

pulse-triage[bot]3d69a8e76e96
diff --git a/docs/RECOVERY.md b/docs/RECOVERY.md
index 245a5b62ce..4159d72307 100644
--- a/docs/RECOVERY.md
+++ b/docs/RECOVERY.md
@@ -59,12 +59,18 @@ answer different questions:
even when an incomplete entry has a size or a verification flag. The total
covers the loaded inventory, not just the rows matching your list filters.
- **Completed restore points per day** also requires a known, non-future date
- within the selected chart range. An undated completed point can count in
+ within the selected chart range. The chart follows the search, node, type,
+ location, source and entry-state filters, unlike the inventory-wide Backup
+ health total. Selecting a day narrows only the list, not the other chart days.
+ An undated completed point can count in
Backup health but not in a daily column. A blank chart is not proof that
no backups exist; check any inventory loading or access warning first.
-- **Completed restore volume per day** adds only positive reported sizes for
+- **Known restore volume per day** adds only positive reported sizes for
those dated completed points. A point with no reported size can count as a
- point without contributing volume. These are recorded artifact sizes, not
+ point without contributing volume. It remains selectable in **Volume** and
+ counts normally in **Count**. Amber marks days with unknown sizes, not zero
+ volume. When a day mixes known and unknown sizes, its known volume is a lower
+ bound, not a complete total. These are recorded artifact sizes, not
PBS datastore usage or deduplicated physical space.
- Guest **snapshots** can contribute to completed-point and chart totals.
They are not independent backups and do not fill Coverage's **Last backup**.
diff --git a/frontend-modern/public/docs/RECOVERY.md b/frontend-modern/public/docs/RECOVERY.md
index 245a5b62ce..4159d72307 100644
--- a/frontend-modern/public/docs/RECOVERY.md
+++ b/frontend-modern/public/docs/RECOVERY.md
@@ -59,12 +59,18 @@ answer different questions:
even when an incomplete entry has a size or a verification flag. The total
covers the loaded inventory, not just the rows matching your list filters.
- **Completed restore points per day** also requires a known, non-future date
- within the selected chart range. An undated completed point can count in
+ within the selected chart range. The chart follows the search, node, type,
+ location, source and entry-state filters, unlike the inventory-wide Backup
+ health total. Selecting a day narrows only the list, not the other chart days.
+ An undated completed point can count in
Backup health but not in a daily column. A blank chart is not proof that
no backups exist; check any inventory loading or access warning first.
-- **Completed restore volume per day** adds only positive reported sizes for
+- **Known restore volume per day** adds only positive reported sizes for
those dated completed points. A point with no reported size can count as a
- point without contributing volume. These are recorded artifact sizes, not
+ point without contributing volume. It remains selectable in **Volume** and
+ counts normally in **Count**. Amber marks days with unknown sizes, not zero
+ volume. When a day mixes known and unknown sizes, its known volume is a lower
+ bound, not a complete total. These are recorded artifact sizes, not
PBS datastore usage or deduplicated physical space.
- Guest **snapshots** can contribute to completed-point and chart totals.
They are not independent backups and do not fill Coverage's **Last backup**.
diff --git a/frontend-modern/src/features/docs/__tests__/completedBackupCountsDocs.test.ts b/frontend-modern/src/features/docs/__tests__/completedBackupCountsDocs.test.ts
index 20ea2a5117..9f5574998e 100644
--- a/frontend-modern/src/features/docs/__tests__/completedBackupCountsDocs.test.ts
+++ b/frontend-modern/src/features/docs/__tests__/completedBackupCountsDocs.test.ts
@@ -2,7 +2,10 @@ import { readFileSync } from 'node:fs';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import { describe, expect, it } from 'vitest';
-import { buildBackupActivityTimeline } from '@/features/proxmox/proxmoxBackupActivityPresentation';
+import {
+ buildBackupActivityTimeline,
+ getBackupActivityUnknownCount,
+} from '@/features/proxmox/proxmoxBackupActivityPresentation';
import { COVERAGE_COLUMNS } from '@/features/proxmox/proxmoxBackupsTablePresentation';
import {
isCompletedRecoveryArtifact,
@@ -49,14 +52,22 @@ describe('completed backup count guidance', () => {
expect(read('frontend-modern/public/docs/RECOVERY.md')).toBe(read('docs/RECOVERY.md'));
const copy = text();
const tableSource = read('frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx');
- for (const label of ['Completed restore points per day', 'Completed restore volume per day']) {
+ for (const label of ['Completed restore points per day', 'Known restore volume per day']) {
expect(copy).toContain(label);
expect(tableSource).toContain(label);
}
+ expect(copy).not.toContain('Completed restore volume per day');
expect(tableSource).toContain('aria-label="Clear date filter"');
expect(copy).toContain(
'covers the loaded inventory, not just the rows matching your list filters',
);
+ expect(copy).toContain(
+ 'The chart follows the search, node, type, location, source and entry-state filters',
+ );
+ expect(copy).toContain('Selecting a day narrows only the list, not the other chart days');
+ expect(tableSource).toContain(
+ 'Activity follows the backup filters. Selecting a day narrows only the list.',
+ );
expect(copy).toContain('Selecting a chart day filters the list');
expect(copy).toContain('Clear date filter');
expect(copy).toContain(
@@ -87,6 +98,7 @@ describe('completed backup count guidance', () => {
});
expect(dated.points.reduce((sum, day) => sum + day.total, 0)).toBe(2);
expect(volume.points.reduce((sum, day) => sum + day.total, 0)).toBe(100);
+ expect(volume.points.reduce((sum, day) => sum + getBackupActivityUnknownCount(day), 0)).toBe(1);
const copy = text();
expect(copy).toContain(
'excludes both, even when an incomplete entry has a size or a verification flag',
@@ -95,6 +107,9 @@ describe('completed backup count guidance', () => {
'An undated completed point can count in Backup health but not in a daily column',
);
expect(copy).toContain('no reported size can count as a point without contributing volume');
+ expect(copy).toContain('It remains selectable in Volume and counts normally in Count');
+ expect(copy).toContain('Amber marks days with unknown sizes, not zero volume');
+ expect(copy).toContain('its known volume is a lower bound, not a complete total');
expect(copy).toContain('not PBS datastore usage or deduplicated physical space');
});