Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.
Go aialertsdashboarddockerdocker-monitoringgohomelabinfrastructure-monitoringkubernetesmonitoringmspproxmoxproxmox-backup-serverproxmox-mail-gatewayproxmox-veself-hostedtruenastypescriptvspherewebhooks
Isolate legacy removal models and retain bounded-read diagnostics
pulse-triage[bot]3e154e6795c4
diff --git a/docs/release-control/v6/internal/subsystems/deployment-installability.md b/docs/release-control/v6/internal/subsystems/deployment-installability.mdindex 9608964e60..84bc546d61 100644--- a/docs/release-control/v6/internal/subsystems/deployment-installability.md+++ b/docs/release-control/v6/internal/subsystems/deployment-installability.md@@ -5027,6 +5027,16 @@ retains source-listed package/API coverage and actual start/finish CPU leases;missing terminal entries are not passes. This repairs a scheduling fault, nota product defect diagnosis or qualification of the interrupted candidate.+The legacy FreeBSD/SysV removal controls select the native runner's Python+interpreter with `-I -S`, as the existing NAS controls do. A private site-hook+adverse control proves that ambient startup output cannot contaminate manager+readback. Five-second production observations and all refusal/retention rules+remain unchanged. Fixture failures retain fixed model roles/numeric bounded+command exits, observation counters and modelled state rather than only the+generic production refusal. The earlier stopped-FreeBSD fixture failure has no+retained per-operation result; isolation fixes a demonstrated fixture weakness,+not an established cause of that historical failure or native removal proof.+Activation-only recovery must distinguish the immutable binary packet fromgoverned release-note presentation sidecars. Release run `33223712880` passedits immutable readiness join and retained draft release `378812881`, but itsdiff --git a/scripts/installtests/agent_legacy_teardown.py b/scripts/installtests/agent_legacy_teardown.pyindex 51dc2a0587..244c464730 100644--- a/scripts/installtests/agent_legacy_teardown.py+++ b/scripts/installtests/agent_legacy_teardown.py@@ -12,8 +12,10 @@ from pathlib import Pathimport shleximport statimport subprocess+import sysimport tempfileimport unittest+from unittest import mockROOT = Path(__file__).resolve().parents[2]SOURCE = Path(os.environ.get("PULSE_AGENT_LEGACY_SOURCE", ROOT / "scripts/install.sh"))@@ -36,12 +38,12 @@ def functions(source, names=FUNCTIONS):return "\n".join(result)-MODEL = r'''#!/usr/bin/python3+MODEL = r'''import json, os, pathlib, sysroot = pathlib.Path(os.environ['FIXTURE'])path = root / 'model.json'v = json.loads(path.read_text())-role, a = pathlib.Path(sys.argv[0]).name, sys.argv[1:]+role, a = sys.argv[1], sys.argv[2:]fault = v['fault']remote = (root / 'events').exists() and 'remote:remove' in (root / 'events').read_text()def save():@@ -125,6 +127,14 @@ else: raise ValueError('operation outside private fixture')'''+def model_launcher(model, role):+ # Like the NAS controls, use the runner's selected interpreter and only+ # the standard library. Ambient site hooks must not alter manager readback+ # or spend a production observation's unchanged bounded deadline.+ return ('#!/bin/sh\nexec ' + shlex.quote(sys.executable) + ' -I -S '+ + shlex.quote(str(model)) + ' ' + shlex.quote(role) + ' "$@"\n')++class AgentLegacyTeardown(unittest.TestCase):source = SOURCE.read_text()@@ -133,14 +143,15 @@ class AgentLegacyTeardown(unittest.TestCase):with tempfile.TemporaryDirectory() as directory:root = Path(directory)tools = root / "tools"; tools.mkdir()+ model_source = root / "model.py"; model_source.write_text(MODEL)for name in ("ps", "sysrc", "update-rc.d", "chkconfig"):- p = tools / name; p.write_text(MODEL); p.chmod(0o700)+ p = tools / name; p.write_text(model_launcher(model_source, name)); p.chmod(0o700)init = root / "init"unrelated = root / "unrelated"; unrelated.write_text("retain unrelated file\n")if path == "linked": init.symlink_to(unrelated)elif path == "directory": init.mkdir()elif path != "missing":- init.write_text(MODEL); init.chmod(0o600 if path == "not-executable" else 0o700)+ init.write_text(model_launcher(model_source, "init")); init.chmod(0o600 if path == "not-executable" else 0o700)for name in ("state", "helper", "profile"):p = root / name; p.mkdir(); (p / "token").write_text("synthetic recovery only\n")(root / "wrapper").write_text("owned boot wrapper\n")@@ -183,6 +194,16 @@ PULSE_URL=https://same-instance.example.invalid AGENT_ID=syntheticACTION_RUNNER_NAME=pulse-agent-runner PRIVILEGED_HELPER_NAME=pulse-agent-helperlog_info() { :; }; log_warn() { :; }fail() { printf '%s\n' "$1" >&2; exit "${2:-1}"; }+timeout() {+ local result=0 role="${4##*/}"+ builtin command timeout "$@" || result=$?+ # Only a fixed model role and numeric exit, never arbitrary argv or output.+ case "$role" in ps|sysrc|init|update-rc.d|chkconfig) ;;+ *) return 96 ;;+ esac+ printf 'bounded:%s:%s\n' "$role" "$result" >> "$EVENTS"+ return "$result"+}uname() { [[ "$PLATFORM" == FreeBSD ]] && printf 'FreeBSD\n' || printf 'Linux\n'; }command() {case "$*" in@@ -409,12 +430,50 @@ remove_safe_profile_state_dir() { builtin command rm -r -- "$SAFE_PROFILE_STATE_for platform in ("FreeBSD", "SysV"):for path, repeat in (("regular", False), ("missing", False), ("regular", True)):with self.subTest(platform=platform, path=path, repeat=repeat):- r, events, before, after, _ = self.exercise(platform, state="stopped", enabled="NO", links="none", path=path, repeat=repeat)- self.assertEqual(r.returncode, 0, r.stderr)+ r, events, before, after, model = self.exercise(platform, state="stopped", enabled="NO", links="none", path=path, repeat=repeat)+ self.assertEqual(r.returncode, 0, r.stderr + "\nPrivate model observations: " + json.dumps(dict(+ events=events, state=model["state"], enabled=model["enabled"],+ process_reads=model["process_reads"], status_reads=model["status_reads"], enable_reads=model["enable_reads"])))self.assertNotIn("service:stop", events)for k in ("state/token", "helper/token", "profile/token", "unrelated"):self.assertEqual(after[k], before[k])+ def test_model_uses_selected_isolated_interpreter(self):+ with tempfile.TemporaryDirectory(prefix="legacy model ") as directory:+ root = Path(directory)+ model = root / "model.py"; model.write_text(MODEL)+ invocations = root / "interpreter-arguments"+ interpreter = root / "selected python"+ interpreter.write_text('#!/bin/sh\nprintf "%s\\n" "$@" >> '+ + shlex.quote(str(invocations)) + '\nexec '+ + shlex.quote(sys.executable) + ' "$@"\n')+ interpreter.chmod(0o700)+ with mock.patch.object(sys, "executable", str(interpreter)):+ launcher = model_launcher(model, "sysrc")+ tool = root / "sysrc"; tool.write_text(launcher); tool.chmod(0o700)+ (root / "model.json").write_text(json.dumps(dict(+ platform="FreeBSD", fault="", state="stopped", enabled="NO", enable_reads=0)))+ marker = root / "site-ran"+ (root / "sitecustomize.py").write_text('from pathlib import Path\nPath('+ + repr(str(marker)) + ').touch()\nprint("unexpected site hook")\n')+ env = dict(os.environ, FIXTURE=str(root), PYTHONPATH=str(root))+ # Deliberate adverse control: the old unisolated model protocol+ # accepts unrelated startup output. Do not turn that into a pass.+ adverse = subprocess.run([sys.executable, str(model), "sysrc", "-n", "pulse_agent_enable"],+ env=env, capture_output=True, text=True, timeout=5)+ self.assertEqual(adverse.returncode, 0, adverse.stderr)+ self.assertIn("unexpected site hook", adverse.stdout)+ self.assertTrue(marker.exists())+ marker.unlink()+ result = subprocess.run([str(tool), "-n", "pulse_agent_enable"], env=env,+ capture_output=True, text=True, timeout=5)+ self.assertEqual(result.returncode, 0, result.stderr)+ self.assertEqual(result.stdout, "NO\n")+ self.assertEqual(result.stderr, "")+ self.assertFalse(marker.exists())+ self.assertEqual(invocations.read_text().splitlines(),+ ["-I", "-S", str(model), "sysrc", "-n", "pulse_agent_enable"])+def test_process_inventory_does_not_return_arguments_or_secrets(self):r, _, _, _, _ = self.exercise("FreeBSD", flow="process")self.assertEqual(r.returncode, 0, r.stderr)@@ -426,6 +485,7 @@ remove_safe_profile_state_dir() { builtin command rm -r -- "$SAFE_PROFILE_STATE_def test_real_process_timeout_stops_owned_child_without_erasure(self):r, events, before, after, model = self.exercise("FreeBSD", fault="timeout-process")self.assertNotEqual(r.returncode, 0, r.stderr)+ self.assertIn("bounded:ps:124", events)self.assertEqual(after, before)self.assertTrue(model["timed_child_absent"])self.assertNotIn("service:stop", events)diff --git a/scripts/installtests/install_sh_test.go b/scripts/installtests/install_sh_test.goindex ee962a9ba8..3212ea2110 100644--- a/scripts/installtests/install_sh_test.go+++ b/scripts/installtests/install_sh_test.go@@ -8815,6 +8815,7 @@ func TestInstallSHLegacyTeardownRequiresObservedQuiescence(t *testing.T) {"test_process_inventory_does_not_return_arguments_or_secrets","test_real_process_timeout_stops_owned_child_without_erasure","test_rendered_stop_retains_pidfiles_on_refused_or_ignored_signals",+ "test_model_uses_selected_isolated_interpreter",}, time.Minute)}