Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.
Go aialertsdashboarddockerdocker-monitoringgohomelabinfrastructure-monitoringkubernetesmonitoringmspproxmoxproxmox-backup-serverproxmox-mail-gatewayproxmox-veself-hostedtruenastypescriptvspherewebhooks
Validate the first version candidate before normalising it
pulse-triage[bot]42794e35f977
diff --git a/.github/scripts/issue-version-triage.cjs b/.github/scripts/issue-version-triage.cjsindex 8352cf5401..537ab49bb6 100644--- a/.github/scripts/issue-version-triage.cjs+++ b/.github/scripts/issue-version-triage.cjs@@ -255,10 +255,12 @@ function isActionableTopicValue(value, report) {function normalizeVersion(value) {if (!value) return null;- // Do not salvage a later dotted fragment after rejecting the original- // token (for example, 6.0.1 inside 6.6.0.1).- const match = String(value).match(new RegExp(String.raw`(?<![0-9A-Za-z_.])v?(${VERSION_TOKEN})`, "i"));- return match ? match[1] : null;+ // Capture the first whole candidate before validating it. A failed match+ // must not resume inside that same malformed token and salvage a later+ // version, even after a hyphen. Trim sentence stops, not version segments.+ const match = String(value).match(/(?<![0-9A-Za-z_.])v?(\d+\.\d+\.\d+[0-9A-Za-z._-]*)/i);+ const candidate = match?.[1].replace(/\.+$/, "");+ return candidate && new RegExp(`^${VERSION_TOKEN}$`).test(candidate) ? candidate : null;}function declaredVersionIsTransition(value) {diff --git a/.github/scripts/issue-version-triage.test.cjs b/.github/scripts/issue-version-triage.test.cjsindex 2d74fe9cea..7e38d35ed0 100644--- a/.github/scripts/issue-version-triage.test.cjs+++ b/.github/scripts/issue-version-triage.test.cjs@@ -4146,14 +4146,14 @@ test("loose-list version declarations inside secondary topics remain topic evide});test("malformed version tokens cannot be shortened or salvaged into another release", () => {- for (const value of ["6.6.0.1", "v6.6.0.12", "6.6.0-", "V6.6.0-beta..3", "6.6.0-beta_3"]) {+ for (const value of ["6.6.0.1", "v6.6.0.12", "6.6.0-", "V6.6.0-beta..3", "6.6.0-beta_3", "6.6.0-beta..-v6.5.0"]) {assert.equal(triage.internals.normalizeVersion(value), null, value);}});test("explicit malformed versions remain authoritative in all supported Markdown layouts", () => {const { extractPulseVersion } = triage.internals;- for (const value of ["6.6.0.1", "6.6.0-", "6.6.0-beta..3", "6.6.0-beta_3"]) {+ for (const value of ["6.6.0.1", "6.6.0-", "6.6.0-beta..3", "6.6.0-beta_3", "6.6.0-beta..-v6.5.0"]) {for (const body of [`### Pulse version\n${value}\n\n### Agent version\n6.5.0`,`**Pulse version:** ${value}\nAgent version: 6.5.0`,@@ -4170,7 +4170,7 @@ test("explicit malformed versions remain authoritative in all supported Markdowntest("title fallback does not shorten a malformed server or neutral version token", () => {const { extractPulseVersion } = triage.internals;- for (const value of ["6.6.0.1", "6.6.0-", "6.6.0-beta..3", "6.6.0-beta_3"]) {+ for (const value of ["6.6.0.1", "6.6.0-", "6.6.0-beta..3", "6.6.0-beta_3", "6.6.0-beta..-v6.5.0"]) {for (const title of [`Pulse ${value} loses readings`,`Pulse Pro version: V${value} loses readings`,@@ -4198,7 +4198,7 @@ test("complete stable and prerelease tokens retain their full value and ordinarytest("malformed attempted archives cannot borrow a valid dotted fragment", () => {for (const stem of ["pulse", "pulse-pro"]) {- for (const value of ["6.6.0.1", "6.6.0-beta..3"]) {+ for (const value of ["6.6.0.1", "6.6.0-beta..3", "6.6.0-beta..-v6.5.0"]) {const archive = `${stem}-v${value}-linux-amd64.tar.gz`;assert.equal(triage.internals.extractPulseVersion("Pulse 6.4.5 install failed",`### Pulse version\n\`${archive}\``), null, archive);@@ -4208,7 +4208,7 @@ test("malformed attempted archives cannot borrow a valid dotted fragment", () =>for (const action of ["opened", "edited", "reopened"]) {test(`${action} malformed-version metadata preserves Community decisions and accepts a later correction`, async () => {- for (const value of ["6.6.0.1", "6.6.0-", "6.6.0-beta..3", "6.6.0-beta_3"]) {+ for (const value of ["6.6.0.1", "6.6.0-", "6.6.0-beta..3", "6.6.0-beta_3", "6.6.0-beta..-v6.5.0"]) {const preserved = ["bug", "needs-retest-on-latest", "needs-decomposition", "operator-reviewed", "affects-storage"];const issue = { number: 42, state: "open", title: "Pulse 6.4.5 update failed",body: `### Pulse version\n${value}\n\n### Additional actionable topics\nKeep failed attempts visible.`,