Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Integrate reviewed Assistant planning controls and saved-policy compatibility

pulse-triage[bot]43c4f50f426f
diff --cc docs/release-control/v6/internal/subsystems/ai-runtime.md
index 30b50b2a63,06e0b64c23..7c91c126ce
--- a/docs/release-control/v6/internal/subsystems/ai-runtime.md
+++ b/docs/release-control/v6/internal/subsystems/ai-runtime.md
@@@ -25,64 -25,36 +25,94 @@@ that same result. Successful reads reta
## Purpose
+### Guest memory remains qualified through tools and local observers
+
+The existing guest get/list/topology tools and Assistant inventory context carry
+selected memory evidence with the percentage. Unavailable/invalid memory is
+null, not zero usage; a measured zero stays numeric. Evidence retains source,
+state and original observation time, including unknown pressure and possible
+reclaimable cache. Condensed query facts retain the same qualification rather
+than saving a bare percentage. `TestGuestMemoryQueryEvidence` and
+`TestAssistantGuestMemoryContextAndFacts` check the real tool/context/fact paths.
+
+The existing local memory observer uses that same interpretation for VM/system
+containers. Unknown pressure wakes it with an explicit evidence gap, not a
+numeric breach or a healthy predicate. A known selected guest sample is bounded
+by its own observation age; refreshing the resource through another source does
+not renew it. Other-platform legacy readings and other metric observers retain
+their existing semantics. `TestPatrolObserverGuestMemoryOrigin` checks unknown,
+retained, undated, future, invalid and stale origins alongside genuine low/zero/
+high pressure and the age boundary. This changes no objective ABI, threshold,
+collection lease, observer authority or guest-command admission.
+
+Performance-tool guest memory history remains numeric, but explicitly lacks
+per-sample source/pressure qualification. A live current reading cannot reattribute
+past samples or prove that past high usage was pressure/a leak.
+`TestGuestMemoryHistoryDoesNotBorrowLiveOrigin` checks unchanged numeric history,
+its truthful limitation and non-guest compatibility. No History writer/schema
+or existing stored finding is changed. These controls do not establish #2762's
+running source, episode cause, native recovery or a containing release.
+
+### Patrol guest memory is qualified evidence, not an unlabelled percentage
+
+Patrol consumes the selected guest memory metric's original observation,
+including absence, last-known state, source and time. It does not borrow a
+different raw Proxmox facet, a refreshed resource timestamp or disk readiness.
+Current, dated cache-aware Proxmox/QGA/Pulse-agent readings can support guest
+pressure flags, anomalies, forecasts, actionability and recovery verification.
+Cache-inclusive status/cluster/total-minus-used estimates, unknown sources,
+undated/future origins and retained readings remain visible but cannot establish
+current pressure or recovery. Missing memory is N/A, not measured zero; real
+current zero and real high pressure both retain their meaning. Other platforms
+without Proxmox observations keep their existing selected readings.
+
+Full, quiet and condensed inventory and actual triage seeds preserve these
+qualifications, including unflagged running guests within the existing analysis scope. Guest
+analysis opt-outs do not acquire the new evidence section. The no-flag rollup is
+not a health verdict. Native guest runtime status, rather than canonical collection
+status, owns running/paused/stopped eligibility. A snapshot-only alert review
+cannot auto-resolve a memory alert from unknown guest pressure; independently
+verified current recovery and removed-resource handling remain separate.
+
+`TestPatrolGuestMemoryEvidence`, `TestPatrolGuestMemoryForecastsAndAnomalies`,
+`TestPatrolGuestMemoryAlertRecovery` and
+`TestPatrolGuestMemorySelectedMetricAndOtherPlatforms` exercise these connected
+paths. `TestIssue2762NamedMemoryFields` checks the existing named MemAvailable
+parser against synthetic cache-heavy/reordered evidence, not a new free-table
+parser. These controls do not establish issue #2762's installed input or cause,
+a cleared finding, or a containing release. Monitoring collection, guest-agent
+admission, configured alert thresholds, history storage and access are unchanged.
+
+ A legacy client echoing the projected `controlled` mode into an unrelated AI
+ settings PUT must retain a stored `autonomous` preference and its existing
+ legacy command-approval selection. `TestAssistantProjectedModeEchoPreservesLegacyPolicy`
+ uses actual encrypted GET/PUT persistence with and without the entitlement,
+ then checks explicit read-only opt-out and later opt-in remain possible.
+
+ ### Legacy protection copy is not a canonical-plan guarantee
+
+ The retained Protected guests list is older configuration, not a filter of
+ canonical saved resource plans. Settings and both existing help pages must
+ state that limitation and direct the operator to Actions target/approval review.
+ The value is preserved on unrelated saves. Mounted component, accessible
+ description and mirrored-help checks prevent a false exclusion promise.
+ `TestService_isAutonomousModeEnabled` also covers every current saved level,
+ explicit core-owned investigation enable/disable and unchanged stored values.
+
+ ### Interactive Assistant modes reflect action planning
+
+ Interactive Assistant offers Read-only and Ask first (`controlled`).
+ `config.AssistantControlLevel` projects legacy `autonomous` to controlled only
+ for interactive responses/tool availability. Saved bytes, shared capability
+ vocabulary, entitlement checks and legacy `IsAutonomous` approval-admission
+ remain intact; removing that legacy check would relax command approval.
+ Chat's control tool saves typed plans to Actions without execution. Scoped
+ handoff flags, execute authority, policy and action lifecycle
+ review/run/verification remain necessary; Patrol mode/Autopilot is separate.
+ Unrelated Settings saves compare normalised values and preserve saved legacy
+ preferences. Runtime, real encrypted-settings roundtrip/API, mounted component
+ and public-help controls cover this boundary; no installed action is proved.
+
### Assistant action plans do not guess an installation from session placement
An explicit current canonical resource ID takes precedence over stale session
diff --cc docs/release-control/v6/internal/subsystems/api-contracts.md
index e5e7b3702f,0cb63b015e..c109654346
--- a/docs/release-control/v6/internal/subsystems/api-contracts.md
+++ b/docs/release-control/v6/internal/subsystems/api-contracts.md
@@@ -20,20 -20,28 +20,42 @@@
## Purpose
+### AI guest memory projections preserve uncertainty
+
+Existing AI get/list/topology responses carry selected guest memory evidence:
+availability, pressure qualification, source, state and original observation time.
+A missing/invalid guest percentage is JSON null rather than zero; a measured zero
+is explicitly numeric, including in list/topology and Assistant inventory. Get
+usage bytes are null when unavailable. Non-guest response numbers remain unchanged.
+The added evidence is a read-only projection, not a new route, command, feature,
+collector or diagnostic authority. `TestGuestMemoryQueryEvidence` exercises actual
+tool serialization and `TestAssistantGuestMemoryContextAndFacts` preserves it
+through Assistant condensation. Performance responses add a guest-history source
+limitation without relabelling past samples or changing their numbers; their
+actual tool controls are in `TestGuestMemoryHistoryDoesNotBorrowLiveOrigin`.
+
+ The retained `protected_guests` settings field is legacy compatibility data,
+ not an exclusion filter for canonical saved action plans. Existing Assistant
+ help now states that limitation and requires target/approval review in Actions.
+ No field value, GET/PUT shape, scope or approval authority changes.
+
+ A legacy client echoing the projected `controlled` mode into an unrelated AI
+ settings PUT must retain a stored `autonomous` preference and its existing
+ legacy command-approval selection. `TestAssistantProjectedModeEchoPreservesLegacyPolicy`
+ uses actual encrypted GET/PUT persistence with and without the entitlement,
+ then checks explicit read-only opt-out and later opt-in remain possible.
+
+ ### Assistant control_level is an interactive projection
+
+ AI settings GET/PUT responses expose `read_only` or `controlled`: an entitled
+ legacy `autonomous` preference presents planning for operator review, never
+ unprompted execution. Existing legacy PUT validation and `ai_autofix` checks
+ remain; an entitled old client can retain the stored preference, an unentitled
+ request is refused. Unrelated saves do not rewrite it. Shared external-agent
+ vocabulary, Patrol settings, protected-guest arrays and authenticated authority
+ remain unchanged. `TestContract_AssistantSettingsAdvertisePlanningNotExecution`
+ and the actual persistence/handler tests pin responses and compatibility.
+
### Optional held-alert breach date consumer
`MetricAlertStatus.lastBreachAt?: string` mirrors the existing backend ISO