Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Verify failed backup identities respect source withdrawal

pulse-triage[bot]486557267f9f
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index efec0a3ea4..6ab8ac41d0 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -27,16 +27,17 @@ Each PVE task, archive and guest-snapshot collection, and the PBS snapshot
collection, requires unique exact record IDs. Identical repeats inflate counts;
conflicting repeats share disclosure state and cannot select a trustworthy
record. Reject the entire source read through the existing format-error path,
-without deduplication, partial acceptance or invented IDs. Preserve warned
-previously accepted evidence and independent sources until a valid retry;
-scope/access withdrawal remains unchanged. IDs stay opaque, with independent
-collection namespaces. Valid empty/nil collections, policy, provider and guest
+without deduplication, partial acceptance or invented IDs. Preserve the existing
+withdrawal of a failed source's old restore points and open details, while
+independent source evidence remains usable. Only a valid read restores the
+failed source; scope/access withdrawal remains unchanged. IDs stay opaque,
+with independent collection namespaces. Valid empty/nil collections, policy, provider and guest
operations are unchanged.
Normal-suite `proxmoxBackupInventory.test.ts` checks identical/conflicting IDs
in all four collections and distinct-ID controls. `ProxmoxBackupsTable.test.tsx`
-checks initial and refresh rejection, retained details/counts, independent
-sources, isolated retry and recurrence through the consuming page. Browser
+checks initial/refresh rejection, withdrawal of affected points/details,
+independent inspection, isolated retry and recurrence through the consuming page. Browser
proof must exercise the real HTTP reader and desktop/narrow interactions and
pixels. This establishes inspection safety, not native guest or backup recovery.
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
index 1d42085402..7fef2facc3 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
@@ -1234,7 +1234,9 @@ describe('independent Proxmox backup inventory reads', () => {
await screen.findByText(/The response format is invalid/);
await waitFor(() => expect(recoverableRows()).toHaveLength(1));
expect(screen.queryByText('No backups yet')).not.toBeInTheDocument();
- expect(screen.getByText('Backup inventory is incomplete')).toBeInTheDocument();
+ expect(screen.getByText(/The response format is invalid/)).toHaveTextContent(
+ 'Counts are incomplete.',
+ );
expect(
screen.getByRole('button', { name: `Retry ${source.toUpperCase()} inventory` }),
).toBeEnabled();
@@ -1245,7 +1247,7 @@ describe('independent Proxmox backup inventory reads', () => {
);
it.each(duplicateCases)(
- 'retains accepted details/counts after a duplicate %s %s refresh, retries only that source and rejects recurrence',
+ 'withdraws ambiguous %s %s on refresh, preserves independent details and recovers only through valid reads',
async (source, key) => {
let bad = false;
apiFetchMock.mockImplementation((url: string) =>
@@ -1263,20 +1265,24 @@ describe('independent Proxmox backup inventory reads', () => {
try {
mountBackupReadState();
await waitFor(() => expect(recoverableRows()).toHaveLength(3));
- const firstRow = recoverableRows()[0] as HTMLElement;
- fireEvent.click(within(firstRow).getByRole('button', { name: /expand details/i }));
- const detail = await screen.findByTestId('proxmox-recoverable-detail');
- const accepted = detail.textContent;
+ const affected = [...recoverableRows()].find((row) =>
+ row.textContent?.includes(source === 'pve' ? 'PVE file' : 'PBS'),
+ )! as HTMLElement;
+ fireEvent.click(within(affected).getByRole('button', { name: /expand details/i }));
+ await screen.findByTestId('proxmox-recoverable-detail');
bad = true;
await vi.advanceTimersByTimeAsync(30_000);
await screen.findByText(/The response format is invalid/);
- expect(recoverableRows()).toHaveLength(3);
- expect(screen.getByTestId('proxmox-recoverable-detail')).toBe(detail);
- expect(detail.textContent).toBe(accepted);
+ expect(recoverableRows()).toHaveLength(source === 'pve' ? 1 : 2);
+ expect(screen.queryByTestId('proxmox-recoverable-detail')).not.toBeInTheDocument();
expect(document.body).not.toHaveTextContent('UNACCEPTED_CONNECTION');
expect(screen.getByText(/The response format is invalid/)).toHaveTextContent(
'Counts are incomplete.',
);
+ const independent = recoverableRows()[0] as HTMLElement;
+ fireEvent.click(within(independent).getByRole('button', { name: /expand details/i }));
+ const detail = await screen.findByTestId('proxmox-recoverable-detail');
+ const accepted = detail.textContent;
const other = source === 'pve' ? 'pbs' : 'pve';
const before = sourceCalls(other).length;
const retry = screen.getByRole('button', {
@@ -1291,7 +1297,9 @@ describe('independent Proxmox backup inventory reads', () => {
bad = true;
await vi.advanceTimersByTimeAsync(30_000);
await screen.findByText(/The response format is invalid/);
- expect(recoverableRows()).toHaveLength(3);
+ expect(recoverableRows()).toHaveLength(source === 'pve' ? 1 : 2);
+ expect(screen.getByTestId('proxmox-recoverable-detail')).toBe(detail);
+ expect(detail.textContent).toBe(accepted);
expect(document.body).not.toHaveTextContent('UNACCEPTED_CONNECTION');
} finally {
vi.useRealTimers();