Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Say a silent agent stopped reporting, not that its host is offline

rcourtman48d4f45cbe09
diff --git a/docs/release-control/v6/internal/subsystems/alerts.md b/docs/release-control/v6/internal/subsystems/alerts.md
index 0613efe29e..9e9efb7b70 100644
--- a/docs/release-control/v6/internal/subsystems/alerts.md
+++ b/docs/release-control/v6/internal/subsystems/alerts.md
@@ -2784,6 +2784,15 @@ health handling, host cleanup, and host offline lifecycle handling; future host
agent alert behavior should extend that resource checker owner while shared
health-assessment evaluation remains package-level until all storage-health
callers can be separated behind a narrower owner.
+The host offline lifecycle is raised only by a lapsed agent report, and
+Pulse cannot tell a dead host from an agent that lost its route to Pulse.
+Its message therefore names the silent agent ("Pulse agent on '<name>'
+stopped reporting", using the agent's own name without the linked
+`(Host Agent)` qualifier) and never claims the host is offline, because a
+linked Proxmox node keeps reporting through its API while its agent is
+silent. The `host-offline` type, alert identity and lifecycle stay
+unchanged. `TestHandleHostOfflineNamesSilentAgentNotHostOutage` in
+`internal/alerts/alerts_test.go` pins this wording.
Host long-running storage-operation alerts require fresh operation evidence.
An accepted Unraid cancellation/completion or terminal Linux RAID report
resolves the corresponding operation alert immediately. A normal polling gap
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 2b2d620684..08b9dadfbc 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -4991,6 +4991,10 @@ bounds, including provider-backed alert-history wording. `frontend-modern/src/fe
backed host and VM incidents with the shared `resource-incident` vocabulary
and existing alert-history shells instead of introducing VMware-only labels,
badges, or panel copy just because the underlying signal came from vSphere.
+The same helper labels the `host-offline` alert type `Agent Not Reporting`:
+that alert only means an agent's reports lapsed, so drawers and the alerts
+page must not call it a host outage beside a node row that is still online.
+`docker-host-offline` keeps its own `Host Offline` label.
That same shared settings and modal boundary now also owns the public usage-data
vocabulary. `frontend-modern/src/components/Settings/GeneralSettingsPanel.tsx`,
`frontend-modern/src/components/Settings/useSystemSettingsState.ts`, and
diff --git a/frontend-modern/browser-verification/94e98d379b2a1317.json b/frontend-modern/browser-verification/94e98d379b2a1317.json
new file mode 100644
index 0000000000..78179db2ec
--- /dev/null
+++ b/frontend-modern/browser-verification/94e98d379b2a1317.json
@@ -0,0 +1,36 @@
+{
+ "version": 1,
+ "base_sha": "65e3fa6f24a866dcee4ba9bf3d6a239ac846abcb",
+ "verified_at": "2026-10-15T08:16:00Z",
+ "result": "passed",
+ "changed_paths": [
+ "frontend-modern/src/features/alerts/helpers.ts"
+ ],
+ "content_sha256": {
+ "frontend-modern/src/features/alerts/helpers.ts": "d13d4b6f013a9de2f2e39a382f885b147b431148a09755d67edd239d5b1d6053"
+ },
+ "routes": [
+ "/proxmox/overview",
+ "/alerts"
+ ],
+ "viewports": [
+ {
+ "width": 1440,
+ "height": 900
+ },
+ {
+ "width": 390,
+ "height": 844
+ }
+ ],
+ "states": [
+ "Production frontend build of this branch served by the preview server on pulse-dev, proxied to this branch's mock backend with a build overlay that keeps the first Proxmox-linked mock agent silent (agent West Production A linked to node pve1)",
+ "Node drawer Needs attention lists 'West Production A (Host Agent) - Agent Not Reporting' with 'Pulse agent on 'West Production A' stopped reporting', CRITICAL badge, while the node row stays online with live metrics",
+ "Alerts page lists the same alert labelled (Agent Not Reporting); no 'Host Offline' label remains for the agent alert, Docker host offline alerts keep their own label",
+ "Phone width wraps the drawer attention row without clipping the label or message"
+ ],
+ "interactions": [
+ "Signed in, opened Proxmox overview, expanded the West Production A node row with its chevron, scrolled Needs attention into view",
+ "Opened the Alerts page and scrolled the agent alert into view at both widths"
+ ]
+}
diff --git a/frontend-modern/src/features/alerts/__tests__/helpers.test.ts b/frontend-modern/src/features/alerts/__tests__/helpers.test.ts
index 8b1298590d..4e2a5d81d0 100644
--- a/frontend-modern/src/features/alerts/__tests__/helpers.test.ts
+++ b/frontend-modern/src/features/alerts/__tests__/helpers.test.ts
@@ -216,7 +216,7 @@ describe('alerts helpers', () => {
});
it('maps infrastructure alert types', () => {
- expect(alertTypeDisplayLabel('host-offline')).toBe('Host Offline');
+ expect(alertTypeDisplayLabel('host-offline')).toBe('Agent Not Reporting');
expect(alertTypeDisplayLabel('offline')).toBe('Offline');
expect(alertTypeDisplayLabel('powered-off')).toBe('Powered Off');
expect(alertTypeDisplayLabel('connectivity')).toBe('Connectivity');
diff --git a/frontend-modern/src/features/alerts/helpers.ts b/frontend-modern/src/features/alerts/helpers.ts
index eb84df8737..d348285107 100644
--- a/frontend-modern/src/features/alerts/helpers.ts
+++ b/frontend-modern/src/features/alerts/helpers.ts
@@ -303,7 +303,7 @@ export function alertTypeDisplayLabel(type: string): string {
// Infrastructure alert types
case 'host-offline':
- return 'Host Offline';
+ return 'Agent Not Reporting';
case 'offline':
return 'Offline';
case 'powered-off':
diff --git a/internal/alerts/alerts_test.go b/internal/alerts/alerts_test.go
index 2d94b8c2b8..a2bb13d132 100644
--- a/internal/alerts/alerts_test.go
+++ b/internal/alerts/alerts_test.go
@@ -1250,6 +1250,32 @@ func TestHandleHostOfflineRequiresConfirmations(t *testing.T) {
m.mu.RUnlock()
}
+func TestHandleHostOfflineNamesSilentAgentNotHostOutage(t *testing.T) {
+ m := newTestManager(t)
+ m.ClearActiveAlerts()
+ // A Proxmox node keeps reporting through its API while its linked agent
+ // is silent, so the alert must not claim the host itself is offline.
+ host := models.Host{ID: "host-linked", Hostname: "delly", LinkedNodeID: "homelab-delly"}
+ alertID := canonicalConnectivityStateID(hostResourceID(host.ID))
+
+ for i := 0; i < 3; i++ {
+ m.HandleHostOffline(host)
+ }
+
+ m.mu.RLock()
+ defer m.mu.RUnlock()
+ alert, ok := testLookupActiveAlert(t, m, alertID)
+ if !ok {
+ t.Fatalf("expected alert %q after three offline detections", alertID)
+ }
+ if want := "Pulse agent on 'delly' stopped reporting"; alert.Message != want {
+ t.Fatalf("message = %q, want %q", alert.Message, want)
+ }
+ if want := "delly (Host Agent)"; alert.ResourceName != want {
+ t.Fatalf("resource name = %q, want %q", alert.ResourceName, want)
+ }
+}
+
func TestHandleHostOfflineWithCorrelationPreservesHostLifecycleIdentity(t *testing.T) {
m := newTestManager(t)
host := models.Host{ID: "host-correlated", Hostname: "pve-1"}
diff --git a/internal/alerts/host.go b/internal/alerts/host.go
index e437248481..652172be82 100644
--- a/internal/alerts/host.go
+++ b/internal/alerts/host.go
@@ -56,15 +56,21 @@ func stripHostResourcePrefix(resourceID string) string {
return strings.TrimSpace(trimmed)
}
-func hostDisplayName(host models.Host) string {
- base := "Agent"
+func hostBaseName(host models.Host) string {
if name := strings.TrimSpace(host.DisplayName); name != "" {
- base = name
- } else if name := strings.TrimSpace(host.Hostname); name != "" {
- base = name
- } else if host.ID != "" {
- base = host.ID
+ return name
+ }
+ if name := strings.TrimSpace(host.Hostname); name != "" {
+ return name
}
+ if host.ID != "" {
+ return host.ID
+ }
+ return "Agent"
+}
+
+func hostDisplayName(host models.Host) string {
+ base := hostBaseName(host)
// When a host agent is linked to a Proxmox node/VM/container, qualify its
// name so its alerts are not confused with the linked resource's alerts.
@@ -938,8 +944,11 @@ func (m *Manager) HandleHostOfflineWithCorrelation(host models.Host, correlation
ResourceName: resourceName,
Node: nodeName,
Instance: instanceName,
- Message: fmt.Sprintf("Host '%s' is offline", resourceName),
- Correlation: correlation,
+ // Pulse only knows the agent went quiet. The machine itself may still
+ // be up (a linked Proxmox node keeps reporting through its API), so
+ // the message names the missing reports, not a host outage.
+ Message: fmt.Sprintf("Pulse agent on '%s' stopped reporting", hostBaseName(host)),
+ Correlation: correlation,
Metadata: map[string]interface{}{
"resourceType": "agent",
alertPlatformTypeKey: string(unifiedresources.SourceAgent),