Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Run required governance on stable-patch preparation targets

pulse-triage[bot]497c55cfbf08
diff --git a/.github/workflows/canonical-governance.yml b/.github/workflows/canonical-governance.yml
index b13f515c13..392c550115 100644
--- a/.github/workflows/canonical-governance.yml
+++ b/.github/workflows/canonical-governance.yml
@@ -4,9 +4,11 @@ on:
push:
branches:
- main
+ - 'release/v*'
pull_request:
branches:
- main
+ - 'release/v*'
workflow_dispatch:
permissions:
diff --git a/docs/release-control/v6/internal/HIGH_RISK_RELEASE_VERIFICATION_MATRIX.md b/docs/release-control/v6/internal/HIGH_RISK_RELEASE_VERIFICATION_MATRIX.md
index 05a8f19cfb..618cbab8e4 100644
--- a/docs/release-control/v6/internal/HIGH_RISK_RELEASE_VERIFICATION_MATRIX.md
+++ b/docs/release-control/v6/internal/HIGH_RISK_RELEASE_VERIFICATION_MATRIX.md
@@ -1361,6 +1361,11 @@ as verification progresses:
- `stable_patch_test.py` uses real disposable Git history for whole merge results,
skipped conflicts followed by clean fixes, successive patch bases, exact control
copies and rejection of unrelated or tampered source. Canonical CI runs it.
+- Its workflow regression derives actual candidate/promotion targets from the
+ control plane and parses Canonical Governance's real triggers and required
+ job context. Main-only, path-filtered, renamed, conditional and tolerant
+ variants fail. Infra's train regression separately requires that context
+ before a patch preparation can merge; absence is never success.
- `release_snapshot_test.py` keeps reviewed-head/target/repository ancestry binding
on version-bound patch targets. `control_plane_audit_test.py` preserves minor and
historical mappings while deriving new patch branches.
diff --git a/docs/release-control/v6/internal/subsystems/deployment-installability.md b/docs/release-control/v6/internal/subsystems/deployment-installability.md
index 26bdbbb131..cc416e91e4 100644
--- a/docs/release-control/v6/internal/subsystems/deployment-installability.md
+++ b/docs/release-control/v6/internal/subsystems/deployment-installability.md
@@ -39,6 +39,13 @@ installation, publication or host activation. The train's independent patch stat
owns selection, bounded retries, soak, abandonment, retirement and keeping the
weekly minor's clock and progress unchanged.
+The independently required `governance` context must be produced for preparation
+PRs targeting `release/v*` as well as `main`, including metadata-only promotions.
+Canonical Governance runs on those PRs and branch pushes without path filters,
+with its existing read-only permission and public checks. Private credentialed
+governance remains post-merge only. A missing required context stays pending in
+the train; branch admission does not remove or synthesise a required check.
+
### Unraid boot replacement preserves operator work
Agent setup/upgrade replaces only complete exact generated top-level go entries.
diff --git a/scripts/release_control/stable_patch_test.py b/scripts/release_control/stable_patch_test.py
index 92da470489..593136b412 100644
--- a/scripts/release_control/stable_patch_test.py
+++ b/scripts/release_control/stable_patch_test.py
@@ -1,5 +1,6 @@
"""Whole merge results and exact controls, with real Git but no network or publishing."""
from copy import deepcopy
+from fnmatch import fnmatchcase
import json
from pathlib import Path
import subprocess
@@ -8,6 +9,7 @@ import unittest
from unittest import mock
import stable_patch as patch
+from control_plane import release_branch_for_version
class StablePatchTest(unittest.TestCase):
@@ -165,5 +167,64 @@ class StablePatchTest(unittest.TestCase):
self.assertEqual('do not discard', (self.root / 'untracked').read_text())
+class StablePatchGovernanceTest(unittest.TestCase):
+ """Real patch targets must produce the independently required check context."""
+
+ def workflow(self):
+ import yaml
+ repo = Path(__file__).resolve().parents[2]
+ return yaml.load((repo / '.github/workflows/canonical-governance.yml').read_text(),
+ Loader=yaml.BaseLoader)
+
+ def assert_admitted(self, workflow, version, event):
+ branch = release_branch_for_version(version)
+ self.assertEqual('release/v' + version.removesuffix('-rc.1'), branch)
+ trigger = workflow['on'][event]
+ # A paths filter would strand metadata-only promotion PRs even when
+ # their target matches. The required job must not be renamed or skipped.
+ self.assertFalse({'branches-ignore', 'paths', 'paths-ignore'} & trigger.keys())
+ self.assertTrue(any(fnmatchcase(branch, pattern) for pattern in trigger['branches']))
+ job = workflow['jobs']['governance']
+ self.assertEqual('governance', job.get('name', 'governance'))
+ self.assertNotIn('if', job)
+ self.assertNotIn('needs', job)
+ self.assertNotIn('continue-on-error', job)
+ steps = '\n'.join(step.get('run', '') for step in job['steps'])
+ self.assertIn('canonical_completion_guard.py', steps)
+ self.assertIn('stable_patch_test.py', steps)
+
+ def test_actual_governance_triggers_admit_candidate_and_promotion_targets(self):
+ workflow = self.workflow()
+ for version in ('6.6.1-rc.1', '6.6.1', '6.6.2-rc.1', '6.6.2'):
+ for event in ('pull_request', 'push'):
+ with self.subTest(version=version, event=event):
+ self.assert_admitted(workflow, version, event)
+ # Extending branch admission must not import the private post-merge
+ # credential-bearing workflow into an unreviewed preparation.
+ self.assertEqual({'contents': 'read'}, workflow['permissions'])
+ self.assertIn('main', workflow['on']['pull_request']['branches'])
+ self.assertIn('main', workflow['on']['push']['branches'])
+
+ def test_old_main_only_or_filtered_or_renamed_job_cannot_pass(self):
+ for event in ('pull_request', 'push'):
+ changes = ('old-main-only', 'path-filter', 'renamed', 'conditional', 'tolerant')
+ for change in changes:
+ with self.subTest(event=event, change=change):
+ workflow = self.workflow()
+ trigger, job = workflow['on'][event], workflow['jobs']['governance']
+ if change == 'old-main-only':
+ trigger['branches'] = ['main']
+ elif change == 'path-filter':
+ trigger['paths'] = ['scripts/**']
+ elif change == 'renamed':
+ job['name'] = 'patch-governance'
+ elif change == 'conditional':
+ job['if'] = "github.base_ref == 'main'"
+ else:
+ job['continue-on-error'] = 'true'
+ with self.assertRaises(AssertionError):
+ self.assert_admitted(workflow, '6.6.1-rc.1', event)
+
+
if __name__ == '__main__':
unittest.main()