Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.
Go aialertsdashboarddockerdocker-monitoringgohomelabinfrastructure-monitoringkubernetesmonitoringmspproxmoxproxmox-backup-serverproxmox-mail-gatewayproxmox-veself-hostedtruenastypescriptvspherewebhooks
Recognise community-scripts LXC installs again
rcourtman4ba6185c4b41
diff --git a/docs/release-control/v6/internal/subsystems/deployment-installability.md b/docs/release-control/v6/internal/subsystems/deployment-installability.mdindex a2f9cf501e..8659a025de 100644--- a/docs/release-control/v6/internal/subsystems/deployment-installability.md+++ b/docs/release-control/v6/internal/subsystems/deployment-installability.md@@ -2515,6 +2515,11 @@ Generated install and rollback sections must each state this ownership boundaryand link the signed server-installer flow from the candidate's versioned docs,with the exact installation or rollback target, for absent or unverified helpers.Operators verify the resulting version after restart.+Runtime deployment detection in `internal/updates/version.go` classifies a+community-scripts container as `proxmoxve` from either the legacy `ct/pulse.sh`+text in `/bin/update` or the `export UPDATE_SCRIPT_NAME="pulse"` line of the+community-scripts/core update bootstrap that replaced it; the Pulse installer's+own helper also classifies native-installer hosts as `proxmoxve`.Signed installer recipes run in a fresh temporary directory and stop on anydownload or signature-verification failure before executing the installer.`scripts/tests/test_signed_installer_docs.py` executes both documented recipesdiff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.mdindex 6e358dd7fc..f26d6b48c6 100644--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md@@ -8709,6 +8709,9 @@ That same AI settings boundary now also ownsempty, OAuth, action/error, shell-description, and workload-discovery copyfor the settings shell stays on one governed helper instead of drifting backinto section-local strings.+`SecurityAuthPanel.tsx` follows the same rule for post-auth restart guidance: it+renders the `getSecurityAuthRestartInstruction()` label and optional command+once for every deployment type instead of hand-written per-type blocks.`frontend-modern/src/components/Settings/AuditLogPanel.tsx`,`frontend-modern/src/components/Settings/AuditWebhookPanel.tsx`,`frontend-modern/src/components/Settings/GeneralSettingsPanel.tsx`,diff --git a/docs/release-control/v6/internal/subsystems/security-privacy.md b/docs/release-control/v6/internal/subsystems/security-privacy.mdindex 08c1f69a69..a6df4a2da9 100644--- a/docs/release-control/v6/internal/subsystems/security-privacy.md+++ b/docs/release-control/v6/internal/subsystems/security-privacy.md@@ -3117,6 +3117,11 @@ restart guidance after auth changes. When `securityAuthPresentation.ts`describes the development deployment, it must point at the canonical managedruntime control surface (`npm run dev:restart` from the repo root), not astale `pulse-hot-dev` service name or any lane-local restart folklore.+For the ProxmoxVE deployment it must give `systemctl restart pulse` as root and+name the older `pulse-backend` unit, never the community-scripts `update`+helper, which exits without restarting Pulse when no newer release exists.+`SecurityAuthPanel.tsx` renders that instruction's label and optional command+once for every deployment type rather than through per-type blocks.`frontend-modern/src/components/Settings/useAPITokenManagerState.ts` mustcontinue to carry the direct `security-settings-surfaces` proof path togetherwith the API-contract token-management proof instead of borrowing coverage onlydiff --git a/frontend-modern/browser-verification/098f9543879cd3e7.json b/frontend-modern/browser-verification/098f9543879cd3e7.jsonnew file mode 100644index 0000000000..4a6c54175d--- /dev/null+++ b/frontend-modern/browser-verification/098f9543879cd3e7.json@@ -0,0 +1,36 @@+{+ "version": 1,+ "base_sha": "a315a4878070098435213143ea6587f15dbda12e",+ "verified_at": "2026-11-03T09:58:00Z",+ "result": "passed",+ "changed_paths": [+ "frontend-modern/src/components/Settings/SecurityAuthPanel.tsx",+ "frontend-modern/src/utils/securityAuthPresentation.ts"+ ],+ "content_sha256": {+ "frontend-modern/src/components/Settings/SecurityAuthPanel.tsx": "f11687c6113d98868b2a51e9bdb76b227182a42f6e9aa3f0a4f9c05f2af891d7",+ "frontend-modern/src/utils/securityAuthPresentation.ts": "41d839ffe1ac82e10b8f8e922ba44d7a389ceb24511c214d07d97ffc753e0ce1"+ },+ "routes": [+ "/settings/security-auth"+ ],+ "viewports": [+ {+ "width": 1440,+ "height": 900+ },+ {+ "width": 390,+ "height": 844+ }+ ],+ "states": [+ "Embedded production build of this tree served by a mock-mode Pulse backend on pulse-dev (3 nodes), Chromium via the perf rig's browser package 1.62.1, logged in through /api/login.",+ "Real /api/version and /api/security/status responses with only deploymentType and configuredButPendingRestart=true overridden, for deploymentType proxmoxve, systemd, docker, source and unset, at both viewports (10 cases).",+ "Restart Required card renders one label plus an optional command for every type: proxmoxve 'Restart the service as root (older installs use pulse-backend): systemctl restart pulse'; systemd 'sudo systemctl restart pulse'; docker 'docker restart pulse'; source and unset show the generic 'Restart Pulse using your deployment method' with no command (previously source rendered an empty box).",+ "No horizontal overflow in the instruction box in any case; desktop and 390px screenshots of the proxmoxve card inspected by eye."+ ],+ "interactions": [+ "Navigated to /settings/security-auth per case, waited for the 'How to restart Pulse:' heading, read the instruction box text and its scroll width, scrolled the card into view and captured it."+ ]+}diff --git a/frontend-modern/src/components/Settings/SecurityAuthPanel.tsx b/frontend-modern/src/components/Settings/SecurityAuthPanel.tsxindex a421640fd4..059b5702b8 100644--- a/frontend-modern/src/components/Settings/SecurityAuthPanel.tsx+++ b/frontend-modern/src/components/Settings/SecurityAuthPanel.tsx@@ -185,56 +185,16 @@ export const SecurityAuthPanel: Component<SecurityAuthPanelProps> = (props) => {<div class="rounded-md border border-amber-200 bg-surface p-3 dark:border-amber-700"><p class="text-xs font-semibold text-base-content mb-2">How to restart Pulse:</p>- <Show when={props.versionInfo()?.deploymentType === 'proxmoxve'}>- <div class="space-y-2">- <p class="text-xs text-base-content">- Type <code class="px-1 py-0.5 bg-surface-hover rounded-sm">update</code> in your- ProxmoxVE console- </p>- <p class="text-xs text-muted italic">- {restartInstruction().secondaryLabel}{' '}- <code class="text-xs">{restartInstruction().command}</code>- </p>- </div>- </Show>-- <Show when={props.versionInfo()?.deploymentType === 'docker'}>- <div class="space-y-1">- <p class="text-xs text-base-content">{restartInstruction().label}</p>- <code class="block text-xs bg-surface-hover p-2 rounded-sm mt-1">- {restartInstruction().command}- </code>- </div>- </Show>-- <Show- when={- props.versionInfo()?.deploymentType === 'systemd' ||- props.versionInfo()?.deploymentType === 'manual'- }- >- <div class="space-y-1">- <p class="text-xs text-base-content">{restartInstruction().label}</p>- <code class="block text-xs bg-surface-hover p-2 rounded-sm mt-1">- {restartInstruction().command}- </code>- </div>- </Show>-- <Show when={props.versionInfo()?.deploymentType === 'development'}>- <div class="space-y-1">- <p class="text-xs text-base-content">{restartInstruction().label}</p>- <code class="block text-xs bg-surface-hover p-2 rounded-sm mt-1">- {restartInstruction().command}- </code>- </div>- </Show>-- <Show when={!props.versionInfo()?.deploymentType}>- <div class="space-y-1">- <p class="text-xs text-base-content">{restartInstruction().label}</p>- </div>- </Show>+ <div class="space-y-1">+ <p class="text-xs text-base-content">{restartInstruction().label}</p>+ <Show when={restartInstruction().command}>+ {(command) => (+ <code class="block text-xs bg-surface-hover p-2 rounded-sm mt-1">+ {command()}+ </code>+ )}+ </Show>+ </div></div><div class="rounded-sm border border-green-200 bg-green-50 p-2 dark:border-green-800 dark:bg-green-900/25">diff --git a/frontend-modern/src/components/Settings/__tests__/settingsArchitecture.test.ts b/frontend-modern/src/components/Settings/__tests__/settingsArchitecture.test.tsindex d4c59fbbc6..edbeafa307 100644--- a/frontend-modern/src/components/Settings/__tests__/settingsArchitecture.test.ts+++ b/frontend-modern/src/components/Settings/__tests__/settingsArchitecture.test.ts@@ -700,6 +700,11 @@ describe('settings architecture guardrails', () => {expect(securityAuthPanelSource).not.toContain('w-full sm:w-auto min-h-10 sm:min-h-10 px-4 py-2.5 text-sm font-medium border border-border',);+ // Restart guidance comes from the shared presenter for every deployment+ // type, not from a hand-written block per type.+ expect(securityAuthPanelSource).toContain('{restartInstruction().label}');+ expect(securityAuthPanelSource).not.toContain('deploymentType ===');+ expect(securityAuthPanelSource).not.toContain('ProxmoxVE console');expect(rolesPanelSource).toContain("import { ActionIconButton, Button } from '@/components/shared/Button';",diff --git a/frontend-modern/src/utils/__tests__/securityAuthPresentation.branchcov0713.test.ts b/frontend-modern/src/utils/__tests__/securityAuthPresentation.branchcov0713.test.tsindex 42c22960ae..4fc5ec1af5 100644--- a/frontend-modern/src/utils/__tests__/securityAuthPresentation.branchcov0713.test.ts+++ b/frontend-modern/src/utils/__tests__/securityAuthPresentation.branchcov0713.test.ts@@ -36,8 +36,6 @@ describe('getSecurityAuthRestartInstruction — branch coverage (batch 0713)', (label: 'Restart the service:',command: 'sudo systemctl restart pulse',});- // The shared arm never exposes a secondaryLabel.- expect(manual.secondaryLabel).toBeUndefined();});it('routes systemd/manual to the sudo-prefixed command, not the dev command', () => {@@ -57,7 +55,6 @@ describe('getSecurityAuthRestartInstruction — branch coverage (batch 0713)', (label: 'Restart Pulse using your deployment method',});expect(result.command).toBeUndefined();- expect(result.secondaryLabel).toBeUndefined();});it('returns the generic fallback for another unknown deployment type', () => {@@ -94,7 +91,6 @@ describe('getSecurityAuthRestartInstruction — branch coverage (batch 0713)', (label: 'Restart Pulse using your deployment method',});expect(result.command).toBeUndefined();- expect(result.secondaryLabel).toBeUndefined();});it('falls through to default for a non-string runtime value (deliberately malformed)', () => {diff --git a/frontend-modern/src/utils/__tests__/securityAuthPresentation.test.ts b/frontend-modern/src/utils/__tests__/securityAuthPresentation.test.tsindex fdf3b85ef8..eac01a15cb 100644--- a/frontend-modern/src/utils/__tests__/securityAuthPresentation.test.ts+++ b/frontend-modern/src/utils/__tests__/securityAuthPresentation.test.ts@@ -31,8 +31,7 @@ describe('securityAuthPresentation', () => {command: 'docker restart pulse',});expect(getSecurityAuthRestartInstruction('proxmoxve')).toEqual({- label: 'Type update in your ProxmoxVE console',- secondaryLabel: 'Or restart manually with:',+ label: 'Restart the service as root (older installs use pulse-backend):',command: 'systemctl restart pulse',});expect(getSecurityAuthRestartInstruction('development')).toEqual({diff --git a/frontend-modern/src/utils/securityAuthPresentation.ts b/frontend-modern/src/utils/securityAuthPresentation.tsindex a9de9fa1f3..e1ce437f8f 100644--- a/frontend-modern/src/utils/securityAuthPresentation.ts+++ b/frontend-modern/src/utils/securityAuthPresentation.ts@@ -19,7 +19,6 @@ export const SECURITY_AUTH_RESTART_TIP =export interface SecurityAuthRestartInstruction {label: string;command?: string;- secondaryLabel?: string;}export function getSecurityAuthRestartInstruction(@@ -27,9 +26,11 @@ export function getSecurityAuthRestartInstruction(): SecurityAuthRestartInstruction {switch (deploymentType) {case 'proxmoxve':+ // Not `update`: the community-scripts helper exits without restarting+ // Pulse when no newer release exists. LXC consoles are root shells, and+ // older ProxmoxVE installs still run pulse-backend.service.return {- label: 'Type update in your ProxmoxVE console',- secondaryLabel: 'Or restart manually with:',+ label: 'Restart the service as root (older installs use pulse-backend):',command: 'systemctl restart pulse',};case 'docker':diff --git a/internal/updates/version.go b/internal/updates/version.goindex ba252bcb83..6671bf4ac5 100644--- a/internal/updates/version.go+++ b/internal/updates/version.go@@ -578,12 +578,8 @@ func GetDeploymentType() string {}// Check for ProxmoxVE LXC installation (has update command)- if fileExists("/bin/update") {- // Read file directly instead of using exec.Command- data, err := os.ReadFile("/bin/update")- if err == nil && (strings.Contains(string(data), "pulse.sh") || strings.Contains(string(data), "install.sh")) {- return "proxmoxve"- }+ if data, err := os.ReadFile("/bin/update"); err == nil && isProxmoxVEUpdateHelper(string(data)) {+ return "proxmoxve"}// Check for systemd service to determine installation type@@ -611,6 +607,20 @@ func GetDeploymentType() string {return "manual"}+// communityScriptsPulseEntrypoint matches the community-scripts update+// bootstrap generated for the Pulse LXC. Since September 2026 that bootstrap+// names the app only through this export; it no longer contains ct/pulse.sh.+var communityScriptsPulseEntrypoint = regexp.MustCompile(`(?m)^export UPDATE_SCRIPT_NAME="pulse"\s*$`)++// isProxmoxVEUpdateHelper reports whether /bin/update classifies this install+// as proxmoxve: the Pulse installer's helper (which native hosts also carry),+// or the community-scripts updater in its old direct-pull or bootstrap form.+func isProxmoxVEUpdateHelper(content string) bool {+ return strings.Contains(content, "pulse.sh") ||+ strings.Contains(content, "install.sh") ||+ communityScriptsPulseEntrypoint.MatchString(content)+}+// dockerUpdatesAllowed returns true when Docker environments should expose update functionality.func dockerUpdatesAllowed() bool {if envBool("PULSE_ALLOW_DOCKER_UPDATES") {diff --git a/internal/updates/version_additional_test.go b/internal/updates/version_additional_test.goindex 6269ce086d..105cdcd8b2 100644--- a/internal/updates/version_additional_test.go+++ b/internal/updates/version_additional_test.go@@ -220,3 +220,46 @@ func TestGetDeploymentType_Manual(t *testing.T) {t.Fatalf("GetDeploymentType = %q, want manual", got)}}++func TestIsProxmoxVEUpdateHelper(t *testing.T) {+ // Current community-scripts bootstrap, as written by write_update_entrypoint+ // in community-scripts/core. It names the app only through the export.+ communityBootstrap := func(name string) string {+ return `#!/usr/bin/env bash+# Community-Scripts update entrypoint (generated - do not edit by hand).+# Regenerated on install and on every successful update.+export SCRIPT_SLUG="` + name + `"+export UPDATE_SCRIPT_NAME="` + name + `"+export COMMUNITY_SCRIPTS_URL="https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main"+export COMMUNITY_SCRIPTS_CORE_URL="https://raw.githubusercontent.com/community-scripts/core/main"+export COMMUNITY_SCRIPTS_WEBSITE_URL="https://community-scripts.org"+_cs_helper="$(curl -fsSL --connect-timeout 10 "${COMMUNITY_SCRIPTS_CORE_URL}/misc/update.sh" 2>/dev/null)"+if [[ -n "$_cs_helper" ]]; then+ bash -c "$_cs_helper"+else+ echo "Update helper unavailable - falling back to direct update."+ bash -c "$(curl -fsSL "${COMMUNITY_SCRIPTS_URL}/ct/${UPDATE_SCRIPT_NAME}.sh")"+fi+`+ }++ cases := []struct {+ name string+ content string+ want bool+ }{+ {"community-scripts bootstrap", communityBootstrap("pulse"), true},+ {"legacy community-scripts direct pull", `bash -c "$(curl -fsSL https://github.com/community-scripts/ProxmoxVE/raw/main/ct/pulse.sh)"`, true},+ {"pulse installer helper", "#!/usr/bin/env bash\n# Pulse update command\nINSTALLER_URL=\"https://github.com/rcourtman/Pulse/releases/latest/download/install.sh\"\n", true},+ {"bootstrap for another app", communityBootstrap("plex"), false},+ {"bootstrap for a pulse-prefixed app", communityBootstrap("pulsechain"), false},+ {"unrelated script", "#!/bin/sh\napt update\n", false},+ }+ for _, tc := range cases {+ t.Run(tc.name, func(t *testing.T) {+ if got := isProxmoxVEUpdateHelper(tc.content); got != tc.want {+ t.Fatalf("isProxmoxVEUpdateHelper = %v, want %v", got, tc.want)+ }+ })+ }+}