Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Clear agent disk temperature alerts when their threshold is off (#2589)

rcourtman4bd567b41a85
diff --cc internal/alerts/host.go
index 29e325deeb,5fb2692605..297e525356
--- a/internal/alerts/host.go
+++ b/internal/alerts/host.go
@@@ -366,21 -358,15 +381,15 @@@ func (m *Manager) CheckHost(host models
if len(host.Sensors.SMART) > 0 {
for _, disk := range host.Sensors.SMART {
if disk.Temperature > 0 && !disk.Standby {
- effectiveTempThreshold := thresholds.DiskTemperature
- if diskType := strings.ToLower(strings.TrimSpace(disk.Type)); diskType != "" && !diskTempOverridden {
- m.mu.RLock()
- if th, ok := m.config.DiskTempByType[diskType]; ok {
- t := th
- effectiveTempThreshold = &t
- }
- m.mu.RUnlock()
- }
+ m.mu.RLock()
+ effectiveTempThreshold := m.hostDiskTemperatureThresholdNoLock(thresholds.DiskTemperature, diskTempOverridden, disk.Type)
+ m.mu.RUnlock()
// Use specific resource ID for the disk: hostID/disk-temp:device
- tempResourceID := fmt.Sprintf("%s/disk_temp:%s", hostResourceID(host.ID), sanitizeHostComponent(disk.Device))
+ tempResourceID := hostDiskTemperatureResourcePrefix(host.ID) + sanitizeHostComponent(disk.Device)
tempResourceName := fmt.Sprintf("%s (%s Temp)", hostDisplayName(host), disk.Device)
- diskTempMetadata := cloneMetadata(baseMetadata)
+ diskTempMetadata := hostChildAlertMetadata(baseMetadata, hostDiskAlertResourceType)
diskTempMetadata["metric"] = "diskTemperature"
diskTempMetadata["device"] = disk.Device
diskTempMetadata["temperature"] = disk.Temperature