Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.
Go aialertsdashboarddockerdocker-monitoringgohomelabinfrastructure-monitoringkubernetesmonitoringmspproxmoxproxmox-backup-serverproxmox-mail-gatewayproxmox-veself-hostedtruenastypescriptvspherewebhooks
Build the lifecycle agent once per installer test process
pulse-triage[bot]4c67df5dbd4d
diff --git a/scripts/installtests/agent_state_dir_lifecycle_test.go b/scripts/installtests/agent_state_dir_lifecycle_test.goindex e52b251531..e41950e7f6 100644--- a/scripts/installtests/agent_state_dir_lifecycle_test.go+++ b/scripts/installtests/agent_state_dir_lifecycle_test.go@@ -158,13 +158,7 @@ func waitForLifecycleState(t *testing.T, timeout time.Duration, describe string,func buildLifecycleAgent(t *testing.T) string {t.Helper()- binaryPath := filepath.Join(t.TempDir(), "pulse-agent")- cmd := exec.Command("go", "build", "-o", binaryPath, "./cmd/pulse-agent")- cmd.Dir = repoFile()- if output, err := cmd.CombinedOutput(); err != nil {- t.Fatalf("build pulse-agent: %v\n%s", err, output)- }- return binaryPath+ return buildPulseAgentLifecycleBinary(t)}func renderLifecycleService(t *testing.T, stateDir, stateSource, unitPath, pulseURL, token string, commandsEnabled, recoverExisting bool) {diff --git a/scripts/installtests/install_sh_test.go b/scripts/installtests/install_sh_test.goindex 900d95e7d0..8d04bd33e5 100644--- a/scripts/installtests/install_sh_test.go+++ b/scripts/installtests/install_sh_test.go@@ -3321,11 +3321,9 @@ func extractCollectorLifecycleShellFunctions(t *testing.T, includeVerify bool) sfunc buildPulseAgentLifecycleBinary(t *testing.T) string {t.Helper()- binary := filepath.Join(t.TempDir(), "pulse-agent")- build := exec.Command("go", "build", "-o", binary, "./cmd/pulse-agent")- build.Dir = filepath.Dir(repoFile("go.mod"))- if output, err := build.CombinedOutput(); err != nil {- t.Fatalf("build pulse-agent lifecycle binary: %v\n%s", err, output)+ binary, err := lifecycleAgentFixture(t.TempDir())+ if err != nil {+ t.Fatal(err)}return binary}diff --git a/scripts/installtests/lifecycle_binary_fixture_test.go b/scripts/installtests/lifecycle_binary_fixture_test.gonew file mode 100644index 0000000000..c67bfa0153--- /dev/null+++ b/scripts/installtests/lifecycle_binary_fixture_test.go@@ -0,0 +1,189 @@+package installtests++import (+ "bytes"+ "errors"+ "fmt"+ "os"+ "os/exec"+ "path/filepath"+ "sync"+ "sync/atomic"+ "testing"+)++// Only the build is shared, and only within this test process. Each caller+// receives its own executable, so replacing or removing it cannot affect+// another lifecycle test. Keep the real source build and its failures: the Go+// build cache alone still links the same agent once for every caller.+var lifecycleAgentFixture = newLifecycleBinaryFixture(func(binary string) error {+ build := exec.Command("go", "build", "-o", binary, "./cmd/pulse-agent")+ build.Dir = repoFile()+ if output, err := build.CombinedOutput(); err != nil {+ return fmt.Errorf("build pulse-agent lifecycle binary: %w\n%s", err, output)+ }+ return nil+})++func newLifecycleBinaryFixture(build func(string) error) func(string) (string, error) {+ load := sync.OnceValues(func() (payload []byte, resultErr error) {+ dir, err := os.MkdirTemp("", "pulse-installtest-agent-")+ if err != nil {+ return nil, err+ }+ defer func() {+ if err := os.RemoveAll(dir); err != nil {+ resultErr = errors.Join(resultErr, fmt.Errorf("clean agent build directory: %w", err))+ }+ }()+ binary := filepath.Join(dir, "pulse-agent")+ if err := build(binary); err != nil {+ return nil, err+ }+ payload, err = os.ReadFile(binary)+ if err != nil {+ return nil, err+ }+ if len(payload) == 0 {+ return nil, errors.New("pulse-agent build produced an empty executable")+ }+ return payload, nil+ })+ return func(dir string) (string, error) {+ payload, err := load()+ if err != nil {+ return "", err+ }+ binary := filepath.Join(dir, "pulse-agent")+ if err := os.WriteFile(binary, payload, 0755); err != nil {+ return "", err+ }+ return binary, nil+ }+}++func TestLifecycleBinaryFixtureBuildsOnceWithIndependentCopies(t *testing.T) {+ t.Parallel()+ var builds atomic.Int32+ var buildDir string+ payload := []byte("fixture executable bytes")+ fixture := newLifecycleBinaryFixture(func(binary string) error {+ builds.Add(1)+ buildDir = filepath.Dir(binary)+ return os.WriteFile(binary, payload, 0755)+ })+ const callers = 8+ dirs := make([]string, callers)+ paths := make([]string, callers)+ errs := make([]error, callers)+ for i := range dirs {+ dirs[i] = t.TempDir()+ }+ var wg sync.WaitGroup+ for i := range dirs {+ wg.Add(1)+ go func() {+ defer wg.Done()+ paths[i], errs[i] = fixture(dirs[i])+ }()+ }+ wg.Wait()+ if builds.Load() != 1 {+ t.Fatalf("builds = %d, want 1", builds.Load())+ }+ if _, err := os.Stat(buildDir); !errors.Is(err, os.ErrNotExist) {+ t.Fatalf("temporary build directory still exists: %v", err)+ }+ for i := range paths {+ if errs[i] != nil || paths[i] != filepath.Join(dirs[i], "pulse-agent") {+ t.Fatalf("copy %d: path=%q err=%v", i, paths[i], errs[i])+ }+ if info, err := os.Stat(paths[i]); err != nil || info.Mode().Perm()&0100 == 0 {+ t.Fatalf("copy %d is not executable: %v", i, err)+ }+ }+ if err := os.WriteFile(paths[0], []byte("replaced by one test"), 0755); err != nil {+ t.Fatal(err)+ }+ if err := os.Remove(paths[1]); err != nil {+ t.Fatal(err)+ }+ for i := 2; i < callers; i++ {+ got, err := os.ReadFile(paths[i])+ if err != nil || !bytes.Equal(got, payload) {+ t.Fatalf("copy %d changed with another caller: bytes=%q err=%v", i, got, err)+ }+ }+ // A new caller must also get the original, not the mutated first copy.+ path, err := fixture(t.TempDir())+ if err != nil {+ t.Fatal(err)+ }+ if got, err := os.ReadFile(path); err != nil || !bytes.Equal(got, payload) {+ t.Fatalf("later copy: bytes=%q err=%v", got, err)+ }+}++func TestLifecycleBinaryFixtureKeepsBuildFailures(t *testing.T) {+ t.Parallel()+ wantErr := errors.New("compiler failed after partial output")+ builds := 0+ var buildDir string+ fixture := newLifecycleBinaryFixture(func(binary string) error {+ builds+++ buildDir = filepath.Dir(binary)+ if err := os.WriteFile(binary, []byte("partial"), 0755); err != nil {+ return err+ }+ return wantErr+ })+ for i := 0; i < 2; i++ {+ dir := t.TempDir()+ path, err := fixture(dir)+ if path != "" || !errors.Is(err, wantErr) {+ t.Fatalf("failed build was replaced: path=%q err=%v", path, err)+ }+ if _, err := os.Stat(filepath.Join(dir, "pulse-agent")); !errors.Is(err, os.ErrNotExist) {+ t.Fatalf("partial executable reached caller: %v", err)+ }+ }+ if builds != 1 {+ t.Fatalf("failed build retried %d times", builds)+ }+ if _, err := os.Stat(buildDir); !errors.Is(err, os.ErrNotExist) {+ t.Fatalf("failed build directory still exists: %v", err)+ }+}++func TestLifecycleBinaryFixtureRejectsMissingOrEmptyOutput(t *testing.T) {+ t.Parallel()+ for _, empty := range []bool{false, true} {+ fixture := newLifecycleBinaryFixture(func(binary string) error {+ if empty {+ return os.WriteFile(binary, nil, 0755)+ }+ return nil+ })+ if path, err := fixture(t.TempDir()); path != "" || err == nil {+ t.Fatalf("invalid executable accepted: empty=%t path=%q err=%v", empty, path, err)+ }+ }+}++func TestLifecycleBinaryFixtureKeepsCopyFailuresLocal(t *testing.T) {+ t.Parallel()+ builds := 0+ fixture := newLifecycleBinaryFixture(func(binary string) error {+ builds+++ return os.WriteFile(binary, []byte("complete"), 0755)+ })+ if path, err := fixture(filepath.Join(t.TempDir(), "absent")); path != "" || err == nil {+ t.Fatalf("failed copy accepted: path=%q err=%v", path, err)+ }+ if path, err := fixture(t.TempDir()); path == "" || err != nil {+ t.Fatalf("one failed copy poisoned the build: path=%q err=%v", path, err)+ }+ if builds != 1 {+ t.Fatalf("copy failure retried the build %d times", builds)+ }+}