Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Finish shared-name fixtures and assert exact visible counts

pulse-triage[bot]51a1ea194eec
diff --git a/frontend-modern/src/__tests__/App.architecture.test.ts b/frontend-modern/src/__tests__/App.architecture.test.ts
index 959f8fe7a0..a1e8176d97 100644
--- a/frontend-modern/src/__tests__/App.architecture.test.ts
+++ b/frontend-modern/src/__tests__/App.architecture.test.ts
@@ -795,7 +795,7 @@ describe('App architecture', () => {
expect(appLayoutSource).toContain("const NAV_TAB_ICON_CLASS = 'w-4 h-4 shrink-0';");
expect(appLayoutSource).toContain("} from '@/components/shared/mobileNavBarModel';");
expect(appLayoutSource).not.toContain('function getDesktopUtilityTabAriaLabel');
- expect(appLayoutSource).toContain('return `${count} ${tab.label}`;');
+ expect(appLayoutSource).not.toContain('return `${count} ${tab.label}`;');
expect(appLayoutSource).toContain('const primaryTabsSource = createMemo<PrimaryTab[]>(() =>');
expect(appLayoutSource).toContain("id: 'proxmox',");
expect(appLayoutSource).toContain("icon: getPlatformIcon('proxmox'),");
diff --git a/frontend-modern/src/__tests__/AppLayout.test.tsx b/frontend-modern/src/__tests__/AppLayout.test.tsx
index 8d67198c3b..1b3de39c13 100644
--- a/frontend-modern/src/__tests__/AppLayout.test.tsx
+++ b/frontend-modern/src/__tests__/AppLayout.test.tsx
@@ -285,6 +285,9 @@ describe('AppLayout navigation icons', () => {
expect(desktopPatrolTab.querySelector('[class~="xs:hidden"]')?.nextSibling?.textContent).toBe(
' ',
);
+ expect(
+ desktopPatrolTab.querySelector('[class~="xs:hidden"]')?.nextElementSibling,
+ ).toHaveTextContent(/^2$/);
expect(within(systemGroup as HTMLElement).queryByText('Needs Attention')).toBeNull();
const mobileNav = screen.getByRole('navigation', { name: 'Mobile navigation' });
@@ -296,6 +299,7 @@ describe('AppLayout navigation icons', () => {
// The visible label precedes the icon/badge wrapper in DOM order.
expect(mobilePatrolTab.firstElementChild).toHaveClass('order-2');
expect(mobilePatrolTab.firstElementChild?.textContent).toBe('Patrol ');
+ expect(mobilePatrolTab.querySelector('.absolute')).toHaveTextContent(/^2$/);
expect(within(mobileNav).queryByText('Needs Attention')).toBeNull();
});
@@ -329,12 +333,19 @@ describe('AppLayout navigation icons', () => {
expect(actionsTab).toHaveAttribute('href', '/actions');
expect(actionsTab).toHaveAttribute('aria-current', 'page');
expect(actionsTab.querySelector('[class~="xs:hidden"]')?.nextSibling?.textContent).toBe(' ');
+ expect(actionsTab.querySelector('[class~="xs:inline"]')?.textContent).toBe('Actions');
+ expect(actionsTab.querySelector('[class~="xs:hidden"]')?.nextElementSibling).toHaveTextContent(
+ /^3$/,
+ );
expect(within(systemGroup as HTMLElement).getByRole('link', { name: 'Patrol' })).toBeTruthy();
const mobileNav = screen.getByRole('navigation', { name: 'Mobile navigation' });
- expect(
- within(mobileNav).getByRole('link', { name: 'Actions: 3 actions await approval' }),
- ).toHaveAttribute('aria-current', 'page');
+ const mobileActionsTab = within(mobileNav).getByRole('link', {
+ name: 'Actions: 3 actions await approval',
+ });
+ expect(mobileActionsTab).toHaveAttribute('aria-current', 'page');
+ expect(mobileActionsTab.firstElementChild?.textContent).toBe('Actions ');
+ expect(mobileActionsTab.querySelector('.absolute')).toHaveTextContent(/^3$/);
expect(document.title).toContain('Actions');
});
diff --git a/frontend-modern/src/components/shared/__tests__/MobileNavBar.test.tsx b/frontend-modern/src/components/shared/__tests__/MobileNavBar.test.tsx
index 9327042b3b..4838238626 100644
--- a/frontend-modern/src/components/shared/__tests__/MobileNavBar.test.tsx
+++ b/frontend-modern/src/components/shared/__tests__/MobileNavBar.test.tsx
@@ -233,11 +233,12 @@ describe('MobileNavBar', () => {
// a visible label. Test label order/boundaries and badge contents directly.
expect(alertsLink.firstElementChild).toHaveClass('order-2');
expect(alertsLink.firstElementChild?.textContent).toBe('Alerts ');
- expect(alertsLink.querySelector('.absolute')).toHaveTextContent('2 3');
+ expect(alertsLink.querySelector('.absolute')).toHaveTextContent(/^2 3$/);
expect(alertsLink).toHaveAccessibleDescription('2 critical, 3 warning');
- expect(within(nav).getByRole('link', { name: 'Patrol: 2 open work items' })).toHaveTextContent(
- 'Patrol 2',
- );
+ const patrolLink = within(nav).getByRole('link', { name: 'Patrol: 2 open work items' });
+ expect(patrolLink.firstElementChild).toHaveClass('order-2');
+ expect(patrolLink.firstElementChild?.textContent).toBe('Patrol ');
+ expect(patrolLink.querySelector('.absolute')).toHaveTextContent(/^2$/);
expect(within(nav).queryByRole('link', { name: 'Pulse Patrol Patrol' })).toBeNull();
fireEvent.click(within(nav).getByRole('button', { name: 'Switch platform, current Proxmox' }));