Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Correct Assistant validation fixtures and copy style

pulse-triage[bot]5572159e1407
diff --git a/frontend-modern/browser-tests/assistant-control-compatibility.cjs b/frontend-modern/browser-tests/assistant-control-compatibility.cjs
index 261770e04d..e50cc1f108 100644
--- a/frontend-modern/browser-tests/assistant-control-compatibility.cjs
+++ b/frontend-modern/browser-tests/assistant-control-compatibility.cjs
@@ -67,9 +67,10 @@ const hash = (f) => crypto.createHash('sha256').update(fs.readFileSync(f)).diges
const text = await page.locator('main').innerText();
assert.ok(!text.includes('chat-only') && !text.includes('Infrastructure changes stay with Patrol'));
if (expected === 'controlled') { assert.ok(text.includes('Chat does not execute the plan')); assert.equal(await page.getByLabel('Protected guests').inputValue(), 'vm-101'); }
+ else assert.ok(text.includes('Assistant can query and explain only. It cannot plan infrastructure actions.'));
assert.ok(await page.evaluate(() => document.documentElement.scrollWidth <= innerWidth + 1));
});
- if (level === 'autonomous') { await select.scrollIntoViewIfNeeded(); await capture('legacy-settings'); }
+ if (level === 'autonomous' || level === 'read_only') { await select.scrollIntoViewIfNeeded(); await capture(level === 'read_only' ? 'read-only-settings' : 'legacy-settings'); }
const before = writes.length;
await page.getByRole('button', { name: 'Save Assistant settings', exact: true }).click();
await check(`Unrelated save preserves ${level} and scoped policy`, async () => {
diff --git a/frontend-modern/browser-verification/2056b31327e08d09.json b/frontend-modern/browser-verification/2056b31327e08d09.json
new file mode 100644
index 0000000000..650b8af514
--- /dev/null
+++ b/frontend-modern/browser-verification/2056b31327e08d09.json
@@ -0,0 +1,46 @@
+{
+ "version": 1,
+ "base_sha": "1927020ba221f76e28224ad521bc1a1dd14fff58",
+ "result": "passed",
+ "verified_at": "2026-10-09T23:40:18Z",
+ "changed_paths": [
+ "frontend-modern/src/utils/aiControlLevelPresentation.ts"
+ ],
+ "content_sha256": {
+ "frontend-modern/src/utils/aiControlLevelPresentation.ts": "362d5610b78512ea76a85c524d775bf853af1c8fb36c45b9bd7bcaca6e899761"
+ },
+ "routes": [
+ "Existing AIAssistantSettings and AIChat in local /browser-tests/assistant-control-compatibility.html fixture",
+ "/settings/ai/assistant",
+ "/docs/AI#control-levels",
+ "/docs/AI_AUTONOMY#assistant-control-levels"
+ ],
+ "states": [
+ "Saved autonomous/suggest/controlled/read_only/unknown: truthful two-mode projection",
+ "Protected guest and Patrol policy preservation on unrelated save",
+ "Scoped alert attachment with explicit approval boundary",
+ "503 settings save failure retains displayed mode",
+ "Desktop light and WebKit phone dark/narrow light",
+ "Existing Docs with locally scrollable wide table"
+ ],
+ "interactions": [
+ "48 assertion groups cover the five saved-config states, unrelated save preservation, keyboard menu, scoped alert approval, failed save, explicit mode change and actual Docs",
+ "19 inspected screenshots include corrected Read-only copy at all three viewports; same-byte captures have explicit prior inspection bindings",
+ "The 320px guide table remains locally scrollable to its final column"
+ ],
+ "viewports": [
+ {
+ "width": 1365,
+ "height": 900
+ },
+ {
+ "width": 390,
+ "height": 844
+ },
+ {
+ "width": 320,
+ "height": 740
+ }
+ ],
+ "notes": "Necessary copy-style punctuation correction and synthetic plan test alignment after failed source checks. Only this frontend file changed from the parent; no mode, saved preference, scope, approval, entitlement or execution delta. No model/native action or deployment/release claim."
+}
diff --git a/frontend-modern/src/utils/aiControlLevelPresentation.ts b/frontend-modern/src/utils/aiControlLevelPresentation.ts
index 6dfb7b0e50..c44628e702 100644
--- a/frontend-modern/src/utils/aiControlLevelPresentation.ts
+++ b/frontend-modern/src/utils/aiControlLevelPresentation.ts
@@ -35,7 +35,7 @@ export function getAIControlLevelDescription(level: AIControlLevel): string {
case 'controlled':
return 'Assistant can plan infrastructure actions and saves each plan to Actions for you to review and run. Chat does not execute the plan.';
default:
- return 'Assistant can query and explain only; it cannot plan infrastructure actions.';
+ return 'Assistant can query and explain only. It cannot plan infrastructure actions.';
}
}
diff --git a/internal/ai/tools/control_resource_test.go b/internal/ai/tools/control_resource_test.go
index df8d77a813..9585942dcd 100644
--- a/internal/ai/tools/control_resource_test.go
+++ b/internal/ai/tools/control_resource_test.go
@@ -211,6 +211,18 @@ func TestAssistantProjectedModesStillOnlyPlanAndRespectExecuteAuthority(t *testi
for _, authority := range []bool{false, true} {
t.Run(raw+map[bool]string{true: "/authorised", false: "/unauthorised"}[authority], func(t *testing.T) {
provider := newTrueNASUnifiedQueryProvider(t)
+ canonicalID := ""
+ for _, resource := range provider.GetByType(unifiedresources.ResourceTypeAppContainer) {
+ if strings.EqualFold(resource.Name, "Nextcloud") {
+ if canonicalID != "" {
+ t.Fatal("fixture has ambiguous Nextcloud resources")
+ }
+ canonicalID = resource.ID
+ }
+ }
+ if canonicalID == "" {
+ t.Fatal("fixture has no canonical Nextcloud resource")
+ }
native := &stubAppContainerActionProvider{}
planned := 0
executor := NewPulseToolExecutor(ExecutorConfig{
@@ -219,7 +231,7 @@ func TestAssistantProjectedModesStillOnlyPlanAndRespectExecuteAuthority(t *testi
ControlLevel: ControlLevel(config.AssistantControlLevel(raw)),
TypedActionPlanner: typedActionPlannerFunc(func(_ context.Context, org string, req unifiedresources.ActionRequest) (*unifiedresources.ActionPlan, error) {
planned++
- if org != "lab" || req.ResourceID != "app-container:truenas-main:nextcloud" {
+ if org != "lab" || req.ResourceID != canonicalID || req.CapabilityName != "restart" {
t.Fatalf("plan lost scope: %q/%s", org, req.ResourceID)
}
return &unifiedresources.ActionPlan{ActionID: "synthetic-action", Allowed: true, RequiresApproval: true, ApprovalPolicy: unifiedresources.ApprovalAdmin, PlanHash: "synthetic-plan"}, nil
@@ -245,7 +257,13 @@ func TestAssistantProjectedModesStillOnlyPlanAndRespectExecuteAuthority(t *testi
t.Fatalf("plans=%d", planned)
}
} else {
- if err == nil && !result.IsError {
+ // Read-only returns the existing informational disabled-mode reply,
+ // not a failed native action. Unauthorised planning is an error.
+ if raw == config.ControlLevelReadOnly {
+ if err != nil || len(result.Content) != 1 || !strings.Contains(result.Content[0].Text, "Control tools are disabled") {
+ t.Fatalf("missing read-only refusal: %v / %+v", err, result)
+ }
+ } else if err == nil && !result.IsError {
t.Fatalf("unauthorised/read-only plan accepted: %+v", result)
}
if planned != 0 {