Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep known PBS servers usable through backup inventory failures

pulse-triage[bot]560ba9072e6b
diff --git a/docs/release-control/v6/internal/subsystems/agent-lifecycle.md b/docs/release-control/v6/internal/subsystems/agent-lifecycle.md
index 03b53e8b83..51678e45ab 100644
--- a/docs/release-control/v6/internal/subsystems/agent-lifecycle.md
+++ b/docs/release-control/v6/internal/subsystems/agent-lifecycle.md
@@ -15,6 +15,16 @@
## Purpose
+### Optional configuration-signing guidance fits narrow installers (13 October 2026)
+
+The three existing signing environment names wrap within their advice card.
+Their complete text, values, optional semantics, trust defaults and copied
+installation/removal commands are unchanged. The source regression in
+`InfrastructureOperationsModel.test.tsx` preserves those exact names and the
+wrapping class; desktop/phone light/dark browser proof must inspect the actual
+installer and preserve separate-token/private-file copy behaviour. This is
+readability, not an installed agent or QNAP recovery result.
+
### Backend bootstrap preserves silent input on BusyBox hosts
Setup, Proxmox and container bootstrap commands prefer standalone `stty`,
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 49a9402346..1c832b3192 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -20,6 +20,19 @@
## Purpose
+### Independent PBS resource and inventory rendering (13 October 2026)
+
+The existing PBS health/datastore/detail table remains mounted outside backup
+inventory loading/error gates. Explicit per-source notices and retries are
+independent too; both inventory failures retain their error state and never
+publish zero restore-point success. Known resource identity and readable
+capacity remain usable, while PBS backup counts stay Loading/Unavailable until
+a valid inventory arrives. `ProxmoxBackupsTable.test.tsx` verifies pending,
+single/both failure and ordinary recovery with a stable server-table owner.
+Desktop/narrow production-app proof must retain actual API resource identity,
+keyboard/touch detail access and truthful incomplete counts. No monitoring,
+backup execution, agent, credential or access authority is added.
+
### Alert-first drawer composition retains usable evidence guidance (13 October 2026)
The guest's full OS caption moves to the visible, wrapping facts strip; it is
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index 917008ab8f..e0ed7f42f3 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -21,6 +21,18 @@
## Purpose
+### Known PBS health survives unreadable backup inventories (13 October 2026)
+
+Backups keeps the separately supplied PBS server/datastore projection mounted
+while PVE and PBS inventories load, fail or recover. Inventory notices and
+source-local retries remain explicit; both failures still suppress the inventory
+summary rather than claim zero restore points or no backups. PBS counts are
+Loading/Unavailable until its own valid response arrives; resource health,
+capacity, identity and detail access remain independent. No backup execution,
+agent requirement, credential/access change or reporter recovery is implied.
+`ProxmoxBackupsTable.test.tsx` covers both pending reads, each source failure,
+both failures and ordinary recovery without replacing the known server table.
+
### Portable installation input does not change recovery authority
The backend setup/Proxmox/container copied-command reader can use BusyBox `stty`
diff --git a/docs/release-control/v6/internal/subsystems/unified-resources.md b/docs/release-control/v6/internal/subsystems/unified-resources.md
index a22acf2e09..478f70fac3 100644
--- a/docs/release-control/v6/internal/subsystems/unified-resources.md
+++ b/docs/release-control/v6/internal/subsystems/unified-resources.md
@@ -23,6 +23,16 @@ and sort the complete canonical change table while startup and ingestion wait.
## Purpose
+### Independently known PBS remains available in Backups (13 October 2026)
+
+The resource-owned PBS table is outside backup-inventory loading/error gates.
+Its canonical identity, datastore health/capacity and details remain usable
+when either or both inventory endpoints fail. Error/loading counts are not zero
+backup evidence. The inventory-only surface retains incomplete notices and
+ordinary retries. `ProxmoxBackupsTable.test.tsx` checks stable server-table
+ownership through loading, single/both failures and valid response recovery.
+This consumes existing resources; it adds no producer or native recovery claim.
+
### Shared interpretation of selected guest memory
`GuestMemoryEvidenceForResource` and the VM/container `MemoryEvidence` accessors
diff --git a/frontend-modern/src/components/Settings/InfrastructureInstallerSection.tsx b/frontend-modern/src/components/Settings/InfrastructureInstallerSection.tsx
index b7780a566f..ca4e6f8c12 100644
--- a/frontend-modern/src/components/Settings/InfrastructureInstallerSection.tsx
+++ b/frontend-modern/src/components/Settings/InfrastructureInstallerSection.tsx
@@ -636,9 +636,10 @@ export const InfrastructureInstallerSection: Component<InfrastructureInstallerSe
<div class="rounded-md border border-emerald-200 bg-emerald-50 px-4 py-2 text-sm text-emerald-900 dark:border-emerald-700 dark:bg-emerald-900/25 dark:text-emerald-100">
<span class="font-medium">Config signing (optional)</span> — Require signed
remote config payloads with{' '}
- <code>PULSE_AGENT_CONFIG_SIGNATURE_REQUIRED=true</code>. Provide keys via{' '}
- <code>PULSE_AGENT_CONFIG_SIGNING_KEY</code> (Pulse) and{' '}
- <code>PULSE_AGENT_CONFIG_PUBLIC_KEYS</code> (agents).
+ <code class="wrap-anywhere">PULSE_AGENT_CONFIG_SIGNATURE_REQUIRED=true</code>.
+ Provide keys via{' '}
+ <code class="wrap-anywhere">PULSE_AGENT_CONFIG_SIGNING_KEY</code> (Pulse) and{' '}
+ <code class="wrap-anywhere">PULSE_AGENT_CONFIG_PUBLIC_KEYS</code> (agents).
</div>
<div class="rounded-md border border-border bg-surface-hover px-4 py-3">
diff --git a/frontend-modern/src/components/Settings/__tests__/InfrastructureOperationsModel.test.tsx b/frontend-modern/src/components/Settings/__tests__/InfrastructureOperationsModel.test.tsx
index a5c2b4087a..58c4ca0ed9 100644
--- a/frontend-modern/src/components/Settings/__tests__/InfrastructureOperationsModel.test.tsx
+++ b/frontend-modern/src/components/Settings/__tests__/InfrastructureOperationsModel.test.tsx
@@ -19,6 +19,19 @@ import {
} from '../infrastructureOperationsModel';
describe('infrastructure operations model', () => {
+ it('keeps the complete optional signing settings wrappable without changing their values', () => {
+ const note = infrastructureInstallerSectionSource
+ .split('Config signing (optional)')[1]
+ .split('</div>')[0];
+ for (const value of [
+ 'PULSE_AGENT_CONFIG_SIGNATURE_REQUIRED=true',
+ 'PULSE_AGENT_CONFIG_SIGNING_KEY',
+ 'PULSE_AGENT_CONFIG_PUBLIC_KEYS',
+ ]) {
+ expect(note).toContain(`<code class="wrap-anywhere">${value}</code>`);
+ }
+ });
+
it('offers the existing private-file alternative on Linux/NAS and FreeBSD only when supplied', () => {
const cards = buildCommandsByPlatform(
'prompt-command',
diff --git a/frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx b/frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx
index aeb2085371..77b8c8a058 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx
@@ -665,324 +665,327 @@ export const ProxmoxBackupsTable: Component<{
);
return (
- <Show
- when={!allInventoriesFailed()}
- fallback={
- <PlatformErrorState
- title="Could not load Proxmox backup inventory"
- description="PVE and PBS backup inventories are unavailable. Counts are incomplete. Refresh to retry both sources."
- onRefresh={retryAllInventories}
+ <div class="space-y-3">
+ <For each={inventorySources}>
+ {({ label, query }) => (
+ <Show when={!query.resolvedOnce() || query.error()}>
+ <div
+ role="status"
+ class={`${BACKUP_READ_NOTICE_CLASS} flex flex-wrap items-center justify-between gap-2`}
+ >
+ <span>
+ {label} backup inventory is {query.error() ? 'unavailable' : 'loading'}. Counts are
+ incomplete. {getAPIReadAccessErrorMessage(query.error())}
+ <Show when={query.error() instanceof BackupInventoryFormatError}>
+ {' '}
+ The response format is invalid. Missing restore points do not mean no backups
+ exist.
+ </Show>
+ </span>
+ <Show when={query.error()}>
+ <button
+ type="button"
+ class="min-h-10 shrink-0 rounded-md border border-current px-3 font-medium hover:underline focus-visible:outline-solid focus-visible:outline-2 focus-visible:outline-offset-2 disabled:opacity-50"
+ aria-label={`Retry ${label} inventory`}
+ disabled={query.loading()}
+ onClick={() => void query.refetch()}
+ >
+ {query.loading() ? 'Retrying…' : `Retry ${label} inventory`}
+ </button>
+ </Show>
+ </div>
+ </Show>
+ )}
+ </For>
+ {/* Server health comes from /api/resources, not either backup inventory.
+ Keep this owner mounted through loading, failure and ordinary retries. */}
+ <Show when={(props.servers?.length ?? 0) > 0}>
+ <ProxmoxBackupServersTable
+ servers={props.servers ?? []}
+ backups={pbsArtifacts()}
+ backupInventoryState={
+ pbsBackups.error() ? 'unavailable' : pbsBackups.resolvedOnce() ? 'available' : 'loading'
+ }
/>
- }
- >
+ </Show>
<Show
- when={
- hasReadableInventory() || inventorySources.some(({ query }) => Boolean(query.error()))
- }
+ when={!allInventoriesFailed()}
fallback={
- <PlatformTableLoadingState
- title="Loading Proxmox backup inventory"
- description="Reading PBS snapshots, PVE backup files, guest snapshots, and recent backup tasks."
+ <PlatformErrorState
+ title="Could not load Proxmox backup inventory"
+ description="PVE and PBS backup inventories are unavailable. Counts are incomplete. Refresh to retry both sources."
+ onRefresh={retryAllInventories}
/>
}
>
- <div class="space-y-3">
- <PlatformSectionTabs tabs={backupViewTabs()} active={view()} ariaLabel="Backup views" />
- <For each={inventorySources}>
- {({ label, query }) => (
- <Show when={!query.resolvedOnce() || query.error()}>
- <div
- role="status"
- class={`${BACKUP_READ_NOTICE_CLASS} flex flex-wrap items-center justify-between gap-2`}
- >
- <span>
- {label} backup inventory is {query.error() ? 'unavailable' : 'loading'}. Counts
- are incomplete. {getAPIReadAccessErrorMessage(query.error())}
- <Show when={query.error() instanceof BackupInventoryFormatError}>
- {' '}
- The response format is invalid. Missing restore points do not mean no backups
- exist.
- </Show>
- </span>
- <Show when={query.error()}>
- <button
- type="button"
- class="min-h-10 shrink-0 rounded-md border border-current px-3 font-medium hover:underline focus-visible:outline-solid focus-visible:outline-2 focus-visible:outline-offset-2 disabled:opacity-50"
- aria-label={`Retry ${label} inventory`}
- disabled={query.loading()}
- onClick={() => void query.refetch()}
- >
- {query.loading() ? 'Retrying…' : `Retry ${label} inventory`}
- </button>
+ <Show
+ when={
+ hasReadableInventory() || inventorySources.some(({ query }) => Boolean(query.error()))
+ }
+ fallback={
+ <PlatformTableLoadingState
+ title="Loading Proxmox backup inventory"
+ description="Reading PBS snapshots, PVE backup files, guest snapshots, and recent backup tasks."
+ />
+ }
+ >
+ <div class="space-y-3">
+ <PlatformSectionTabs tabs={backupViewTabs()} active={view()} ariaLabel="Backup views" />
+ <Show when={protectionPostures.response.error}>
+ <div role="status" class={BACKUP_READ_NOTICE_CLASS}>
+ Protection posture is unavailable. Pulse is showing restore evidence without
+ guessing whether workloads are protected.
+ </div>
+ </Show>
+
+ {/* The health strip renders identically in both route-backed views. */}
+ <ProxmoxBackupsCoverageStrip
+ title="Backup health"
+ footnote={getBackupPostureRuleText(protectionPostures.policy()) ?? undefined}
+ tail={
+ <span>
+ {liveTotalCount()} targets ·{' '}
+ {recoveryModel().coverageSummary.recoverableArtifacts} restore points
+ {inventoryIncomplete() ? ' read' : ''}
+ <Show when={recoveryModel().coverageSummary.withPBS > 0}>
+ {' · '}
+ {recoveryModel().coverageSummary.withPBS} with{' '}
+ {getProxmoxBackupSourcePresentation('pbs').filterLabel}
</Show>
- </div>
- </Show>
- )}
- </For>
- <Show when={protectionPostures.response.error}>
- <div role="status" class={BACKUP_READ_NOTICE_CLASS}>
- Protection posture is unavailable. Pulse is showing restore evidence without guessing
- whether workloads are protected.
- </div>
- </Show>
- <Show when={(props.servers?.length ?? 0) > 0}>
- <ProxmoxBackupServersTable
- servers={props.servers ?? []}
- backups={pbsArtifacts()}
- backupInventoryState={
- pbsBackups.error()
- ? 'unavailable'
- : pbsBackups.resolvedOnce()
- ? 'available'
- : 'loading'
+ <Show when={orphanedTotalCount() > 0}>
+ {' · '}
+ {orphanedTotalCount()} unmatched
+ </Show>
+ </span>
}
+ segments={[
+ {
+ key: 'protected',
+ value: liveHealthSummary().protected,
+ ...postureSegmentFilter('protected'),
+ label: 'protected',
+ toneClass: 'bg-emerald-500',
+ },
+ {
+ key: 'attention',
+ value: liveHealthSummary().attention,
+ ...postureSegmentFilter('attention'),
+ label: 'attention',
+ toneClass: 'bg-amber-500',
+ muted: liveHealthSummary().attention === 0,
+ },
+ {
+ key: 'unprotected',
+ value: liveHealthSummary().unprotected,
+ ...postureSegmentFilter('unprotected'),
+ label: 'unprotected',
+ toneClass: 'bg-red-500',
+ muted: liveHealthSummary().unprotected === 0,
+ },
+ {
+ key: 'unknown',
+ value: liveHealthSummary().unknown,
+ ...postureSegmentFilter('unknown'),
+ label: 'unknown',
+ toneClass: 'bg-slate-400',
+ muted: liveHealthSummary().unknown === 0,
+ },
+ {
+ key: 'checking',
+ value: liveHealthSummary().checking,
+ label: 'checking',
+ toneClass: 'bg-blue-400',
+ muted: liveHealthSummary().checking === 0,
+ },
+ {
+ key: 'not-evaluated',
+ value: liveHealthSummary().notEvaluated,
+ label: 'not evaluated',
+ toneClass: 'bg-slate-300 dark:bg-slate-600',
+ muted: liveHealthSummary().notEvaluated === 0,
+ },
+ ]}
/>
- </Show>
- {/* The health strip renders identically in both route-backed views. */}
- <ProxmoxBackupsCoverageStrip
- title="Backup health"
- footnote={getBackupPostureRuleText(protectionPostures.policy()) ?? undefined}
- tail={
- <span>
- {liveTotalCount()} targets · {recoveryModel().coverageSummary.recoverableArtifacts}{' '}
- restore points{inventoryIncomplete() ? ' read' : ''}
- <Show when={recoveryModel().coverageSummary.withPBS > 0}>
- {' · '}
- {recoveryModel().coverageSummary.withPBS} with{' '}
- {getProxmoxBackupSourcePresentation('pbs').filterLabel}
- </Show>
- <Show when={orphanedTotalCount() > 0}>
- {' · '}
- {orphanedTotalCount()} unmatched
- </Show>
- </span>
- }
- segments={[
- {
- key: 'protected',
- value: liveHealthSummary().protected,
- ...postureSegmentFilter('protected'),
- label: 'protected',
- toneClass: 'bg-emerald-500',
- },
- {
- key: 'attention',
- value: liveHealthSummary().attention,
- ...postureSegmentFilter('attention'),
- label: 'attention',
- toneClass: 'bg-amber-500',
- muted: liveHealthSummary().attention === 0,
- },
- {
- key: 'unprotected',
- value: liveHealthSummary().unprotected,
- ...postureSegmentFilter('unprotected'),
- label: 'unprotected',
- toneClass: 'bg-red-500',
- muted: liveHealthSummary().unprotected === 0,
- },
- {
- key: 'unknown',
- value: liveHealthSummary().unknown,
- ...postureSegmentFilter('unknown'),
- label: 'unknown',
- toneClass: 'bg-slate-400',
- muted: liveHealthSummary().unknown === 0,
- },
- {
- key: 'checking',
- value: liveHealthSummary().checking,
- label: 'checking',
- toneClass: 'bg-blue-400',
- muted: liveHealthSummary().checking === 0,
- },
- {
- key: 'not-evaluated',
- value: liveHealthSummary().notEvaluated,
- label: 'not evaluated',
- toneClass: 'bg-slate-300 dark:bg-slate-600',
- muted: liveHealthSummary().notEvaluated === 0,
- },
- ]}
- />
-
- <Show when={view() === 'date' && recoveryModel().recoverableArtifacts.length > 0}>
- <Show
- when={recoveryModel().recoverableArtifacts.some(
- (artifact) => artifact.createdMs === undefined,
- )}
- >
- <p class="text-xs text-amber-700 dark:text-amber-300" role="status">
- Backup entries with unavailable or future dates remain listed. Their ages are
- unknown. They are excluded from the activity chart and day filters.
- </p>
- </Show>
- <Show
- when={hasRecoverableActivityInRange()}
- fallback={
- <div class="flex flex-col gap-2 rounded-md border border-border-subtle px-3 py-3 text-xs text-muted sm:flex-row sm:items-center sm:justify-between">
- <span>No dated backup activity in the selected {chartRange()}-day window.</span>
- <div class="flex items-center gap-2">
- <button
- type="button"
- class="font-medium text-blue-600 hover:underline dark:text-blue-300"
- onClick={() => setChartRange(90)}
- >
- Show 90 days
- </button>
- <span aria-hidden="true">·</span>
- <button
- type="button"
- class="font-medium text-blue-600 hover:underline dark:text-blue-300"
- onClick={() => setChartRange(365)}
- >
- Show 1 year
- </button>
+ <Show when={view() === 'date' && recoveryModel().recoverableArtifacts.length > 0}>
+ <Show
+ when={recoveryModel().recoverableArtifacts.some(
+ (artifact) => artifact.createdMs === undefined,
+ )}
+ >
+ <p class="text-xs text-amber-700 dark:text-amber-300" role="status">
+ Backup entries with unavailable or future dates remain listed. Their ages are
+ unknown. They are excluded from the activity chart and day filters.
+ </p>
+ </Show>
+ <Show
+ when={hasRecoverableActivityInRange()}
+ fallback={
+ <div class="flex flex-col gap-2 rounded-md border border-border-subtle px-3 py-3 text-xs text-muted sm:flex-row sm:items-center sm:justify-between">
+ <span>No dated backup activity in the selected {chartRange()}-day window.</span>
+ <div class="flex items-center gap-2">
+ <button
+ type="button"
+ class="font-medium text-blue-600 hover:underline dark:text-blue-300"
+ onClick={() => setChartRange(90)}
+ >
+ Show 90 days
+ </button>
+ <span aria-hidden="true">·</span>
+ <button
+ type="button"
+ class="font-medium text-blue-600 hover:underline dark:text-blue-300"
+ onClick={() => setChartRange(365)}
+ >
+ Show 1 year
+ </button>
+ </div>
</div>
- </div>
- }
- >
- <BackupActivityChart
- title={
- recoverableMetricMode() === 'volume' ? 'Backup volume per day' : 'Backups per day'
}
- noun="backup"
- segmentKinds={RECOVERABLE_SEGMENT_KINDS}
- range={chartRange}
- onRangeChange={setChartRange}
- timeline={recoverableTimeline}
- selectedDateKey={selectedDateKey}
- onToggleDay={toggleDay}
- metricToggle={{ mode: recoverableMetricMode, onChange: setRecoverableMetricMode }}
- />
- </Show>
- </Show>
-
- <FilterBar
- role="group"
- ariaLabel="Backups filters"
- isMobile={isMobile}
- search={{
- value: search,
- setValue: setSearch,
- placeholder: 'Search backups by workload, node, source, or status',
- }}
- filters={buildBackupsFilters()}
- showClearAll={hasActiveBackupsFilters}
- onClearAll={resetBackupsFilters}
- searchTrailing={
- <Show when={view() === 'date' && selectedDateKey() !== null}>
- <button
- type="button"
- onClick={() => setSelectedDateKey(null)}
- class="inline-flex items-center gap-1 rounded-full border border-blue-300 bg-blue-50 px-2 py-0.5 text-[11px] font-medium text-blue-700 transition-colors hover:bg-blue-100 dark:border-blue-700 dark:bg-blue-900/30 dark:text-blue-200 dark:hover:bg-blue-900/50"
- aria-label="Clear date filter"
- >
- <span class="uppercase tracking-wide text-[9px] text-blue-600 dark:text-blue-300">
- Date
- </span>
- <span class="font-mono tabular-nums">
- {getRecoveryFilterDateLabel(selectedDateKey()!)}
- </span>
- <span aria-hidden="true">×</span>
- </button>
+ >
+ <BackupActivityChart
+ title={
+ recoverableMetricMode() === 'volume'
+ ? 'Backup volume per day'
+ : 'Backups per day'
+ }
+ noun="backup"
+ segmentKinds={RECOVERABLE_SEGMENT_KINDS}
+ range={chartRange}
+ onRangeChange={setChartRange}
+ timeline={recoverableTimeline}
+ selectedDateKey={selectedDateKey}
+ onToggleDay={toggleDay}
+ metricToggle={{ mode: recoverableMetricMode, onChange: setRecoverableMetricMode }}
+ />
</Show>
- }
- trailingControls={
- <PlatformResourceCounter
- visible={view() === 'date' ? visibleRecoverableCount() : visibleLiveCount()}
- total={view() === 'date' ? totalRecoverableCount() : liveTotalCount()}
- rowNoun={
- view() === 'date'
- ? inventoryIncomplete()
- ? 'backups read'
- : 'backups'
- : 'targets'
- }
- />
- }
- />
+ </Show>
- <Show when={view() === 'date'}>
- <ProxmoxRecoverableTable
- artifacts={filteredRecoverableArtifacts()}
- hasAnyArtifacts={recoveryModel().recoverableArtifacts.length > 0}
- emptyIcon={props.emptyIcon}
- emptyTitle={
- inventoryIncomplete() ? 'Backup inventory is incomplete' : 'No backups yet'
+ <FilterBar
+ role="group"
+ ariaLabel="Backups filters"
+ isMobile={isMobile}
+ search={{
+ value: search,
+ setValue: setSearch,
+ placeholder: 'Search backups by workload, node, source, or status',
+ }}
+ filters={buildBackupsFilters()}
+ showClearAll={hasActiveBackupsFilters}
+ onClearAll={resetBackupsFilters}
+ searchTrailing={
+ <Show when={view() === 'date' && selectedDateKey() !== null}>
+ <button
+ type="button"
+ onClick={() => setSelectedDateKey(null)}
+ class="inline-flex items-center gap-1 rounded-full border border-blue-300 bg-blue-50 px-2 py-0.5 text-[11px] font-medium text-blue-700 transition-colors hover:bg-blue-100 dark:border-blue-700 dark:bg-blue-900/30 dark:text-blue-200 dark:hover:bg-blue-900/50"
+ aria-label="Clear date filter"
+ >
+ <span class="uppercase tracking-wide text-[9px] text-blue-600 dark:text-blue-300">
+ Date
+ </span>
+ <span class="font-mono tabular-nums">
+ {getRecoveryFilterDateLabel(selectedDateKey()!)}
+ </span>
+ <span aria-hidden="true">×</span>
+ </button>
+ </Show>
}
- emptyDescription={
- inventoryIncomplete()
- ? 'Some backup sources are still loading or unavailable. Missing restore points do not mean no backups exist.'
- : 'PBS snapshots, PVE backup files, and guest snapshots will appear here once backups run.'
+ trailingControls={
+ <PlatformResourceCounter
+ visible={view() === 'date' ? visibleRecoverableCount() : visibleLiveCount()}
+ total={view() === 'date' ? totalRecoverableCount() : liveTotalCount()}
+ rowNoun={
+ view() === 'date'
+ ? inventoryIncomplete()
+ ? 'backups read'
+ : 'backups'
+ : 'targets'
+ }
+ />
}
- sortKey={recoverableSortKey}
- sortDirection={recoverableSortDirection}
- onSort={handleRecoverableSort}
- sizeMaxBytes={recoverableSizeMaxBytes()}
- groupByDay
/>
- </Show>
- <Show when={view() === 'coverage'}>
- <ProxmoxCoverageTable
- rows={liveCoverageRows()}
- hasAnyRows={liveTotalCount() > 0}
- emptyIcon={props.emptyIcon}
- emptyTitle="No backup target coverage"
- emptyDescription="VM, container, and host restore posture will appear here once backup data exists."
- sortKey={coverageSortKey}
- sortDirection={coverageSortDirection}
- onSort={handleCoverageSort}
- expandedKeys={expandedCoverageRows()}
- onToggleExpand={toggleCoverageExpansion}
- showTaskColumn={coverageHasTask()}
- />
+ <Show when={view() === 'date'}>
+ <ProxmoxRecoverableTable
+ artifacts={filteredRecoverableArtifacts()}
+ hasAnyArtifacts={recoveryModel().recoverableArtifacts.length > 0}
+ emptyIcon={props.emptyIcon}
+ emptyTitle={
+ inventoryIncomplete() ? 'Backup inventory is incomplete' : 'No backups yet'
+ }
+ emptyDescription={
+ inventoryIncomplete()
+ ? 'Some backup sources are still loading or unavailable. Missing restore points do not mean no backups exist.'
+ : 'PBS snapshots, PVE backup files, and guest snapshots will appear here once backups run.'
+ }
+ sortKey={recoverableSortKey}
+ sortDirection={recoverableSortDirection}
+ onSort={handleRecoverableSort}
+ sizeMaxBytes={recoverableSizeMaxBytes()}
+ groupByDay
+ />
+ </Show>
- <Show when={orphanedTotalCount() > 0}>
- <div class="rounded-lg border border-border-subtle">
- <button
- type="button"
- onClick={() => setShowOrphaned((v) => !v)}
- class="flex w-full flex-wrap items-center justify-between gap-2 px-3 py-2 text-left"
- aria-expanded={showOrphaned()}
- >
- <span class="flex items-center gap-2 text-[11px] font-semibold uppercase tracking-[0.18em] text-muted">
- <ChevronRightIcon
- class={`h-3.5 w-3.5 transition-transform ${showOrphaned() ? 'rotate-90' : ''}`}
- aria-hidden="true"
- />
- {orphanedTotalCount()} unmatched{' '}
- {orphanedTotalCount() === 1 ? 'backup' : 'backups'}
- </span>
- <span class="w-full text-[11px] text-muted sm:w-auto">
- No unambiguous inventory match
- </span>
- </button>
- <Show when={showOrphaned()}>
- <div class="border-t border-border-subtle p-2">
- <ProxmoxCoverageTable
- rows={orphanedCoverageRows()}
- hasAnyRows={orphanedTotalCount() > 0}
- emptyIcon={props.emptyIcon}
- emptyTitle="No unmatched backups"
- emptyDescription="Backups without an unambiguous live guest match will appear here."
- sortKey={coverageSortKey}
- sortDirection={coverageSortDirection}
- onSort={handleCoverageSort}
- expandedKeys={expandedCoverageRows()}
- onToggleExpand={toggleCoverageExpansion}
- showTaskColumn={coverageHasTask()}
- />
- </div>
- </Show>
- </div>
+ <Show when={view() === 'coverage'}>
+ <ProxmoxCoverageTable
+ rows={liveCoverageRows()}
+ hasAnyRows={liveTotalCount() > 0}
+ emptyIcon={props.emptyIcon}
+ emptyTitle="No backup target coverage"
+ emptyDescription="VM, container, and host restore posture will appear here once backup data exists."
+ sortKey={coverageSortKey}
+ sortDirection={coverageSortDirection}
+ onSort={handleCoverageSort}
+ expandedKeys={expandedCoverageRows()}
+ onToggleExpand={toggleCoverageExpansion}
+ showTaskColumn={coverageHasTask()}
+ />
+
+ <Show when={orphanedTotalCount() > 0}>
+ <div class="rounded-lg border border-border-subtle">
+ <button
+ type="button"
+ onClick={() => setShowOrphaned((v) => !v)}
+ class="flex w-full flex-wrap items-center justify-between gap-2 px-3 py-2 text-left"
+ aria-expanded={showOrphaned()}
+ >
+ <span class="flex items-center gap-2 text-[11px] font-semibold uppercase tracking-[0.18em] text-muted">
+ <ChevronRightIcon
+ class={`h-3.5 w-3.5 transition-transform ${showOrphaned() ? 'rotate-90' : ''}`}
+ aria-hidden="true"
+ />
+ {orphanedTotalCount()} unmatched{' '}
+ {orphanedTotalCount() === 1 ? 'backup' : 'backups'}
+ </span>
+ <span class="w-full text-[11px] text-muted sm:w-auto">
+ No unambiguous inventory match
+ </span>
+ </button>
+ <Show when={showOrphaned()}>
+ <div class="border-t border-border-subtle p-2">
+ <ProxmoxCoverageTable
+ rows={orphanedCoverageRows()}
+ hasAnyRows={orphanedTotalCount() > 0}
+ emptyIcon={props.emptyIcon}
+ emptyTitle="No unmatched backups"
+ emptyDescription="Backups without an unambiguous live guest match will appear here."
+ sortKey={coverageSortKey}
+ sortDirection={coverageSortDirection}
+ onSort={handleCoverageSort}
+ expandedKeys={expandedCoverageRows()}
+ onToggleExpand={toggleCoverageExpansion}
+ showTaskColumn={coverageHasTask()}
+ />
+ </div>
+ </Show>
+ </div>
+ </Show>
</Show>
- </Show>
- </div>
+ </div>
+ </Show>
</Show>
- </Show>
+ </div>
);
};
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
index 2841bd95cc..344635c18b 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
@@ -923,7 +923,7 @@ describe('independent Proxmox backup inventory reads', () => {
mountBackupReadState();
await screen.findByText(/PBS backup inventory is loading/);
expect(screen.queryByText('No backups yet')).not.toBeInTheDocument();
- expect(screen.getByText('Backup inventory is incomplete')).toBeInTheDocument();
+ await screen.findByText('Backup inventory is incomplete');
expect(serverTable()).toHaveTextContent('Loading');
pending.resolve(jsonResponse(emptyPBS));
await screen.findByText('No backups yet');
@@ -940,7 +940,7 @@ describe('independent Proxmox backup inventory reads', () => {
);
mountBackupReadState();
await screen.findByText(/PVE backup inventory is loading/);
- expect(recoverableRows()).toHaveLength(1);
+ await waitFor(() => expect(recoverableRows()).toHaveLength(1));
expect(screen.getByText(/1 restore points read/)).toBeInTheDocument();
pending.resolve(jsonResponse(readPvePayload));
await waitFor(() => expect(recoverableRows()).toHaveLength(2));
@@ -996,6 +996,77 @@ describe('independent Proxmox backup inventory reads', () => {
},
);
+ it('keeps known PBS health and unknown counts usable while both inventories are loading', async () => {
+ const pve = deferred<Response>();
+ const pbs = deferred<Response>();
+ apiFetchMock.mockImplementation((url) => (url.endsWith('/pbs') ? pbs.promise : pve.promise));
+ mountBackupReadState();
+ expect(serverTable()).toHaveTextContent('pbs-main');
+ expect(serverTable()).toHaveTextContent('Loading');
+ expect(serverTable()).toHaveTextContent('40.0%');
+ expect(screen.queryByText('No backups yet')).not.toBeInTheDocument();
+ await screen.findByText(/PVE backup inventory is loading/);
+ expect(screen.getByText(/PBS backup inventory is loading/)).toBeInTheDocument();
+ const originalServerTable = serverTable();
+ pve.resolve(jsonResponse(emptyPVE));
+ pbs.resolve(jsonResponse(emptyPBS));
+ await screen.findByText('No backups yet');
+ expect(serverTable()).toBe(originalServerTable);
+ expect(
+ within(serverTable() as HTMLElement).getByText('0', { exact: true }),
+ ).toBeInTheDocument();
+ });
+
+ it.each(['pve', 'pbs', 'both'] as const)(
+ 'keeps separately known PBS identity and health mounted through %s inventory failure and recovery',
+ async (failed) => {
+ apiFetchMock.mockImplementation((url) =>
+ Promise.resolve(
+ failed === 'both' || url.endsWith(`/${failed}`)
+ ? new Response('{}', { status: 503 })
+ : jsonResponse(url.endsWith('/pbs') ? emptyPBS : emptyPVE),
+ ),
+ );
+ mountBackupReadState();
+ const originalServerTable = serverTable();
+ await screen.findByText(
+ new RegExp(`${failed === 'pve' ? 'PVE' : 'PBS'} backup inventory is unavailable`),
+ );
+ expect(serverTable()).toBe(originalServerTable);
+ expect(serverTable()).toHaveTextContent('pbs-main');
+ expect(serverTable()).toHaveTextContent('40.0%');
+ if (failed === 'pve') {
+ await within(serverTable() as HTMLElement).findByText('0', { exact: true });
+ } else {
+ expect(serverTable()).toHaveTextContent('Unavailable');
+ }
+ expect(screen.queryByText('No backups yet')).not.toBeInTheDocument();
+ if (failed === 'both') {
+ expect(screen.getByText('Could not load Proxmox backup inventory')).toBeInTheDocument();
+ expect(screen.getByText(/PVE backup inventory is unavailable/)).toBeInTheDocument();
+ expect(screen.queryByText(/0 restore points/)).not.toBeInTheDocument();
+ }
+ apiFetchMock.mockImplementation((url) =>
+ Promise.resolve(jsonResponse(url.endsWith('/pbs') ? pbsPayload : readPvePayload)),
+ );
+ if (failed === 'both') fireEvent.click(screen.getByRole('button', { name: 'Refresh' }));
+ else
+ fireEvent.click(
+ screen.getByRole('button', { name: `Retry ${failed.toUpperCase()} inventory` }),
+ );
+ await waitFor(() =>
+ expect(screen.queryByText(/inventory is unavailable/)).not.toBeInTheDocument(),
+ );
+ expect(serverTable()).toBe(originalServerTable);
+ expect(serverTable()).not.toHaveTextContent('Unavailable');
+ expect(
+ within(serverTable() as HTMLElement).getByText(failed === 'pve' ? '0' : '1', {
+ exact: true,
+ }),
+ ).toBeInTheDocument();
+ },
+ );
+
it('retries both failed inventories and allows the first recovered source to render', async () => {
apiFetchMock.mockResolvedValue(new Response('{}', { status: 500 }));
mountBackupReadState();
@@ -1007,7 +1078,7 @@ describe('independent Proxmox backup inventory reads', () => {
);
fireEvent.click(screen.getByRole('button', { name: 'Refresh' }));
await screen.findByText(/PVE backup inventory is unavailable/);
- expect(recoverableRows()).toHaveLength(1);
+ await waitFor(() => expect(recoverableRows()).toHaveLength(1));
pending.resolve(jsonResponse(readPvePayload));
await waitFor(() => expect(recoverableRows()).toHaveLength(2));
expect(sourceCalls('pve')).toHaveLength(2);