Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Establish real storage firing state before recovery controls

pulse-triage[bot]56c06ec45265
diff --git a/internal/alerts/metric_observation_continuity_test.go b/internal/alerts/metric_observation_continuity_test.go
index ffef188997..cf726ec6f6 100644
--- a/internal/alerts/metric_observation_continuity_test.go
+++ b/internal/alerts/metric_observation_continuity_test.go
@@ -274,14 +274,20 @@ func TestMetricObservationGapRestartsRecovery(t *testing.T) {
t.Run(route+"/"+gap, func(t *testing.T) {
m, elapsed := continuityManager(t, false)
id, metric, observe := continuityObserver(t, m, route, gap)
- observe(95, false) // Critical evidence retains its legacy immediate activation.
+ observe(95, false)
+ // Storage's usage rule retains its configured sustained-for delay.
+ // Establish a firing occurrence before testing recovery timing.
+ if route == "storage" {
+ elapsed.Store(int64(time.Minute))
+ observe(95, false)
+ }
if len(m.GetActiveAlerts()) != 1 {
- t.Fatal("critical control did not fire immediately")
+ t.Fatal("breaching control did not establish a firing occurrence")
}
if err := m.AcknowledgeAlert(m.GetActiveAlerts()[0].ID, "operator"); err != nil {
t.Fatal(err)
}
- elapsed.Store(int64(10 * time.Second))
+ elapsed.Store(int64(70 * time.Second))
observe(10, false)
incident, _ := continuityIncident(m, id, metric)
if incident.RecoverySince.IsZero() {
diff --git a/internal/alerts/threshold_resolution_shared_test.go b/internal/alerts/threshold_resolution_shared_test.go
index 1b05799eb7..8730e0ddd7 100644
--- a/internal/alerts/threshold_resolution_shared_test.go
+++ b/internal/alerts/threshold_resolution_shared_test.go
@@ -1748,7 +1748,7 @@ func TestStorageConnectivityObservationGaps(t *testing.T) {
before := testRequireActiveAlert(t, m, id).Clone()
s.Status = gap
m.CheckStorage(s)
- if !reflect.DeepEqual(before, testRequireActiveAlert(t, m, id)) || m.GetResolvedAlert(id) != nil {
+ if !reflect.DeepEqual(before, testRequireActiveAlert(t, m, id).Clone()) || m.GetResolvedAlert(id) != nil {
t.Fatal("missing connectivity changed acknowledged occurrence")
}
s.Status = "available"