Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Reject native image-pin drift before frontend preparation

pulse-triage[bot]58e510214a70
diff --git a/.github/workflows/unified-agent-native.yml b/.github/workflows/unified-agent-native.yml
index 233e3b4be8..2adf9b2a04 100644
--- a/.github/workflows/unified-agent-native.yml
+++ b/.github/workflows/unified-agent-native.yml
@@ -98,6 +98,13 @@ jobs:
go-version-file: go.mod
cache: true
+ # These source-only checks need neither Node nor generated assets. Reject
+ # a broken pin before frontend acquisition/build and native runtime work;
+ # the complete installer inventory still runs below on passing source.
+ - name: Check immutable integration images before frontend preparation
+ if: matrix.unix
+ run: go test -count=1 -timeout 3m -run '^TestIntegrationContainer' ./scripts/installtests
+
- name: Set up Node.js for native runtime test assets
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
diff --git a/docs/release-control/v6/internal/subsystems/deployment-installability.md b/docs/release-control/v6/internal/subsystems/deployment-installability.md
index 67b5120c1b..86b5afdf31 100644
--- a/docs/release-control/v6/internal/subsystems/deployment-installability.md
+++ b/docs/release-control/v6/internal/subsystems/deployment-installability.md
@@ -51,6 +51,16 @@ missing, mutable or malformed defaults and partial digests. This reconciles
the native source check with the existing compose expression; it changes no
image, Docker admission, installer behaviour, deadline or required CI gate.
+Every native Unix job executes these uncached source-only image checks after
+Go setup and before Node setup, frontend dependency acquisition/build or native
+runtime tests. A pin failure stops that job before those prerequisites; this
+preflight needs no generated frontend assets. Passing source still builds the
+real frontend and runs the unchanged exhaustive installer inventory, helper and
+agent tests and native execution. `TestNativeAgentRejectsBrokenImagesBeforeFrontendPreparation`
+guards ordering, all-Unix coverage, bounded actual selection, terminal failure
+and retention of the real frontend build. Source proof is not hosted timing or
+an installed result; containing native CI remains the operational check.
+
### Existing auto-update timers are discovered without changing consent
Server installer timer discovery is a bounded, exact-unit `systemctl` inventory.
diff --git a/scripts/installtests/native_agent_frontend_test.go b/scripts/installtests/native_agent_frontend_test.go
index 8759a0de37..75b359c97b 100644
--- a/scripts/installtests/native_agent_frontend_test.go
+++ b/scripts/installtests/native_agent_frontend_test.go
@@ -16,6 +16,94 @@ type nativeAgentFrontendStep struct {
With map[string]string
WorkingDirectory string `yaml:"working-directory"`
Run string
+ ContinueOnError bool `yaml:"continue-on-error"`
+}
+
+func validateNativeImagePreflight(steps []nativeAgentFrontendStep) error {
+ goAt, checkAt, nodeAt := -1, -1, -1
+ for i, step := range steps {
+ switch step.Name {
+ case "Set up Go":
+ goAt = i
+ case "Check immutable integration images before frontend preparation":
+ if checkAt >= 0 {
+ return fmt.Errorf("immutable integration image preflight must run once")
+ }
+ checkAt = i
+ case "Set up Node.js for native runtime test assets":
+ nodeAt = i
+ }
+ }
+ if goAt < 0 || checkAt <= goAt || nodeAt <= checkAt {
+ return fmt.Errorf("immutable image checks must follow Go setup and precede frontend preparation")
+ }
+ check := steps[checkAt]
+ if check.If != "matrix.unix" || check.ContinueOnError || check.WorkingDirectory != "" ||
+ strings.TrimSpace(check.Run) != "go test -count=1 -timeout 3m -run '^TestIntegrationContainer' ./scripts/installtests" {
+ return fmt.Errorf("immutable image preflight must execute the uncached bounded source checks on every Unix platform and retain failure")
+ }
+ return validateNativeAgentFrontendPreparation(steps)
+}
+
+func TestNativeAgentRejectsBrokenImagesBeforeFrontendPreparation(t *testing.T) {
+ content, err := os.ReadFile(repoFile(".github", "workflows", "unified-agent-native.yml"))
+ if err != nil {
+ t.Fatal(err)
+ }
+ var workflow struct {
+ Jobs map[string]struct{ Steps []nativeAgentFrontendStep }
+ }
+ if err := yaml.Unmarshal(content, &workflow); err != nil {
+ t.Fatal(err)
+ }
+ steps := workflow.Jobs["native-agent"].Steps
+ if err := validateNativeImagePreflight(steps); err != nil {
+ t.Fatal(err)
+ }
+ checkAt, nodeAt := -1, -1
+ for i, step := range steps {
+ switch step.Name {
+ case "Check immutable integration images before frontend preparation":
+ checkAt = i
+ case "Set up Node.js for native runtime test assets":
+ nodeAt = i
+ }
+ }
+ for _, scenario := range []string{"missing", "late", "before Go", "Linux only", "hidden failure", "cached", "empty selection", "stub assets", "missing real build"} {
+ t.Run(scenario, func(t *testing.T) {
+ changed := append([]nativeAgentFrontendStep(nil), steps...)
+ switch scenario {
+ case "missing":
+ changed = append(changed[:checkAt], changed[checkAt+1:]...)
+ case "late":
+ changed[checkAt], changed[nodeAt] = changed[nodeAt], changed[checkAt]
+ case "before Go":
+ changed[checkAt], changed[checkAt-1] = changed[checkAt-1], changed[checkAt]
+ case "Linux only":
+ changed[checkAt].If = "runner.os == 'Linux'"
+ case "hidden failure":
+ changed[checkAt].ContinueOnError = true
+ case "cached":
+ changed[checkAt].Run = strings.Replace(changed[checkAt].Run, "-count=1 ", "", 1)
+ case "empty selection":
+ changed[checkAt].Run = strings.Replace(changed[checkAt].Run, "^TestIntegrationContainer", "^TestNonexistent", 1)
+ case "stub assets", "missing real build":
+ for i, step := range changed {
+ if step.Name == "Build real frontend assets for API-linked native tests" {
+ if scenario == "stub assets" {
+ changed[i].Run = "touch index.html"
+ } else {
+ changed = append(changed[:i], changed[i+1:]...)
+ }
+ break
+ }
+ }
+ }
+ if err := validateNativeImagePreflight(changed); err == nil {
+ t.Fatalf("accepted %s immutable-image preflight", scenario)
+ }
+ })
+ }
}
func validateNativeAgentFrontendTriggers(content []byte) error {