Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Identify each dated backup disclosure by its restore point

pulse-triage[bot]5a0226c9ce72
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index b874f9f5f7..960917c465 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -21,6 +21,28 @@
## Purpose
+### A dated backup disclosure identifies the restore point, not only its owner
+
+The By date table keeps its existing native disclosure visible at phone widths,
+with a reserved 36px target beside the wrapping identity. A disclosure names the
+workload/PVE connection, source kind, precise creation time (or Unknown), backup
+reader, location and native identifier. Repeated workloads, tied dates and
+unavailable dates do not collapse into indistinguishable controls; sorting does
+not supply identity. Visible Created detail uses the same second/time-zone
+precision. State-only polls do not rename the point; revised reader/location
+facts update the existing disclosure without dropping focus or changing owners.
+
+Normal-suite `ProxmoxRecoverableTable.test.tsx` and
+`recoverableIdentityAccess.test.tsx` cover names, unknown/tied dates, raw inventory
+consumption, visible controls, single native activation and scoped refresh.
+Actual-App desktop/narrow browser proof exercises point selection by accessible
+identity, keyboard/phone activation, close-focus return and same-ID polling,
+with inspected pixels. No shared primitive, source identity, provider read,
+classification, count, policy or guest/backup/restore operation changes. This
+makes existing inspection usable; it does not establish a tested restore,
+original guest recovery or release availability.
+
+
### Restore-point inspection states what its evidence cannot confirm
The existing By date record detail places a visible, wrapping evidence-limits
diff --git a/docs/release-control/v6/internal/subsystems/unified-resources.md b/docs/release-control/v6/internal/subsystems/unified-resources.md
index 825235c090..fb80306d68 100644
--- a/docs/release-control/v6/internal/subsystems/unified-resources.md
+++ b/docs/release-control/v6/internal/subsystems/unified-resources.md
@@ -23,6 +23,28 @@ and sort the complete canonical change table while startup and ingestion wait.
## Purpose
+### A dated backup disclosure identifies the restore point, not only its owner
+
+The By date table keeps its existing native disclosure visible at phone widths,
+with a reserved 36px target beside the wrapping identity. A disclosure names the
+workload/PVE connection, source kind, precise creation time (or Unknown), backup
+reader, location and native identifier. Repeated workloads, tied dates and
+unavailable dates do not collapse into indistinguishable controls; sorting does
+not supply identity. Visible Created detail uses the same second/time-zone
+precision. State-only polls do not rename the point; revised reader/location
+facts update the existing disclosure without dropping focus or changing owners.
+
+Normal-suite `ProxmoxRecoverableTable.test.tsx` and
+`recoverableIdentityAccess.test.tsx` cover names, unknown/tied dates, raw inventory
+consumption, visible controls, single native activation and scoped refresh.
+Actual-App desktop/narrow browser proof exercises point selection by accessible
+identity, keyboard/phone activation, close-focus return and same-ID polling,
+with inspected pixels. No shared primitive, source identity, provider read,
+classification, count, policy or guest/backup/restore operation changes. This
+makes existing inspection usable; it does not establish a tested restore,
+original guest recovery or release availability.
+
+
### Restore-point inspection states what its evidence cannot confirm
The existing By date record detail places a visible, wrapping evidence-limits
diff --git a/frontend-modern/src/features/proxmox/ProxmoxRecoverableTable.tsx b/frontend-modern/src/features/proxmox/ProxmoxRecoverableTable.tsx
index 29124d12d4..a8ec2bd636 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxRecoverableTable.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxRecoverableTable.tsx
@@ -109,6 +109,26 @@ const artifactVerificationText = (artifact: RecoverableArtifact): string => {
return artifact.sourceKind === 'snapshot' ? '' : 'Not reported';
};
+const artifactCreatedLabel = (artifact: RecoverableArtifact): string =>
+ artifact.createdMs === undefined
+ ? 'Unknown'
+ : formatPlatformTableDateTimeValue(artifact.createdMs, {
+ dateTimeFormat: { second: '2-digit', timeZoneName: 'short' },
+ });
+
+// A dated feed can contain many points for the same workload. Name the point,
+// not just its owner: source, repository scope and native ID also distinguish
+// tied/unknown dates without inventing an order or using an unstable row index.
+const artifactDisclosureLabel = (artifact: RecoverableArtifact): string =>
+ [
+ getBackupWorkloadDisclosureLabel(artifact.workload),
+ getProxmoxBackupSourcePresentation(artifact.sourceKind).detailFallbackLabel,
+ `Created: ${artifactCreatedLabel(artifact)}`,
+ `Backup connection: ${artifact.locationConnection || 'Not reported'}`,
+ `Location: ${artifact.location}`,
+ `Identifier: ${artifact.nativeId}`,
+ ].join(' · ');
+
// State badges report provider evidence, not a tested recovery. Keep those
// limits beside the open point's state, where keyboard and touch readers can
// read them without hovering a badge or leaving for workload coverage.
@@ -143,13 +163,9 @@ const buildRecoverableDetailSections = (artifact: RecoverableArtifact): DetailSe
}),
makeDetailRow('Connection', artifact.locationConnection || 'Not reported', { wrap: true }),
makeDetailRow('Location', artifact.location, { wrap: true }),
- makeDetailRow(
- PROXMOX_BACKUP_COLUMN_LABELS.created,
- artifact.createdMs === undefined
- ? 'Unknown'
- : formatPlatformTableDateTimeValue(artifact.createdMs),
- { tone: artifact.createdMs === undefined ? 'warning' : undefined },
- ),
+ makeDetailRow(PROXMOX_BACKUP_COLUMN_LABELS.created, artifactCreatedLabel(artifact), {
+ tone: artifact.createdMs === undefined ? 'warning' : undefined,
+ }),
makeDetailRow(
'Size',
artifact.size && artifact.size > 0 ? formatPlatformTableBytesValue(artifact.size) : '',
@@ -284,8 +300,10 @@ export function ProxmoxRecoverableTable(props: {
<div class={`flex min-w-0 gap-2 ${stackedIdentity() ? 'items-start' : 'items-center'}`}>
<PlatformResourceDetailToggleButton
expanded={drawer.isExpanded(artifact)}
- resourceLabel={getBackupWorkloadDisclosureLabel(artifact.workload)}
+ resourceLabel={artifactDisclosureLabel(artifact)}
controlsId={drawer.detailRowId(artifact)}
+ hideWhenRowTappableOnMobile={false}
+ class="my-0"
onToggle={() => drawer.toggle(artifact)}
/>
<div class="min-w-0 flex-1">
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
index 896836b355..4ec87c042a 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
@@ -3074,7 +3074,7 @@ describe('By-date restore-point scope', () => {
/>
));
const toggle = await screen.findByRole('button', {
- name: 'Expand details for east-100 (VM 100) · PVE connection: east',
+ name: /^Expand details for east-100 \(VM 100\) · PVE connection: east · PBS snapshot/,
});
const point = toggle.closest('tr')!;
expect(point.querySelector('[data-backup-workload-connection]')).toHaveTextContent('PVE: east');
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxRecoverableTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxRecoverableTable.test.tsx
index 0c7cb8d3d6..0dba2089b7 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxRecoverableTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxRecoverableTable.test.tsx
@@ -90,7 +90,7 @@ describe('ProxmoxRecoverableTable record drawer', () => {
));
const toggle = screen.getByRole('button', {
- name: 'Expand details for web (VM 100) · PVE connection: Not reported',
+ name: /^Expand details for web \(VM 100\) · PVE connection: Not reported · PBS snapshot/,
});
expect(toggle).toHaveAttribute('aria-controls', 'proxmox-recoverable-detail-pbs:web:100');
await fireEvent.click(toggle);
@@ -111,7 +111,7 @@ describe('ProxmoxRecoverableTable record drawer', () => {
// Opening another restore point closes the first.
await fireEvent.click(
screen.getByRole('button', {
- name: 'Expand details for db (VM 101) · PVE connection: Not reported',
+ name: /^Expand details for db \(VM 101\) · PVE connection: Not reported · PBS snapshot/,
}),
);
expect(screen.getAllByTestId('proxmox-recoverable-detail')).toHaveLength(1);
@@ -203,3 +203,79 @@ describe('ProxmoxRecoverableTable responsive columns', () => {
expect(document.body.textContent).not.toContain('workload-599');
});
});
+
+describe('restore-point disclosure identity', () => {
+ it.each([320, 479, 720, 1200])('keeps a visible native disclosure at %ipx', (width) => {
+ renderTable(width);
+ const toggle = screen.getByRole('button', { name: /Expand details/ });
+ expect(toggle).not.toHaveClass('sr-only');
+ expect(toggle).toHaveClass('h-9', 'w-9', 'my-0');
+ expect(toggle).toHaveAttribute('type', 'button');
+ expect(toggle).toHaveAttribute('aria-expanded', 'false');
+ expect(toggle.closest('tr')).not.toHaveAttribute('tabindex');
+ });
+
+ it.each(['pbs', 'archive', 'snapshot'] as const)(
+ 'names tied and unknown %s points by their own scope and native identifier',
+ (sourceKind) => {
+ const points = ['first', 'second', 'unknown'].map((id) => ({
+ ...artifact,
+ id,
+ sourceKind,
+ nativeId: `native:${id}`,
+ locationConnection: 'backup-reader',
+ // Same workload, source, repository and instant; no row-index naming.
+ createdMs: id === 'unknown' ? undefined : artifact.createdMs,
+ }));
+ renderInRouter(() => (
+ <ProxmoxRecoverableTable
+ artifacts={points}
+ hasAnyArtifacts
+ emptyIcon={<span />}
+ emptyTitle=""
+ emptyDescription=""
+ sortKey={() => 'created'}
+ sortDirection={() => 'desc'}
+ onSort={() => {}}
+ sizeMaxBytes={0}
+ layoutWidth={() => 320}
+ />
+ ));
+ const toggles = screen.getAllByRole('button', { name: /Expand details/ });
+ expect(new Set(toggles.map((button) => button.getAttribute('aria-label'))).size).toBe(3);
+ for (const [index, button] of toggles.entries()) {
+ expect(button).toHaveAccessibleName(/web \(VM 100\) · PVE connection: Not reported/);
+ expect(button).toHaveAccessibleName(/Backup connection: backup-reader/);
+ expect(button).toHaveAccessibleName(/Location: main \/ pve1/);
+ expect(button).toHaveAccessibleName(new RegExp(`Identifier: native:${points[index].id}$`));
+ if (points[index].createdMs === undefined) {
+ expect(button).toHaveAccessibleName(/Created: Unknown/);
+ } else {
+ expect(button).not.toHaveAccessibleName(/Created: Unknown/);
+ }
+ }
+ fireEvent.click(toggles[2]);
+ const detail = screen.getByTestId('proxmox-recoverable-detail');
+ expect(detail).toHaveAttribute('data-inline-detail-for', 'unknown');
+ expect(within(detail).getByText('Created').closest('tr')).toHaveTextContent('Unknown');
+ expect(toggles[2]).toHaveAttribute('aria-expanded', 'true');
+ expect(toggles[0]).toHaveAttribute('aria-expanded', 'false');
+ },
+ );
+
+ it('does not double-toggle native Enter or Space through the containing row', () => {
+ renderTable(320);
+ const toggle = screen.getByRole('button', { name: /Expand details/ });
+ toggle.focus();
+ fireEvent.keyDown(toggle, { key: 'Enter' });
+ fireEvent.keyUp(toggle, { key: 'Enter' });
+ expect(toggle).toHaveAttribute('aria-expanded', 'true');
+ expect(screen.getAllByTestId('proxmox-recoverable-detail')).toHaveLength(1);
+ expect(toggle).toHaveFocus();
+ fireEvent.keyDown(toggle, { key: ' ', code: 'Space' });
+ fireEvent.keyUp(toggle, { key: ' ', code: 'Space' });
+ expect(toggle).toHaveAttribute('aria-expanded', 'false');
+ expect(screen.queryByTestId('proxmox-recoverable-detail')).not.toBeInTheDocument();
+ expect(toggle).toHaveFocus();
+ });
+});
diff --git a/frontend-modern/src/features/proxmox/__tests__/backupWorkloadIdentity.test.tsx b/frontend-modern/src/features/proxmox/__tests__/backupWorkloadIdentity.test.tsx
index 9a08e30de2..a5b0f4f311 100644
--- a/frontend-modern/src/features/proxmox/__tests__/backupWorkloadIdentity.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/backupWorkloadIdentity.test.tsx
@@ -186,7 +186,7 @@ describe('backup workload identity in real inventory consumers', () => {
);
await fireEvent.click(screen.getByRole('link', { name: /by date/i }));
const point = await screen.findByRole('button', {
- name: 'Expand details for same-name (VM 100) · PVE connection: east',
+ name: /^Expand details for same-name \(VM 100\) · PVE connection: east · PBS snapshot/,
});
fireEvent.click(point);
detail = screen.getByTestId('proxmox-recoverable-detail');
@@ -231,7 +231,7 @@ describe('backup workload identity in real inventory consumers', () => {
await fireEvent.click(screen.getByRole('link', { name: /by date/i }));
fireEvent.click(
await screen.findByRole('button', {
- name: 'Expand details for VM 100 · PVE connection: Not reported',
+ name: /^Expand details for VM 100 · PVE connection: Not reported · PBS snapshot/,
}),
);
expect(connectionRow(screen.getByTestId('proxmox-recoverable-detail'))).toHaveTextContent(
diff --git a/frontend-modern/src/features/proxmox/__tests__/recoverableIdentityAccess.test.tsx b/frontend-modern/src/features/proxmox/__tests__/recoverableIdentityAccess.test.tsx
index 8876a35b3c..da7bd371ac 100644
--- a/frontend-modern/src/features/proxmox/__tests__/recoverableIdentityAccess.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/recoverableIdentityAccess.test.tsx
@@ -214,7 +214,52 @@ describe('restore-point identity without hover', () => {
expect(screen.getByTestId('proxmox-recoverable-detail')).toBe(panel);
expect(panel).toHaveTextContent(reader);
expect(panel).not.toHaveTextContent('pbs-before');
+ expect(toggle).toHaveAccessibleName(/Backup connection: pbs-after/);
+ expect(toggle).toHaveAccessibleName(/Location: after \/ pve-1/);
+ expect(toggle).not.toHaveAccessibleName(/pbs-before/);
expect(document.activeElement).toBe(toggle);
expect(api.fetch).toHaveBeenCalledTimes(4);
});
});
+
+it('names multiple dates, readers and same-time snapshots independently in the raw inventory consumer', async () => {
+ const dated = [
+ identityPBS({ id: 'newer', backupTime: '2026-10-04T10:00:01Z' }),
+ identityPBS({ id: 'older', backupTime: '2026-10-03T10:00:01Z' }),
+ identityPBS({ id: 'offsite', instance: 'offsite-reader', backupTime: '2026-10-04T10:00:01Z' }),
+ ];
+ mount({
+ guests: workloads().slice(0, 1),
+ pve: () => ({
+ ...emptyPVE,
+ guestSnapshots: [
+ identitySnapshot({ id: 'before-upgrade', instance: scopes[0] }),
+ identitySnapshot({ id: 'before-packages', instance: scopes[0], name: 'before-packages' }),
+ ],
+ }),
+ pbs: () => dated,
+ });
+ const points = await rows();
+ expect(points).toHaveLength(5);
+ const controls = points.map((row) => within(row).getByRole('button', { name: /Expand details/ }));
+ expect(new Set(controls.map((button) => button.getAttribute('aria-label'))).size).toBe(5);
+ for (const id of ['newer', 'older', 'offsite', 'before-upgrade', 'before-packages']) {
+ const button = screen.getByRole('button', { name: new RegExp(`Identifier: ${id}$`) });
+ expect(button).not.toHaveClass('sr-only');
+ expect(button).toHaveAccessibleName(/Created:/);
+ expect(button).toHaveAccessibleName(/PVE connection: pve.cluster.production.london/);
+ fireEvent.click(button);
+ const detail = screen.getByTestId('proxmox-recoverable-detail');
+ expect(detail).toHaveAttribute(
+ 'data-inline-detail-for',
+ `${dated.some((p) => p.id === id) ? 'pbs' : 'snapshot'}:${id}`,
+ );
+ const created = within(detail)
+ .getByText('Created')
+ .closest('tr')!
+ .querySelector('td:last-child')!;
+ expect(button.getAttribute('aria-label')).toContain(`Created: ${created.textContent}`);
+ }
+ expect(screen.getAllByTestId('proxmox-recoverable-detail')).toHaveLength(1);
+ expect(api.fetch).toHaveBeenCalledTimes(2);
+});