Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.
Go aialertsdashboarddockerdocker-monitoringgohomelabinfrastructure-monitoringkubernetesmonitoringmspproxmoxproxmox-backup-serverproxmox-mail-gatewayproxmox-veself-hostedtruenastypescriptvspherewebhooks
Use sentence copy for the failure detail control
pulse-triage[bot]5aba90a11fa8
diff --git a/frontend-modern/src/components/Infrastructure/__tests__/ResourceDetailDrawer.platform-content.test.tsx b/frontend-modern/src/components/Infrastructure/__tests__/ResourceDetailDrawer.platform-content.test.tsxindex 65a69b3f54..c0c9e57583 100644--- a/frontend-modern/src/components/Infrastructure/__tests__/ResourceDetailDrawer.platform-content.test.tsx+++ b/frontend-modern/src/components/Infrastructure/__tests__/ResourceDetailDrawer.platform-content.test.tsx@@ -137,42 +137,49 @@ describe('ResourceDetailDrawer platform content', () => {expect(facts(unused.getByTestId)).toContain('Unused');});- it.each(['image', 'consumer'])('shows the %s check failure as ordinary wrapping text', (source) => {- const error = 'authentication required\n<em>registry.example.invalid</em>';- const updateStatus = { updateAvailable: false, error };- const image = baseResource({- id: 'image-failed',- type: 'docker-image',- name: 'registry.example.invalid/team/web:latest',- docker: {- hostname: 'edge-01',- image: 'registry.example.invalid/team/web:latest',- ...(source === 'image' ? { updateStatus } : {}),- },- });- if (source === 'consumer') {- estate.push(- baseResource({- id: 'consumer-failed',- type: 'app-container',- name: 'web',- docker: { image: image.docker!.image, updateStatus },- }),- );- }- const { getByTestId } = render(() => <ResourceDetailDrawer resource={image} />);- const lifted = getByTestId('resource-drawer-exceptions');- const reason = within(lifted).getByText(error, { exact: true, normalizer: (value) => value });- expect(within(lifted).getByText('Check failed')).toBeInTheDocument();- expect(reason).toHaveClass('select-text', 'whitespace-pre-wrap');- expect(reason.parentElement).toHaveClass('wrap-anywhere');- expect(reason.closest('details')).toBeNull();- expect(reason.querySelector('em')).toBeNull();- expect(reason.textContent).toBe(error);- });+ it.each(['image', 'consumer'])(+ 'shows the %s check failure as ordinary wrapping text',+ (source) => {+ const error = 'authentication required\n<em>registry.example.invalid</em>';+ const updateStatus = { updateAvailable: false, error };+ const image = baseResource({+ id: 'image-failed',+ type: 'docker-image',+ name: 'registry.example.invalid/team/web:latest',+ docker: {+ hostname: 'edge-01',+ image: 'registry.example.invalid/team/web:latest',+ ...(source === 'image' ? { updateStatus } : {}),+ },+ });+ if (source === 'consumer') {+ estate.push(+ baseResource({+ id: 'consumer-failed',+ type: 'app-container',+ name: 'web',+ docker: { image: image.docker!.image, updateStatus },+ }),+ );+ }+ const { getByTestId } = render(() => <ResourceDetailDrawer resource={image} />);+ const lifted = getByTestId('resource-drawer-exceptions');+ const reason = within(lifted).getByText(error, { exact: true, normalizer: (value) => value });+ expect(within(lifted).getByText('Check failed')).toBeInTheDocument();+ expect(reason).toHaveClass('select-text', 'whitespace-pre-wrap');+ expect(reason.parentElement).toHaveClass('wrap-anywhere');+ expect(reason.closest('details')).toBeNull();+ expect(reason.querySelector('em')).toBeNull();+ expect(reason.textContent).toBe(error);+ },+ );it.each([- ['Current', { updateAvailable: false }, 'No newer digest was reported by the last image check.'],+ [+ 'Current',+ { updateAvailable: false },+ 'No newer digest was reported by the last image check.',+ ],['Not checked', undefined, 'No update comparison has been reported for this image.'],['Pinned',@@ -184,19 +191,24 @@ describe('ResourceDetailDrawer platform content', () => {{ updateAvailable: false, error: 'local image' },'The image was built or loaded on this host, so no registry has a newer version to check.',],- ] as const)('keeps %s distinct and gives its explanation in Details', (label, updateStatus, reason) => {- const image = baseResource({- id: 'image-state',- type: 'docker-image',- name: 'service:latest',- docker: { image: 'service:latest', updateStatus },- });- const { getByTestId, queryByTestId } = render(() => <ResourceDetailDrawer resource={image} />);- const section = within(getByTestId('resource-docker-image-section'));- expect(section.getByText(label)).toBeInTheDocument();- expect(section.getByText(reason)).toBeInTheDocument();- expect(queryByTestId('resource-drawer-exceptions')).toBeNull();- });+ ] as const)(+ 'keeps %s distinct and gives its explanation in Details',+ (label, updateStatus, reason) => {+ const image = baseResource({+ id: 'image-state',+ type: 'docker-image',+ name: 'service:latest',+ docker: { image: 'service:latest', updateStatus },+ });+ const { getByTestId, queryByTestId } = render(() => (+ <ResourceDetailDrawer resource={image} />+ ));+ const section = within(getByTestId('resource-docker-image-section'));+ expect(section.getByText(label)).toBeInTheDocument();+ expect(section.getByText(reason)).toBeInTheDocument();+ expect(queryByTestId('resource-drawer-exceptions')).toBeNull();+ },+ );it('describes a Docker volume with its mountpoint in full', () => {const volume = baseResource({diff --git a/frontend-modern/src/features/docker/DockerImagesTable.tsx b/frontend-modern/src/features/docker/DockerImagesTable.tsxindex 21d6f13511..964540e6bb 100644--- a/frontend-modern/src/features/docker/DockerImagesTable.tsx+++ b/frontend-modern/src/features/docker/DockerImagesTable.tsx@@ -261,7 +261,7 @@ export const DockerImagesTable: Component<<buttontype="button"class={`inline-flex min-h-9 max-w-full items-center rounded-full px-2 py-0.5 text-[10px] font-medium underline decoration-dotted underline-offset-2 focus-visible:outline-hidden focus-visible:ring-2 focus-visible:ring-sky-400/70 sm:min-h-0 ${updateToneClass[operational().updateTone]}`}- aria-label={`Check failed for ${dockerResourceName(resource)}; details`}+ aria-label={`Check failed for ${dockerResourceName(resource)}. Details`}aria-expanded={isExpanded()}aria-controls={detailRowId()}title={operational().updateDetail}diff --git a/frontend-modern/src/features/docker/__tests__/DockerNativeTables.test.tsx b/frontend-modern/src/features/docker/__tests__/DockerNativeTables.test.tsxindex dcfd1ad6e8..8acb0c9b02 100644--- a/frontend-modern/src/features/docker/__tests__/DockerNativeTables.test.tsx+++ b/frontend-modern/src/features/docker/__tests__/DockerNativeTables.test.tsx@@ -1523,7 +1523,7 @@ describe('Docker native tables', () => {));const button = screen.getByRole('button', {- name: 'Check failed for registry.example.invalid/team/web:latest; details',+ name: 'Check failed for registry.example.invalid/team/web:latest. Details',});expect(button).toHaveAttribute('type', 'button');expect(button.tabIndex).toBe(0);