Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Separate storage runtime dependency proposals from other Go patches

pulse-triage[bot]5b25d801bca6
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
index e41dc22376..c785fa2b1a 100644
--- a/.github/dependabot.yml
+++ b/.github/dependabot.yml
@@ -56,6 +56,19 @@ updates:
applies-to: "version-updates"
patterns:
- "*"
+ exclude-patterns:
+ - "modernc.org/*"
+ update-types:
+ - "minor"
+ - "patch"
+ # Review the storage driver and its matching runtime together, without
+ # rebundling them with unrelated patches when one needs separate proof.
+ # This changes proposal scope, not eligibility: majors stay individual
+ # and the security-update group below continues to cover every module.
+ go-storage-runtime:
+ applies-to: "version-updates"
+ patterns:
+ - "modernc.org/*"
update-types:
- "minor"
- "patch"
diff --git a/docs/release-control/v6/internal/subsystems/deployment-installability.md b/docs/release-control/v6/internal/subsystems/deployment-installability.md
index 3248a1a8b9..5294e4dcff 100644
--- a/docs/release-control/v6/internal/subsystems/deployment-installability.md
+++ b/docs/release-control/v6/internal/subsystems/deployment-installability.md
@@ -7836,6 +7836,25 @@ binary/version/configuration/identity, no installer/manager mutation, exact
requests, and removal of all temporary files. These controls do not establish
published-installer or installed-host recovery.
+### Go dependency proposal isolation
+
+Dependabot's minor/patch version proposals keep the `modernc.org/*` storage
+driver/runtime family together in `go-storage-runtime` and exclude that family
+from `go-minor-patch`. An unrelated exporter or transport patch can therefore
+be reviewed without repeatedly importing a storage update that needs separate
+qualification. The storage group preserves the driver's matching runtime and
+transitive update scope rather than splitting its modules into competing PRs.
+This is review isolation, not a version pin, ignored dependency or acceptance
+of any storage update. Major updates stay individual; `go-security` still
+covers every module, with no new ignore entries or advisory suppression.
+
+`scripts/tests/test_dependabot_config.py`, run by `scripts/tests/run.sh`, checks
+the disjoint groups against the SQLite/libc and Prometheus combination seen in
+PR #3178, the remaining modernc runtime family and other Go patches. It also
+checks unchanged security coverage and individual major updates. This static
+configuration proof does not establish that GitHub has regenerated an existing
+proposal or that any dependency graph has passed runtime qualification.
+
### Governed dependency floors for the go-minor-patch group
The managed `go-minor-patch` group advances three direct modules together with
diff --git a/scripts/tests/test_dependabot_config.py b/scripts/tests/test_dependabot_config.py
index 7c7067bcb7..818d223e09 100644
--- a/scripts/tests/test_dependabot_config.py
+++ b/scripts/tests/test_dependabot_config.py
@@ -1,6 +1,7 @@
#!/usr/bin/env python3
"""Guard the low-noise dependency update policy and its covered manifests."""
+from fnmatch import fnmatchcase
import json
from pathlib import Path
import unittest
@@ -96,19 +97,74 @@ class DependabotConfigTest(unittest.TestCase):
("npm", "npm-minor-patch", "npm-security"),
):
groups = self.updates[ecosystem]["groups"]
+ version_policy = {
+ "applies-to": "version-updates",
+ "patterns": ["*"],
+ "update-types": ["minor", "patch"],
+ }
+ if ecosystem == "gomod":
+ version_policy["exclude-patterns"] = ["modernc.org/*"]
self.assertEqual(
groups[version_group],
- {
- "applies-to": "version-updates",
- "patterns": ["*"],
- "update-types": ["minor", "patch"],
- },
+ version_policy,
)
self.assertEqual(
groups[security_group],
{"applies-to": "security-updates", "patterns": ["*"]},
)
+ def test_go_storage_updates_stay_together_without_blocking_other_patches(self) -> None:
+ gomod = self.updates["gomod"]
+ groups = gomod["groups"]
+ self.assertEqual(
+ groups["go-storage-runtime"],
+ {
+ "applies-to": "version-updates",
+ "patterns": ["modernc.org/*"],
+ "update-types": ["minor", "patch"],
+ },
+ )
+ # Separating review scope must not suppress updates or advisories.
+ self.assertEqual(gomod.get("ignore", []), [])
+ self.assertEqual(set(groups), {"go-minor-patch", "go-storage-runtime", "go-security"})
+
+ def matching_groups(dependency: str, update_type: str, applies_to: str) -> set[str]:
+ return {
+ name
+ for name, group in groups.items()
+ if group["applies-to"] == applies_to
+ and update_type in group.get("update-types", ["major", "minor", "patch"])
+ and any(fnmatchcase(dependency, pattern) for pattern in group["patterns"])
+ and not any(
+ fnmatchcase(dependency, pattern)
+ for pattern in group.get("exclude-patterns", [])
+ )
+ }
+
+ # PR 3178 rebundled the deferred SQLite/libc pair with a new Prometheus
+ # patch immediately after the non-storage refresh landed. Keep the
+ # driver's transitives in its own reviewable proposal, in either order.
+ for dependency in (
+ "modernc.org/sqlite",
+ "modernc.org/libc",
+ "modernc.org/memory",
+ "modernc.org/mathutil",
+ "github.com/prometheus/common",
+ "github.com/klauspost/compress",
+ "golang.org/x/net",
+ ):
+ expected = (
+ "go-storage-runtime" if dependency.startswith("modernc.org/") else "go-minor-patch"
+ )
+ for update_type in ("minor", "patch"):
+ with self.subTest(dependency=dependency, update_type=update_type):
+ self.assertEqual(
+ matching_groups(dependency, update_type, "version-updates"),
+ {expected},
+ )
+ self.assertEqual(matching_groups(dependency, "major", "version-updates"), set())
+ self.assertEqual(matching_groups(dependency, "patch", "security-updates"), {"go-security"})
+
def test_docker_updates_preserve_governed_tags(self) -> None:
docker = self.updates["docker"]
self.assertEqual(