Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Explain unverified guest request completion and transport deferrals

pulse-triage[bot]5b859dda3aa5
diff --git a/frontend-modern/src/components/Workloads/__fixtures__/guestDiskDeferrals.ts b/frontend-modern/src/components/Workloads/__fixtures__/guestDiskDeferrals.ts
index cf30a84096..cba773105a 100644
--- a/frontend-modern/src/components/Workloads/__fixtures__/guestDiskDeferrals.ts
+++ b/frontend-modern/src/components/Workloads/__fixtures__/guestDiskDeferrals.ts
@@ -20,6 +20,18 @@ export const guestDiskDeferrals = [
'agent-response-incomplete',
'Guest reads paused because the previous response was incomplete. Pulse will check again on a later poll.',
],
+ [
+ 'agent-completion-unverified',
+ 'Guest reads paused because completion of the earlier request could not be verified. Pulse will check again after the cooldown. Defer live diagnostics and guest-agent restarts during backups or a guest incident.',
+ ],
+ [
+ 'agent-redirect',
+ 'Guest reads paused because the endpoint returned a redirect. Pulse did not follow it; completion of the original guest request is uncertain. Defer live diagnostics and guest-agent restarts during backups or a guest incident.',
+ ],
+ [
+ 'agent-transport-unverified',
+ 'Guest reads deferred because Pulse cannot verify that the configured connection avoids resending guest requests. This guest request was not sent. Defer connection changes and live probes during backups or a guest incident.',
+ ],
[
'agent-capacity',
'Guest reads deferred because Pulse has reached its guest-read capacity. Pulse will check again on a later poll.',
diff --git a/frontend-modern/src/components/Workloads/__tests__/GuestDrawerOverview.agent-state.test.tsx b/frontend-modern/src/components/Workloads/__tests__/GuestDrawerOverview.agent-state.test.tsx
index c0e662b268..d6a825abe9 100644
--- a/frontend-modern/src/components/Workloads/__tests__/GuestDrawerOverview.agent-state.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/GuestDrawerOverview.agent-state.test.tsx
@@ -20,6 +20,7 @@ import {
getGuestDrawerGuestReadPresentation,
getGuestDrawerGuestReadPrecaution,
} from '../guestDrawerModel';
+import { guestDiskDeferrals } from '../__fixtures__/guestDiskDeferrals';
vi.mock('../GuestPhysicalDisks', () => ({ GuestPhysicalDisks: () => null }));
@@ -220,27 +221,39 @@ describe('guest agent coverage requires current state, not cached metadata', ()
});
describe('fixed guest read state and precaution evidence', () => {
- it.each([
- 'vm-locked',
- 'lock-unverified',
- 'agent-busy',
- 'agent-cooldown',
- 'agent-response-incomplete',
- 'agent-capacity',
- 'invalid-guest-key',
- 'agent-timeout',
- ])('uses %s without a probe or installation diagnosis', (reason) => {
- for (const prefix of ['', 'prev-']) {
- const value = guest({ diskStatusReason: prefix + reason });
- expect(getGuestDrawerGuestReadPresentation(value)).toMatchObject({
- label: 'Deferred',
- precaution: true,
- });
- const message = getGuestDrawerGuestReadPrecaution(value)!;
- expect(message).not.toMatch(/Using last known|may not be installed|may need to be restarted/);
- expect(message).not.toContain('prev-');
- }
- });
+ it.each(guestDiskDeferrals)(
+ 'uses %s without a probe or installation diagnosis',
+ (reason, detail) => {
+ for (const prefix of ['', 'prev-']) {
+ const value = guest({ diskStatusReason: prefix + reason });
+ expect(getGuestDrawerGuestReadPresentation(value)).toMatchObject({
+ label: 'Deferred',
+ precaution: true,
+ detail,
+ });
+ const message = getGuestDrawerGuestReadPrecaution(value)!;
+ expect(message).toBe(detail);
+ expect(message).not.toMatch(
+ /Using last known|may not be installed|may need to be restarted/,
+ );
+ expect(message).not.toContain('prev-');
+ }
+ },
+ );
+
+ it.each(['agent-completion-unverified', 'agent-redirect', 'agent-transport-unverified'])(
+ 'keeps %s caution independent of a reported available flag and live metrics',
+ (reason) => {
+ const value = guest({ guestAgentStatus: 'available', diskStatusReason: `prev-${reason}` });
+ const original = structuredClone(value);
+ expect(getGuestDrawerGuestReadPresentation(value)?.label).toBe('Reported available');
+ expect(getGuestDrawerGuestReadPresentation(value)?.precaution).toBe(true);
+ expect(getGuestDrawerGuestReadPrecaution(value)).toBe(
+ guestDiskDeferrals.find(([key]) => key === reason)![1],
+ );
+ expect(value).toEqual(original);
+ },
+ );
it('does not turn a reported available flag into completed read or thaw evidence', () => {
const value = guest({ guestAgentStatus: 'available', diskStatusReason: 'agent-timeout' });
diff --git a/frontend-modern/src/components/Workloads/guestDrawerModel.ts b/frontend-modern/src/components/Workloads/guestDrawerModel.ts
index 06338f85c4..e2f5632a81 100644
--- a/frontend-modern/src/components/Workloads/guestDrawerModel.ts
+++ b/frontend-modern/src/components/Workloads/guestDrawerModel.ts
@@ -505,6 +505,9 @@ const guestReadDeferrals = new Set([
'agent-busy',
'agent-cooldown',
'agent-response-incomplete',
+ 'agent-completion-unverified',
+ 'agent-redirect',
+ 'agent-transport-unverified',
'agent-capacity',
'invalid-guest-key',
'agent-timeout',
diff --git a/frontend-modern/src/utils/__tests__/workloadGuestPresentation.test.ts b/frontend-modern/src/utils/__tests__/workloadGuestPresentation.test.ts
index d72591afde..86e256ca10 100644
--- a/frontend-modern/src/utils/__tests__/workloadGuestPresentation.test.ts
+++ b/frontend-modern/src/utils/__tests__/workloadGuestPresentation.test.ts
@@ -60,6 +60,26 @@ describe('workloadGuestPresentation', () => {
},
);
+ it('distinguishes uncertain completion and redirects from a request refused before dispatch', () => {
+ const completion = getWorkloadGuestDiskStatusMessage('agent-completion-unverified');
+ expect(completion).toContain('completion of the earlier request could not be verified');
+ expect(completion).toContain('after the cooldown');
+ const redirect = getWorkloadGuestDiskStatusMessage('agent-redirect');
+ expect(redirect).toContain('Pulse did not follow it');
+ expect(redirect).toContain('completion of the original guest request is uncertain');
+ for (const message of [completion, redirect]) {
+ expect(message).not.toContain('This guest request was not sent');
+ }
+ const transport = getWorkloadGuestDiskStatusMessage('agent-transport-unverified');
+ expect(transport).toContain('configured connection avoids resending guest requests');
+ expect(transport).toContain('This guest request was not sent');
+ expect(transport).not.toMatch(/completion.*uncertain|after the cooldown/);
+ for (const message of [completion, redirect, transport]) {
+ expect(message).toContain('backups or a guest incident');
+ expect(message).not.toMatch(/Install|disable verification|retry now|qm agent|curl/);
+ }
+ });
+
it.each(['agent-not-running', 'agent-disabled', 'future-private-error', undefined])(
'keeps %s out of installation, activation and guessed OS advice',
(reason) => {
diff --git a/frontend-modern/src/utils/workloadGuestPresentation.ts b/frontend-modern/src/utils/workloadGuestPresentation.ts
index 02997cc7be..711322fa42 100644
--- a/frontend-modern/src/utils/workloadGuestPresentation.ts
+++ b/frontend-modern/src/utils/workloadGuestPresentation.ts
@@ -119,6 +119,12 @@ export function getWorkloadGuestDiskStatusMessage(reason?: string): string {
return 'Guest reads paused after an earlier request did not complete reliably. Pulse will check again after the cooldown.';
case 'agent-response-incomplete':
return 'Guest reads paused because the previous response was incomplete. Pulse will check again on a later poll.';
+ case 'agent-completion-unverified':
+ return 'Guest reads paused because completion of the earlier request could not be verified. Pulse will check again after the cooldown. Defer live diagnostics and guest-agent restarts during backups or a guest incident.';
+ case 'agent-redirect':
+ return 'Guest reads paused because the endpoint returned a redirect. Pulse did not follow it; completion of the original guest request is uncertain. Defer live diagnostics and guest-agent restarts during backups or a guest incident.';
+ case 'agent-transport-unverified':
+ return 'Guest reads deferred because Pulse cannot verify that the configured connection avoids resending guest requests. This guest request was not sent. Defer connection changes and live probes during backups or a guest incident.';
case 'agent-capacity':
return 'Guest reads deferred because Pulse has reached its guest-read capacity. Pulse will check again on a later poll.';
case 'invalid-guest-key':