Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep native recovery proof aligned with bounded manual downloads

pulse-triage[bot]5d748986b3f5
diff --git a/docs/release-control/v6/internal/subsystems/deployment-installability.md b/docs/release-control/v6/internal/subsystems/deployment-installability.md
index 39165e88d0..d26a1d7bdc 100644
--- a/docs/release-control/v6/internal/subsystems/deployment-installability.md
+++ b/docs/release-control/v6/internal/subsystems/deployment-installability.md
@@ -6379,6 +6379,11 @@ partial-download timeouts, both allocation failures, invalid signatures and a
successful signed bootstrap. They require the deadline/config-isolation options,
no request replay, temporary-input cleanup and saved-configuration preservation.
They do not measure live network deadlines or establish installed/native recovery.
+The native systemd proof's closed transport adapter separately admits this exact
+manual-helper envelope alongside the existing unattended envelope. Its registered
+portable control runs the actual emitted helper and real verifier through that
+adapter, and rejects altered deadlines, retries or TLS options without online
+fallback. This preserves the hosted manual-recovery consumer, not native acceptance.
`TestManualUpdateChannelAdmission` generates and executes the actual helper
against local transport fixtures and genuinely signed installer/sidecar bytes.
diff --git a/scripts/installtests/auto_update_systemd.py b/scripts/installtests/auto_update_systemd.py
index 424d440d10..f4aca331e5 100644
--- a/scripts/installtests/auto_update_systemd.py
+++ b/scripts/installtests/auto_update_systemd.py
@@ -65,8 +65,11 @@ if pathlib.Path(sys.argv[0]).name == "mktemp":
# arbitrary curl option parser. The short form is used by isolated controls.
flags = ["--disable", "-fsSL", "--connect-timeout", "5", "--max-time", "60",
"--proto", "=https", "--proto-redir", "=https"]
+manual_flags = ["-q", "-fsSL", "--connect-timeout", "10", "--max-time", "60"]
if args[:len(flags)] == flags:
args = args[len(flags):]
+elif args[:len(manual_flags)] == manual_flags:
+ args = args[len(manual_flags):]
elif args[:1] == ["-fsSL"]:
args = args[1:]
else:
diff --git a/scripts/installtests/pulse_auto_update_test.go b/scripts/installtests/pulse_auto_update_test.go
index 4bb8b1287f..0a832c7ba2 100644
--- a/scripts/installtests/pulse_auto_update_test.go
+++ b/scripts/installtests/pulse_auto_update_test.go
@@ -33,6 +33,7 @@ func TestAutoUpdateNativeSystemdHarnessContracts(t *testing.T) {
for _, name := range []string{
"test_prepare_owns_generated_signer_mode_before_first_real_signature",
"test_signer_creation_refuses_adoption_wrong_type_owner_or_failed_mode",
+ "test_transport_accepts_emitted_manual_helper_and_rejects_option_drift",
"test_real_verifier_accepts_fixture_and_refuses_tampering",
"test_phase_cannot_accept_wrong_bytes_state_mask_persistence_or_backup",
"test_managed_process_identity_follows_served_readiness_and_rejects_residuals",
diff --git a/scripts/tests/test_auto_update_systemd.py b/scripts/tests/test_auto_update_systemd.py
index b934388e40..4ca21ea7f7 100644
--- a/scripts/tests/test_auto_update_systemd.py
+++ b/scripts/tests/test_auto_update_systemd.py
@@ -145,6 +145,52 @@ class NativeContracts(unittest.TestCase):
self.assertEqual(result.returncode, 97)
self.assertFalse((root / "refused").exists())
+ def test_transport_accepts_emitted_manual_helper_and_rejects_option_drift(self):
+ with tempfile.TemporaryDirectory() as directory:
+ root = Path(directory)
+ for leaf in ("tools", "tmp", "config"):
+ (root / leaf).mkdir(mode=0o700)
+ for name in ("curl", "mktemp"):
+ path = root / "tools" / name
+ path.write_text(native.TRANSPORT)
+ path.chmod(0o755)
+ installer = root / "installer"
+ installer.write_text('#!/bin/bash\nprintf "%s\\n" "$@" > "$PULSE_NATIVE_ROOT/executed"\n')
+ key = root / "key"
+ subprocess.run(["ssh-keygen", "-q", "-t", "ed25519", "-N", "", "-f", str(key)],
+ check=True, capture_output=True)
+ subprocess.run(["ssh-keygen", "-q", "-Y", "sign", "-f", str(key),
+ "-n", "pulse-install", str(installer)], check=True, capture_output=True)
+ Path(str(installer) + ".sig").rename(root / "installer.sshsig")
+ helper = root / "update"
+ env = {**os.environ, "PULSE_NATIVE_ROOT": str(root),
+ "FIXTURE_KEY": (root / "key.pub").read_text().strip(),
+ "PULSE_INSTALL_DIR": str(root), "PULSE_CONFIG_DIR": str(root / "config"),
+ "PULSE_UPDATE_HELPER_PATH": str(helper),
+ "PULSE_PROFILE_PATH": str(root / "profile"),
+ "PULSE_BASHRC_PATH": str(root / "bashrc"),
+ "PATH": str(root / "tools") + os.pathsep + os.environ["PATH"]}
+ generated = subprocess.run(["bash", "-c", 'source "$1"; '
+ 'PINNED_RELEASE_SSH_PUBLIC_KEY="$FIXTURE_KEY"; setup_update_command',
+ "fixture", str(ROOT / "install.sh")], env=env, capture_output=True)
+ self.assertEqual(generated.returncode, 0, generated.stdout + generated.stderr)
+ result = subprocess.run(["bash", str(helper), "--version", "v0.0.1"],
+ env=env, capture_output=True, timeout=10)
+ self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
+ self.assertEqual((root / "executed").read_text(), "--version\nv0.0.1\n")
+ self.assertEqual(list((root / "tmp").iterdir()), [])
+ flags = ["-q", "-fsSL", "--connect-timeout", "10", "--max-time", "60"]
+ url = "https://github.com/rcourtman/Pulse/releases/latest/download/install.sh"
+ for changed in (flags[1:], [*flags, "--insecure"], [*flags, "--retry", "3"],
+ [arg if arg != "60" else "61" for arg in flags],
+ [arg if arg != "10" else "11" for arg in flags]):
+ with self.subTest(flags=changed):
+ target = root / "refused"
+ result = subprocess.run([str(root / "tools/curl"), *changed, url, "-o", str(target)],
+ env=env, capture_output=True, timeout=10)
+ self.assertEqual(result.returncode, 97)
+ self.assertFalse(target.exists())
+
def test_real_verifier_accepts_fixture_and_refuses_tampering(self):
with tempfile.TemporaryDirectory() as directory:
root = Path(directory)