Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.
Go aialertsdashboarddockerdocker-monitoringgohomelabinfrastructure-monitoringkubernetesmonitoringmspproxmoxproxmox-backup-serverproxmox-mail-gatewayproxmox-veself-hostedtruenastypescriptvspherewebhooks
Bound unread task carry-forward to its accepted live window
pulse-triage[bot]5ea5107ad39b
diff --git a/internal/monitoring/backup_task_history.go b/internal/monitoring/backup_task_history.goindex 16c88206bb..89202ffda4 100644--- a/internal/monitoring/backup_task_history.go+++ b/internal/monitoring/backup_task_history.go@@ -118,13 +118,30 @@ func (m *Monitor) retainUnreadBackupTasks(instance string, nodes []proxmox.Backureturn tasks}seen := make(map[string]bool, len(tasks))+ counts := make(map[string]int)+ limits := make(map[string]int)for _, task := range tasks {seen[task.ID] = true+ counts[task.Node]++}- for _, task := range m.state.GetBackupTasks() {- if task.Instance == instance && unread[task.Node] && !seen[task.ID] {+ previous := m.state.GetBackupTasks()+ for _, task := range previous {+ if task.Instance == instance && unread[task.Node] {+ limits[task.Node]+++ }+ }+ // Share the existing 200-provider-task live window. Synthesized guest+ // children can make a previously accepted payload larger; preserve that+ // payload's bound, but never accumulate a fresh window of carried rows on+ // every partially read poll. Accepted new rows always have priority.+ for node := range unread {+ limits[node] = max(200, limits[node], counts[node])+ }+ for _, task := range previous {+ if task.Instance == instance && unread[task.Node] && !seen[task.ID] && counts[task.Node] < limits[task.Node] {tasks = append(tasks, task)seen[task.ID] = true+ counts[task.Node]++}}return tasksdiff --git a/internal/monitoring/backup_task_inventory_lifecycle_test.go b/internal/monitoring/backup_task_inventory_lifecycle_test.goindex 0363f88007..012ccf3eb8 100644--- a/internal/monitoring/backup_task_inventory_lifecycle_test.go+++ b/internal/monitoring/backup_task_inventory_lifecycle_test.go@@ -197,3 +197,27 @@ func TestBackupHistoryUnreadTaskCannotCompleteRunningArchive(t *testing.T) {})}}++func TestBackupHistoryCarryForwardCannotAccumulateLiveWindows(t *testing.T) {+ for _, previousCount := range []int{200, 215} {+ t.Run(fmt.Sprint(previousCount), func(t *testing.T) {+ m := &Monitor{state: models.NewState()}+ old := time.Now().UTC().Add(-time.Hour)+ previous := make([]models.BackupTask, previousCount)+ for i := range previous {+ previous[i] = models.BackupTask{ID: fmt.Sprintf("old-%d", i), Instance: "site", Node: "unread", Type: "vzdump", VMID: 101, StartTime: old, ObservedAt: old}+ }+ m.state.UpdateBackupTasksForInstance("site", previous)+ for poll := range 5 {+ fresh := make([]models.BackupTask, 200)+ for i := range fresh {+ fresh[i] = models.BackupTask{ID: fmt.Sprintf("fresh-%d-%d", poll, i), Instance: "site", Node: "unread", Type: "vzdump", VMID: 101, StartTime: old.Add(time.Duration(poll+1) * time.Minute), ObservedAt: time.Now().UTC()}+ }+ retained := m.retainUnreadBackupTasks("site", []proxmox.BackupTaskHistoryNode{{Node: "unread", Reason: "collection_failed"}}, fresh)+ require.Len(t, retained, previousCount, "partial windows cannot grow the live payload on each failed poll")+ require.Equal(t, fresh, retained[:len(fresh)], "accepted page order and exact facts take priority")+ m.state.UpdateBackupTasksForInstance("site", retained)+ }+ })+ }+}