Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Reconcile current drawer refinements with reviewed maintenance

pulse-triage[bot]6111220dd3ff
diff --cc docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 399093e651,fba65abe99..49a9402346
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@@ -8789,25 -8756,18 +8804,32 @@@ return, active state, badges, and narro
The Proxmox node drawer presents checked zero, current positive, stale,
unavailable, and not-checked package evidence as a labelled detail row with
bounded copy and checked time. The compact table badge remains reserved for a
-current positive observation. Provider errors are never rendered. An
-unavailable check whose reason is `permission_denied` reads neutral, so the
-node Overview keeps it in Details rather than Worth checking: Proxmox gates the
-package list on `Sys.Modify`, and `docs/TROUBLESHOOTING.md` calls keeping the
-narrower monitoring role a valid choice. Other unavailable reasons stay warnings.
-Node Details rows wrap their values (`wrap: true`) rather than truncating them,
-because Details is where a reader goes for the full value: the update reason,
-the linked agent ID and the CPU model read whole at desktop and phone widths. Component
-and browser evidence covers both 1440px and 390px layouts in
-`NodeDrawerOverview.updateEvidence.test.tsx`, `ProxmoxNodesTable.test.tsx`, and
-`frontend-modern/browser-verification.json`.
+current positive observation. Provider errors are never rendered. Component
+evidence is covered by `NodeDrawerOverview.updateEvidence.test.tsx`,
+`proxmoxUpdateEvidence.test.ts`, and `ProxmoxNodesTable.test.tsx`.
+
+Denied update-list access exposes visible guidance beside that status through
+the shared HelpIcon and help-content registry. It explains that inventory and
+metrics use separate permission checks, preserves the choice to monitor with
+read-only access, and describes Sys.Modify as broader access that also permits
+refreshing package indexes. A denied response does not establish the exact
+missing privilege or an empty update list. Status text wraps through the shared
+detail-row contract at phone widths, including retained counts and checked time.
+The operator-context section and its help control retain their identity while
+readings and relative timestamps update. The shared help dialog remains inside
+the viewport with scrollable content, keyboard dismissal and focus return.
+Current-source browser receipts under `frontend-modern/browser-verification/`
+cover desktop, intermediate, phone and short landscape layouts. These checks
+establish presentation and interaction, not installed Proxmox permissions or
+released acceptance.
+
++An unavailable update check whose reason is `permission_denied` reads neutral,
++so it remains in Details rather than Worth checking. Other unavailable reasons
++stay warnings. Node Details values wrap rather than truncate. This preserves
++full reasons, agent IDs and CPU models at desktop and phone widths.
++
++
+
### Docker drawers expose reduced helper coverage without actions
The Docker host drawer consumes the canonical optional `collectionMode` field.
diff --cc frontend-modern/src/components/Workloads/NodeDrawerOverview.tsx
index f02ca3e3b4,db503cd32c..4f7912d10c
--- a/frontend-modern/src/components/Workloads/NodeDrawerOverview.tsx
+++ b/frontend-modern/src/components/Workloads/NodeDrawerOverview.tsx
@@@ -585,15 -578,6 +592,8 @@@ export function NodeDrawerOverview(prop
</Suspense>
</Show>
- <Show when={exceptionRows().length > 0}>
- <TechnicalDetailsSection
- dataTestId="node-drawer-exceptions"
- sections={[{ label: 'Worth checking', rows: exceptionRows() }]}
- />
- </Show>
-
+ {updateAccessGuidance}
+
<Show when={sensorSections().length > 0}>
<TechnicalDetailsSection dataTestId="node-drawer-sensors" sections={sensorSections()} />
</Show>
diff --cc frontend-modern/src/components/Workloads/__tests__/NodeDrawerOverview.updateEvidence.test.tsx
index 5a2676cbd1,ba1d59bd77..43b9f06f29
--- a/frontend-modern/src/components/Workloads/__tests__/NodeDrawerOverview.updateEvidence.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/NodeDrawerOverview.updateEvidence.test.tsx
@@@ -83,51 -79,39 +83,84 @@@ describe('NodeDrawerOverview update evi
/>
));
- expect(screen.getByText('Unavailable · Update check access denied')).toBeInTheDocument();
+ const status = screen.getByText('Unavailable · Update check access denied');
+ expect(screen.getByTestId('node-technical-details')).not.toHaveAttribute('open');
+ expect(status.closest('details')).toBeNull();
+ expect(status).toHaveClass('whitespace-normal');
+ expect(status).not.toHaveClass('truncate');
+ expect(screen.getByText(/Other monitoring can still work/)).toBeInTheDocument();
+ expect(
+ screen.getByRole('button', { name: 'Why update checks are unavailable' }).closest('details'),
+ ).toBeNull();
+ fireEvent.click(screen.getByRole('button', { name: 'Why update checks are unavailable' }));
+ const help = screen.getByRole('dialog', { name: 'Proxmox update-check access' });
+ expect(help).toHaveTextContent('Sys.Modify');
+ expect(help).toHaveTextContent('broader than read-only monitoring');
+ expect(help).toHaveTextContent('does not identify the exact missing privilege');
+ expect(screen.getByRole('link', { name: 'Learn more' })).toHaveAttribute(
+ 'href',
+ '/docs/TROUBLESHOOTING#proxmox-pending-update-access',
+ );
+ });
+
+ it('keeps guidance open while node readings and evidence age update', () => {
+ const start = Date.parse('2026-10-10T12:00:00Z');
+ vi.useFakeTimers({ toFake: ['Date', 'setInterval', 'clearInterval'], now: start });
+ const [node, setNode] = createSignal(
+ makeNode({
+ pendingUpdates: 7,
+ pendingUpdatesStatus: 'stale',
+ pendingUpdatesReason: 'permission_denied',
+ pendingUpdatesCheckedAt: new Date(start - 60_000).toISOString(),
+ }),
+ );
+ render(() => <NodeDrawerOverview node={node()} />);
+ fireEvent.click(screen.getByRole('button', { name: 'Why update checks are unavailable' }));
+ const help = screen.getByRole('dialog', { name: 'Proxmox update-check access' });
+ const trigger = screen.getByRole('button', { name: 'Why update checks are unavailable' });
+ const details = screen.getByTestId('node-technical-details') as HTMLDetailsElement;
+ details.open = true;
+ details.open = false;
+ setNode({ ...node(), cpu: 0.2 });
+ vi.advanceTimersByTime(60_000);
+ expect(screen.getByRole('dialog', { name: 'Proxmox update-check access' })).toBe(help);
+ expect(screen.getByRole('button', { name: 'Why update checks are unavailable' })).toBe(trigger);
+ expect(screen.getByText(/7 pending.*stale.*checked 2 mins ago/)).toBeInTheDocument();
+ setNode({ ...node(), pendingUpdatesStatus: 'unavailable' });
+ expect(screen.getByRole('dialog', { name: 'Proxmox update-check access' })).toBe(help);
+ expect(screen.getByText('Unavailable · Update check access denied')).toBeVisible();
});
+
+ it('keeps a denied update check in Details, not under Worth checking', () => {
+ render(() => (
+ <NodeDrawerOverview
+ node={makeNode({
+ pendingUpdatesStatus: 'unavailable',
+ pendingUpdatesReason: 'permission_denied',
+ })}
+ />
+ ));
+ expect(screen.queryByTestId('node-drawer-exceptions')).toBeNull();
+ // Details shows the whole reason, wrapped, not cut off behind an ellipsis.
+ expect(screen.getByText('Unavailable · Update check access denied')).toHaveClass(
+ 'whitespace-normal',
+ );
+ expect(screen.getByTestId('node-technical-details').textContent).toContain(
+ 'Unavailable · Update check access denied',
+ );
+ });
+
+ it('lists an update check that failed under Worth checking', () => {
+ render(() => (
+ <NodeDrawerOverview
+ node={makeNode({
+ pendingUpdatesStatus: 'unavailable',
+ pendingUpdatesReason: 'source_unavailable',
+ })}
+ />
+ ));
+ expect(screen.getByTestId('node-drawer-exceptions').textContent).toContain(
+ 'Unavailable · Proxmox source unavailable',
+ );
+ });
});
diff --cc frontend-modern/src/utils/__tests__/proxmoxUpdateEvidence.test.ts
index a33e24e9ae,31ba1c2248..488459515f
--- a/frontend-modern/src/utils/__tests__/proxmoxUpdateEvidence.test.ts
+++ b/frontend-modern/src/utils/__tests__/proxmoxUpdateEvidence.test.ts
@@@ -52,36 -52,20 +52,46 @@@ describe('Proxmox update evidence prese
}),
).toMatchObject({
value: 'Unavailable · Update check access denied',
+ tone: 'default',
current: false,
+ helpContentId: 'updates.proxmox.access',
});
});
+ it('offers access guidance for a denied refresh without replacing retained evidence', () => {
+ expect(
+ getProxmoxUpdateEvidencePresentation(
+ {
+ pendingUpdates: 7,
+ pendingUpdatesStatus: 'stale',
+ pendingUpdatesReason: 'permission_denied',
+ pendingUpdatesCheckedAt: '2026-08-29T12:00:00Z',
+ },
+ relative,
+ ),
+ ).toMatchObject({
+ value: '7 pending · stale · checked 5 mins ago',
+ current: false,
+ helpContentId: 'updates.proxmox.access',
+ });
+ for (const state of [
+ { pendingUpdatesStatus: 'checked', pendingUpdatesReason: 'permission_denied' },
+ { pendingUpdatesStatus: 'unavailable', pendingUpdatesReason: 'source_unavailable' },
+ { pendingUpdatesStatus: 'not_checked', pendingUpdatesReason: 'node_offline' },
+ ] as const) {
+ expect(getProxmoxUpdateEvidencePresentation(state)?.helpContentId).toBeUndefined();
+ }
+ });
+
+ it('keeps an unavailable check that is not a permission choice as a warning', () => {
+ expect(
+ getProxmoxUpdateEvidencePresentation({
+ pendingUpdatesStatus: 'unavailable',
+ pendingUpdatesReason: 'source_unavailable',
+ }),
+ ).toMatchObject({ value: 'Unavailable · Proxmox source unavailable', tone: 'warning' });
+ });
+
it('only treats checked or legacy-positive evidence as current', () => {
expect(hasCurrentProxmoxUpdateEvidence({ pendingUpdates: 3 })).toBe(true);
expect(
diff --cc frontend-modern/src/utils/proxmoxUpdateEvidence.ts
index 30b9222183,b426da4f10..3a64505e37
--- a/frontend-modern/src/utils/proxmoxUpdateEvidence.ts
+++ b/frontend-modern/src/utils/proxmoxUpdateEvidence.ts
@@@ -85,9 -78,12 +85,13 @@@ export const getProxmoxUpdateEvidencePr
return {
value: ['Unavailable', reason].filter(Boolean).join(' · '),
title: reason || 'Update evidence is unavailable',
- tone: 'warning',
+ // Proxmox requires Sys.Modify for the package-update list, which is
+ // broader than monitoring needs; docs/TROUBLESHOOTING.md calls keeping
+ // the narrower role a valid choice. That is a setting, not a fault, so
+ // it reads neutral. A source outage or failed check stays a warning.
+ tone: node.pendingUpdatesReason === 'permission_denied' ? 'default' : 'warning',
current: false,
+ ...accessHelp,
};
case 'not_checked':
return {