Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Reconcile guidance assertions with sentences and backup settings links

pulse-triage[bot]62f291eead40
diff --git a/frontend-modern/src/components/Workloads/__tests__/GuestRow.test.tsx b/frontend-modern/src/components/Workloads/__tests__/GuestRow.test.tsx
index 66c36fbcf9..4165ef9cc4 100644
--- a/frontend-modern/src/components/Workloads/__tests__/GuestRow.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/GuestRow.test.tsx
@@ -3593,7 +3593,10 @@ describe('backup disclosures keep completion separate from guest safety', () =>
expect(dialog).toHaveTextContent('Last completed backup');
expect(dialog).toHaveTextContent('Guest-agent reads: Reported available');
expect(dialog).toHaveTextContent('does not independently confirm thaw or filesystem writes');
- expect(within(dialog).queryByRole('link')).toBeNull();
+ expect(within(dialog).queryByRole('link', { name: 'Backup safety guidance' })).toBeNull();
+ expect(
+ within(dialog).getByRole('link', { name: 'Change when backups count as old' }),
+ ).toHaveAttribute('href', '/alerts/thresholds/proxmox#backups');
setGuest({
...guest(),
@@ -3634,7 +3637,10 @@ describe('backup disclosures keep completion separate from guest safety', () =>
expect(dialog).toHaveTextContent('Guest-agent reads: Reported available');
expect(dialog).not.toHaveTextContent('timed out');
expect(dialog).not.toHaveTextContent(GUEST_DRAWER_BACKUP_PRECAUTION);
- expect(within(dialog).queryByRole('link')).toBeNull();
+ expect(within(dialog).queryByRole('link', { name: 'Backup safety guidance' })).toBeNull();
+ expect(
+ within(dialog).getByRole('link', { name: 'Change when backups count as old' }),
+ ).toHaveAttribute('href', '/alerts/thresholds/proxmox#backups');
expect(onClick).not.toHaveBeenCalled();
},
);
diff --git a/frontend-modern/src/utils/__tests__/connectionErrorPresentation.test.ts b/frontend-modern/src/utils/__tests__/connectionErrorPresentation.test.ts
index 8cf808ac88..46a2b78212 100644
--- a/frontend-modern/src/utils/__tests__/connectionErrorPresentation.test.ts
+++ b/frontend-modern/src/utils/__tests__/connectionErrorPresentation.test.ts
@@ -98,7 +98,7 @@ describe('humanizeConnectionError', () => {
expect(result?.hint).toContain('intended resource');
expect(result?.hint).toContain('any proxy policy');
expect(result?.hint).toContain('Keep intentional access limits');
- expect(result?.hint).toContain('do not replace credentials or broaden access just to test');
+ expect(result?.hint).toContain('Do not replace credentials or broaden access just to test');
expect(result?.hint).not.toMatch(/credentials connected|logged in|Administrator/);
});
diff --git a/frontend-modern/src/utils/__tests__/workloadGuestPresentation.test.ts b/frontend-modern/src/utils/__tests__/workloadGuestPresentation.test.ts
index a4db4f8d03..ed73ca5277 100644
--- a/frontend-modern/src/utils/__tests__/workloadGuestPresentation.test.ts
+++ b/frontend-modern/src/utils/__tests__/workloadGuestPresentation.test.ts
@@ -67,7 +67,7 @@ describe('workloadGuestPresentation', () => {
expect(completion).toContain('after the cooldown');
const redirect = getWorkloadGuestDiskStatusMessage('agent-redirect');
expect(redirect).toContain('Pulse did not follow it');
- expect(redirect).toContain('completion of the original guest request is uncertain');
+ expect(redirect).toContain('Completion of the original guest request is uncertain');
for (const message of [completion, redirect]) {
expect(message).not.toContain('This guest request was not sent');
}