Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Integrate update-access guidance with the current node drawer

rcourtman651ae94b3104
diff --cc docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 6f9002e4f6,d29bf6efac..3ea7142fda
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@@ -8769,25 -8767,18 +8770,33 @@@ return, active state, badges, and narro
The Proxmox node drawer presents checked zero, current positive, stale,
unavailable, and not-checked package evidence as a labelled detail row with
bounded copy and checked time. The compact table badge remains reserved for a
- current positive observation. Provider errors are never rendered. Component
- evidence is covered by `NodeDrawerOverview.updateEvidence.test.tsx`,
- `proxmoxUpdateEvidence.test.ts`, and `ProxmoxNodesTable.test.tsx`.
+ current positive observation. Provider errors are never rendered. An
+ unavailable check whose reason is `permission_denied` reads neutral, so the
+ node Overview keeps it in Details rather than Worth checking: Proxmox gates the
+ package list on `Sys.Modify`, and `docs/TROUBLESHOOTING.md` calls keeping the
+ narrower monitoring role a valid choice. Other unavailable reasons stay warnings.
+ Node Details rows wrap their values (`wrap: true`) rather than truncating them,
+ because Details is where a reader goes for the full value: the update reason,
+ the linked agent ID and the CPU model read whole at desktop and phone widths. Component
+ and browser evidence covers both 1440px and 390px layouts in
+ `NodeDrawerOverview.updateEvidence.test.tsx`, `ProxmoxNodesTable.test.tsx`, and
+ `frontend-modern/browser-verification.json`.
+Denied update-list access exposes visible guidance beside that status through
+the shared HelpIcon and help-content registry. It explains that inventory and
+metrics use separate permission checks, preserves the choice to monitor with
+read-only access, and describes Sys.Modify as broader access that also permits
+refreshing package indexes. A denied response does not establish the exact
+missing privilege or an empty update list. Status text wraps through the shared
+detail-row contract at phone widths, including retained counts and checked time.
- The operator-context section and its help control retain their identity while
++The Summary section owns its help control while
+readings and relative timestamps update. The shared help dialog remains inside
+the viewport with scrollable content, keyboard dismissal and focus return.
+Current-source browser receipts under `frontend-modern/browser-verification/`
+cover desktop, intermediate, phone and short landscape layouts. These checks
+establish presentation and interaction, not installed Proxmox permissions or
+released acceptance.
+
### Docker drawers expose reduced helper coverage without actions
The Docker host drawer consumes the canonical optional `collectionMode` field.
diff --cc frontend-modern/src/components/Workloads/NodeDrawerOverview.tsx
index c7072ae28e,109ea7728f..cdc3c7b619
--- a/frontend-modern/src/components/Workloads/NodeDrawerOverview.tsx
+++ b/frontend-modern/src/components/Workloads/NodeDrawerOverview.tsx
@@@ -1,8 -1,14 +1,15 @@@
- import { Show } from 'solid-js';
+ import { For, Show, Suspense, createMemo, lazy } from 'solid-js';
+
+ import { ALERTS_EMPTY_STATE } from '@/utils/alertOverviewPresentation';
import { useRelativeTimeNow } from '@/utils/relativeTimeClock';
+import { HelpIcon } from '@/components/shared/HelpIcon';
- import { TechnicalDetailsSection } from '@/components/shared/TechnicalDetailsDisclosure';
+ import {
+ TechnicalDetailsDisclosure,
+ TechnicalDetailsSection,
+ } from '@/components/shared/TechnicalDetailsDisclosure';
+ import { HOST_METRICS_HISTORY_GROUPS } from '@/components/shared/hostMetricsHistoryModel';
import { DrawerAttentionSection } from '@/components/shared/DrawerAttentionSection';
+ import { DrawerExceptionList } from './DrawerExceptionList';
import {
compactDetailRows,
compactDetailSections,
@@@ -341,63 -393,160 +395,180 @@@ export function NodeDrawerOverview(prop
},
]);
- const overviewSections = () => {
- const primaryTemperature = props.node.cpuTemperature;
- const updates = updateEvidence();
- const temperatureClass =
- typeof primaryTemperature === 'number'
- ? getTemperatureTextClass(primaryTemperature, props.temperatureThresholds)
- : '';
- return compactDetailSections([
- {
- label: 'Summary',
- rows: compactDetailRows([
- makeDetailRow('Platform', versionLabel() ? `PVE ${versionLabel()}` : null),
- makeDetailRow(
- 'Pulse coverage',
- linkedAgentId() ? `Agent ${stripAgentPrefix(linkedAgentId())}` : 'PVE API only',
- { wrap: true },
- ),
- updates
- ? makeDetailRow('Updates', updates.value, {
- tone: updates.tone,
- title: updates.title,
- wrap: true,
- })
- : null,
- typeof primaryTemperature === 'number' &&
- (temperatureClass.includes('yellow') || temperatureClass.includes('red'))
- ? makeDetailRow('Temperature', formatTemperature(primaryTemperature), {
- tone: temperatureClass.includes('red') ? 'danger' : 'warning',
- })
- : null,
- ]),
- },
- ]);
+ const updateAccessGuidance = (
+ <Show when={updateEvidence()?.helpContentId}>
+ <div class="space-y-1 text-left text-[11px] font-normal text-muted">
+ <p class="whitespace-normal wrap-anywhere">
+ Update checks use separate Proxmox access. Other monitoring can still work.
+ </p>
+ <HelpIcon
+ contentId="updates.proxmox.access"
+ triggerLabel="Why update checks are unavailable"
+ size="xs"
+ class="-ml-2"
+ />
+ </div>
+ </Show>
+ );
+
- // Keep the interactive guidance owned by the drawer, rather than rebuilding
- // its section and help state whenever node readings or relative ages change.
- const operatorContextSection: DetailSection = {
- label: 'Operator context',
++ // The drawer owns the interactive help across reading and age updates.
++ const summarySection: DetailSection = {
++ label: 'Summary',
+ get rows() {
- const primaryTemperature = getCpuTemperature(props.node.temperature);
++ const primaryTemperature = props.node.cpuTemperature;
+ const updates = updateEvidence();
+ const temperatureClass =
+ typeof primaryTemperature === 'number'
+ ? getTemperatureTextClass(primaryTemperature, props.temperatureThresholds)
+ : '';
+ return compactDetailRows([
+ makeDetailRow('Platform', versionLabel() ? `PVE ${versionLabel()}` : null),
+ makeDetailRow(
+ 'Pulse coverage',
+ linkedAgentId() ? `Agent ${stripAgentPrefix(linkedAgentId())}` : 'PVE API only',
++ { wrap: true },
+ ),
+ updates
+ ? makeDetailRow('Updates', updates.value, {
+ tone: updates.tone,
+ title: updates.title,
+ wrap: true,
+ })
+ : null,
+ typeof primaryTemperature === 'number' &&
+ (temperatureClass.includes('yellow') || temperatureClass.includes('red'))
+ ? makeDetailRow('Temperature', formatTemperature(primaryTemperature), {
+ tone: temperatureClass.includes('red') ? 'danger' : 'warning',
+ })
+ : null,
+ ]);
+ },
+ get footerContent() {
+ return updateEvidence()?.helpContentId ? updateAccessGuidance : undefined;
+ },
};
- const overviewSections = () => [operatorContextSection];
++ const overviewSections = () => [summarySection];
++
+ const exceptionRows = createMemo(() =>
+ collectDrawerExceptionRows([...overviewSections(), ...technicalSections()]),
+ );
+
+ // The table withholds readings from an offline or stale node; the trend
+ // cards do the same instead of presenting the last numbers as live.
+ const liveReadingsWithheld = (): string | null => {
+ const health = (props.node.connectionHealth || '').trim().toLowerCase();
+ if (props.node.status === 'offline') return 'Node is offline. Showing its history only.';
+ if (
+ props.node.status === 'unknown' ||
+ health === 'error' ||
+ health === 'degraded' ||
+ health === 'stale'
+ ) {
+ return 'Proxmox readings for this node are stale. Showing its history only.';
+ }
+ return null;
+ };
+
+ const trendCards = (): DrawerTrendCardConfig[] => {
+ const card = (
+ metric: string,
+ label: string,
+ unit: DrawerTrendCardConfig['unit'],
+ current: number | undefined,
+ detail?: string,
+ deferred?: GuestDrawerHistoryDeferredMetric,
+ ): DrawerTrendCardConfig => {
+ const alert = getDrawerMetricAlert(props.metricAlerts, metric);
+ const withheld = liveReadingsWithheld();
+ return {
+ metric,
+ label,
+ unit,
+ color: hostSeriesColor(metric),
+ current: withheld ? undefined : current,
+ deferred: withheld ? { message: withheld } : deferred,
+ detail: withheld ? undefined : detail,
+ alertSeverity: alert?.severity,
+ alertThreshold: alert?.threshold,
+ };
+ };
+ const memory = props.node.memory;
+ const disk = props.node.disk;
+ // The adapter fills missing usage with zero; a known total is the
+ // evidence that a percentage was measured at all.
+ const memoryValue =
+ memory?.usageUnavailable || !((memory?.total ?? 0) > 0)
+ ? undefined
+ : finitePercent(memory?.usage);
+ // A retained or undated reading is shown as last known, the same rule the
+ // guest cards follow, rather than as a live value.
+ const memoryReading = getMemoryObservationPresentation(memoryValue, memory?.observation);
+ const memoryDeferred: GuestDrawerHistoryDeferredMetric | undefined =
+ memoryReading && memoryReading.state !== 'current'
+ ? {
+ lastKnownValue: memoryReading.state === 'unavailable' ? undefined : memoryValue,
+ ...(memoryReading.state === 'unknown'
+ ? { valueLabel: 'freshness unknown' as const }
+ : {}),
+ message: memoryReading.message,
+ }
+ : undefined;
+ const memoryCurrent = memoryDeferred ? undefined : memoryValue;
+ const diskMeasured = (disk?.total ?? 0) > 0;
+ // The backend's primary reading, recorded under the same rule as the line.
+ const temperature = props.node.cpuTemperature;
+ return [
+ card(
+ 'cpu',
+ 'CPU',
+ '%',
+ finitePercent(props.node.cpu),
+ loadAverageLabel() !== '-' ? `load ${props.node.loadAverage?.[0]?.toFixed(2)}` : undefined,
+ ),
+ card(
+ 'memory',
+ 'Memory',
+ '%',
+ memoryCurrent,
+ (memoryCurrent ?? memoryDeferred?.lastKnownValue) !== undefined
+ ? `${formatBytes(memory.used ?? 0)} of ${formatBytes(memory.total)}`
+ : undefined,
+ memoryDeferred,
+ ),
+ ...(typeof temperature === 'number'
+ ? [card('temperature', 'CPU temperature', 'C', temperature)]
+ : []),
+ card(
+ 'disk',
+ 'Root disk',
+ '%',
+ diskMeasured ? finitePercent(disk?.usage) : undefined,
+ diskMeasured
+ ? `${formatBytes(disk?.used ?? 0)} of ${formatBytes(disk?.total ?? 0)}`
+ : undefined,
+ ),
+ ];
+ };
+
+ const facts = () => {
+ const model = cleanText(props.node.cpuInfo?.model);
+ const cores = props.node.cpuInfo?.cores;
+ const firstAddress = (props.node.networkInterfaces || [])
+ .flatMap((networkInterface) => networkInterface.addresses || [])
+ .map((address) => cleanText(address))
+ .find(Boolean);
+ return [
+ versionLabel() ? `Proxmox VE ${versionLabel()}` : '',
+ [model, hasPositiveNumber(cores) ? `${cores} logical CPUs` : ''].filter(Boolean).join(' · '),
+ (props.node.memory?.total ?? 0) > 0 ? `${formatBytes(props.node.memory.total)} RAM` : '',
+ firstAddress ?? '',
+ clusterLabel() && clusterLabel() !== 'Standalone' ? `Cluster ${clusterLabel()}` : '',
+ ].filter((fact) => fact.trim().length > 0);
+ };
return (
- <div class="space-y-3">
+ <div class="space-y-3" data-testid="node-drawer-overview">
<DrawerAttentionSection
items={(props.alerts ?? []).map((alert) => ({
id: alert.id,
diff --cc frontend-modern/src/components/Workloads/__tests__/NodeDrawerOverview.updateEvidence.test.tsx
index bea667f748,ba1d59bd77..b265e36d99
--- a/frontend-modern/src/components/Workloads/__tests__/NodeDrawerOverview.updateEvidence.test.tsx
+++ b/frontend-modern/src/components/Workloads/__tests__/NodeDrawerOverview.updateEvidence.test.tsx
@@@ -80,34 -79,39 +80,69 @@@ describe('NodeDrawerOverview update evi
/>
));
- expect(screen.getByText('Unavailable · Update check access denied')).toBeInTheDocument();
++ fireEvent.click(screen.getByTestId('node-technical-details').querySelector('summary')!);
+ const status = screen.getByText('Unavailable · Update check access denied');
+ expect(status).toHaveClass('whitespace-normal');
+ expect(status).not.toHaveClass('truncate');
+ expect(screen.getByText(/Other monitoring can still work/)).toBeInTheDocument();
+ fireEvent.click(screen.getByRole('button', { name: 'Why update checks are unavailable' }));
+ const help = screen.getByRole('dialog', { name: 'Proxmox update-check access' });
+ expect(help).toHaveTextContent('Sys.Modify');
+ expect(help).toHaveTextContent('broader than read-only monitoring');
+ expect(help).toHaveTextContent('does not identify the exact missing privilege');
+ });
+
+ it('keeps guidance open while node readings and evidence age update', () => {
+ const start = Date.parse('2026-10-10T12:00:00Z');
+ vi.useFakeTimers({ toFake: ['Date', 'setInterval', 'clearInterval'], now: start });
+ const [node, setNode] = createSignal(
+ makeNode({
+ pendingUpdates: 7,
+ pendingUpdatesStatus: 'stale',
+ pendingUpdatesReason: 'permission_denied',
+ pendingUpdatesCheckedAt: new Date(start - 60_000).toISOString(),
+ }),
+ );
+ render(() => <NodeDrawerOverview node={node()} />);
++ fireEvent.click(screen.getByTestId('node-technical-details').querySelector('summary')!);
+ fireEvent.click(screen.getByRole('button', { name: 'Why update checks are unavailable' }));
+ const help = screen.getByRole('dialog', { name: 'Proxmox update-check access' });
+ setNode({ ...node(), cpu: 0.2 });
+ vi.advanceTimersByTime(60_000);
+ expect(screen.getByRole('dialog', { name: 'Proxmox update-check access' })).toBe(help);
+ expect(screen.getByText(/7 pending.*stale.*checked 2 mins ago/)).toBeInTheDocument();
});
+
+ it('keeps a denied update check in Details, not under Worth checking', () => {
+ render(() => (
+ <NodeDrawerOverview
+ node={makeNode({
+ pendingUpdatesStatus: 'unavailable',
+ pendingUpdatesReason: 'permission_denied',
+ })}
+ />
+ ));
+ expect(screen.queryByTestId('node-drawer-exceptions')).toBeNull();
+ // Details shows the whole reason, wrapped, not cut off behind an ellipsis.
+ expect(screen.getByText('Unavailable · Update check access denied')).toHaveClass(
+ 'whitespace-normal',
+ );
+ expect(screen.getByTestId('node-technical-details').textContent).toContain(
+ 'Unavailable · Update check access denied',
+ );
+ });
+
+ it('lists an update check that failed under Worth checking', () => {
+ render(() => (
+ <NodeDrawerOverview
+ node={makeNode({
+ pendingUpdatesStatus: 'unavailable',
+ pendingUpdatesReason: 'source_unavailable',
+ })}
+ />
+ ));
+ expect(screen.getByTestId('node-drawer-exceptions').textContent).toContain(
+ 'Unavailable · Proxmox source unavailable',
+ );
+ });
});
diff --cc frontend-modern/src/utils/__tests__/proxmoxUpdateEvidence.test.ts
index a33e24e9ae,31ba1c2248..488459515f
--- a/frontend-modern/src/utils/__tests__/proxmoxUpdateEvidence.test.ts
+++ b/frontend-modern/src/utils/__tests__/proxmoxUpdateEvidence.test.ts
@@@ -52,36 -52,20 +52,46 @@@ describe('Proxmox update evidence prese
}),
).toMatchObject({
value: 'Unavailable · Update check access denied',
+ tone: 'default',
current: false,
+ helpContentId: 'updates.proxmox.access',
});
});
+ it('offers access guidance for a denied refresh without replacing retained evidence', () => {
+ expect(
+ getProxmoxUpdateEvidencePresentation(
+ {
+ pendingUpdates: 7,
+ pendingUpdatesStatus: 'stale',
+ pendingUpdatesReason: 'permission_denied',
+ pendingUpdatesCheckedAt: '2026-08-29T12:00:00Z',
+ },
+ relative,
+ ),
+ ).toMatchObject({
+ value: '7 pending · stale · checked 5 mins ago',
+ current: false,
+ helpContentId: 'updates.proxmox.access',
+ });
+ for (const state of [
+ { pendingUpdatesStatus: 'checked', pendingUpdatesReason: 'permission_denied' },
+ { pendingUpdatesStatus: 'unavailable', pendingUpdatesReason: 'source_unavailable' },
+ { pendingUpdatesStatus: 'not_checked', pendingUpdatesReason: 'node_offline' },
+ ] as const) {
+ expect(getProxmoxUpdateEvidencePresentation(state)?.helpContentId).toBeUndefined();
+ }
+ });
+
+ it('keeps an unavailable check that is not a permission choice as a warning', () => {
+ expect(
+ getProxmoxUpdateEvidencePresentation({
+ pendingUpdatesStatus: 'unavailable',
+ pendingUpdatesReason: 'source_unavailable',
+ }),
+ ).toMatchObject({ value: 'Unavailable · Proxmox source unavailable', tone: 'warning' });
+ });
+
it('only treats checked or legacy-positive evidence as current', () => {
expect(hasCurrentProxmoxUpdateEvidence({ pendingUpdates: 3 })).toBe(true);
expect(
diff --cc frontend-modern/src/utils/proxmoxUpdateEvidence.ts
index 30b9222183,b426da4f10..3a64505e37
--- a/frontend-modern/src/utils/proxmoxUpdateEvidence.ts
+++ b/frontend-modern/src/utils/proxmoxUpdateEvidence.ts
@@@ -85,9 -78,12 +85,13 @@@ export const getProxmoxUpdateEvidencePr
return {
value: ['Unavailable', reason].filter(Boolean).join(' · '),
title: reason || 'Update evidence is unavailable',
- tone: 'warning',
+ // Proxmox requires Sys.Modify for the package-update list, which is
+ // broader than monitoring needs; docs/TROUBLESHOOTING.md calls keeping
+ // the narrower role a valid choice. That is a setting, not a fault, so
+ // it reads neutral. A source outage or failed check stays a warning.
+ tone: node.pendingUpdatesReason === 'permission_denied' ? 'default' : 'warning',
current: false,
+ ...accessHelp,
};
case 'not_checked':
return {