Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Align PBS evidence guidance with independent retention state

pulse-triage[bot]672bd026a226
diff --git a/docs/PBS.md b/docs/PBS.md
index aba350f0ff..358752580f 100644
--- a/docs/PBS.md
+++ b/docs/PBS.md
@@ -388,7 +388,7 @@ backup or working protection from the strip alone.
| --- | --- |
| **With PBS snapshots** or a matching backup row | That Pulse's protection assessment received the same subject-linked backup evidence. A similar name or guest ID alone is not identity proof. |
| **Verified** on a PBS backup | That every backup is current, every covered disk is included, or the guest recovered after the backup. Verification is evidence about that backup, not a successful restore. |
-| **Protected** in a restore point's **State** | That this point is verified. This displays the backup's protected flag before its verification state; it is not the workload's protection assessment. |
+| **Kept** in a restore point's **State** | A verification result or the workload's protection assessment. This point is kept when pruning, but its verification was not reported. Expand its By date row for separate **Verification** and **Prune protection** details. |
| **Protected**, **Attention**, **Unprotected** or **Unknown** on the workload | An independent check that backups are restorable. These are Pulse's assessment from the backup evidence it can read, not instructions to change backups. |
Check one affected guest without changing its setup:
@@ -418,8 +418,11 @@ is an inventory discrepancy, before comparing verification. **Unverified** on
the matching point means Pulse has no successful verification evidence for it;
it does not prove that PBS's verification job failed. **Verified** with a
workload still needing attention is a separate assessment disagreement: retain
-its explanation and Provider evidence. A **Protected** point leaves its
-verification state unknown from that label alone. **Job OK** is not an
+its explanation and Provider evidence. A **Kept** point has no reported
+verification result. **Prune protection** is shown separately in the By date
+detail and never replaces a reported **Verified** or **Unverified** state.
+Older Pulse versions may show **Protected** for the prune flag instead. That
+point label alone does not establish verification. **Job OK** is not an
individual point's verification result. Use the records already available,
without running Diagnostics or another verification just to compare them.
diff --git a/frontend-modern/public/docs/PBS.md b/frontend-modern/public/docs/PBS.md
index aba350f0ff..358752580f 100644
--- a/frontend-modern/public/docs/PBS.md
+++ b/frontend-modern/public/docs/PBS.md
@@ -388,7 +388,7 @@ backup or working protection from the strip alone.
| --- | --- |
| **With PBS snapshots** or a matching backup row | That Pulse's protection assessment received the same subject-linked backup evidence. A similar name or guest ID alone is not identity proof. |
| **Verified** on a PBS backup | That every backup is current, every covered disk is included, or the guest recovered after the backup. Verification is evidence about that backup, not a successful restore. |
-| **Protected** in a restore point's **State** | That this point is verified. This displays the backup's protected flag before its verification state; it is not the workload's protection assessment. |
+| **Kept** in a restore point's **State** | A verification result or the workload's protection assessment. This point is kept when pruning, but its verification was not reported. Expand its By date row for separate **Verification** and **Prune protection** details. |
| **Protected**, **Attention**, **Unprotected** or **Unknown** on the workload | An independent check that backups are restorable. These are Pulse's assessment from the backup evidence it can read, not instructions to change backups. |
Check one affected guest without changing its setup:
@@ -418,8 +418,11 @@ is an inventory discrepancy, before comparing verification. **Unverified** on
the matching point means Pulse has no successful verification evidence for it;
it does not prove that PBS's verification job failed. **Verified** with a
workload still needing attention is a separate assessment disagreement: retain
-its explanation and Provider evidence. A **Protected** point leaves its
-verification state unknown from that label alone. **Job OK** is not an
+its explanation and Provider evidence. A **Kept** point has no reported
+verification result. **Prune protection** is shown separately in the By date
+detail and never replaces a reported **Verified** or **Unverified** state.
+Older Pulse versions may show **Protected** for the prune flag instead. That
+point label alone does not establish verification. **Job OK** is not an
individual point's verification result. Use the records already available,
without running Diagnostics or another verification just to compare them.
diff --git a/frontend-modern/src/utils/__tests__/pbsProtectionHelp.test.ts b/frontend-modern/src/utils/__tests__/pbsProtectionHelp.test.ts
index c71dc97ed2..f1c42e7fad 100644
--- a/frontend-modern/src/utils/__tests__/pbsProtectionHelp.test.ts
+++ b/frontend-modern/src/utils/__tests__/pbsProtectionHelp.test.ts
@@ -79,7 +79,7 @@ describe('PBS protection disagreement help', () => {
expect(text()).toContain('without running Diagnostics or another verification');
});
- it('keeps the Protected caution truthful for every hidden verification value', () => {
+ it('keeps retention guidance truthful without hiding a reported verification value', () => {
const point: RecoverableArtifact = {
id: 'fixture-point',
nativeId: 'fixture-point',
@@ -97,15 +97,20 @@ describe('PBS protection disagreement help', () => {
detail: '',
protected: true,
};
- for (const verified of [true, false, undefined]) {
- expect(artifactStateLabel({ ...point, verified })).toBe('Protected');
+ for (const [verified, label] of [
+ [true, 'Verified'],
+ [false, 'Unverified'],
+ [undefined, 'Kept'],
+ ] as const) {
+ expect(artifactStateLabel({ ...point, verified })).toBe(label);
}
expect(artifactStateLabel({ ...point, protected: false, verified: true })).toBe('Verified');
expect(artifactStateLabel({ ...point, protected: false, verified: false })).toBe('Unverified');
- expect(text()).toContain(
- 'Protected point leaves its verification state unknown from that label alone',
- );
- expect(text()).toContain("displays the backup's protected flag before its verification state");
+ expect(text()).toContain('Kept point has no reported verification result');
+ expect(text()).toContain('Prune protection is shown separately in the By date detail');
+ expect(text()).toContain('never replaces a reported Verified or Unverified state');
+ expect(text()).toContain('Older Pulse versions may show Protected for the prune flag instead');
+ expect(text()).toContain('point label alone does not establish verification');
});
it('prevents destructive diagnostics and an assumed freshness-policy cause', () => {