Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Show whole workload names in phone Coverage rows

rcourtman68d9800aece0
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index bc9b254354..b2bb0f9aa4 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -587,6 +587,17 @@ its presentation module are deleted. Backup jobs is the page's one daily bar
chart, so two look-alike bar charts never stack on one page. Earlier notes here
about the chart's tooltip portal and day-control focus are historical.
+### Compact Coverage columns give the name the slack (3 November 2026)
+
+`ProxmoxCoverageTable` takes `identityRows` (every row before filters) to find
+namesakes, and in the compact layout shows the VM id and connection beside the
+name only for them. In the compact layout, once the table knows its width,
+the cells beside the name take their measured needs at 320px (posture 80px
+for "Unknown" with its dot, age 52px for an "Unknown" age, job 34px for its
+header) as shares of that width, and the name takes the rest; without a width
+the shared 40% identity share still applies. At 360px and up a 16-character
+guest name fits whole. Rows stay 32px and single-line.
+
### Backup view tabs head the restore points, not the page (2 November 2026)
On the Backups page the shared `PlatformSectionTabs` ("Backup views": By date,
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index 0809d000f6..006b4770a7 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -5091,6 +5091,17 @@ reserved: the inventory makes no all-time completeness claim. The empty
Coverage table reads "Nothing to check yet". Which workloads each reason
selects is unchanged.
+### Phone Coverage rows keep the workload name whole (3 November 2026)
+
+On a phone the Coverage name cell also carried the VM id and the PVE
+connection, which cut names to a few letters ("ch..."), so every
+"checkout-web-*" guest looked the same. In the compact layout a row now
+shows the name alone unless another Coverage row shares it, judged across
+every row before search and filters so a filter never changes how a row is
+named; namesakes keep the VM id and connection that tell them apart. The
+disclosure label and the row drawer always carry both. Wider layouts are
+unchanged.
+
### Backup health reason rows show they open Coverage (2 November 2026)
Each Backup health reason row was already a button that filters Coverage to
diff --git a/docs/release-control/v6/internal/subsystems/unified-resources.md b/docs/release-control/v6/internal/subsystems/unified-resources.md
index 33a72abd66..7265a9c35d 100644
--- a/docs/release-control/v6/internal/subsystems/unified-resources.md
+++ b/docs/release-control/v6/internal/subsystems/unified-resources.md
@@ -36,6 +36,14 @@ unused `topByMemory` sort ranks no reading as 0. `resource.test.ts` and
`ResourceDetailDrawer.history.test.tsx` cover measured zero, invalid pairs and
percentage-only readings.
+### Phone Coverage names namesakes from every row (3 November 2026)
+
+The compact Coverage table now judges which workloads share a name across
+every Coverage row before search and filters (`identityRows`), using the same
+workload identity it already reads, and keeps the VM id and PVE connection
+beside the name only for those. Workload identity, connection data and the
+disclosure label are unchanged.
+
### Compact Proxmox node Disk cells show the fullest disk (2 November 2026)
A compact Proxmox node row (phone width or compact metrics) has no room for
diff --git a/frontend-modern/browser-verification/b978a12e99c72d38.json b/frontend-modern/browser-verification/b978a12e99c72d38.json
new file mode 100644
index 0000000000..0b4b7ae23e
--- /dev/null
+++ b/frontend-modern/browser-verification/b978a12e99c72d38.json
@@ -0,0 +1,49 @@
+{
+ "version": 1,
+ "base_sha": "749a884113103684f65567cf2fc192f56e9647ea",
+ "verified_at": "2026-11-03T17:48:24Z",
+ "result": "passed",
+ "changed_paths": [
+ "frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx",
+ "frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx",
+ "frontend-modern/src/features/proxmox/proxmoxBackupsTablePresentation.ts"
+ ],
+ "content_sha256": {
+ "frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx": "97f6719d06cdeec63e1610bda56b7ca26c6b9228737d50234a9e2a0e4dbf8f67",
+ "frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx": "ca29105df4774ab40d29dcce415f7e06f36e9ad73cc7474e5cd908f29abbe9f9",
+ "frontend-modern/src/features/proxmox/proxmoxBackupsTablePresentation.ts": "6b8e5fd087e94024bf57bd69f4ce09bc6a496b3f44e77614ee1fa932c3964511"
+ },
+ "routes": [
+ "/proxmox/backups/coverage",
+ "/proxmox/backups/coverage?posture=unknown"
+ ],
+ "viewports": [
+ {
+ "width": 320,
+ "height": 740
+ },
+ {
+ "width": 360,
+ "height": 780
+ },
+ {
+ "width": 390,
+ "height": 844
+ },
+ {
+ "width": 1024,
+ "height": 607
+ }
+ ],
+ "states": [
+ "mock mode built from this change on pulse-dev: 929 guests, many sharing long prefixes such as checkout-web-*, including unknown-posture rows",
+ "phone widths and desktop, dark theme"
+ ],
+ "interactions": [
+ "at 390x844 the workload cells show whole names (checkout-web-110) with no VM id or connection beside them; columns measure 207/80/52/34px, rows 32px, no clipped names",
+ "at 360x780 none of 36 measured names clip (177/80/52/34px)",
+ "at 320x740 posture, age and job cells hold their content on all and on unknown rows (Unknown fits); 16-character names still truncate by one or two characters",
+ "at 1024px the operational layout is unchanged: names keep VM id and PVE connection beside them",
+ "no horizontal page overflow at any width"
+ ]
+}
diff --git a/frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx b/frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx
index 9212bc607a..fd303f4213 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxBackupsTable.tsx
@@ -999,6 +999,7 @@ export const ProxmoxBackupsTable: Component<{
</Show>
<ProxmoxCoverageTable
rows={liveCoverageRows()}
+ identityRows={recoveryModel().coverageRows}
hasAnyRows={liveTotalCount() > 0}
emptyIcon={props.emptyIcon}
emptyTitle="Nothing to check yet"
diff --git a/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx b/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx
index d448139d0e..19a631ee51 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx
@@ -512,6 +512,9 @@ function coverageRestorePointDetails(artifact: RecoverableArtifact) {
// guest's connection is independent of its restore-evidence reader below.
export function ProxmoxCoverageTable(props: {
rows: WorkloadCoverageRow[];
+ // Every row before search and filters, to tell namesakes apart. A filter
+ // that leaves one of two namesakes must not change how that row is named.
+ identityRows?: readonly WorkloadCoverageRow[];
hasAnyRows: boolean;
emptyIcon: JSX.Element;
emptyTitle: string;
@@ -557,8 +560,9 @@ export function ProxmoxCoverageTable(props: {
return rows;
}, []);
const observedWidth = useObservedElementWidth();
+ const containerWidth = () => props.layoutWidth?.() ?? observedWidth.width();
const layoutMode = createMemo(() => {
- const width = props.layoutWidth?.() ?? observedWidth.width();
+ const width = containerWidth();
return typeof width === 'number' && width > 0 ? getCoverageLayoutForContainer(width) : 'full';
});
// Rows stay on one line at every width. The PVE connection is named inline
@@ -569,6 +573,20 @@ export function ProxmoxCoverageTable(props: {
props.showWorkloadConnection ??
hasMultipleConnections(props.rows.map((row) => getBackupWorkloadPVEConnection(row.workload))),
);
+ // On a phone the name column is narrow; the VM id and connection beside the
+ // name cut it to a few letters. There they stay only for namesakes, the rows
+ // they tell apart; the disclosure label and the drawer always carry both.
+ const sharedNames = createMemo(() => {
+ const counts = new Map<string, number>();
+ for (const row of props.identityRows ?? props.rows) {
+ const name = (row.workload.name || row.workload.label).trim().toLowerCase();
+ counts.set(name, (counts.get(name) ?? 0) + 1);
+ }
+ return new Set([...counts].filter(([, count]) => count > 1).map(([name]) => name));
+ });
+ const showIdentityBesideName = (row: WorkloadCoverageRow): boolean =>
+ layoutMode() !== 'compact' ||
+ sharedNames().has((row.workload.name || row.workload.label).trim().toLowerCase());
const visibleColumns = createMemo(() =>
getCoverageColumns(layoutMode(), {
task: props.showTaskColumn,
@@ -614,7 +632,12 @@ export function ProxmoxCoverageTable(props: {
<For each={visibleColumns()}>
{(column) => (
<col
- style={getCoverageColumnWidthStyle(column.id, layoutMode(), visibleColumnIds())}
+ style={getCoverageColumnWidthStyle(
+ column.id,
+ layoutMode(),
+ visibleColumnIds(),
+ containerWidth() ?? undefined,
+ )}
data-proxmox-backups-column={column.id}
/>
)}
@@ -727,6 +750,7 @@ export function ProxmoxCoverageTable(props: {
</span>
<Show
when={
+ showIdentityBesideName(row) &&
!columnVisible('targetId') &&
row.workload.name &&
row.workload.name.trim() !==
@@ -740,6 +764,7 @@ export function ProxmoxCoverageTable(props: {
</Show>
<Show
when={
+ showIdentityBesideName(row) &&
showWorkloadConnection() &&
getBackupWorkloadPVEConnection(row.workload)
}
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxCoverageTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxCoverageTable.test.tsx
index 7d4c73a350..548ade02ac 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxCoverageTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxCoverageTable.test.tsx
@@ -70,6 +70,77 @@ const headerTexts = () =>
afterEach(cleanup);
describe('ProxmoxCoverageTable column visibility', () => {
+ it('gives a phone row its full name, keeping the VM id only for namesakes', () => {
+ const guest = (key: string, name: string, vmid: string, node: string) =>
+ ({
+ ...row,
+ key,
+ workload: { ...row.workload, key, name, vmid, node, label: `${name} (VM ${vmid})` },
+ }) as WorkloadCoverageRow;
+ renderInRouter(() => (
+ <ProxmoxCoverageTable
+ rows={[
+ guest('a', 'checkout-web-02', '101', 'pve1'),
+ guest('b', 'db', '200', 'pve1'),
+ guest('c', 'db', '201', 'pve2'),
+ ]}
+ hasAnyRows
+ emptyIcon={<span />}
+ emptyTitle=""
+ emptyDescription=""
+ sortKey={() => 'posture'}
+ sortDirection={() => 'asc'}
+ onSort={() => {}}
+ expandedKey={null}
+ onToggleExpand={() => {}}
+ layoutWidth={() => 375}
+ showTaskColumn
+ />
+ ));
+ const nameCell = (name: RegExp) => screen.getByRole('button', { name }).closest('td')!;
+ // A unique name stands alone, so the narrow column holds it in full; its
+ // disclosure label still names the VM.
+ expect(nameCell(/Expand details for checkout-web-02/)).toHaveTextContent(/^checkout-web-02$/);
+ expect(
+ screen.getByRole('button', { name: /Expand details for checkout-web-02 \(VM 101\)/ }),
+ ).toBeInTheDocument();
+ // Namesakes keep the id that tells them apart.
+ expect(nameCell(/Expand details for db \(VM 200\)/)).toHaveTextContent('VM 200');
+ expect(nameCell(/Expand details for db \(VM 201\)/)).toHaveTextContent('VM 201');
+ });
+
+ it("keeps a namesake's VM id on a phone when a filter hides its twin, across letter case", () => {
+ const guest = (key: string, name: string, vmid: string) =>
+ ({
+ ...row,
+ key,
+ workload: { ...row.workload, key, name, vmid, label: `${name} (VM ${vmid})` },
+ }) as WorkloadCoverageRow;
+ const all = [guest('b', 'DB', '200'), guest('c', 'db ', '201'), guest('d', 'web', '300')];
+ renderInRouter(() => (
+ <ProxmoxCoverageTable
+ rows={[all[0], all[2]]}
+ identityRows={all}
+ hasAnyRows
+ emptyIcon={<span />}
+ emptyTitle=""
+ emptyDescription=""
+ sortKey={() => 'posture'}
+ sortDirection={() => 'asc'}
+ onSort={() => {}}
+ expandedKey={null}
+ onToggleExpand={() => {}}
+ layoutWidth={() => 375}
+ showTaskColumn
+ />
+ ));
+ const nameCell = (name: RegExp) => screen.getByRole('button', { name }).closest('td')!;
+ // "DB" and "db " are the same name to a reader; the filtered-out twin
+ // still counts, so the visible one keeps its id.
+ expect(nameCell(/Expand details for DB \(VM 200\)/)).toHaveTextContent('VM 200');
+ expect(nameCell(/Expand details for web \(VM 300\)/)).toHaveTextContent(/^web$/);
+ });
+
it('keeps a visible native phone disclosure through row activation and refresh [visible-coverage-disclosure]', () => {
const [rows, setRows] = createSignal([row]);
const [expanded, setExpanded] = createSignal<string | null>(null);
diff --git a/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupsTablePresentation.test.ts b/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupsTablePresentation.test.ts
index cd0bec13bc..f40d9aef02 100644
--- a/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupsTablePresentation.test.ts
+++ b/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupsTablePresentation.test.ts
@@ -115,6 +115,29 @@ describe('Proxmox backups responsive table presentation', () => {
).toEqual({
width: '40%',
});
+ // With a measured table, the short phone cells take what they need and
+ // the name, the only identity on a phone row, takes the rest.
+ const compactIds = ids(getCoverageColumns('compact', withTasks));
+ expect(getCoverageColumnWidthStyle('posture', 'compact', compactIds, 342)).toEqual({
+ width: '23.39%',
+ });
+ expect(getCoverageColumnWidthStyle('workload', 'compact', compactIds, 342)).toEqual({
+ width: '51.46%',
+ });
+ expect(getCoverageColumnWidthStyle('workload', 'compact', compactIds, 302)).toEqual({
+ width: '45.03%',
+ });
+ // Without the Job column its room goes to the name.
+ const noJob = compactIds.filter((id) => id !== 'task');
+ expect(getCoverageColumnWidthStyle('workload', 'compact', noJob, 342)).toEqual({
+ width: '61.4%',
+ });
+ // An unknown or zero width keeps the shared phone share.
+ for (const width of [undefined, 0]) {
+ expect(getCoverageColumnWidthStyle('workload', 'compact', compactIds, width)).toEqual({
+ width: '40%',
+ });
+ }
expect(ids(getCoverageColumns('operational', withTasks))).toEqual([
'workload',
'type',
diff --git a/frontend-modern/src/features/proxmox/proxmoxBackupsTablePresentation.ts b/frontend-modern/src/features/proxmox/proxmoxBackupsTablePresentation.ts
index c3d9980320..7e794d181f 100644
--- a/frontend-modern/src/features/proxmox/proxmoxBackupsTablePresentation.ts
+++ b/frontend-modern/src/features/proxmox/proxmoxBackupsTablePresentation.ts
@@ -193,25 +193,57 @@ export const getCoverageColumns = (
});
};
+// Coverage's phone rows carry only the name in their identity cell, and guest
+// names often share a long prefix ("checkout-web-110"), so cutting their ends
+// hides what tells them apart. The cells beside it hold short, fixed content,
+// measured at 320px: "Unknown" with its dot, an "Unknown" age, the job dot
+// under "Job". When the table knows its width they take exactly that and the
+// name takes the rest, instead of a fixed share that wastes room at 360px and
+// up. A 302px table still leaves the other cells whole.
+const COVERAGE_COMPACT_CELL_WIDTH_PX: Partial<Record<CoverageColumnId, number>> = {
+ posture: 80,
+ latest: 52,
+ task: 34,
+};
+
+const compactCoverageWidthStyle = (
+ columnId: CoverageColumnId,
+ visibleColumnIds: readonly CoverageColumnId[],
+ containerWidth: number,
+): JSX.CSSProperties => {
+ const share = (px: number) => (px / containerWidth) * 100;
+ if (columnId !== 'workload') {
+ const px = COVERAGE_COMPACT_CELL_WIDTH_PX[columnId];
+ return px ? { width: `${Number(share(px).toFixed(2))}%` } : {};
+ }
+ const taken = visibleColumnIds
+ .filter((id) => id !== 'workload')
+ .reduce((sum, id) => sum + share(COVERAGE_COMPACT_CELL_WIDTH_PX[id] ?? 0), 0);
+ return { width: `${Number(Math.max(0, 100 - taken).toFixed(2))}%` };
+};
+
export const getCoverageColumnWidthStyle = (
columnId: CoverageColumnId,
layout: ProxmoxBackupsTableLayoutMode,
visibleColumnIds: readonly CoverageColumnId[],
+ containerWidth?: number,
): JSX.CSSProperties =>
- getPlatformTableWeightedColumnWidthStyle(
- columnId,
- COVERAGE_WEIGHTS[layout],
- visibleColumnIds,
- layout === 'compact' || layout === 'basic'
- ? {
- columnId: 'workload',
- widthPercent:
- layout === 'compact'
- ? PLATFORM_TABLE_NARROW_IDENTITY_WIDTH_PERCENT
- : PLATFORM_TABLE_PHONE_IDENTITY_WIDTH_PERCENT,
- }
- : undefined,
- );
+ layout === 'compact' && typeof containerWidth === 'number' && containerWidth > 0
+ ? compactCoverageWidthStyle(columnId, visibleColumnIds, containerWidth)
+ : getPlatformTableWeightedColumnWidthStyle(
+ columnId,
+ COVERAGE_WEIGHTS[layout],
+ visibleColumnIds,
+ layout === 'compact' || layout === 'basic'
+ ? {
+ columnId: 'workload',
+ widthPercent:
+ layout === 'compact'
+ ? PLATFORM_TABLE_NARROW_IDENTITY_WIDTH_PERCENT
+ : PLATFORM_TABLE_PHONE_IDENTITY_WIDTH_PERCENT,
+ }
+ : undefined,
+ );
export const RECOVERABLE_COLUMNS: readonly BackupTableColumn<RecoverableColumnId>[] = [
{ id: 'workload', label: 'Workload', kind: 'name' },