Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep TrueNAS protection evidence readable on phones

pulse-triage[bot]69bfe382accd
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index 4f2c2b0c7c..979511f1b2 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -21,6 +21,21 @@
## Purpose
+### Phone protection summaries prioritise completion and outcome
+
+TrueNAS Protection uses the existing container-led phone projection to keep
+Dataset, Finished and the labelled Outcome readable in single-line summary
+rows. Artifact and Target columns return at the shared wider-table breakpoint;
+both remain available in the existing wrapping inline details on phones. Header
+and body priorities match. The completion sort remains available, and the same
+actual-finish requirement applies to summary, sort and details: running and
+start-only events still have no completion evidence. The registered
+`TrueNASProtectionTable.completion.test.tsx` pairs those priorities and exercises
+the real query/normalizer through details and completion transitions. Source-bound
+desktop and narrow browser proof establishes actual fit and interaction; a DOM
+class assertion alone does not establish readability. No date, outcome, query,
+API, identity, policy or recovery operation changes.
+
### TrueNAS start and active-run dates are not completion evidence
The Protection table's Completed column, its explicit completion sort and its
diff --git a/frontend-modern/src/features/truenas/TrueNASProtectionTable.tsx b/frontend-modern/src/features/truenas/TrueNASProtectionTable.tsx
index 23f4aafd8d..ea39056bdc 100644
--- a/frontend-modern/src/features/truenas/TrueNASProtectionTable.tsx
+++ b/frontend-modern/src/features/truenas/TrueNASProtectionTable.tsx
@@ -485,6 +485,8 @@ export const TrueNASProtectionTable: Component<{
tableClass="min-w-full table-fixed text-xs md:min-w-[960px]"
header={
<>
+ {/* On phones, keep identity, completion and outcome readable.
+ Artifact and target remain in the existing wrapping details. */}
<PlatformSortableTableHead
kind="name"
sort={sort}
@@ -497,7 +499,7 @@ export const TrueNASProtectionTable: Component<{
kind="text"
sort={sort}
sortKey="artifact"
- class="platform-table-mobile-w-25 md:w-[25%]"
+ class="platform-table-phone-hidden md:w-[25%]"
>
Artifact
</PlatformSortableTableHead>
@@ -505,7 +507,7 @@ export const TrueNASProtectionTable: Component<{
kind="text"
sort={sort}
sortKey="target"
- class="platform-table-mobile-w-15 md:w-[23%]"
+ class="platform-table-phone-hidden md:w-[23%]"
>
Target
</PlatformSortableTableHead>
@@ -513,7 +515,7 @@ export const TrueNASProtectionTable: Component<{
kind="numeric-value"
sort={sort}
sortKey="completed"
- class="platform-table-mobile-w-15 md:w-[12%]"
+ class="md:w-[12%]"
>
<PlatformResponsiveTableLabel compact="Finished" full="Completed" />
</PlatformSortableTableHead>
@@ -529,7 +531,7 @@ export const TrueNASProtectionTable: Component<{
kind="badge"
sort={sort}
sortKey="outcome"
- class="platform-table-mobile-w-15 md:w-[9%]"
+ class="platform-table-mobile-w-25 md:w-[9%]"
>
Outcome
</PlatformSortableTableHead>
@@ -568,7 +570,9 @@ export const TrueNASProtectionTable: Component<{
}
/>
</TableCell>
- <TableCell class={getPlatformTableCellClassForKind('text')}>
+ <TableCell
+ class={`${getPlatformTableCellClassForKind('text')} platform-table-phone-hidden`}
+ >
<span
class="block truncate text-base-content"
title={[artifact(), artifactSecondary()]
@@ -578,7 +582,9 @@ export const TrueNASProtectionTable: Component<{
{artifact()}
</span>
</TableCell>
- <TableCell class={getPlatformTableCellClassForKind('text')}>
+ <TableCell
+ class={`${getPlatformTableCellClassForKind('text')} platform-table-phone-hidden`}
+ >
<span
class="block truncate text-base-content"
title={[target(), targetSecondary()].filter(Boolean).join(' · ')}
diff --git a/frontend-modern/src/features/truenas/__tests__/TrueNASProtectionTable.completion.test.tsx b/frontend-modern/src/features/truenas/__tests__/TrueNASProtectionTable.completion.test.tsx
index 920276c6f3..af5ebf2eff 100644
--- a/frontend-modern/src/features/truenas/__tests__/TrueNASProtectionTable.completion.test.tsx
+++ b/frontend-modern/src/features/truenas/__tests__/TrueNASProtectionTable.completion.test.tsx
@@ -64,6 +64,66 @@ afterEach(() => {
});
describe('TrueNAS protection completion evidence', () => {
+ it('pairs phone column priorities with their cells and preserves the hidden fields in details', async () => {
+ apiFetchJSON.mockResolvedValueOnce({
+ data: [
+ point('phone', {
+ completedAt,
+ display: {
+ subjectLabel: 'tank/departmental-archives',
+ subjectType: 'dataset',
+ nodeHostLabel: 'nas-east',
+ },
+ details: {
+ taskName: 'replicate-departmental-archives-to-offsite',
+ targetDataset: 'vault/offsite/departmental-archives',
+ },
+ }),
+ ],
+ });
+ mountProtection();
+ await vi.waitFor(() => expect(row('phone')).not.toBeNull());
+ const cells = row('phone').querySelectorAll('td');
+ for (const [label, index] of [
+ ['Artifact', 1],
+ ['Target', 2],
+ ] as const) {
+ expect(screen.getByRole('columnheader', { name: label })).toHaveClass(
+ 'platform-table-phone-hidden',
+ );
+ expect(cells[index]).toHaveClass('platform-table-phone-hidden');
+ }
+ for (const [label, index] of [
+ ['Dataset', 0],
+ ['Completed', 3],
+ ['Outcome', 5],
+ ] as const) {
+ expect(screen.getByRole('columnheader', { name: new RegExp(label) })).not.toHaveClass(
+ 'platform-table-phone-hidden',
+ );
+ expect(cells[index]).not.toHaveClass('platform-table-phone-hidden');
+ }
+ expect(screen.getByRole('columnheader', { name: /Completed/ })).not.toHaveClass(
+ 'platform-table-mobile-w-15',
+ );
+ expect(screen.getByRole('columnheader', { name: 'Outcome' })).toHaveClass(
+ 'platform-table-mobile-w-25',
+ );
+ await fireEvent.click(
+ within(row('phone')).getByRole('button', { name: /details.*tank\/departmental-archives/i }),
+ );
+ const detail = within(screen.getByTestId('truenas-protection-detail'));
+ expect(detail.getByText('Artifact', { exact: true }).closest('tr')).toHaveTextContent(
+ 'replicate-departmental-archives-to-offsite',
+ );
+ expect(detail.getByText('Target', { selector: 'td', exact: true }).closest('tr')).toHaveTextContent(
+ 'vault/offsite/departmental-archives',
+ );
+ expect(detail.getByText('Host', { exact: true }).closest('tr')).toHaveTextContent('nas-east');
+ expect(detail.getByText('Completed', { exact: true }).closest('tr')).toHaveTextContent('2026');
+ expect(detail.getByText('Outcome', { exact: true }).closest('tr')).toHaveTextContent('Healthy');
+ });
+
it('never substitutes a start or a running last-run date for completion in rows or details', async () => {
apiFetchJSON.mockResolvedValueOnce({
data: [