Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep revised secondary issue topics in the review queue

pulse-triage[bot]6ab763c2e6dd
diff --git a/.github/scripts/issue-version-triage.cjs b/.github/scripts/issue-version-triage.cjs
index 4af8321c9d..5b5397e045 100644
--- a/.github/scripts/issue-version-triage.cjs
+++ b/.github/scripts/issue-version-triage.cjs
@@ -107,13 +107,17 @@ function extractSectionValue(body, heading, followingHeadings = []) {
return lines.slice(start + 1, end).map((line) => line.text).join("\n").trim();
}
-function classifyAdditionalActionableTopics(body) {
- const value = extractSectionValue(body, "Additional actionable topics", [
+function additionalActionableTopicsValue(body) {
+ return extractSectionValue(body, "Additional actionable topics", [
"Pulse version",
"Additional context",
"Logs, screenshots, or diagnostics",
"Confirmations",
]);
+}
+
+function classifyAdditionalActionableTopics(body) {
+ const value = additionalActionableTopicsValue(body);
if (value === null) return null;
const normalized = value
@@ -388,17 +392,19 @@ async function syncLabels({ github, context, core }) {
isBugLike,
} = buildTriageState(issue, core, null);
- // A form declaration creates a review task only when it is new. A later
+ // A new or revised form declaration creates a review task. A later
// empty field cannot prove that comment topics were dispositioned, and an
// unrelated or superseded event must not restore a label Community cleared.
const previousBody = context.payload.changes?.body?.from;
+ const topicText = (body) => (additionalActionableTopicsValue(body) || "")
+ .replace(/\s+/g, " ").trim();
const eventIsCurrent = typeof issue.updated_at === "string" &&
issue.body === eventIssue.body &&
issue.updated_at === eventIssue.updated_at;
const newlyDeclared = eventIsCurrent && hasAdditionalActionableTopics === true && (
context.payload.action === "opened" ||
(context.payload.action === "edited" && previousBody !== undefined &&
- classifyAdditionalActionableTopics(previousBody) !== true)
+ topicText(previousBody) !== topicText(issue.body))
);
if (newlyDeclared) {
core.info("Issue newly declares additional actionable topics; decomposition is required.");
diff --git a/.github/scripts/issue-version-triage.test.cjs b/.github/scripts/issue-version-triage.test.cjs
index 5c6db3ed5c..0037a420f9 100644
--- a/.github/scripts/issue-version-triage.test.cjs
+++ b/.github/scripts/issue-version-triage.test.cjs
@@ -281,6 +281,87 @@ test("syncLabels adds newly declared topics but respects a completed disposition
}
});
+for (const [name, before, after] of [
+ ["appended", "Add a storage filter.", "Add a storage filter.\nAlso retain failed notification attempts."],
+ ["replaced", "Add a storage filter.", "Retain failed notification attempts."],
+ ["revised", "Retain one failed attempt.", "Retain every failed attempt."],
+]) {
+ test(`syncLabels requeues ${name} secondary topics after an earlier disposition`, async () => {
+ const body = value => `### Additional actionable topics\n${value}\n### Pulse version\n6.5.0\n`;
+ const { github, calls } = createGithub();
+ await syncLabels({
+ github,
+ context: createContext({ action: "edited", previousBody: body(before), issue: {
+ number: 1796, title: "Monitoring workflow", body: body(after),
+ labels: [{ name: "enhancement" }, { name: "operator-reviewed" }],
+ } }),
+ core: createCore(),
+ });
+ assert.deepEqual(calls.addLabels.map(call => call.labels), [["needs-decomposition"]]);
+ assert.equal(calls.removeLabel.length, 0);
+ assert.equal(calls.createComment.length, 0);
+ assert.equal(calls.getLatestRelease.length, 0);
+ });
+}
+
+for (const [name, before, after] of [
+ ["an unrelated field", "### Summary\nOld wording\n### Additional actionable topics\nAdd a storage filter.\n",
+ "### Summary\nNew wording\n### Additional actionable topics\nAdd a storage filter.\n"],
+ ["whitespace only", "### Additional actionable topics\nRetain every failed attempt.\n",
+ "### Additional actionable topics\n\nRetain every\nfailed attempt. \n"],
+ ["hidden comments only", "### Additional actionable topics\nRetain every failed attempt. <!-- old note -->\n",
+ "### Additional actionable topics\nRetain every failed attempt. <!-- new note -->\n"],
+ ["removing the topics", "### Additional actionable topics\nAdd a storage filter.\n",
+ "### Additional actionable topics\nNone.\n"],
+]) {
+ test(`syncLabels does not requeue dispositioned topics for ${name}`, async () => {
+ const { github, calls } = createGithub();
+ await syncLabels({
+ github,
+ context: createContext({ action: "edited", previousBody: before, issue: {
+ number: 1796, title: "Monitoring workflow", body: after,
+ labels: [{ name: "enhancement" }, { name: "operator-reviewed" }],
+ } }),
+ core: createCore(),
+ });
+ assert.equal(calls.addLabels.length, 0);
+ assert.equal(calls.removeLabel.length, 0);
+ assert.equal(calls.createComment.length, 0);
+ });
+}
+
+test("triage guidance preserves revised-topic review", () => {
+ const guide = fs.readFileSync(path.resolve(__dirname, "../../docs/ISSUE_TRIAGE.md"), "utf8");
+ assert.match(guide.replace(/\s+/g, " "), /adding or revising actionable content/);
+ assert.match(guide, /after an earlier topic was dispositioned/);
+});
+
+test("a revised topic cannot override a newer Community disposition", async () => {
+ const previousBody = "### Additional actionable topics\nRetain one failed attempt.\n";
+ const issue = {
+ number: 1796, title: "Monitoring workflow", state: "open",
+ body: "### Additional actionable topics\nRetain every failed attempt.\n",
+ updated_at: "2026-10-08T10:00:00Z", labels: [{ name: "enhancement" }],
+ };
+ for (const stage of ["before initial read", "during label preparation"]) {
+ const { github, calls } = createGithub({ currentIssue: { ...issue } });
+ if (stage === "before initial read") {
+ github.currentIssue.updated_at = "2026-10-08T11:00:00Z";
+ } else {
+ const getLabel = github.rest.issues.getLabel;
+ github.rest.issues.getLabel = async payload => {
+ github.currentIssue = { ...issue, updated_at: "2026-10-08T11:00:00Z" };
+ return getLabel(payload);
+ };
+ }
+ await syncLabels({ github, core: createCore(),
+ context: createContext({ action: "edited", previousBody, issue }) });
+ assert.equal(calls.addLabels.length, 0, stage);
+ assert.equal(calls.removeLabel.length, 0, stage);
+ assert.equal(calls.createComment.length, 0, stage);
+ }
+});
+
test("additional topic classification is explicit and fail-quiet for legacy forms", () => {
const { classifyAdditionalActionableTopics } = triage.internals;
diff --git a/docs/ISSUE_TRIAGE.md b/docs/ISSUE_TRIAGE.md
index 376eca0978..2a17c2825c 100644
--- a/docs/ISSUE_TRIAGE.md
+++ b/docs/ISSUE_TRIAGE.md
@@ -7,8 +7,10 @@ documentation gaps, or operator workflows described in the same report.
## Intake contract
Issue forms ask for one primary outcome and provide an **Additional actionable
-topics** field. Declaring a topic when opening an issue or newly adding one to
-this field applies the `needs-decomposition` label automatically. This is a
+topics** field. Declaring a topic when opening an issue, or adding or revising
+actionable content in this field, applies the `needs-decomposition` label
+automatically, including after an earlier topic was dispositioned. Whitespace
+or hidden-comment changes alone do not reopen that review. This is a
queue-integrity signal, not a statement that every topic will be built.
The synchronizer never removes this label, nor restores it after a maintainer
has cleared it when an unrelated edit or reopen occurs. A later `None` in the
diff --git a/frontend-modern/browser-verification/0fcfebd9d44e74c3.json b/frontend-modern/browser-verification/0fcfebd9d44e74c3.json
new file mode 100644
index 0000000000..b54dab0b21
--- /dev/null
+++ b/frontend-modern/browser-verification/0fcfebd9d44e74c3.json
@@ -0,0 +1,35 @@
+{
+ "version": 1,
+ "base_sha": "871d94f53d48af1f98ac5a1412b35f1410a373d0",
+ "verified_at": "2026-10-24T00:59:05Z",
+ "result": "passed",
+ "changed_paths": [
+ "frontend-modern/public/docs/ISSUE_TRIAGE.md"
+ ],
+ "content_sha256": {
+ "frontend-modern/public/docs/ISSUE_TRIAGE.md": "8eea911fbfc8a758ee3374327e47b483cf2a42404d750caf093a4d68bb7cac07"
+ },
+ "routes": [
+ "/docs/ISSUE_TRIAGE"
+ ],
+ "viewports": [
+ {
+ "width": 1440,
+ "height": 1000
+ },
+ {
+ "width": 320,
+ "height": 900
+ }
+ ],
+ "states": [
+ "Source and served triage guidance describe additions and revisions after an earlier topic disposition, while whitespace and hidden-comment-only edits do not reopen review.",
+ "Actual production Docs.tsx, docMarkdown.ts, PageHeader and production CSS consume the planned final static Markdown. A synthetic router/static preview has no backend, external service or credentials.",
+ "Playwright 1.56.1; Chromium 141.0.7390.37 at 1440\u00d71000 and WebKit 26.0 at 320\u00d7900. No page/console error or horizontal overflow; browser contexts and server close.",
+ "Both retained screenshots were opened with the native image tool. Changed text and focused documentation link are readable at both widths. No stopped Docs Back/reload or original SSO/native recovery is exercised."
+ ],
+ "interactions": [
+ "Loaded the existing document route once in each synthetic browser context; no history Back or reload.",
+ "Used Tab to focus the actual All documentation link and checked visible keyboard focus without following it."
+ ]
+}
diff --git a/frontend-modern/public/docs/ISSUE_TRIAGE.md b/frontend-modern/public/docs/ISSUE_TRIAGE.md
index 376eca0978..2a17c2825c 100644
--- a/frontend-modern/public/docs/ISSUE_TRIAGE.md
+++ b/frontend-modern/public/docs/ISSUE_TRIAGE.md
@@ -7,8 +7,10 @@ documentation gaps, or operator workflows described in the same report.
## Intake contract
Issue forms ask for one primary outcome and provide an **Additional actionable
-topics** field. Declaring a topic when opening an issue or newly adding one to
-this field applies the `needs-decomposition` label automatically. This is a
+topics** field. Declaring a topic when opening an issue, or adding or revising
+actionable content in this field, applies the `needs-decomposition` label
+automatically, including after an earlier topic was dispositioned. Whitespace
+or hidden-comment changes alone do not reopen that review. This is a
queue-integrity signal, not a statement that every topic will be built.
The synchronizer never removes this label, nor restores it after a maintainer
has cleared it when an unrelated edit or reopen occurs. A later `None` in the