Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Remove inert runtime alert switches and explain their supported scope

pulse-triage[bot]6fa11969b239
diff --git a/docs/release-control/v6/internal/subsystems/alerts.md b/docs/release-control/v6/internal/subsystems/alerts.md
index 3c56bc1cd4..9d72b6a04c 100644
--- a/docs/release-control/v6/internal/subsystems/alerts.md
+++ b/docs/release-control/v6/internal/subsystems/alerts.md
@@ -15,6 +15,28 @@
## Purpose
+### Runtime alert controls describe only supported scope (28 October 2026)
+
+Container Runtime rows expose their existing Offline Alerts control, not an
+all-alerts switch or metric bulk editor that cannot mutate runtime settings.
+Visible guidance explains that connectivity settings do not mute container or
+machine alerts, and directs operators to existing per-container Alerts switches
+and saving; newly added containers need their own setting. No single-runtime
+child mute, inheritance, policy evaluation, persistence or machine-wide mute is
+introduced. Existing global-disabled connectivity precedence remains intact.
+
+The shared resource table can omit the Alerts column for this connectivity-only
+surface, including row, group, default, delay and empty-state column counts;
+other tables retain their existing controls by default. Phone cards honour the
+same choice. `ResourceTable.test.tsx` and `ThresholdsTable.test.tsx` verify the
+omitted controls, remaining connectivity action, independent container drafts
+and preserved machine/other-runtime settings. Desktop and narrow browser proof
+must join the real projection, mutation hooks and consuming table, not an Off
+label unsupported by the producer. This is truthful control presentation, not
+fulfilment of discussion #3432/#2107 whole-runtime-and-children demand, recipient
+proof, installed recovery or release availability.
+
+
### Missing PBS node-status polls restart metric timing
When PBS node-status collection fails, absent CPU and memory observations pass
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 5fa49ebb02..2840b61454 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -20,6 +20,28 @@
## Purpose
+### Runtime alert controls describe only supported scope (28 October 2026)
+
+Container Runtime rows expose their existing Offline Alerts control, not an
+all-alerts switch or metric bulk editor that cannot mutate runtime settings.
+Visible guidance explains that connectivity settings do not mute container or
+machine alerts, and directs operators to existing per-container Alerts switches
+and saving; newly added containers need their own setting. No single-runtime
+child mute, inheritance, policy evaluation, persistence or machine-wide mute is
+introduced. Existing global-disabled connectivity precedence remains intact.
+
+The shared resource table can omit the Alerts column for this connectivity-only
+surface, including row, group, default, delay and empty-state column counts;
+other tables retain their existing controls by default. Phone cards honour the
+same choice. `ResourceTable.test.tsx` and `ThresholdsTable.test.tsx` verify the
+omitted controls, remaining connectivity action, independent container drafts
+and preserved machine/other-runtime settings. Desktop and narrow browser proof
+must join the real projection, mutation hooks and consuming table, not an Off
+label unsupported by the producer. This is truthful control presentation, not
+fulfilment of discussion #3432/#2107 whole-runtime-and-children demand, recipient
+proof, installed recovery or release availability.
+
+
### Coverage evidence remains inspectable without a pointer
The bounded Coverage preview includes undated source/state witnesses and a
diff --git a/frontend-modern/src/components/Alerts/AlertResourceTableDesktop.tsx b/frontend-modern/src/components/Alerts/AlertResourceTableDesktop.tsx
index 0e079fcb83..78fb4df493 100644
--- a/frontend-modern/src/components/Alerts/AlertResourceTableDesktop.tsx
+++ b/frontend-modern/src/components/Alerts/AlertResourceTableDesktop.tsx
@@ -70,7 +70,8 @@ interface AlertResourceTableDesktopProps {
export function AlertResourceTableDesktop(props: AlertResourceTableDesktopProps) {
const totalColumnCount = () =>
props.table.columns.length +
- 3 +
+ 2 +
+ (props.table.showAlertsColumn === false ? 0 : 1) +
(props.table.showOfflineAlertsColumn ? 1 : 0) +
(props.table.onBulkEdit ? 1 : 0);
@@ -152,6 +153,7 @@ export function AlertResourceTableDesktop(props: AlertResourceTableDesktopProps)
onSaveEdit={props.table.onSaveEdit}
onCancelEdit={props.table.onCancelEdit}
onRemoveOverride={props.table.onRemoveOverride}
+ showAlertsColumn={props.table.showAlertsColumn}
onToggleDisabled={props.table.onToggleDisabled}
onToggleNodeConnectivity={props.table.onToggleNodeConnectivity}
showOfflineAlertsColumn={props.table.showOfflineAlertsColumn}
@@ -199,9 +201,11 @@ export function AlertResourceTableDesktop(props: AlertResourceTableDesktopProps)
/>
</TableHead>
</Show>
- <TableHead class={`${getPlatformTableHeadClassForKind('badge')} w-16`}>
- Alerts
- </TableHead>
+ <Show when={props.table.showAlertsColumn !== false}>
+ <TableHead class={`${getPlatformTableHeadClassForKind('badge')} w-16`}>
+ Alerts
+ </TableHead>
+ </Show>
<TableHead class={`${getPlatformTableHeadClassForKind('name')} w-1/4`}>
Resource
</TableHead>
@@ -245,30 +249,32 @@ export function AlertResourceTableDesktop(props: AlertResourceTableDesktopProps)
class={`${getPlatformTableCellClassForKind('badge')} border-r border-border`}
/>
</Show>
- <TableCell class={`${getPlatformTableCellClassForKind('badge')} align-middle`}>
- <Show
- when={props.table.onToggleGlobalDisable}
- fallback={
- <span class="text-sm text-slate-400" aria-hidden="true">
- -
- </span>
- }
- >
- <div class="flex items-center justify-center">
- <TogglePrimitive
- size="sm"
- checked={!props.table.globalDisableFlag?.()}
- onToggle={() => {
- props.table.onToggleGlobalDisable?.();
- props.table.setHasUnsavedChanges?.(true);
- }}
- class="-my-0.5"
- title="Global alerts toggle - disable all alerts for this resource type"
- ariaLabel="Global alerts toggle"
- />
- </div>
- </Show>
- </TableCell>
+ <Show when={props.table.showAlertsColumn !== false}>
+ <TableCell class={`${getPlatformTableCellClassForKind('badge')} align-middle`}>
+ <Show
+ when={props.table.onToggleGlobalDisable}
+ fallback={
+ <span class="text-sm text-slate-400" aria-hidden="true">
+ -
+ </span>
+ }
+ >
+ <div class="flex items-center justify-center">
+ <TogglePrimitive
+ size="sm"
+ checked={!props.table.globalDisableFlag?.()}
+ onToggle={() => {
+ props.table.onToggleGlobalDisable?.();
+ props.table.setHasUnsavedChanges?.(true);
+ }}
+ class="-my-0.5"
+ title="Global alerts toggle - disable all alerts for this resource type"
+ ariaLabel="Global alerts toggle"
+ />
+ </div>
+ </Show>
+ </TableCell>
+ </Show>
<TableCell class={getPlatformTableCellClassForKind('name')}>
<div class="flex items-center gap-2">
<span class="text-sm font-semibold text-base-content">Global Defaults</span>
@@ -431,11 +437,13 @@ export function AlertResourceTableDesktop(props: AlertResourceTableDesktopProps)
class={`${getPlatformTableCellClassForKind('badge')} border-r border-border`}
/>
</Show>
- <TableCell class={`${getPlatformTableCellClassForKind('badge')} align-middle`}>
- <span class="text-sm" aria-hidden="true">
- -
- </span>
- </TableCell>
+ <Show when={props.table.showAlertsColumn !== false}>
+ <TableCell class={`${getPlatformTableCellClassForKind('badge')} align-middle`}>
+ <span class="text-sm" aria-hidden="true">
+ -
+ </span>
+ </TableCell>
+ </Show>
<TableCell class={`${getPlatformTableCellClassForKind('name')} align-middle`}>
<span class="text-xs font-semibold uppercase tracking-wide text-muted inline-flex items-center gap-1">
{getAlertResourceTableAlertDelayLabel()}
diff --git a/frontend-modern/src/components/Alerts/AlertResourceTableMobile.tsx b/frontend-modern/src/components/Alerts/AlertResourceTableMobile.tsx
index e992af0caa..72a6bac84c 100644
--- a/frontend-modern/src/components/Alerts/AlertResourceTableMobile.tsx
+++ b/frontend-modern/src/components/Alerts/AlertResourceTableMobile.tsx
@@ -195,7 +195,9 @@ export function AlertResourceTableMobile(props: AlertResourceTableMobileProps) {
</span>
</Show>
</div>
- <Show when={props.table.onToggleGlobalDisable}>
+ <Show
+ when={props.table.showAlertsColumn !== false && props.table.onToggleGlobalDisable}
+ >
<TogglePrimitive
size="sm"
checked={!props.table.globalDisableFlag?.()}
@@ -334,7 +336,9 @@ export function AlertResourceTableMobile(props: AlertResourceTableMobileProps) {
>
<div class="flex items-center justify-between">
<div class="flex items-center gap-3 min-w-0">
- <Show when={props.table.onToggleDisabled}>
+ <Show
+ when={props.table.showAlertsColumn !== false && props.table.onToggleDisabled}
+ >
<div class="shrink-0 scale-90 origin-left">
<TogglePrimitive
size="sm"
diff --git a/frontend-modern/src/components/Alerts/AlertResourceTableRow.tsx b/frontend-modern/src/components/Alerts/AlertResourceTableRow.tsx
index 91ac90a1f5..6056c6a950 100644
--- a/frontend-modern/src/components/Alerts/AlertResourceTableRow.tsx
+++ b/frontend-modern/src/components/Alerts/AlertResourceTableRow.tsx
@@ -60,6 +60,7 @@ interface AlertResourceTableRowProps {
onSaveEdit: (resourceId: string) => void;
onCancelEdit: () => void;
onRemoveOverride: (resourceId: string) => void;
+ showAlertsColumn?: boolean;
onToggleDisabled?: (resourceId: string) => void;
onToggleNodeConnectivity?: (nodeId: string) => void;
showOfflineAlertsColumn?: boolean;
@@ -267,34 +268,38 @@ export function AlertResourceTableRow(props: AlertResourceTableRowProps) {
</TableCell>
</Show>
- <TableCell class={`${getPlatformTableCellClassForKind('badge')} align-middle`}>
- <Show when={props.onToggleDisabled}>
- {(() => {
- const globallyDisabled = props.globalDisableFlag?.() ?? false;
- const isChecked = !globallyDisabled && !props.resource.disabled;
- return (
- <div class="flex items-center justify-center">
- <TogglePrimitive
- size="sm"
- checked={isChecked}
- disabled={globallyDisabled}
- onToggle={() => !globallyDisabled && props.onToggleDisabled?.(props.resource.id)}
- class="-my-0.5"
- title={
- globallyDisabled
- ? 'Alerts disabled globally'
- : props.resource.disabled
- ? 'Click to enable alerts'
- : 'Click to disable alerts'
- }
- // The switch role carries on/off; the name says whose alerts.
- ariaLabel={`Alerts for ${resourceLabel()}`}
- />
- </div>
- );
- })()}
- </Show>
- </TableCell>
+ <Show when={props.showAlertsColumn !== false}>
+ <TableCell class={`${getPlatformTableCellClassForKind('badge')} align-middle`}>
+ <Show when={props.onToggleDisabled}>
+ {(() => {
+ const globallyDisabled = props.globalDisableFlag?.() ?? false;
+ const isChecked = !globallyDisabled && !props.resource.disabled;
+ return (
+ <div class="flex items-center justify-center">
+ <TogglePrimitive
+ size="sm"
+ checked={isChecked}
+ disabled={globallyDisabled}
+ onToggle={() =>
+ !globallyDisabled && props.onToggleDisabled?.(props.resource.id)
+ }
+ class="-my-0.5"
+ title={
+ globallyDisabled
+ ? 'Alerts disabled globally'
+ : props.resource.disabled
+ ? 'Click to enable alerts'
+ : 'Click to disable alerts'
+ }
+ // The switch role carries on/off; the name says whose alerts.
+ ariaLabel={`Alerts for ${resourceLabel()}`}
+ />
+ </div>
+ );
+ })()}
+ </Show>
+ </TableCell>
+ </Show>
<TableCell class={getPlatformTableCellClassForKind('name')}>
<div class="flex items-center gap-2 min-w-0">
diff --git a/frontend-modern/src/components/Alerts/ResourceTable.test.tsx b/frontend-modern/src/components/Alerts/ResourceTable.test.tsx
index f2cb4c6ea4..57ccbc4f5b 100644
--- a/frontend-modern/src/components/Alerts/ResourceTable.test.tsx
+++ b/frontend-modern/src/components/Alerts/ResourceTable.test.tsx
@@ -228,6 +228,89 @@ describe('ResourceTable', () => {
vi.clearAllMocks();
});
+ it.each([false, true])(
+ 'omits unavailable all-alert controls but retains connectivity (mobile=%s)',
+ (mobile) => {
+ mockIsMobile.mockReturnValue(mobile);
+ const onToggleDisabled = vi.fn();
+ const onToggleNodeConnectivity = vi.fn();
+ render(() => (
+ <ResourceTable
+ {...makeProps({
+ resources: [
+ makeResource({
+ id: 'runtime-a',
+ name: 'Runtime A',
+ type: 'dockerHost',
+ editable: false,
+ }),
+ ],
+ columns: [],
+ showAlertsColumn: false,
+ showOfflineAlertsColumn: true,
+ onToggleDisabled,
+ onToggleNodeConnectivity,
+ })}
+ />
+ ));
+ expect(
+ screen.queryByRole('switch', { name: 'Alerts for Runtime A' }),
+ ).not.toBeInTheDocument();
+ expect(
+ screen.queryByRole('columnheader', { name: 'Alerts', exact: true }),
+ ).not.toBeInTheDocument();
+ fireEvent.click(screen.getByRole('button', { name: 'Offline alerts for Runtime A: On' }));
+ expect(onToggleNodeConnectivity).toHaveBeenCalledWith('runtime-a');
+ expect(onToggleDisabled).not.toHaveBeenCalled();
+ if (!mobile) {
+ expect(screen.getAllByRole('columnheader')).toHaveLength(3);
+ expect(screen.getAllByRole('cell')).toHaveLength(3);
+ }
+ },
+ );
+
+ it('keeps grouped, default, delay and empty rows aligned without an Alerts column', () => {
+ const { unmount } = render(() => (
+ <ResourceTable
+ {...makeProps({
+ resources: undefined,
+ groupedResources: { runtimes: [makeResource()] },
+ columns: ['CPU %'],
+ showAlertsColumn: false,
+ showOfflineAlertsColumn: true,
+ globalDefaults: { cpu: 80 },
+ setGlobalDefaults: vi.fn(),
+ setHasUnsavedChanges: vi.fn(),
+ onToggleGlobalDisable: vi.fn(),
+ showDelayColumn: true,
+ onMetricDelayChange: vi.fn(),
+ })}
+ />
+ ));
+ expect(screen.queryByRole('switch', { name: 'Global alerts toggle' })).not.toBeInTheDocument();
+ expect(screen.getAllByRole('columnheader')).toHaveLength(4);
+ fireEvent.click(screen.getByLabelText('Show alert delay settings'));
+ expect(screen.getByText('Alert Delay (s)')).toBeInTheDocument();
+ const group = screen.getByText('runtimes').closest('td');
+ expect(group).toHaveAttribute('colspan', '4');
+ for (const row of screen.getAllByRole('row').slice(1)) {
+ if (row.contains(group)) continue;
+ expect(row.querySelectorAll('td')).toHaveLength(4);
+ }
+ unmount();
+ render(() => (
+ <ResourceTable
+ {...makeProps({
+ resources: [],
+ columns: [],
+ showAlertsColumn: false,
+ showOfflineAlertsColumn: true,
+ })}
+ />
+ ));
+ for (const cell of screen.getAllByRole('cell')) expect(cell).toHaveAttribute('colspan', '3');
+ });
+
describe('rendering basics', () => {
it.each([false, true])(
'keeps filesystem reading explanations visible and reactive (mobile=%s)',
diff --git a/frontend-modern/src/components/Alerts/ResourceTable.tsx b/frontend-modern/src/components/Alerts/ResourceTable.tsx
index 84e2499c5a..8c28c22336 100644
--- a/frontend-modern/src/components/Alerts/ResourceTable.tsx
+++ b/frontend-modern/src/components/Alerts/ResourceTable.tsx
@@ -36,6 +36,8 @@ export interface ResourceTableProps {
onRemoveOverride: (resourceId: string) => void;
onToggleDisabled?: (resourceId: string) => void;
onToggleNodeConnectivity?: (nodeId: string) => void;
+ /** Omit the all-alerts control for connectivity-only resource tables. */
+ showAlertsColumn?: boolean;
showOfflineAlertsColumn?: boolean; // Show separate column for offline/connectivity alerts
globalOfflineSeverity?: 'warning' | 'critical';
onSetGlobalOfflineState?: (state: OfflineState) => void;
@@ -120,7 +122,8 @@ export function ResourceTable(props: ResourceTableProps) {
const totalColumnCount = createMemo(
() =>
props.columns.length +
- 3 +
+ 2 +
+ (props.showAlertsColumn === false ? 0 : 1) +
(props.showOfflineAlertsColumn ? 1 : 0) +
(props.onBulkEdit ? 1 : 0),
);
diff --git a/frontend-modern/src/components/Alerts/ThresholdsTableDockerHostsSection.tsx b/frontend-modern/src/components/Alerts/ThresholdsTableDockerHostsSection.tsx
index be7ee3021b..a8c0d76a45 100644
--- a/frontend-modern/src/components/Alerts/ThresholdsTableDockerHostsSection.tsx
+++ b/frontend-modern/src/components/Alerts/ThresholdsTableDockerHostsSection.tsx
@@ -22,6 +22,12 @@ export function ThresholdsTableDockerHostsSection(props: ThresholdsTableSectionP
emptyMessage={state.CONTAINER_RUNTIMES_FILTER_EMPTY_STATE}
>
<div ref={state.registerSection('dockerHosts')} class="scroll-mt-24">
+ <p class="mb-3 text-sm text-muted">
+ Offline Alerts only controls runtime-disconnection alerts, not container or machine
+ alerts. To mute existing containers, turn off their Alerts switches in Containers and
+ save. Newly added containers need their own setting; there is no single-runtime mute for
+ all its containers.
+ </p>
<ResourceTable
title=""
onConfigureResourceIntent={tableProps.onConfigureResourceIntent}
@@ -33,7 +39,7 @@ export function ThresholdsTableDockerHostsSection(props: ThresholdsTableSectionP
onSaveEdit={state.saveEdit}
onCancelEdit={state.cancelEdit}
onRemoveOverride={state.removeOverride}
- onToggleDisabled={state.toggleDisabled}
+ showAlertsColumn={false}
onToggleNodeConnectivity={state.toggleNodeConnectivity}
showOfflineAlertsColumn={true}
editingId={state.editingId}
@@ -41,25 +47,9 @@ export function ThresholdsTableDockerHostsSection(props: ThresholdsTableSectionP
setEditingThresholds={state.setEditingThresholds}
editingNote={state.editingNote}
setEditingNote={state.setEditingNote}
- onBulkEdit={(ids) =>
- state.handleBulkEdit(ids, [
- 'CPU %',
- 'Memory %',
- 'Disk %',
- 'Disk R MB/s',
- 'Disk W MB/s',
- 'Net In MB/s',
- 'Net Out MB/s',
- 'Restart Count',
- 'Restart Window (s)',
- ])
- }
formatMetricValue={formatMetricValue}
hasActiveAlert={state.hasActiveAlert}
globalDisableFlag={tableProps.disableAllDockerHosts}
- onToggleGlobalDisable={() =>
- tableProps.setDisableAllDockerHosts(!tableProps.disableAllDockerHosts())
- }
globalDisableOfflineFlag={tableProps.disableAllDockerHostsOffline}
onToggleGlobalDisableOffline={() =>
tableProps.setDisableAllDockerHostsOffline(!tableProps.disableAllDockerHostsOffline())
diff --git a/frontend-modern/src/components/Alerts/__tests__/ThresholdsTable.test.tsx b/frontend-modern/src/components/Alerts/__tests__/ThresholdsTable.test.tsx
index 740c0c636f..6e0769135e 100644
--- a/frontend-modern/src/components/Alerts/__tests__/ThresholdsTable.test.tsx
+++ b/frontend-modern/src/components/Alerts/__tests__/ThresholdsTable.test.tsx
@@ -1105,6 +1105,86 @@ describe('ThresholdsTable V6 ID compatibility', () => {
).not.toBeInTheDocument();
});
+ it('offers only runtime connectivity, with honest scope and independent container/machine drafts', async () => {
+ setPathname('/alerts/thresholds/containers');
+ const runtime = (id: string) => ({
+ id,
+ type: 'docker-host',
+ name: id,
+ displayName: id,
+ platformId: id,
+ platformType: 'docker',
+ sourceType: 'agent',
+ status: 'online',
+ lastSeen: 123,
+ });
+ const container = (parentId: string) => ({
+ id: `${parentId}-web`,
+ parentId,
+ type: 'app-container',
+ name: 'web',
+ displayName: 'Web',
+ platformId: parentId,
+ platformType: 'docker',
+ sourceType: 'agent',
+ status: 'running',
+ lastSeen: 123,
+ docker: { containerId: `${parentId}-container` },
+ });
+ const machineOverride = {
+ id: 'machine-a',
+ name: 'Machine A',
+ type: 'agent',
+ disabled: false,
+ thresholds: { cpu: 77 },
+ };
+ const [overrides, setOverrides] = createSignal<any[]>([machineOverride]);
+ const [rawOverridesConfig, setRawOverridesConfig] = createSignal<any>({
+ 'machine-a': { cpu: 77 },
+ });
+ const setHasUnsavedChanges = vi.fn();
+ render(() => (
+ <ThresholdsTable
+ {...(baseProps() as any)}
+ containerRuntimes={[runtime('runtime-a'), runtime('runtime-b')]}
+ allResources={[container('runtime-a'), container('runtime-b')]}
+ overrides={overrides}
+ setOverrides={setOverrides}
+ rawOverridesConfig={rawOverridesConfig}
+ setRawOverridesConfig={setRawOverridesConfig}
+ setHasUnsavedChanges={setHasUnsavedChanges}
+ />
+ ));
+ expect(screen.queryByTestId('toggle-disabled-runtime-a')).not.toBeInTheDocument();
+ expect(screen.queryByTestId('toggle-disabled-runtime-b')).not.toBeInTheDocument();
+ expect(
+ screen.getByText(/Offline Alerts only controls runtime-disconnection alerts/),
+ ).toHaveTextContent('not container or machine alerts');
+ expect(screen.getByText(/Newly added containers need their own setting/)).toHaveTextContent(
+ 'no single-runtime mute',
+ );
+ expect(setHasUnsavedChanges).not.toHaveBeenCalled();
+ await fireEvent.click(screen.getByTestId('toggle-connectivity-runtime-a'));
+ expect(rawOverridesConfig()).toEqual({
+ 'machine-a': { cpu: 77 },
+ 'runtime-a': { disableConnectivity: true },
+ });
+ expect(overrides().find((entry) => entry.id === 'runtime-a')).toMatchObject({
+ type: 'dockerHost',
+ disableConnectivity: true,
+ });
+ expect(overrides().find((entry) => entry.id === 'runtime-a')?.disabled).not.toBe(true);
+ await fireEvent.click(screen.getByTestId('toggle-disabled-docker:runtime-a/web'));
+ expect(rawOverridesConfig()).toEqual({
+ 'machine-a': { cpu: 77 },
+ 'runtime-a': { disableConnectivity: true },
+ 'docker:runtime-a/web': { disabled: true },
+ });
+ expect(overrides().find((entry) => entry.id === 'machine-a')).toEqual(machineOverride);
+ expect(overrides().some((entry) => entry.id.includes('runtime-b'))).toBe(false);
+ expect(screen.getByTestId('toggle-disabled-docker:runtime-b/web')).toBeInTheDocument();
+ });
+
it('removes docker host offline alerts using legacy compatibility IDs', async () => {
setPathname('/alerts/thresholds/containers');
const removeAlerts = vi.fn();