Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep save-recovery checks typed and fixture identities distinct

pulse-triage[bot]731dff1273a4
diff --git a/frontend-modern/browser-tests/webhook-save-acknowledgement.cjs b/frontend-modern/browser-tests/webhook-save-acknowledgement.cjs
index b79e308579..58b1d817e5 100644
--- a/frontend-modern/browser-tests/webhook-save-acknowledgement.cjs
+++ b/frontend-modern/browser-tests/webhook-save-acknowledgement.cjs
@@ -131,7 +131,7 @@ const hash = (file) => crypto.createHash('sha256').update(fs.readFileSync(file))
});
const accepted = {
...write.payload,
- id: req.method() === 'POST' ? 'new-hook' : 'saved-hook',
+ id: req.method() === 'POST' ? `new-hook-${writes.length}` : 'saved-hook',
headers: { Authorization: '********' },
};
inventory =
@@ -318,6 +318,7 @@ const hash = (file) => crypto.createHash('sha256').update(fs.readFileSync(file))
);
await other.close();
assert.equal(writes.length, 5);
+ assert.equal(new Set(inventory.map((hook) => hook.id)).size, inventory.length);
await noOverflow();
});
await page.getByRole('alert').scrollIntoViewIfNeeded();
diff --git a/frontend-modern/src/components/Alerts/WebhookConfig.persistence.test.tsx b/frontend-modern/src/components/Alerts/WebhookConfig.persistence.test.tsx
index 94ffd60035..f1a64fcccc 100644
--- a/frontend-modern/src/components/Alerts/WebhookConfig.persistence.test.tsx
+++ b/frontend-modern/src/components/Alerts/WebhookConfig.persistence.test.tsx
@@ -82,7 +82,7 @@ describe('webhook persistence acknowledgement', () => {
vi.mocked(NotificationsAPI.createWebhook).mockReturnValue(pending.promise);
const owner = mount([savedWebhook]);
openNewDraft();
- const save = screen.getByRole('button', { name: 'Add Webhook', exact: true });
+ const save = screen.getByRole('button', { name: 'Add Webhook' });
fireEvent.click(save);
fireEvent.click(save);
@@ -91,7 +91,7 @@ describe('webhook persistence acknowledgement', () => {
expect(screen.getByLabelText('Name')).toBeDisabled();
expect(screen.getByRole('button', { name: 'Saving…' })).toBeDisabled();
for (const name of ['Cancel', 'Edit', 'Delete', 'Disable All', 'Enabled']) {
- expect(screen.getByRole('button', { name, exact: true })).toBeDisabled();
+ expect(screen.getByRole('button', { name })).toBeDisabled();
}
expect(owner.webhooks()).toEqual([savedWebhook]);
@@ -108,7 +108,7 @@ describe('webhook persistence acknowledgement', () => {
fireEvent.input(screen.getByLabelText('Custom header 1 value'), {
target: { value: 'application/custom+json' },
});
- fireEvent.click(screen.getByRole('button', { name: 'Add Webhook', exact: true }));
+ fireEvent.click(screen.getByRole('button', { name: 'Add Webhook' }));
await waitFor(() => expect(screen.getByRole('alert')).toHaveTextContent('Could not confirm'));
expect(screen.getByLabelText('Name')).toHaveValue('New destination');
@@ -124,7 +124,7 @@ describe('webhook persistence acknowledgement', () => {
id: 'new-hook',
name: 'Accepted destination',
});
- fireEvent.click(screen.getByRole('button', { name: 'Add Webhook', exact: true }));
+ fireEvent.click(screen.getByRole('button', { name: 'Add Webhook' }));
await waitFor(() => expect(screen.queryByRole('alert')).not.toBeInTheDocument());
expect(screen.queryByLabelText('Name')).not.toBeInTheDocument();
expect(NotificationsAPI.createWebhook).toHaveBeenCalledTimes(2);
@@ -138,7 +138,7 @@ describe('webhook persistence acknowledgement', () => {
const pending = deferred<Webhook>();
vi.mocked(NotificationsAPI.updateWebhook).mockReturnValueOnce(pending.promise);
const owner = mount([savedWebhook]);
- fireEvent.click(screen.getByRole('button', { name: 'Edit', exact: true }));
+ fireEvent.click(screen.getByRole('button', { name: 'Edit' }));
fireEvent.input(screen.getByLabelText('Name'), { target: { value: 'Edited destination' } });
const draft = screen.getByLabelText('Name');
fireEvent.click(screen.getByRole('button', { name: 'Update Webhook' }));
@@ -171,7 +171,7 @@ describe('webhook persistence acknowledgement', () => {
vi.mocked(NotificationsAPI.createWebhook).mockRejectedValue(new Error('Save unavailable'));
mount();
openNewDraft();
- fireEvent.click(screen.getByRole('button', { name: 'Add Webhook', exact: true }));
+ fireEvent.click(screen.getByRole('button', { name: 'Add Webhook' }));
await waitFor(() => expect(screen.getByRole('alert')).toBeInTheDocument());
fireEvent.click(screen.getByRole('button', { name: 'Cancel' }));
fireEvent.click(screen.getByRole('button', { name: '+ Add Webhook' }));
@@ -194,7 +194,7 @@ describe('webhook persistence acknowledgement', () => {
/>
));
openNewDraft();
- fireEvent.click(screen.getByRole('button', { name: 'Add Webhook', exact: true }));
+ fireEvent.click(screen.getByRole('button', { name: 'Add Webhook' }));
await waitFor(() =>
expect(screen.getByRole('alert')).toHaveTextContent('Check the configured destinations'),
);