Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.
Go aialertsdashboarddockerdocker-monitoringgohomelabinfrastructure-monitoringkubernetesmonitoringmspproxmoxproxmox-backup-serverproxmox-mail-gatewayproxmox-veself-hostedtruenastypescriptvspherewebhooks
Remove WorkloadsSurface's unreachable built-in filter toolbar
rcourtman73ce61359ce9
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.mdindex 9d922f47a1..9277d8ee7f 100644--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md@@ -942,10 +942,11 @@ or assuming identical value scales.Workload tables expose their inline history lens through one shared filtercontract. Its first-use hint is visible only while bar or history metrics areavailable, disappears after a populated guest preview succeeds, and is passed-through `getWorkloadsMetricFilterProps`. The generic `WorkloadsSurface` and-provider-owned compositions such as `ProxmoxPageSurface` and-`VmwarePageSurface` must consume that binding atomically rather than selecting-display, hover, range, or hint accessors independently. Hover and range+through `getWorkloadsMetricFilterProps`. The provider-owned compositions+`ProxmoxPageSurface` and `VmwarePageSurface` render the only `WorkloadsFilter`+above their embedded `WorkloadsSurface`, which renders no toolbar of its own,+and must consume that binding atomically rather than selecting display, hover,+range, or hint accessors independently. Hover and rangeinteractions remain session deduplicated so the presentation layer cannotcreate per-row or per-frame telemetry traffic. Provider-native inventoriesthat do not render `WorkloadsFilter` are outside this guest-row contract anddiff --git a/docs/release-control/v6/internal/subsystems/performance-and-scalability.md b/docs/release-control/v6/internal/subsystems/performance-and-scalability.mdindex b772ef7eaa..09ca4765d2 100644--- a/docs/release-control/v6/internal/subsystems/performance-and-scalability.md+++ b/docs/release-control/v6/internal/subsystems/performance-and-scalability.md@@ -1386,12 +1386,13 @@ change may globally weaken the Task 03 lifecycle-state idempotency invariant.Workload filter option semantics stay workload-owned, but FilterBar chippresentation is frontend-primitives-owned: status and runtime leading dotsmust use `filterChipStatusDot` rather than workload-local span factories.- WorkloadsFilter remains the shared interaction shell only; platform-owned- embedded Workloads surfaces must pass page-owned aria labels, search- placeholders, empty-search copy, status labels, and forced view-mode- context into route option derivation so Docker, Kubernetes, TrueNAS,- Proxmox, and VMware pages expose filters for the objects visible on that- page rather than generic mixed-workload labels.+ WorkloadsFilter remains the shared interaction shell only. The Proxmox+ and vSphere overviews, the pages that embed a Workloads surface, pass+ their own aria label, search placeholder, empty-search copy, and status+ option labels straight to their page-owned toolbar, and pass forced+ platform (and, for vSphere, forced view-mode) context into the shared+ workload state, so each page exposes filters for the objects visible on+ that page rather than generic mixed-workload labels.19. Extend threshold-slider value-position math, title/label derivation, and drag scroll-lock runtime through `frontend-modern/src/components/Workloads/thresholdSliderModel.ts` and `frontend-modern/src/components/Workloads/useThresholdSliderState.ts` rather than rebuilding slider-local state and pointer lifecycle inside `frontend-modern/src/components/Workloads/ThresholdSlider.tsx`20. Extend stacked disk-bar capacity math, segment/tooltip derivation, summary-strategy selection, and resize-observer runtime through `frontend-modern/src/components/Workloads/stackedDiskBarModel.ts` and `frontend-modern/src/components/Workloads/useStackedDiskBarState.ts` rather than rebuilding disk-bar-local state, mode branching, and tooltip shaping inside `frontend-modern/src/components/Workloads/StackedDiskBar.tsx`. Compact multi-disk rows default to same-height per-disk lanes so each filesystem has its own visible usage bar without implying the whole host disk state is one max or aggregate percentage; explicit `mode="stacked"` remains the capacity-contribution stack for callers that intentionally need that presentation, and explicit aggregate callers may choose total-capacity or worst-disk summaries when the owning table's operator job needs one compact risk signal, while tooltips continue to carry the full per-disk breakdown.21. Extend stacked memory-bar capacity math, balloon/swap derivation, and resize-observer runtime through `frontend-modern/src/components/Workloads/stackedMemoryBarModel.ts` and `frontend-modern/src/components/Workloads/useStackedMemoryBarState.ts` rather than rebuilding memory-bar-local state, tooltip shaping, and label-fit logic inside `frontend-modern/src/components/Workloads/StackedMemoryBar.tsx`@@ -1705,19 +1706,21 @@ shell clickable behind another overlay.and `frontend-modern/src/features/vmware/VmwarePageSurface.tsx`). Each pagebuilds the workloads state itself with `useWorkloadsState`, renders theone shared `WorkloadsFilter` toolbar (search, status filter, a type- filter that vSphere suppresses, and the View options for grouping, metric display, and columns on the- shared `FilterBar`) from that state, and hands the same state to `WorkloadsSurface` through its- `state` prop with `suppressFilterToolbar`, so the surface skips its own- filter row and the page never stacks two toolbars wired to one state.+ filter that vSphere suppresses, and the View options for grouping, metric+ display, and columns on the shared `FilterBar`) from that state, directly+ above the surface, and hands the same state to `WorkloadsSurface` through+ its `state` prop. The surface renders no filter row of its own, so the+ page never stacks two toolbars wired to one state.Proxmox also passes that state's search, plus its page-owned metric modeand history range, to the nodes table above the guests, so one toolbardrives both tables. `WorkloadsSurface` has no `tableOnly` mode, no- `showFilterToolbar` prop, and no dashboard cards or summary strip to- hide: it renders its filter row (unless suppressed or in kiosk mode), the- workloads table, or an empty-state table card. The platform scope flows- through `forcedPlatform` as a typed page input to `useWorkloadsState`,- the toolbar, and the surface. `suppressPlatformFilter: true` makes the- state expose no Platform filter config and both pages pass+ toolbar prop, and no dashboard cards or summary strip to hide: it renders+ the workloads table or an empty-state table card, plus a Back to top+ control while scrolled. The platform scope flows through `forcedPlatform`+ as a typed page input to `useWorkloadsState`, the toolbar, and the+ surface. `suppressPlatformFilter: true` makes the state expose no Platform+ filter config, so a platform the page already fixed never counts as an+ operator filter in the surface's filtered-empty state, and both pages pass`platformFilter={undefined}` to the toolbar, so the user never sees thelocked platform as a removable chip.@@ -1992,11 +1995,13 @@ each. StandaloneWorkloadsSurface callers (no override props) keep the originalpersistent-signal-backed behavior.Every toolbar that controls a `WorkloadsSurface` consumes-`getWorkloadsMetricFilterProps` as one atomic binding. This keeps the display-mode, row-hover mode, history range, and first-use hint on the same state owner-for the generic surface and the Proxmox and vSphere platform compositions;-provider pages must not recreate a partial metric prop list that can enable-prefetching without exposing the matching control or discovery state.+`getWorkloadsMetricFilterProps` as one atomic binding. Those toolbars are the+page-owned `WorkloadsFilter` instances on the Proxmox and vSphere overviews,+since the surface renders none, and the binding keeps the display mode,+row-hover mode, history range, and first-use hint on the page's one workload+state owner; provider pages must not recreate a partial metric prop list that+can enable prefetching without exposing the matching control or discovery+state.That first-use hint clears while the pointer is over a guest row, because thefirst populated preview marks it seen. Clearing it must not unmount it orchange the toolbar height: wherever the hint wraps the action row onto its owndiff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.mdindex ccb8f2ea1d..60895d9c95 100644--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md@@ -966,7 +966,9 @@ viewport; narrow layouts must not move it after the full guest list's virtualscroll extent, where the node estate would become effectively undiscoverable.The workload filter belongs immediately before the workload table it controls,after the node preview, and its committed search term must also flow into the-node table. The node table must use the shared Proxmox search model so a+node table. `ProxmoxPageSurface` renders that one `WorkloadsFilter` itself and+passes the embedded `WorkloadsSurface` the same workload state; the surface+renders no filter row of its own. The node table must use the shared Proxmox search model so amatching guest retains its owning node while unrelated nodes disappear; anode search must likewise retain the directly matching node. The table stillreceives the real already-loaded PVE node collection as its source, so thediff --git a/docs/release-control/v6/internal/subsystems/unified-resources.md b/docs/release-control/v6/internal/subsystems/unified-resources.mdindex c284a54e4a..ae92b02474 100644--- a/docs/release-control/v6/internal/subsystems/unified-resources.md+++ b/docs/release-control/v6/internal/subsystems/unified-resources.md@@ -3070,10 +3070,11 @@ grouped rows: the shared Workloads group row carries host identity only, withno drawer, hover preview, or group pin, and per-host stats and details stay inthe page's own hosts table. The Workloads route model no longer parses a`summaryGroup` param, because no group focus remains to hydrate.-Its page-owned workload toolbar consumes the complete shared+Its page-owned workload toolbar, the only one on the page because the embedded+`WorkloadsSurface` renders none, consumes the complete shared`getWorkloadsMetricFilterProps` binding, so vSphere VMs expose the same Bars,-Trends, Details, History, range, and first-use discovery contract as every-other `WorkloadsSurface` consumer. The page must not select only display and+Trends, Details, History, range, and first-use discovery contract as the+Proxmox overview, the only other `WorkloadsSurface` consumer. The page must not select only display andrange props while silently dropping row-hover state from that shared resourceprojection.Docker and Kubernetes page owners use the same source-aware projection fordiff --git a/frontend-modern/browser-verification/5333c576e9616b17.json b/frontend-modern/browser-verification/5333c576e9616b17.jsonnew file mode 100644index 0000000000..bb542776ca--- /dev/null+++ b/frontend-modern/browser-verification/5333c576e9616b17.json@@ -0,0 +1,57 @@+{+ "version": 1,+ "base_sha": "d2ac0c511257b8a494dc53800ea62b519d2040ae",+ "verified_at": "2026-10-08T09:13:54Z",+ "result": "passed",+ "changed_paths": [+ "frontend-modern/src/components/Workloads/WorkloadsFilter.tsx",+ "frontend-modern/src/components/Workloads/WorkloadsSurface.tsx",+ "frontend-modern/src/components/Workloads/useWorkloadsControlsState.ts",+ "frontend-modern/src/components/Workloads/useWorkloadsState.ts",+ "frontend-modern/src/components/Workloads/workloadsFilterModel.ts",+ "frontend-modern/src/features/proxmox/ProxmoxPageSurface.tsx",+ "frontend-modern/src/features/vmware/VmwarePageSurface.tsx"+ ],+ "content_sha256": {+ "frontend-modern/src/components/Workloads/WorkloadsFilter.tsx": "eac614158bde8f094c3149615da44d24f18cb692edeee79073e03e91719bb352",+ "frontend-modern/src/components/Workloads/WorkloadsSurface.tsx": "2d1ace3380674b5defb87046d8de09f1f24e1b7a84b0b54f4406f3dceb8a4a95",+ "frontend-modern/src/components/Workloads/useWorkloadsControlsState.ts": "eec7c3bf66f2efe3b0a4fd8c1ae68b0330ce284f07de2825e2a2787240f8bde4",+ "frontend-modern/src/components/Workloads/useWorkloadsState.ts": "16a61ff9cd61bac8baffde2c07705a0b718acff00680956f85bf898a112177fe",+ "frontend-modern/src/components/Workloads/workloadsFilterModel.ts": "a5dae912b6b23b075fce2ca2c7fe2e0e8f05eca5c51087b0b21a3e7a86951635",+ "frontend-modern/src/features/proxmox/ProxmoxPageSurface.tsx": "a017251a1e32298f2e62bf76f94471420333e2f74979addd57f082cc71c82e21",+ "frontend-modern/src/features/vmware/VmwarePageSurface.tsx": "18d2f9ffdb97c311070d3282a75ee5a4f7496225633eceae7eaaf9981eb7decd"+ },+ "routes": [+ "/proxmox/overview",+ "/vmware/overview",+ "/proxmox/overview?kiosk=1",+ "/vmware/overview?kiosk=1"+ ],+ "viewports": [+ {+ "width": 1440,+ "height": 900+ },+ {+ "width": 390,+ "height": 844+ }+ ],+ "states": [+ "Before/after pair on pulse-dev: production builds of the parent d2ac0c5112 (origin/main) and of this tree, each embedded with go build and run as a DEMO_MODE mock stack (ports 7771/7772, fresh data dirs, telemetry off), driven by the same headless Chromium script.",+ "Small mock estate for both builds (PULSE_MOCK_NODES=6, 4 VMs and 4 LXCs per node, 2 Docker hosts, 6 containers, 2 generic hosts): on the default 50-node estate the parent itself stalls before serving (startup watchdog fires during the initial alert evaluation; the backend is identical in both builds and is reported separately), while the small estate starts in about 15 s.",+ "Both builds, both overviews, both widths: exactly one workload FilterBar on the page (aria-label \"Proxmox workload filters\" / \"vSphere workload filters\"), zero filter groups and zero inputs inside [data-testid=workloads-page], zero toolbars with the default \"Workloads filters\" label or default search placeholder, and the page toolbar precedes the surface in document order.",+ "Search for a guest name narrows the embedded table to that one row (Proxmox auth-service-01: 55 to 1 at desktop, 36 to 1 at phone; vSphere etl-batch-01: 18 to 1); a no-match search shows the surface empty state \"No guests found / No guests match your search\" and Clear filters restores 55 / 18 rows.",+ "Opening a guest drawer shows the page toolbar \"Clear pinned selection\" button; clicking it closes the drawer and the button goes away, at both widths on both pages.",+ "Kiosk mode (?kiosk=1, sessionStorage pulse_kiosk_mode=true) shows the same single page toolbar in both builds; only the deleted branch ever read kiosk mode.",+ "Results JSON: all 104 measurements identical between the builds, including the toolbar/surface chrome signature (tag, test id, role, aria-label multiset outside tbody) on all four page/width pairs. The only failing request in either build is the demo-mode 403 on POST /api/usage/workload-history; no page errors.",+ "Dist proof: 189 files each side; 94 byte-identical, 92 differ only in chunk-hash names and SRI strings, 3 differ in code. After normalising hashes and 1-3 character identifiers, Proxmox-*.js and Vmware-*.js lose only suppressFilterToolbar:!0 on the WorkloadsSurface mount, and WorkloadsSurface-*.js loses only the toolbar JSX and its show-condition, the useKioskMode() call and kioskMode state entry, and the defaultSortKey fallbacks. CSS unchanged.",+ "check-bundle-size.mjs passes on both builds: WorkloadsSurface 57.25 kB to 56.86 kB gzip (baseline 61.07, cap 70.23), Proxmox 78.85 to 78.83, Vmware 11.24 to 11.24, total JS 1367.68 to 1367.27 kB; no chunk renamed, .bundlesize.json unchanged."+ ],+ "interactions": [+ "Demo sign-in, then for /proxmox/overview and /vmware/overview: wait for guest rows, count toolbars and inputs inside and outside the surface, record the chrome signature, screenshot.",+ "Type the first guest name into the page search, read the row count, then type a no-match term, read the empty state, click Clear filters (or clear the box at phone width) and read the restored row count.",+ "Click the first guest row name cell to open its inline drawer, read the Clear pinned selection button, click it, confirm the drawer closed.",+ "Repeat in a 1440x900 desktop context and a 390x844 touch phone context, then load both overviews with ?kiosk=1 in a fresh context and count toolbars and rows; screenshots of every state inspected."+ ]+}diff --git a/frontend-modern/src/components/Workloads/WorkloadsFilter.tsx b/frontend-modern/src/components/Workloads/WorkloadsFilter.tsxindex fee0c80fb0..b683f64693 100644--- a/frontend-modern/src/components/Workloads/WorkloadsFilter.tsx+++ b/frontend-modern/src/components/Workloads/WorkloadsFilter.tsx@@ -177,7 +177,7 @@ export const WorkloadsFilter: Component<WorkloadsFilterProps> = (props) => {const handleClearAll = () => {props.setSearch('');- props.setSortKey(props.defaultSortKey ?? DEFAULT_WORKLOADS_SORT_KEY);+ props.setSortKey(DEFAULT_WORKLOADS_SORT_KEY);props.setSortDirection(DEFAULT_WORKLOADS_SORT_DIRECTION);if (!props.suppressTypeFilter) {props.setViewMode(DEFAULT_WORKLOADS_VIEW_MODE);diff --git a/frontend-modern/src/components/Workloads/WorkloadsSurface.tsx b/frontend-modern/src/components/Workloads/WorkloadsSurface.tsxindex 945bbde267..6a8c84dccc 100644--- a/frontend-modern/src/components/Workloads/WorkloadsSurface.tsx+++ b/frontend-modern/src/components/Workloads/WorkloadsSurface.tsx@@ -9,12 +9,7 @@ import { TableCard } from '@/components/shared/TableCard';import { TableCardHeader } from '@/components/shared/TableCardHeader';import { sessionCanReadInfrastructureSettings } from '@/stores/sessionSettingsCapabilities';import { getWorkloadsNoInventoryState } from '@/utils/workloadEmptyStatePresentation';-import { WorkloadsFilter } from './WorkloadsFilter';-import {- DEFAULT_WORKLOADS_VIEW_MODE,- getWorkloadsMetricFilterProps,- hasActiveWorkloadsFilters,-} from './workloadsFilterModel';+import { DEFAULT_WORKLOADS_VIEW_MODE, hasActiveWorkloadsFilters } from './workloadsFilterModel';import { WorkloadsTable } from './WorkloadsTable';import { WorkloadWebLinksAction } from './WorkloadWebLinksAction';import type { WorkloadInventorySourceIssue } from './workloadInventorySourceIssues';@@ -134,51 +129,6 @@ export function WorkloadsSurface(props: WorkloadsSurfaceComponentProps) {</Portal></Show><div class="space-y-3" data-testid="workloads-interaction-surface">- <Show- when={- !props.suppressFilterToolbar &&- !state.kioskMode() &&- state.surfaceConnected() &&- state.surfaceInitialDataReceived() &&- state.allGuests().length > 0- }- >- <div data-summary-clear-ignore>- <WorkloadsFilter- search={state.search}- setSearch={state.setSearch}- viewMode={state.viewMode}- setViewMode={state.setViewMode}- statusMode={state.statusMode}- setStatusMode={state.setStatusMode}- groupingMode={state.groupingMode}- setGroupingMode={state.setGroupingMode}- defaultSortKey={props.defaultSortKey}- setSortKey={state.setSortKey}- setSortDirection={state.setSortDirection}- onBeforeAutoFocus={state.handleBeforeAutoFocus}- ariaLabel={props.filterAriaLabel}- searchPlaceholder={props.filterSearchPlaceholder}- searchEmptyMessage={props.filterSearchEmptyMessage}- searchSuggestionWorkloads={state.allGuests}- statusOptions={props.filterStatusOptions}- columnVisibility={state.workloadsFilterColumnVisibility()}- containerRuntimeFilter={state.containerRuntimeFilterConfig()}- hostFilter={state.hostFilterConfig()}- namespaceFilter={state.namespaceFilterConfig()}- platformFilter={state.platformFilterConfig()}- suppressTypeFilter={props.forcedViewMode !== undefined}- {...getWorkloadsMetricFilterProps(state)}- memoryDisplayBasis={- props.memoryDisplayBasis ? state.workloadMemoryDisplayBasis : undefined- }- forcedPlatform={props.forcedPlatform}- pinnedSelectionActive={() => Boolean(state.selectedGuestId())}- onClearPinnedSelection={state.clearPinnedSummaryScope}- />- </div>- </Show>-<Showwhen={state.surfaceConnected() &&diff --git a/frontend-modern/src/components/Workloads/__tests__/WorkloadsFilter.test.tsx b/frontend-modern/src/components/Workloads/__tests__/WorkloadsFilter.test.tsxindex b8644fb976..ea0140dc6d 100644--- a/frontend-modern/src/components/Workloads/__tests__/WorkloadsFilter.test.tsx+++ b/frontend-modern/src/components/Workloads/__tests__/WorkloadsFilter.test.tsx@@ -708,7 +708,6 @@ describe('WorkloadsFilter', () => {render(() => (<WorkloadsFilter{...makeProps({- defaultSortKey: 'name',search: vi.fn(() => 'nginx'),setSearch,setSortKey,@@ -722,7 +721,7 @@ describe('WorkloadsFilter', () => {fireEvent.click(screen.getByRole('button', { name: 'Clear filters' }));expect(setSearch).toHaveBeenCalledWith('');- expect(setSortKey).toHaveBeenCalledWith('name');+ expect(setSortKey).toHaveBeenCalledWith(DEFAULT_WORKLOADS_SORT_KEY);expect(setViewMode).not.toHaveBeenCalled();});});diff --git a/frontend-modern/src/components/Workloads/__tests__/WorkloadsSurface.k8s.test.tsx b/frontend-modern/src/components/Workloads/__tests__/WorkloadsSurface.k8s.test.tsxindex 0d72951e29..7f23bb9262 100644--- a/frontend-modern/src/components/Workloads/__tests__/WorkloadsSurface.k8s.test.tsx+++ b/frontend-modern/src/components/Workloads/__tests__/WorkloadsSurface.k8s.test.tsx@@ -2,6 +2,8 @@ import { beforeEach, describe, expect, it, vi } from 'vitest';import { render, screen, waitFor } from '@solidjs/testing-library';import { createEffect } from 'solid-js';import { WorkloadsSurface } from '../WorkloadsSurface';+import { useWorkloadsState, type WorkloadsSurfaceProps } from '../useWorkloadsState';+import type { WorkloadsToolbarFilterConfig } from '../workloadsFilterModel';import type { State } from '@/types/api';const mockWebSocketState: State = {@@ -36,18 +38,10 @@ const mockWebSocketState: State = {let mockLocationSearch = '?type=pod';let mockWorkloads: Array<Record<string, unknown>> = [];const navigateSpy = vi.fn();-type HostFilterMock = {- id?: string;- label?: string;- value: string;- options: { value: string; label: string }[];- onChange: (value: string) => void;-};--let lastHostFilter: HostFilterMock | undefined;+let lastHostFilter: WorkloadsToolbarFilterConfig | undefined;let lastDrawerGuestName: string | null = null;-const requireLastHostFilter = (): HostFilterMock => {+const requireLastHostFilter = (): WorkloadsToolbarFilterConfig => {if (!lastHostFilter) {throw new Error('Expected host filter to be available');}@@ -142,19 +136,6 @@ vi.mock('@/components/shared/InfrastructureSelector', () => ({),}));-vi.mock('../WorkloadsFilter', () => ({- WorkloadsFilter: (props: { hostFilter?: HostFilterMock }) => {- createEffect(() => {- lastHostFilter = props.hostFilter;- });- return (- <div data-testid="workloads-filter">- {props.hostFilter ? 'host-filter-enabled' : 'host-filter-disabled'}- </div>- );- },-}));-vi.mock('../GuestDrawer', () => ({GuestDrawer: (props: { guest: { name: string } }) => {lastDrawerGuestName = props.guest.name;@@ -186,6 +167,17 @@ vi.mock('../GuestRow', () => {};});+// Platform pages own the workload toolbar: they build the state, pass it to+// the surface, and hand state.hostFilterConfig() to their WorkloadsFilter.+// This harness reads that same config.+function PageOwnedWorkloadsSurface(props: WorkloadsSurfaceProps) {+ const state = useWorkloadsState(props);+ createEffect(() => {+ lastHostFilter = state.hostFilterConfig();+ });+ return <WorkloadsSurface {...props} state={state} />;+}+describe('Workloads pod workloads integration', () => {beforeEach(() => {navigateSpy.mockReset();@@ -223,15 +215,15 @@ describe('Workloads pod workloads integration', () => {},];mockLocationSearch = '?type=pod';- const { getByText, getByTestId } = render(() => (- <WorkloadsSurface vms={[]} containers={[]} nodes={[]} useWorkloads />+ const { getByText } = render(() => (+ <PageOwnedWorkloadsSurface vms={[]} containers={[]} nodes={[]} useWorkloads />));await waitFor(() => {expect(getByText('api-6c4d8')).toBeInTheDocument();});- expect(getByTestId('workloads-filter')).toHaveTextContent('host-filter-enabled');+ expect(lastHostFilter).toBeDefined();});it('excludes app-container workloads when a platform page owns them as nested context', async () => {@@ -296,7 +288,6 @@ describe('Workloads pod workloads integration', () => {state={{setClearSurfaceRootRef: vi.fn(),- kioskMode: () => false,surfaceConnected: () => true,surfaceInitialDataReceived: () => true,allGuests: () => [{ id: 'vm-1' }],@@ -346,7 +337,6 @@ describe('Workloads pod workloads integration', () => {state={{setClearSurfaceRootRef: vi.fn(),- kioskMode: () => false,surfaceConnected: () => true,surfaceInitialDataReceived: () => true,allGuests: () => [],@@ -515,7 +505,7 @@ describe('Workloads pod workloads integration', () => {];const { getByText, queryByText } = render(() => (- <WorkloadsSurface vms={[]} containers={[]} nodes={[]} useWorkloads />+ <PageOwnedWorkloadsSurface vms={[]} containers={[]} nodes={[]} useWorkloads />));await waitFor(() => {diff --git a/frontend-modern/src/components/Workloads/__tests__/WorkloadsSurface.performance.contract.test.tsx b/frontend-modern/src/components/Workloads/__tests__/WorkloadsSurface.performance.contract.test.tsxindex 7e7dde7a22..4ddeffe4bb 100644--- a/frontend-modern/src/components/Workloads/__tests__/WorkloadsSurface.performance.contract.test.tsx+++ b/frontend-modern/src/components/Workloads/__tests__/WorkloadsSurface.performance.contract.test.tsx@@ -7,6 +7,8 @@ import { syncSessionSettingsCapabilities } from '@/stores/sessionSettingsCapabilimport { WorkloadsSurface } from '../WorkloadsSurface';import { WORKLOAD_TABLE_CONTAINER_TABLET_WIDTH, getGuestColumnStyle } from '../guestRowModel';import workloadsSource from '../WorkloadsSurface.tsx?raw';+import proxmoxPageSurfaceSource from '@/features/proxmox/ProxmoxPageSurface.tsx?raw';+import vmwarePageSurfaceSource from '@/features/vmware/VmwarePageSurface.tsx?raw';import workloadsFilterSource from '../WorkloadsFilter.tsx?raw';import workloadsWorkloadTableSource from '../WorkloadsTable.tsx?raw';import metricDisplayModeSegmentedControlSource from '../MetricDisplayModeSegmentedControl.tsx?raw';@@ -248,10 +250,6 @@ vi.mock('@/components/shared/InfrastructureSelector', () => ({),}));-vi.mock('../WorkloadsFilter', () => ({- WorkloadsFilter: () => <div data-testid="workloads-filter">filter</div>,-}));-vi.mock('../GuestDrawer', () => ({GuestDrawer: (props: { nestedWorkloadContext?: { label: string; count: number } }) => (<div data-testid="guest-drawer">@@ -503,8 +501,16 @@ describe('Workloads performance contract', () => {it('binds every workload toolbar to the complete canonical metric-control contract', () => {expect(workloadsFilterModelSource).toContain('getWorkloadsMetricFilterProps');expect(workloadsFilterModelSource).toContain('metricHistoryHintVisible');- expect(workloadsSource).toContain('{...getWorkloadsMetricFilterProps(state)}');- expect(workloadsSource).not.toContain('metricDisplayMode={state.workloadMetricDisplayMode}');+ // The owning platform pages render the only workload toolbars; the+ // embedded surface renders none.+ expect(workloadsSource).not.toContain('<WorkloadsFilter');+ expect(workloadsSource).not.toContain("from './WorkloadsFilter'");+ for (const pageSource of [proxmoxPageSurfaceSource, vmwarePageSurfaceSource]) {+ expect(pageSource).toContain('{...getWorkloadsMetricFilterProps(workloadsState)}');+ expect(pageSource).not.toContain(+ 'metricDisplayMode={workloadsState.workloadMetricDisplayMode}',+ );+ }});it('keeps the workloads route visible when websocket connectivity degrades but REST workload data is healthy', async () => {@@ -516,9 +522,6 @@ describe('Workloads performance contract', () => {render(() => <WorkloadsSurface vms={[]} containers={[]} nodes={[]} useWorkloads />);- await waitFor(() => {- expect(document.querySelector('[data-testid="workloads-filter"]')).toBeInTheDocument();- });await waitFor(() => {expect(document.querySelector('[data-testid="guest-row-route-owned-workload"]'),@@ -586,7 +589,6 @@ describe('Workloads performance contract', () => {state={{setClearSurfaceRootRef: vi.fn(),- kioskMode: () => false,surfaceConnected: () => true,surfaceInitialDataReceived: () => true,allGuests: () => [],@@ -676,7 +678,6 @@ describe('Workloads performance contract', () => {state={{setClearSurfaceRootRef: vi.fn(),- kioskMode: () => false,surfaceConnected: () => true,surfaceInitialDataReceived: () => true,allGuests: () => [],@@ -1323,8 +1324,11 @@ describe('Workloads performance contract', () => {expect(workloadsSource).toContain('setClearSurfaceRootRef');expect(workloadsSource).toContain('setTableRootRef={state.setTableRootRef}');expect(workloadsSource).toContain('data-testid="workloads-interaction-surface"');- expect(workloadsSource).toContain('data-summary-clear-ignore');- expect(workloadsSource).toContain('onClearPinnedSelection={state.clearPinnedSummaryScope}');+ for (const pageSource of [proxmoxPageSurfaceSource, vmwarePageSurfaceSource]) {+ expect(pageSource).toContain(+ 'onClearPinnedSelection={workloadsState.clearPinnedSummaryScope}',+ );+ }expect(workloadsWorkloadTableSource).toContain('data-summary-clear-surface');expect(workloadsWorkloadTableSource).toContain('data-testid="workloads-table-surface"');expect(workloadsWorkloadTableSource).toContain('TableCard');diff --git a/frontend-modern/src/components/Workloads/useWorkloadsControlsState.ts b/frontend-modern/src/components/Workloads/useWorkloadsControlsState.tsindex e79ca7b01e..f1974afb65 100644--- a/frontend-modern/src/components/Workloads/useWorkloadsControlsState.ts+++ b/frontend-modern/src/components/Workloads/useWorkloadsControlsState.ts@@ -64,7 +64,6 @@ import {interface WorkloadsControlsStateOptions {layoutWidth?: Accessor<number | null | undefined>;forcedGroupingMode?: WorkloadsGroupingMode;- defaultSortKey?: WorkloadsSortKey;statusModeStorageScope?: string;// When a platform page owns the metric display mode (e.g. Proxmox// overview shares it across a top hosts table and the embedded workloads@@ -262,8 +261,7 @@ export function useWorkloadsControlsState(options: WorkloadsControlsStateOptionssetInternalMetricHistoryRange(value);};- const defaultSortKey = options.defaultSortKey ?? DEFAULT_WORKLOADS_SORT_KEY;- const [sortKey, setSortKey] = createSignal<WorkloadsSortKey | null>(defaultSortKey);+ const [sortKey, setSortKey] = createSignal<WorkloadsSortKey | null>(DEFAULT_WORKLOADS_SORT_KEY);const [sortDirection, setSortDirection] = createSignal<'asc' | 'desc'>(DEFAULT_WORKLOADS_SORT_DIRECTION,);@@ -499,7 +497,7 @@ export function useWorkloadsControlsState(options: WorkloadsControlsStateOptionsconst resetWorkloadsControls = () => {setSearch('');setIsSearchLocked(false);- setSortKey(defaultSortKey);+ setSortKey(DEFAULT_WORKLOADS_SORT_KEY);setSortDirection(DEFAULT_WORKLOADS_SORT_DIRECTION);setStatusMode(DEFAULT_WORKLOADS_STATUS_MODE);blurFocusedTypeToSearch();diff --git a/frontend-modern/src/components/Workloads/useWorkloadsState.ts b/frontend-modern/src/components/Workloads/useWorkloadsState.tsindex 4565c12f1a..4c8351cc27 100644--- a/frontend-modern/src/components/Workloads/useWorkloadsState.ts+++ b/frontend-modern/src/components/Workloads/useWorkloadsState.ts@@ -15,7 +15,6 @@ import { usePersistentSignal } from '@/hooks/usePersistentSignal';import { createNonSuspendingQuery } from '@/hooks/createNonSuspendingQuery';import { useUnifiedResources } from '@/hooks/useUnifiedResources';import { useWorkloads } from '@/hooks/useWorkloads';-import { useKioskMode } from '@/hooks/useKioskMode';import {getWorkloadsDisconnectedState,getWorkloadsGuestsEmptyState,@@ -37,7 +36,6 @@ import {type WorkloadsMemoryDisplayBasis,type WorkloadsMetricDisplayMode,type WorkloadsMetricHoverMode,- type WorkloadsStatusOption,type WorkloadsSortKey,} from './workloadsFilterModel';import { type WorkloadTableMetricHistoryRange } from './workloadMetricHistoryModel';@@ -78,21 +76,13 @@ export interface WorkloadsSurfaceProps {excludedWorkloadTypes?: readonly WorkloadType[];showNestedExcludedWorkloads?: boolean;forcedGroupingMode?: WorkloadsGroupingMode;- defaultSortKey?: WorkloadsSortKey;- filterAriaLabel?: string;- filterSearchPlaceholder?: string;- filterSearchEmptyMessage?: string;- filterStatusOptions?: readonly WorkloadsStatusOption[];// When the surface is mounted inside a platform-first page, the page owns// platform scope through `forcedPlatform`. `suppressPlatformFilter`- // removes the redundant Platform chip from the filter row since the- // platform is already fixed by the owning page.+ // withholds the Platform filter config from the returned state, so a+ // platform the owning page already fixed never counts as an operator+ // filter. The owning page renders the one WorkloadsFilter; the surface+ // renders none.suppressPlatformFilter?: boolean;- // When a platform page renders its own shared WorkloadsFilter above the- // embedded surface (so one toolbar drives both the page's top table and- // this surface), set `suppressFilterToolbar` so the surface skips its- // internal filter row and avoids a duplicate.- suppressFilterToolbar?: boolean;// An owning platform page may provide the canonical unified-resource// snapshot it already fetched. This avoids a second workload/infrastructure// request and keeps both surfaces on the same refresh generation.@@ -150,8 +140,6 @@ export function useWorkloadsState(props: WorkloadsSurfaceProps) {const alertsActivation = useAlertsActivation();const alertsEnabled = alertsActivation.detectionEnabled;- const kioskMode = useKioskMode();-const { guestMetadata, handleCustomUrlUpdate } = useWorkloadGuestMetadataState();const workloadsEnabled = createMemo(() => props.useWorkloads === true);@@ -347,7 +335,6 @@ export function useWorkloadsState(props: WorkloadsSurfaceProps) {setWorkloadMetricHoverMode,setWorkloadMetricHistoryRange,} = useWorkloadsControlsState({- defaultSortKey: props.defaultSortKey,forcedGroupingMode: props.forcedGroupingMode,statusModeStorageScope: props.statusModeStorageScope,metricDisplayMode: props.metricDisplayMode,@@ -615,7 +602,6 @@ export function useWorkloadsState(props: WorkloadsSurfaceProps) {isMobile,isSearchLocked,isWorkloadsRoute,- kioskMode,kubernetesContextOptions,kubernetesNamespaceOptions,navigate,diff --git a/frontend-modern/src/components/Workloads/workloadsFilterModel.ts b/frontend-modern/src/components/Workloads/workloadsFilterModel.tsindex 766269bc0b..01839c63c5 100644--- a/frontend-modern/src/components/Workloads/workloadsFilterModel.ts+++ b/frontend-modern/src/components/Workloads/workloadsFilterModel.ts@@ -49,7 +49,6 @@ export interface WorkloadsFilterProps {setStatusMode: (value: WorkloadsStatusMode) => void;groupingMode: () => WorkloadsGroupingMode;setGroupingMode: (value: WorkloadsGroupingMode) => void;- defaultSortKey?: WorkloadsSortKey;setSortKey: (value: WorkloadsSortKey) => void;setSortDirection: (value: 'asc' | 'desc') => void;onBeforeAutoFocus?: () => boolean;diff --git a/frontend-modern/src/features/platformPage/__tests__/platformOverviewLayout.guardrails.test.ts b/frontend-modern/src/features/platformPage/__tests__/platformOverviewLayout.guardrails.test.tsindex 3eb045400c..2276ebb7b5 100644--- a/frontend-modern/src/features/platformPage/__tests__/platformOverviewLayout.guardrails.test.ts+++ b/frontend-modern/src/features/platformPage/__tests__/platformOverviewLayout.guardrails.test.ts@@ -761,8 +761,10 @@ describe('platform overview layout guardrails', () => {// Proxmox and vSphere overview pages render their own page-level// WorkloadsFilter above the embedded WorkloadsSurface so a single// toolbar drives both the page's top table and the workloads table.- // If the embedded surface also renders its own filter the page ends- // up with two stacked toolbars wired to the same state (RC6 bug).+ // The surface renders no filter of its own; one there would stack a+ // second toolbar wired to the same state (RC6 bug).+ expect(workloadsSurfaceSource).not.toContain('<WorkloadsFilter');+ expect(workloadsSurfaceSource).not.toContain("from './WorkloadsFilter'");const surfacesWithSharedToolbar: Array<[string, string]> = [['ProxmoxPageSurface', proxmoxPageSurfaceSource],['VmwarePageSurface', vmwarePageSurfaceSource],@@ -771,9 +773,9 @@ describe('platform overview layout guardrails', () => {const filterCount = (source.match(/<WorkloadsFilter\b/g) ?? []).length;expect(filterCount, `${name} should render exactly one <WorkloadsFilter>`).toBe(1);expect(- /<WorkloadsSurface\b[^>]*?suppressFilterToolbar/s.test(source),- `${name} should pass suppressFilterToolbar to <WorkloadsSurface>`,- ).toBe(true);+ source.indexOf('<WorkloadsFilter'),+ `${name} filter precedes the surface`,+ ).toBeLessThan(source.indexOf('<WorkloadsSurface'));}});@@ -817,7 +819,8 @@ describe('platform overview layout guardrails', () => {expect(existsSync('src/components/Recovery')).toBe(false);// Neither surface has an embedded or table-only mode, and WorkloadsSurface- // has no opt-in toolbar prop: the embedding page suppresses its toolbar.+ // has no toolbar prop at all: it renders no toolbar, and the embedding page+ // renders the only one.const surfaceSources: Array<[string, string]> = [['WorkloadsSurface', workloadsSurfaceSource],['useWorkloadsState', useWorkloadsStateSource],@@ -825,10 +828,10 @@ describe('platform overview layout guardrails', () => {];for (const [name, source] of surfaceSources) {expect(source, `${name} must not declare an embed-mode prop`).not.toMatch(- /\b(?:embedded|tableOnly|showFilterToolbar)\??:/,+ /\b(?:embedded|tableOnly|showFilterToolbar|suppressFilterToolbar)\??:/,);expect(source, `${name} must not read an embed-mode prop`).not.toMatch(- /props\.(?:embedded|tableOnly|showFilterToolbar)\b/,+ /props\.(?:embedded|tableOnly|showFilterToolbar|suppressFilterToolbar)\b/,);}@@ -855,7 +858,6 @@ describe('platform overview layout guardrails', () => {expect(jsxAttr(toolbar, 'forcedPlatform'), name).toBe(platform);const surface = onlyJsxTag(overviewFn, 'WorkloadsSurface');expect(jsxAttr(surface, 'state'), name).toBe('workloadsState');- expect(jsxAttr(surface, 'suppressFilterToolbar'), name).toBe('true');}// StorageSurface sits on the Proxmox Storage tab with the source locked anddiff --git a/frontend-modern/src/features/proxmox/ProxmoxPageSurface.tsx b/frontend-modern/src/features/proxmox/ProxmoxPageSurface.tsxindex e0d72b7bbb..c874cc48ee 100644--- a/frontend-modern/src/features/proxmox/ProxmoxPageSurface.tsx+++ b/frontend-modern/src/features/proxmox/ProxmoxPageSurface.tsx@@ -630,7 +630,6 @@ function ProxmoxOverview(props: ProxmoxOverviewProps) {forcedPlatform={PROXMOX_PLATFORM_FILTER}excludedWorkloadTypes={PROXMOX_WORKLOAD_EXCLUDED_TYPES}showNestedExcludedWorkloads- suppressFilterToolbaremptyStateTitle="No Proxmox workloads"emptyStateDescription="Proxmox VMs and LXCs appear here when inventory is available."tableTitle={diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxPageSurface.contract.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxPageSurface.contract.test.tsxindex e3c47a6883..3ce18b0550 100644--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxPageSurface.contract.test.tsx+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxPageSurface.contract.test.tsx@@ -21,6 +21,7 @@ const mockWorkloadSearch = vi.hoisted(() => vi.fn(() => ''));const mockSelectedNode = vi.hoisted(() => vi.fn<() => string | null>(() => null));const mockHandleNodeSelect = vi.hoisted(() => vi.fn());const mockWorkloadsOptions = vi.hoisted(() => vi.fn());+const mockWorkloadsReady = vi.hoisted(() => vi.fn(() => false));const mockFetchReplicationJobs = vi.hoisted(() =>vi.fn((_signal?: AbortSignal) => Promise.resolve([] as unknown[])),);@@ -97,9 +98,9 @@ vi.mock('@/components/Workloads/useWorkloadsState', () => ({useWorkloadsState: (options: unknown) => {mockWorkloadsOptions(options);return {- surfaceConnected: () => false,- surfaceInitialDataReceived: () => false,- allGuests: () => [],+ surfaceConnected: mockWorkloadsReady,+ surfaceInitialDataReceived: mockWorkloadsReady,+ allGuests: () => (mockWorkloadsReady() ? [{ id: 'vm-1' }] : []),selectedNode: mockSelectedNode,handleNodeSelect: mockHandleNodeSelect,selectedHostHint: () => null,@@ -179,6 +180,7 @@ const renderSurface = () =>describe('ProxmoxPageSurface contract', () => {beforeEach(() => {mockWorkloadsOptions.mockClear();+ mockWorkloadsReady.mockReturnValue(false);mockSelectedNode.mockReturnValue(null);mockHandleNodeSelect.mockClear();mockPathname.mockReturnValue('/proxmox/overview');@@ -593,6 +595,24 @@ describe('ProxmoxPageSurface contract', () => {);});+ it('renders the one workload toolbar above the guests table once workload state is ready', () => {+ setResources([makeResource({ id: 'vm-1', type: 'vm' })]);++ renderSurface();+ expect(screen.queryByTestId('workloads-filter')).not.toBeInTheDocument();+ cleanup();++ mockWorkloadsReady.mockReturnValue(true);+ renderSurface();+ expect(screen.getAllByTestId('workloads-filter')).toHaveLength(1);+ expect(+ screen+ .getByTestId('workloads-filter')+ .compareDocumentPosition(screen.getByTestId('workloads-surface')) &+ Node.DOCUMENT_POSITION_FOLLOWING,+ ).toBeTruthy();+ });+it('keeps the bounded node preview before guests at every viewport', () => {expect(proxmoxPageSurfaceSource).toContain('<section>\n <ProxmoxNodesTable');expect(proxmoxPageSurfaceSource).toContain('class="space-y-3 scroll-mt-4"');diff --git a/frontend-modern/src/features/vmware/VmwarePageSurface.tsx b/frontend-modern/src/features/vmware/VmwarePageSurface.tsxindex ee925fd5f3..355b5e7dfd 100644--- a/frontend-modern/src/features/vmware/VmwarePageSurface.tsx+++ b/frontend-modern/src/features/vmware/VmwarePageSurface.tsx@@ -539,7 +539,6 @@ function VmwareOverview(props: VmwareOverviewProps) {useWorkloadsforcedPlatform={VMWARE_PLATFORM_FILTER}forcedViewMode="vm"- suppressFilterToolbaremptyStateTitle="No vSphere VMs"emptyStateDescription="Virtual machines appear here once the vCenter connection enumerates them."/>diff --git a/frontend-modern/src/features/vmware/__tests__/VmwarePageSurface.contract.test.tsx b/frontend-modern/src/features/vmware/__tests__/VmwarePageSurface.contract.test.tsxindex b9a4c5a43a..ebb81d89d2 100644--- a/frontend-modern/src/features/vmware/__tests__/VmwarePageSurface.contract.test.tsx+++ b/frontend-modern/src/features/vmware/__tests__/VmwarePageSurface.contract.test.tsx@@ -149,6 +149,30 @@ describe('VmwarePageSurface contract', () => {);});+ it('renders the one workload toolbar above the VM table once workload state is ready', () => {+ setResources([makeResource({ id: 'vm-app-01', type: 'vm' })]);++ render(() => <VmwarePageSurface />);+ expect(screen.queryByTestId('workloads-filter')).not.toBeInTheDocument();+ cleanup();++ mockUseWorkloadsState.mockReturnValue({+ surfaceConnected: () => true,+ surfaceInitialDataReceived: () => true,+ allGuests: () => [{ id: 'vm-app-01' }],+ search: () => '',+ setSearch: vi.fn(),+ });+ render(() => <VmwarePageSurface />);+ expect(screen.getAllByTestId('workloads-filter')).toHaveLength(1);+ expect(+ screen+ .getByTestId('workloads-filter')+ .compareDocumentPosition(screen.getByTestId('workloads-surface')) &+ Node.DOCUMENT_POSITION_FOLLOWING,+ ).toBeTruthy();+ });+it('surfaces stale in-guest agents on correlated vSphere VMs', () => {mockVersionInfo.mockReturnValue({version: 'v6.0.0-rc.6',