Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep consumer persistence-failure fixtures on the owned descriptor

pulse-triage[bot]748707ca9e7a
diff --git a/internal/api/action_runner_credentials_test.go b/internal/api/action_runner_credentials_test.go
index 10508fd4cf..1650221eef 100644
--- a/internal/api/action_runner_credentials_test.go
+++ b/internal/api/action_runner_credentials_test.go
@@ -37,6 +37,9 @@ func (actionRunnerFailingPersistenceFS) ReadFile(name string) ([]byte, error) {
func (actionRunnerFailingPersistenceFS) WriteFile(string, []byte, os.FileMode) error {
return errors.New("injected action-runner persistence failure")
}
+func (fs actionRunnerFailingPersistenceFS) CreateTemp(dir, pattern string) (config.TemporaryFile, error) {
+ return newFailingPersistenceTempFile(dir, pattern, func() error { return fs.WriteFile("", nil, 0) })
+}
func (actionRunnerFailingPersistenceFS) Rename(oldPath, newPath string) error {
return os.Rename(oldPath, newPath)
}
@@ -58,6 +61,9 @@ func (fs *actionRunnerBlockingFailingPersistenceFS) WriteFile(string, []byte, os
})
return errors.New("injected blocked action-runner persistence failure")
}
+func (fs *actionRunnerBlockingFailingPersistenceFS) CreateTemp(dir, pattern string) (config.TemporaryFile, error) {
+ return newFailingPersistenceTempFile(dir, pattern, func() error { return fs.WriteFile("", nil, 0) })
+}
func (fs *actionRunnerBlockingFailingPersistenceFS) Rename(oldPath, newPath string) error {
return os.Rename(oldPath, newPath)
}
diff --git a/internal/api/agenttokens/install_test.go b/internal/api/agenttokens/install_test.go
index 2ba14ac2d9..9ccfe6d0c5 100644
--- a/internal/api/agenttokens/install_test.go
+++ b/internal/api/agenttokens/install_test.go
@@ -50,6 +50,12 @@ func (fs *actionRunnerFailAfterWritesFS) ReadFile(name string) ([]byte, error) {
return os.ReadFile(name)
}
func (fs *actionRunnerFailAfterWritesFS) WriteFile(name string, data []byte, perm os.FileMode) error {
+ if err := fs.beforeWrite(); err != nil {
+ return err
+ }
+ return os.WriteFile(name, data, perm)
+}
+func (fs *actionRunnerFailAfterWritesFS) beforeWrite() error {
fs.mu.Lock()
fs.writes++
writes := fs.writes
@@ -57,7 +63,10 @@ func (fs *actionRunnerFailAfterWritesFS) WriteFile(name string, data []byte, per
if writes > fs.allowWrites {
return errors.New("injected rollback persistence failure")
}
- return os.WriteFile(name, data, perm)
+ return nil
+}
+func (fs *actionRunnerFailAfterWritesFS) CreateTemp(dir, pattern string) (config.TemporaryFile, error) {
+ return newActionRunnerTempFile(dir, pattern, fs.beforeWrite)
}
func (fs *actionRunnerFailAfterWritesFS) Rename(oldPath, newPath string) error {
return os.Rename(oldPath, newPath)
@@ -72,6 +81,12 @@ func (fs *actionRunnerFailAfterWritesFS) MkdirAll(path string, perm os.FileMode)
func (fs *actionRunnerTestFS) ReadFile(name string) ([]byte, error) { return os.ReadFile(name) }
func (fs *actionRunnerTestFS) WriteFile(name string, data []byte, perm os.FileMode) error {
+ if err := fs.beforeWrite(); err != nil {
+ return err
+ }
+ return os.WriteFile(name, data, perm)
+}
+func (fs *actionRunnerTestFS) beforeWrite() error {
blocked := false
fs.blockOnce.Do(func() {
blocked = fs.entered != nil
@@ -82,10 +97,30 @@ func (fs *actionRunnerTestFS) WriteFile(name string, data []byte, perm os.FileMo
if blocked {
<-fs.release
}
- if fs.writeErr != nil {
- return fs.writeErr
+ return fs.writeErr
+}
+func (fs *actionRunnerTestFS) CreateTemp(dir, pattern string) (config.TemporaryFile, error) {
+ return newActionRunnerTempFile(dir, pattern, fs.beforeWrite)
+}
+
+type actionRunnerTempFile struct {
+ *os.File
+ beforeWrite func() error
+}
+
+func (f *actionRunnerTempFile) Write(data []byte) (int, error) {
+ if err := f.beforeWrite(); err != nil {
+ return 0, err
+ }
+ return f.File.Write(data)
+}
+
+func newActionRunnerTempFile(dir, pattern string, beforeWrite func() error) (config.TemporaryFile, error) {
+ f, err := os.CreateTemp(dir, pattern)
+ if err != nil {
+ return nil, err
}
- return os.WriteFile(name, data, perm)
+ return &actionRunnerTempFile{File: f, beforeWrite: beforeWrite}, nil
}
func (fs *actionRunnerTestFS) Rename(oldPath, newPath string) error {
return os.Rename(oldPath, newPath)
diff --git a/internal/api/security_setup_fix_additional_test.go b/internal/api/security_setup_fix_additional_test.go
index 308ea42dde..b9c33bcb49 100644
--- a/internal/api/security_setup_fix_additional_test.go
+++ b/internal/api/security_setup_fix_additional_test.go
@@ -25,6 +25,28 @@ func (failingWriteFileSystem) WriteFile(string, []byte, os.FileMode) error {
return errors.New("forced write failure")
}
+// Inject the same write failure through the owned temporary descriptor.
+type failingPersistenceTempFile struct {
+ *os.File
+ fail func() error
+}
+
+func (f *failingPersistenceTempFile) Write([]byte) (int, error) {
+ return 0, f.fail()
+}
+
+func newFailingPersistenceTempFile(dir, pattern string, fail func() error) (config.TemporaryFile, error) {
+ f, err := os.CreateTemp(dir, pattern)
+ if err != nil {
+ return nil, err
+ }
+ return &failingPersistenceTempFile{File: f, fail: fail}, nil
+}
+
+func (fs failingWriteFileSystem) CreateTemp(dir, pattern string) (config.TemporaryFile, error) {
+ return newFailingPersistenceTempFile(dir, pattern, func() error { return fs.WriteFile("", nil, 0) })
+}
+
func (failingWriteFileSystem) Rename(oldPath, newPath string) error {
return os.Rename(oldPath, newPath)
}