Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Refresh a threshold override when only its note changes

probe77e5b9df6661
diff --git a/docs/release-control/v6/internal/subsystems/alerts.md b/docs/release-control/v6/internal/subsystems/alerts.md
index aef80568bb..f3d676707b 100644
--- a/docs/release-control/v6/internal/subsystems/alerts.md
+++ b/docs/release-control/v6/internal/subsystems/alerts.md
@@ -1747,7 +1747,10 @@ stores no threshold and removes an override left with nothing else, and any stor
a saved 0 included, shows as Custom with a revert action. Other rows keep an
explicit Off over an Off inherited default, so it survives a later change to
that default. The overrides projection carries each stored override's note
-for every resource type, so a reloaded editor keeps it. A row's delay action opens the alert intent editor on
+for every resource type, so a reloaded editor keeps it, and
+`useAlertOverridesState` re-projects when only a note changes, so a discarded
+note-only edit or a note removed on the server does not linger on the row and
+get saved back (`useAlertOverridesState.test.tsx`). A row's delay action opens the alert intent editor on
`metric.temperature` (shared `getAlertResourcePreferredIntentSignal`), and
the editor keeps a target that is not a listed resource, such as a machine
sensor or disk, as its own option under the row's label instead of falling
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 764d9fc27b..8448fcdf81 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -10434,8 +10434,10 @@ applies each handoff once, reading the resource list untracked, so an
inventory change cannot replay it over the operator's later selection. The
Machine Sensors section reuses the shared table with no Global Defaults row
and no Alerts column; its rows stay one line, with the reading and chip in the
-subtitle and any `readingMessage` on the name's line. No shared primitive or
-layout changes.
+subtitle and any `readingMessage` on the name's line. The threshold override
+read model (`useAlertOverridesState`) treats a note-only change as a change,
+so the row and its editor show the stored note after Discard or a reload. No
+shared primitive or layout changes.
### Stopped VM filesystem presentation (12 October 2026)
diff --git a/frontend-modern/browser-verification/907922cd0df97a5e.json b/frontend-modern/browser-verification/907922cd0df97a5e.json
new file mode 100644
index 0000000000..7857eabd6a
--- /dev/null
+++ b/frontend-modern/browser-verification/907922cd0df97a5e.json
@@ -0,0 +1,38 @@
+{
+ "version": 1,
+ "base_sha": "5cbcb053308675c0422b0bc52e8419e566e8a3f5",
+ "verified_at": "2026-11-01T17:10:00Z",
+ "result": "passed",
+ "changed_paths": [
+ "frontend-modern/src/features/alerts/useAlertOverridesState.ts"
+ ],
+ "content_sha256": {
+ "frontend-modern/src/features/alerts/useAlertOverridesState.ts": "fc7e6f8ee5f3ec93a55347270c350b6bbf7034518ccf38e6bffd1975c8e4d1f3"
+ },
+ "routes": [
+ "/alerts/thresholds/systems"
+ ],
+ "viewports": [
+ {
+ "width": 1366,
+ "height": 900
+ },
+ {
+ "width": 375,
+ "height": 812
+ }
+ ],
+ "states": [
+ "Machine Sensors section expanded on a private mock stack built from this branch",
+ "TB0T sensor override saved with a 60 C limit and the note \"saved note\" (stored under the hex sensor ID)",
+ "unsaved note-only edit pending (\"discarded note\" shown on the row, Discard and Save Changes visible)",
+ "after Discard the row shows \"saved note\" and the reopened editor holds \"saved note\"",
+ "phone width: Machine Sensors lists TB0T with its 60 C limit and Revert action after reload"
+ ],
+ "interactions": [
+ "opened the TB0T row editor, set the limit and note, committed the row and clicked Save Changes",
+ "reopened the editor, changed only the note, committed the row, clicked Discard",
+ "reopened the editor and read the note field",
+ "reloaded at 375x812, expanded Machine Sensors and found the TB0T row"
+ ]
+}
diff --git a/frontend-modern/src/features/alerts/__tests__/useAlertOverridesState.test.tsx b/frontend-modern/src/features/alerts/__tests__/useAlertOverridesState.test.tsx
index 2fb3f002f2..2ea277f007 100644
--- a/frontend-modern/src/features/alerts/__tests__/useAlertOverridesState.test.tsx
+++ b/frontend-modern/src/features/alerts/__tests__/useAlertOverridesState.test.tsx
@@ -222,6 +222,48 @@ describe('useAlertOverridesState', () => {
expect(overviewOverrides()).toEqual([]);
});
+ it('refreshes a projected override when only its note changes', async () => {
+ const [hasUnsavedChanges] = createSignal(false);
+ const [, setOverviewOverrides] = createSignal([]);
+ const resources = [
+ makeResource({
+ id: 'cluster-a:node-2:100',
+ name: 'db-01',
+ type: 'vm',
+ platformId: 'qemu/100',
+ proxmox: { vmid: 100, node: 'node-2', instance: 'cluster-a' },
+ platformData: { proxmox: { vmid: 100, node: 'node-2', instance: 'cluster-a' } },
+ }),
+ ];
+
+ const { result } = renderHook(() =>
+ useAlertOverridesState({
+ allResources: () => resources,
+ byType: (resourceType) => resources.filter((resource) => resource.type === resourceType),
+ children: () => [],
+ hasUnsavedChanges,
+ setOverviewOverrides,
+ }),
+ );
+
+ result.replaceRawOverridesConfig({
+ 'guest:cluster-a:100': { cpu: { trigger: 95, clear: 90 }, note: 'saved note' } as any,
+ });
+ await waitFor(() => expect(result.overrides()[0]?.note).toBe('saved note'));
+
+ // A local edit changes only the note, then the config is discarded or reloaded.
+ result.setOverrides([{ ...result.overrides()[0], note: 'discarded note' }]);
+ result.replaceRawOverridesConfig({
+ 'guest:cluster-a:100': { cpu: { trigger: 95, clear: 90 }, note: 'saved note' } as any,
+ });
+ await waitFor(() => expect(result.overrides()[0]?.note).toBe('saved note'));
+
+ result.replaceRawOverridesConfig({
+ 'guest:cluster-a:100': { cpu: { trigger: 95, clear: 90 } } as any,
+ });
+ await waitFor(() => expect(result.overrides()[0]?.note).toBeUndefined());
+ });
+
it('canonicalizes shared-storage overrides for the live thresholds surface', async () => {
const [hasUnsavedChanges] = createSignal(false);
const [overviewOverrides, setOverviewOverrides] = createSignal([]);
diff --git a/frontend-modern/src/features/alerts/useAlertOverridesState.ts b/frontend-modern/src/features/alerts/useAlertOverridesState.ts
index a8114afa7c..6e2241d35e 100644
--- a/frontend-modern/src/features/alerts/useAlertOverridesState.ts
+++ b/frontend-modern/src/features/alerts/useAlertOverridesState.ts
@@ -143,6 +143,7 @@ export function useAlertOverridesState(props: AlertOverridesStateProps) {
if (!existing) return true;
return (
JSON.stringify(newOverride.thresholds) !== JSON.stringify(existing.thresholds) ||
+ (newOverride.note ?? '') !== (existing.note ?? '') ||
Boolean(newOverride.disableConnectivity) !== Boolean(existing.disableConnectivity) ||
Boolean(newOverride.disabled) !== Boolean(existing.disabled) ||
(newOverride.poweredOffSeverity ?? null) !== (existing.poweredOffSeverity ?? null) ||