Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Patch the frontend serialization and parser dependencies

pulse-triage[bot]795e5345176b
diff --git a/docs/release-control/v6/internal/subsystems/deployment-installability.md b/docs/release-control/v6/internal/subsystems/deployment-installability.md
index 6a47430081..c38a0cd1d8 100644
--- a/docs/release-control/v6/internal/subsystems/deployment-installability.md
+++ b/docs/release-control/v6/internal/subsystems/deployment-installability.md
@@ -4121,6 +4121,22 @@ Vitest migration must preserve test assertions while using constructable
constructor mocks and explicit standalone mock-history cleanup. Dependency
updates must retain the required full-graph audit rather than suppressing it.
+The October deserialization/parsing advisory floors are Seroval `1.6.3`
+(GHSA-p6vx-979v-rg4c and GHSA-jp82-f5mq-hwhp), postcss-selector-parser `7.1.6`
+(GHSA-rj75-hqrm-r3gf), and source-map-js `1.2.2` (GHSA-68fv-2mgg-jv7q).
+Maintained-major overrides apply to every copy, without downgrading Solid,
+typography, Tailwind, or the other reviewed dependency floors. The Seroval
+override intentionally supersedes Solid's `~1.5.4` requirement; the unchanged
+seroval-plugins `1.5.5` peer accepts Seroval `^1.0`. The selector-parser override
+intentionally supersedes typography's exact `6.0.10` dependency. Such overrides
+require actual consumer compatibility, not just a version assertion:
+`dependencyTooling.test.ts` checks shared consumer resolution, cyclic/plugin
+serialization, typography pseudo placement, named maps and PostCSS source
+content. `dependencySecurity.test.ts` checks all three manifest/lock floors,
+including nested copies. Exact acquired-graph source/build/browser validation
+and the complete hosted audit remain distinct obligations; official patch
+metadata and a lockfile do not by themselves clear an audit failure.
+
That same dev-runtime dependency-manifest boundary now also owns the maintained
Docker engine module floor. `go.mod`, `go.sum`, and
`internal/cloudcp/docker/manager.go` must route hosted runtime orchestration
diff --git a/frontend-modern/package-lock.json b/frontend-modern/package-lock.json
index d5830a3717..78f8a43477 100644
--- a/frontend-modern/package-lock.json
+++ b/frontend-modern/package-lock.json
@@ -5059,9 +5059,9 @@
}
},
"node_modules/postcss-selector-parser": {
- "version": "6.0.10",
- "resolved": "https://registry.npmjs.org/postcss-selector-parser/-/postcss-selector-parser-6.0.10.tgz",
- "integrity": "sha512-IQ7TZdoaqbT+LCpShg46jnZVlhWD2w6iQYAcYXfHARZ7X1t/UGhhceQDs5X0cGqKvYlHNOuv7Oa1xmb0oQuA3w==",
+ "version": "7.1.6",
+ "resolved": "https://registry.npmjs.org/postcss-selector-parser/-/postcss-selector-parser-7.1.6.tgz",
+ "integrity": "sha512-7qASPzhKF2l2KLboRZux8CCTRMdGiV08vWmyKzPz22qZ7ZjQBOeY7rNzNoCLSUiftJ7HUq0GERHmxw/t0dCdMw==",
"dev": true,
"license": "MIT",
"dependencies": {
@@ -5312,9 +5312,9 @@
}
},
"node_modules/seroval": {
- "version": "1.5.5",
- "resolved": "https://registry.npmjs.org/seroval/-/seroval-1.5.5.tgz",
- "integrity": "sha512-bSjOuPcwPKLSJNhr9+bZxA20nQxVle5J5MNsYRVE6cIg7KpRLXGupymePavu0jrxlPiPsr4xGZSB8yUY2sH2sw==",
+ "version": "1.6.3",
+ "resolved": "https://registry.npmjs.org/seroval/-/seroval-1.6.3.tgz",
+ "integrity": "sha512-5PwLbVPpT4DEki1hYVSSsoxWY6xCNMVucAVLK/CH0mXSDfp/I4KaAex72q80GNt5hpn7CCMGdSpIg4YGqH/wXQ==",
"license": "MIT",
"engines": {
"node": ">=10"
@@ -5395,9 +5395,9 @@
}
},
"node_modules/source-map-js": {
- "version": "1.2.1",
- "resolved": "https://registry.npmjs.org/source-map-js/-/source-map-js-1.2.1.tgz",
- "integrity": "sha512-UXWMKhLOwVKb728IUtQPXxfYU+usdybtUrK/8uGE8CQMvrhOpwvzDBwj0QhSL7MQc7vIsISBG8VQ8+IDQxpfQA==",
+ "version": "1.2.2",
+ "resolved": "https://registry.npmjs.org/source-map-js/-/source-map-js-1.2.2.tgz",
+ "integrity": "sha512-KGj/8Y43x35aZVDtt+J4mK1hoLGHULMYfSkODJNQjNDC3oW1PqPoxMwo0pLUsWM/UEGzON/NxeHywEfNXNP3Vw==",
"dev": true,
"license": "BSD-3-Clause",
"engines": {
diff --git a/frontend-modern/package.json b/frontend-modern/package.json
index 1397934259..9909821e4b 100644
--- a/frontend-modern/package.json
+++ b/frontend-modern/package.json
@@ -63,10 +63,12 @@
"overrides": {
"esbuild": "0.28.1",
"form-data": "^4.0.6",
- "seroval": "^1.4.1",
+ "seroval": "^1.6.3",
"seroval-plugins": "^1.4.1",
"@babel/core": "^7.29.6",
- "js-yaml": "^4.3.2"
+ "js-yaml": "^4.3.2",
+ "postcss-selector-parser": "^7.1.6",
+ "source-map-js": "^1.2.2"
},
"devDependencies": {
"@eslint/js": "^9.39.2",
diff --git a/frontend-modern/src/security/__tests__/dependencySecurity.test.ts b/frontend-modern/src/security/__tests__/dependencySecurity.test.ts
index 6e9e7f3036..1d0eda04b1 100644
--- a/frontend-modern/src/security/__tests__/dependencySecurity.test.ts
+++ b/frontend-modern/src/security/__tests__/dependencySecurity.test.ts
@@ -78,6 +78,25 @@ const prettierPinIsReviewed = (version: string): boolean =>
/^3\.(?:0|[1-9]\d*)\.(?:0|[1-9]\d*)$/.test(version) && atLeast(version, [3, 9, 9]);
describe('frontend dependency security floors', () => {
+ it.each<[string, [number, number, number]]>([
+ // GHSA-p6vx-979v-rg4c and GHSA-jp82-f5mq-hwhp: both Seroval fixes
+ // are required, including the TypedArray fix after the first 1.6.x patch.
+ ['seroval', [1, 6, 3]],
+ // GHSA-rj75-hqrm-r3gf: typography's exact 6.0.10 needs a 7.x override.
+ ['postcss-selector-parser', [7, 1, 6]],
+ // GHSA-68fv-2mgg-jv7q: all PostCSS/source-map consumers need the fix.
+ ['source-map-js', [1, 2, 2]],
+ ])('keeps every %s copy above the October deserialization and parsing floors', (name, floor) => {
+ expect(manifest.overrides[name]).toBe(`^${floor.join('.')}`);
+ const versions = lockedVersions(name);
+ expect(versions, `${name} must be locked`).not.toHaveLength(0);
+ for (const version of versions) {
+ expect(version).not.toContain('-');
+ expect(parseVersion(version)[0], `${name} must stay on the reviewed major`).toBe(floor[0]);
+ expect(atLeast(version, floor), `${name} ${version} is vulnerable`).toBe(true);
+ }
+ });
+
it('keeps Vitest and its mocker above the redirect-mock file-read floor', () => {
// GHSA-82fw-gwwq-j7x9: the maintained 4.x fix starts at 4.1.11.
expect(manifest.devDependencies.vitest).toBe('^4.1.11');
diff --git a/frontend-modern/src/security/__tests__/dependencyTooling.test.ts b/frontend-modern/src/security/__tests__/dependencyTooling.test.ts
index 4d0adb126f..dc9abf7341 100644
--- a/frontend-modern/src/security/__tests__/dependencyTooling.test.ts
+++ b/frontend-modern/src/security/__tests__/dependencyTooling.test.ts
@@ -7,6 +7,7 @@ import { describe, expect, it } from 'vitest';
// Vite's browser resolution picks Prettier's parser-free standalone bundle.
// Exercise the Node formatter used by repository tooling, not that UI bundle.
const prettier = createRequire(import.meta.url)('prettier') as typeof import('prettier');
+const require = createRequire(import.meta.url);
const manifest = JSON.parse(
readFileSync(new URL('../../../package.json', import.meta.url), 'utf8'),
@@ -30,3 +31,131 @@ describe('reviewed formatter behaviour', () => {
).toBe(markdown);
});
});
+
+describe('patched transitive dependency compatibility', () => {
+ it.each([
+ ['solid-js', 'seroval'],
+ ['seroval-plugins/web', 'seroval'],
+ ['@tailwindcss/typography', 'postcss-selector-parser'],
+ ['postcss', 'source-map-js'],
+ ['@tailwindcss/node', 'source-map-js'],
+ ['magicast', 'source-map-js'],
+ ])('routes %s through the shared patched %s', (consumer, dependency) => {
+ // Catch a stale/nested install that would evade an otherwise correct
+ // top-level lock assertion. These are the real installed consumers.
+ const fromConsumer = createRequire(require.resolve(consumer));
+ expect(fromConsumer.resolve(dependency)).toBe(require.resolve(dependency));
+ });
+
+ it('round-trips cyclic values, typed arrays and the existing URL plugin', () => {
+ const { toJSON, fromJSON } = require('seroval') as typeof import('seroval');
+ const { URLPlugin } = require('seroval-plugins/web') as typeof import('seroval-plugins/web');
+ const values = {
+ name: 'Pulse',
+ date: new Date('2026-10-06T00:00:00Z'),
+ bytes: new Uint8Array([0, 42, 255]),
+ groups: new Map([['alerts', new Set(['node-a', 'node-b'])]]),
+ url: new URL('https://example.test/history?period=24h'),
+ };
+ const original = { values, again: values };
+ Object.assign(values, { parent: original });
+ const options = { plugins: [URLPlugin] };
+ const restored = fromJSON(toJSON(original, options), options) as typeof original;
+ expect(restored.values).toEqual(values);
+ expect(restored.again).toBe(restored.values);
+ expect((restored.values as typeof values & { parent: typeof original }).parent).toBe(restored);
+ });
+
+ it('keeps typography trailing pseudos outside the zero-specificity selector wrapper', () => {
+ type CSS = Record<string, Record<string, unknown>>;
+ const variants: Record<string, string> = {};
+ const components: CSS[] = [];
+ const css = {
+ 'h1::before, h2::before': { content: '"heading"' },
+ 'pre code': { color: 'inherit' },
+ '> ul > li': { color: 'inherit' },
+ };
+ const typography = require('@tailwindcss/typography') as () => {
+ handler: (api: {
+ addVariant: (name: string, selector: string) => void;
+ addComponents: (styles: CSS[]) => void;
+ theme: (name: string) => unknown;
+ prefix: (selector: string) => string;
+ }) => void;
+ };
+ // Run the public plugin, which consumes selector-parser through its
+ // commonTrailingPseudos helper, rather than a hand-written parser imitation.
+ typography().handler({
+ addVariant: (name, selector) => {
+ variants[name] = selector;
+ },
+ addComponents: (styles) => {
+ components.push(...styles);
+ },
+ theme: (name) => (name === 'typography' ? { DEFAULT: { css } } : undefined),
+ prefix: (selector) => selector,
+ });
+ const notProse = ':not(:where([class~="not-prose"],[class~="not-prose"] *))';
+ expect(components[0]['.prose']).toEqual({
+ [`:where(h1, h2)${notProse}::before`]: css['h1::before, h2::before'],
+ [`:where(pre code)${notProse}`]: css['pre code'],
+ [`:where(.prose > ul > li)${notProse}`]: css['> ul > li'],
+ });
+ expect(variants['prose-code']).toBe(`& :is(:where(code)${notProse})`);
+ });
+
+ it('preserves named source mappings and their source content', () => {
+ const { SourceMapGenerator, SourceMapConsumer } =
+ require('source-map-js') as typeof import('source-map-js');
+ const source = '.status {\n color: red;\n}\n';
+ const map = new SourceMapGenerator({ file: 'output.css' });
+ map.addMapping({
+ generated: { line: 2, column: 2 },
+ original: { line: 2, column: 2 },
+ source: 'input.css',
+ name: 'status-colour',
+ });
+ map.setSourceContent('input.css', source);
+ const consumer = new SourceMapConsumer(map.toJSON());
+ expect(consumer.originalPositionFor({ line: 2, column: 2 })).toEqual({
+ source: 'input.css',
+ line: 2,
+ column: 2,
+ name: 'status-colour',
+ });
+ expect(consumer.sourceContentFor('input.css')).toBe(source);
+ expect(
+ consumer.generatedPositionFor({ source: 'input.css', line: 2, column: 2 }),
+ ).toMatchObject({
+ line: 2,
+ column: 2,
+ });
+ });
+
+ it('preserves original CSS positions through the actual PostCSS consumer', async () => {
+ const postcss = require('postcss') as typeof import('postcss');
+ const { SourceMapConsumer } = require('source-map-js') as typeof import('source-map-js');
+ const source = '.status {\n color: red;\n}\n';
+ const result = await postcss([
+ {
+ postcssPlugin: 'compatibility-colour',
+ Declaration(declaration) {
+ if (declaration.prop === 'color') declaration.value = 'green';
+ },
+ },
+ ]).process(source, {
+ from: '/fixture/input.css',
+ to: '/fixture/output.css',
+ map: { inline: false, annotation: false },
+ });
+ expect(result.css).toContain('color: green');
+ expect(result.map).toBeDefined();
+ const consumer = new SourceMapConsumer(result.map!.toJSON());
+ expect(consumer.originalPositionFor({ line: 2, column: 2 })).toMatchObject({
+ source: 'input.css',
+ line: 2,
+ column: 2,
+ });
+ expect(consumer.sourceContentFor('input.css')).toBe(source);
+ });
+});