Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Use sentence punctuation in credential-aware CORS help

pulse-triage[bot]7da9e621504e
diff --git a/frontend-modern/browser-verification/71d8cc7af9239766.json b/frontend-modern/browser-verification/71d8cc7af9239766.json
new file mode 100644
index 0000000000..816d487784
--- /dev/null
+++ b/frontend-modern/browser-verification/71d8cc7af9239766.json
@@ -0,0 +1,38 @@
+{
+ "version": 1,
+ "base_sha": "2003e843d089f3c8d542bdd66aac4ac148e3572c",
+ "verified_at": "2026-10-06T11:11:00Z",
+ "result": "passed",
+ "changed_paths": [
+ "frontend-modern/src/components/Settings/NetworkBoundarySettingsSection.tsx"
+ ],
+ "content_sha256": {
+ "frontend-modern/src/components/Settings/NetworkBoundarySettingsSection.tsx": "1e4ad1c5905528ebf5fd21f0dfb504bcf9f5c3740b718f56f084d70881f99822"
+ },
+ "routes": [
+ "/settings/system/network",
+ "/settings/system/network?override=1",
+ "/docs/FAQ",
+ "/docs/TROUBLESHOOTING#cors-errors"
+ ],
+ "viewports": [
+ {
+ "width": 1280,
+ "height": 1000
+ },
+ {
+ "width": 390,
+ "height": 1000
+ }
+ ],
+ "states": [
+ "Actual NetworkBoundarySettingsSection, Docs, router and source stylesheet using existing cors-guidance fixture. Chromium141.0.7390.37/light desktop and WebKit26.0/dark phone with Playwright1.56.1. Six captures inspected. This is a sentence-punctuation repair after copy lint failure, not changed CORS runtime policy.",
+ "The same-origin/exact-origin and wildcard credential limits are readable and associated with the CORS input through aria-describedby. Empty editable field and managed environment override retain their exact values and dirty-state semantics.",
+ "No horizontal page overflow or console/page errors. This is not settings persistence, saved-effective reversal, native CORS, login, CSRF, TLS, proxy, installed, published or physical-device acceptance."
+ ],
+ "interactions": [
+ "Keyboard input preserves two exact trusted origins and marks the existing form changed. The environment-overridden field remains disabled and unchanged.",
+ "Keyboard Enter follows the real FAQ and troubleshooting CORS links, scrolls/focuses the heading and renders the actual shipped docs.",
+ "Completed script closes each browser and awaits server.close in its finally block; client exit0. No independent detached descendant audit is inferred."
+ ]
+}
diff --git a/frontend-modern/src/components/Settings/NetworkBoundarySettingsSection.tsx b/frontend-modern/src/components/Settings/NetworkBoundarySettingsSection.tsx
index 4af47548d7..bf6f24256d 100644
--- a/frontend-modern/src/components/Settings/NetworkBoundarySettingsSection.tsx
+++ b/frontend-modern/src/components/Settings/NetworkBoundarySettingsSection.tsx
@@ -115,7 +115,7 @@ export const NetworkBoundarySettingsSection: Component<NetworkBoundarySettingsSe
</p>
<p id="cors-origin-limits" class="text-xs text-muted">
Empty grants no cross-origin browser permission. * allows any origin without
- credentialed browser access; it is not a login or proxy repair. CORS does not replace
+ credentialed browser access. It is not a login or proxy repair. CORS does not replace
authentication, CSRF protection or TLS.
</p>
<div class="relative">
diff --git a/frontend-modern/src/components/Settings/__tests__/NetworkBoundaryCorsGuidance.test.tsx b/frontend-modern/src/components/Settings/__tests__/NetworkBoundaryCorsGuidance.test.tsx
index 3a247272af..ac3c2a8f35 100644
--- a/frontend-modern/src/components/Settings/__tests__/NetworkBoundaryCorsGuidance.test.tsx
+++ b/frontend-modern/src/components/Settings/__tests__/NetworkBoundaryCorsGuidance.test.tsx
@@ -46,6 +46,7 @@ describe('CORS settings guidance', () => {
expect(input).toHaveAccessibleDescription(/without a path or trailing slash/);
expect(input).toHaveAccessibleDescription(/Separate origins with commas/);
expect(input).toHaveAccessibleDescription(/without credentialed browser access/);
+ expect(input).toHaveAccessibleDescription(/credentialed browser access\. It is not/);
expect(input).toHaveAccessibleDescription(/not a login or proxy repair/);
expect(input).toHaveAccessibleDescription(/authentication, CSRF protection or TLS/);
expect(input).toHaveAttribute('placeholder', 'https://app.example.com:8443');