Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Clarify backup task-log collection in the overnight walkthrough

pulse-triage[bot]8110a60c304a
diff --git a/docs/WHAT_HAPPENED_OVERNIGHT.md b/docs/WHAT_HAPPENED_OVERNIGHT.md
index b59fea92f7..8c2ff76683 100644
--- a/docs/WHAT_HAPPENED_OVERNIGHT.md
+++ b/docs/WHAT_HAPPENED_OVERNIGHT.md
@@ -112,8 +112,12 @@ empty or short answer.
rather than when it happened. Resources that appeared in the gap are
recorded as discovered. Removals and reboots during the gap are not
recorded.
-- **Logs and task history.** Pulse doesn't read system journals, container
- logs or the Proxmox task log. Your agent can still read those on the host.
+- **Logs and task history.** For multi-guest `vzdump` backup jobs, Pulse reads
+ Proxmox task logs to derive per-guest backup results. This bounded backup
+ collection is not a general task-log archive: `list_recent_changes` and the
+ other MCP reads above don't return raw Proxmox task logs, system journals or
+ container logs. Your agent needs separate authorised host access to read
+ those directly; a Pulse token doesn't grant it.
- **Retention.** The change history keeps 30 days. Metric history keeps seven
days on Community.
- **An empty answer is not proof that nothing happened.** It means Pulse
diff --git a/frontend-modern/public/docs/WHAT_HAPPENED_OVERNIGHT.md b/frontend-modern/public/docs/WHAT_HAPPENED_OVERNIGHT.md
index b59fea92f7..8c2ff76683 100644
--- a/frontend-modern/public/docs/WHAT_HAPPENED_OVERNIGHT.md
+++ b/frontend-modern/public/docs/WHAT_HAPPENED_OVERNIGHT.md
@@ -112,8 +112,12 @@ empty or short answer.
rather than when it happened. Resources that appeared in the gap are
recorded as discovered. Removals and reboots during the gap are not
recorded.
-- **Logs and task history.** Pulse doesn't read system journals, container
- logs or the Proxmox task log. Your agent can still read those on the host.
+- **Logs and task history.** For multi-guest `vzdump` backup jobs, Pulse reads
+ Proxmox task logs to derive per-guest backup results. This bounded backup
+ collection is not a general task-log archive: `list_recent_changes` and the
+ other MCP reads above don't return raw Proxmox task logs, system journals or
+ container logs. Your agent needs separate authorised host access to read
+ those directly; a Pulse token doesn't grant it.
- **Retention.** The change history keeps 30 days. Metric history keeps seven
days on Community.
- **An empty answer is not proof that nothing happened.** It means Pulse
diff --git a/scripts/tests/test_external_agent_docs.py b/scripts/tests/test_external_agent_docs.py
index 87293ae6d3..0ca3eae4c0 100644
--- a/scripts/tests/test_external_agent_docs.py
+++ b/scripts/tests/test_external_agent_docs.py
@@ -25,6 +25,10 @@ def adapter_readme():
return (ROOT / "cmd/pulse-mcp/README.md").read_text(encoding="utf-8")
+def walkthrough():
+ return (ROOT / "docs/WHAT_HAPPENED_OVERNIGHT.md").read_text(encoding="utf-8")
+
+
def compact(value):
return " ".join(value.split())
@@ -38,6 +42,26 @@ class ExternalAgentDocsTest(unittest.TestCase):
def test_shipped_guide_matches_canonical(self):
self.assertEqual(guide(), (ROOT / "frontend-modern/public/docs/AGENT_SUBSTRATE.md").read_text())
+ def test_shipped_walkthrough_matches_canonical(self):
+ self.assertEqual(walkthrough(), (ROOT / "frontend-modern/public/docs/WHAT_HAPPENED_OVERNIGHT.md").read_text())
+
+ def test_walkthrough_separates_backup_log_collection_from_agent_access(self):
+ text = compact(walkthrough())
+ limitation = text.split("**Logs and task history.**", 1)[1].split("**Retention.**", 1)[0]
+ # The backup collector already fetches and parses multi-guest job logs.
+ # Don't deny that collection or advertise it as a raw MCP log reader.
+ collector = (ROOT / "internal/monitoring/monitor_backups.go").read_text()
+ self.assertIn("client.GetTaskLog(ctx, jobTask.Node, upid)", collector)
+ self.assertIn("parseVzdumpJobLog(jobTask, upid, logLines)", collector)
+ for fact in ("multi-guest `vzdump` backup jobs", "per-guest backup results",
+ "not a general task-log archive", "`list_recent_changes`",
+ "don't return raw Proxmox task logs, system journals or container logs",
+ "separate authorised host access", "a Pulse token doesn't grant it"):
+ with self.subTest(fact=fact):
+ self.assertIn(fact, limitation)
+ self.assertIn("`monitoring:read`", text)
+ self.assertIn("it never receives command text or output", text)
+
def test_adapter_bootstrap_is_saved_verified_and_separate_from_execution(self):
install = guide().split("## Install the MCP adapter safely\n", 1)[1].split("\n## ", 1)[0]
readme = adapter_readme().split("## Install\n", 1)[1].split("\n## Quick start", 1)[0]