Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Name each PBS server once in the Backup servers table

rcourtman8254756f4a9c
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 943203957f..d6eab93366 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -544,6 +544,13 @@ route, navigation, access or backup operation changes.
and phone, so a filtering row looks clickable without adding height. Rows that
open nothing leave the track empty, so every row's columns still line up.
+### Backup servers datastore rows name their server once (2 November 2026)
+
+`ProxmoxBackupServersTable` renders `ResourceNameWithWebInterfaceLink` only on
+a server's first datastore row; rows with `continuesServer` leave the name cell
+to the detail toggle plus an `sr-only` server name, so the shared web-interface
+link appears once per server rather than once per datastore.
+
### Backups By date carries no activity chart (2 November 2026)
The restore points no longer render `BackupActivityChart`; the component and
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index ad357d841d..f31102925a 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -5078,6 +5078,17 @@ keeps its columns aligned. Rows stay 32px, the accessible names are unchanged,
and the phone bar narrows from 5rem to 4rem to make room. Which workloads each
reason selects is unchanged.
+### A server's later datastore rows stop repeating its name (2 November 2026)
+
+The Backup servers table keeps one row per datastore, but a server's later
+datastore rows no longer show its name or web-interface link. A muted repeated
+name still read as a second PBS server on a real two-datastore install. The
+name, status and link now appear once, on the server's first row; later rows
+keep their toggle (whose accessible name still names the server and datastore)
+and a screen-reader-only server name, and their drawer still reads the server.
+Earlier notes here that later rows keep the muted name and a link per datastore
+are historical.
+
### Restore points drop the per-day chart (2 November 2026)
By date no longer draws "Completed restore points per day" (or its Volume
diff --git a/docs/release-control/v6/internal/subsystems/unified-resources.md b/docs/release-control/v6/internal/subsystems/unified-resources.md
index da1e0d7bc9..04344e038b 100644
--- a/docs/release-control/v6/internal/subsystems/unified-resources.md
+++ b/docs/release-control/v6/internal/subsystems/unified-resources.md
@@ -222,6 +222,14 @@ narrow browser proof exercises the same producer through the inventory consumer
with native interactions and inspected pixels. No API, provider, guest, polling,
auth, resource identity or protection-policy change, nor installed recovery claim.
+### Backup servers rows name a PBS resource once (2 November 2026)
+
+`ProxmoxBackupServersTable` still renders one row per datastore of a `pbs`
+resource, but only the resource's first row shows its name and web-interface
+link; later rows carry the name for screen readers alone and keep their own
+detail toggle and drawer. The rows and their resource identity are unchanged;
+only the repeated visible label is gone.
+
### Backup empty states name only filters that exist (2 November 2026)
With the per-day restore point chart removed from Backups By date, no control
diff --git a/frontend-modern/browser-verification/0f455eba3f79cb17.json b/frontend-modern/browser-verification/0f455eba3f79cb17.json
new file mode 100644
index 0000000000..e210f71b20
--- /dev/null
+++ b/frontend-modern/browser-verification/0f455eba3f79cb17.json
@@ -0,0 +1,37 @@
+{
+ "version": 1,
+ "base_sha": "53099e283b59852dbcfd54122bb857a193b669bf",
+ "verified_at": "2026-11-02T17:05:00Z",
+ "result": "passed",
+ "changed_paths": [
+ "frontend-modern/src/features/proxmox/ProxmoxBackupServersTable.tsx"
+ ],
+ "content_sha256": {
+ "frontend-modern/src/features/proxmox/ProxmoxBackupServersTable.tsx": "6bcf6c9e20ba0a54bc1b8a37fcd38d1c05b4269e47ebe1c6fdbd7f7b4cc3e4fe"
+ },
+ "routes": [
+ "/proxmox/backups/date"
+ ],
+ "viewports": [
+ {
+ "width": 1440,
+ "height": 1000
+ },
+ {
+ "width": 375,
+ "height": 812
+ }
+ ],
+ "states": [
+ "private mock-mode backend built from this branch on pulse-dev",
+ "Backup servers table with a two-datastore server, closed and with the second row expanded",
+ "dark and light themes, desktop and phone layouts"
+ ],
+ "interactions": [
+ "built this branch and ran it in mock mode on pulse-dev, signed in and opened Proxmox > Backups > By date at 1440x1000 and 375x812 in dark and light themes",
+ "the Backup servers table shows backup-vault once with Healthy on its offsite-vault row; its primary-vault row shows only the toggle and datastore figures, then dr-vault starts a new server with its own name and status",
+ "rows measured 33px on desktop and 32px on phone; no horizontal page overflow at either width",
+ "opened the primary-vault row's drawer on desktop: it reads Backup reader backup-vault, Datastore primary-vault and the backup-vault host panel",
+ "tapped the primary-vault row on phone: aria-expanded became true and the drawer opened"
+ ]
+}
diff --git a/frontend-modern/src/features/proxmox/ProxmoxBackupServersTable.tsx b/frontend-modern/src/features/proxmox/ProxmoxBackupServersTable.tsx
index f17f23b3b6..78b01458e7 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxBackupServersTable.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxBackupServersTable.tsx
@@ -59,10 +59,10 @@ import {
// gets a reachability row.
// PBS hosts left the v5 nodes table in the v6 IA, so this is where their health
// lives. The row says whether the server is reachable; its CPU, memory, uptime,
-// version and their history are in the server's drawer, one click away. Status
-// shows once, on the server's first datastore row; its later rows keep the
-// server name (muted), toggle and web link, so two datastores never read as two
-// identical servers.
+// version and their history are in the server's drawer, one click away. The
+// server's name, status and web link show once, on its first datastore row; its
+// later rows keep only their toggle, so two datastores never read as two
+// servers. A muted repeated name still read as a second server.
interface BackupServerRow {
key: string;
@@ -677,9 +677,7 @@ export function ProxmoxBackupServersTable(props: {
})}
>
<TableCell
- class={`${getPlatformTableCellClassForKind('name')} truncate ${
- row.continuesServer ? 'text-muted' : 'text-base-content font-medium'
- }`}
+ class={`${getPlatformTableCellClassForKind('name')} truncate text-base-content font-medium`}
title={[row.serverName, row.datastore?.name].filter(Boolean).join(' · ')}
>
<div class="flex min-w-0 items-center gap-1">
@@ -693,12 +691,17 @@ export function ProxmoxBackupServersTable(props: {
controlsId={detailRowId()}
onToggle={() => detail.toggle(rowIdentity)}
/>
- <ResourceNameWithWebInterfaceLink
- name={row.serverName}
- url={row.resource.customUrl}
- class="min-w-0 flex-1"
- nameClass="block min-w-0 flex-1 truncate"
- />
+ <Show
+ when={!row.continuesServer}
+ fallback={<span class="sr-only">{row.serverName}</span>}
+ >
+ <ResourceNameWithWebInterfaceLink
+ name={row.serverName}
+ url={row.resource.customUrl}
+ class="min-w-0 flex-1"
+ nameClass="block min-w-0 flex-1 truncate"
+ />
+ </Show>
</div>
</TableCell>
<TableCell class={getPlatformTableCellClassForKind('text')}>
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupServersTable.webInterface.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupServersTable.webInterface.test.tsx
index d0392e04f3..2e1afec5fe 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupServersTable.webInterface.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupServersTable.webInterface.test.tsx
@@ -54,7 +54,7 @@ const host: Resource = {
describe('PBS Backups web-interface parity', () => {
it.each([320, 390, 768, 1365])(
- 'uses the service-owned URL on every datastore at width %s without opening details',
+ 'uses the service-owned URL once per server at width %s without opening details',
(width) => {
const ancestorKeydown = vi.fn();
const { container } = render(() => (
@@ -65,7 +65,13 @@ describe('PBS Backups web-interface parity', () => {
const links = within(container).getAllByRole('link', {
name: 'Open web interface for pbs-main',
});
- expect(links).toHaveLength(2);
+ // The second datastore row names no server and repeats no link, so the
+ // two datastores never read as two servers.
+ expect(links).toHaveLength(1);
+ const names = within(container).getAllByText('pbs-main');
+ expect(names).toHaveLength(2);
+ expect(names[0]).not.toHaveClass('sr-only');
+ expect(names[1]).toHaveClass('sr-only');
for (const link of links) {
expect(link).toHaveAttribute('href', 'https://pbs-east.example:8007');
expect(link).toHaveAttribute('target', '_blank');
@@ -100,14 +106,12 @@ describe('PBS Backups web-interface parity', () => {
within(container)
.getAllByRole('link')
.map((a) => a.getAttribute('href'));
- expect(hrefs()).toEqual([east.customUrl, east.customUrl, west.customUrl, west.customUrl]);
+ expect(hrefs()).toEqual([east.customUrl, west.customUrl]);
setServers([
{ ...west, pbs: { ...west.pbs!, datastores: [...west.pbs!.datastores!].reverse() } },
east,
]);
- await waitFor(() =>
- expect(hrefs()).toEqual([east.customUrl, east.customUrl, west.customUrl, west.customUrl]),
- );
+ await waitFor(() => expect(hrefs()).toEqual([east.customUrl, west.customUrl]));
});
it.each([
@@ -123,7 +127,7 @@ describe('PBS Backups web-interface parity', () => {
expect(within(container).queryByRole('link')).not.toBeInTheDocument();
expect(
within(container).getAllByRole('img', { name: 'Web interface URL for pbs-main is invalid' }),
- ).toHaveLength(2);
+ ).toHaveLength(1);
expect(within(container).getAllByText('pbs-main')).toHaveLength(2);
});
@@ -131,7 +135,7 @@ describe('PBS Backups web-interface parity', () => {
const pbs = server();
const [servers, setServers] = createSignal([pbs, host]);
const { container } = render(() => <ProxmoxBackupServersTable servers={servers()} />);
- expect(within(container).getAllByRole('link')).toHaveLength(2);
+ expect(within(container).getAllByRole('link')).toHaveLength(1);
setServers([{ ...pbs, customUrl: 'javascript:alert(1)' }, host]);
await waitFor(() => expect(within(container).queryByRole('link')).not.toBeInTheDocument());
setServers([{ ...pbs, customUrl: '' }, host]);
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
index 5344039403..7fb6e0f2e4 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
@@ -391,12 +391,15 @@ describe('ProxmoxBackupsTable', () => {
return dataRows()[row].querySelectorAll('td')[columns.indexOf(column)].textContent?.trim();
};
- // Two datastores of one server read as one server, not two identical ones:
- // status sits on its first row, and the second row keeps its name and its
- // own datastore figures. Host CPU, memory, uptime and version are in the
- // server's drawer, not the row.
+ // Two datastores of one server read as one server, not two: its name and
+ // status sit on its first row, and the second row shows only its own
+ // datastore figures, naming the server for screen readers alone. Host CPU,
+ // memory, uptime and version are in the server's drawer, not the row.
expect(dataRows()).toHaveLength(2);
- expect(within(table).getAllByText('pbs-main')).toHaveLength(2);
+ const names = within(table).getAllByText('pbs-main');
+ expect(names).toHaveLength(2);
+ expect(names[0]).not.toHaveClass('sr-only');
+ expect(names[1]).toHaveClass('sr-only');
expect(cellText(0, 'status')).not.toBe('');
expect(cellText(1, 'status')).toBe('');
expect(