Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep platform sort focus styling within the production CSP

pulse-triage[bot]829c31fc1450
diff --git a/frontend-modern/src/components/shared/SharedPrimitives.guardrails.test.ts b/frontend-modern/src/components/shared/SharedPrimitives.guardrails.test.ts
index 9d07110e6c..41beeeb06a 100644
--- a/frontend-modern/src/components/shared/SharedPrimitives.guardrails.test.ts
+++ b/frontend-modern/src/components/shared/SharedPrimitives.guardrails.test.ts
@@ -1561,7 +1561,8 @@ describe('shared primitive guardrails', () => {
});
it('keeps platform sort activation native and responsive labels stable at the shared boundary', () => {
- const heading = sharedPlatformPageSource.split('export function PlatformSortableTableHead')[1]!
+ const heading = sharedPlatformPageSource
+ .split('export function PlatformSortableTableHead')[1]!
.split('export const formatPlatformTableTextValue')[0]!;
expect(heading).toContain('scope="col"');
expect(heading).toContain('children(() => props.children)');
diff --git a/frontend-modern/src/features/platformPage/__tests__/PlatformSortableTableHead.test.tsx b/frontend-modern/src/features/platformPage/__tests__/PlatformSortableTableHead.test.tsx
index aac60f023b..893c567933 100644
--- a/frontend-modern/src/features/platformPage/__tests__/PlatformSortableTableHead.test.tsx
+++ b/frontend-modern/src/features/platformPage/__tests__/PlatformSortableTableHead.test.tsx
@@ -59,6 +59,17 @@ afterEach(() => {
});
describe('PlatformSortableTableHead', () => {
+ it('does not recreate or erase responsive heading text when the pointer sort marker changes', async () => {
+ mountTable();
+ const heading = screen.getByRole('columnheader', { name: /Completed/ });
+ const label = heading.querySelector('.platform-table-label-full');
+ for (let i = 0; i < 3; i++) {
+ await fireEvent.click(heading);
+ expect(heading.querySelector('.platform-table-label-full')).toBe(label);
+ expect(heading).toHaveTextContent('Completed');
+ }
+ });
+
it('uses scoped column headings and native, non-submitting sort controls only for sortable columns', () => {
mountTable();
const headings = screen.getAllByRole('columnheader');
@@ -97,13 +108,21 @@ describe('PlatformSortableTableHead', () => {
expect(control).toHaveAccessibleName(/Completed/);
expect(control).not.toHaveAccessibleName(/[▲▼]/);
}
- await fireEvent.click(within(screen.getByRole('columnheader', { name: 'Name' })).getByRole('button'));
+ await fireEvent.click(
+ within(screen.getByRole('columnheader', { name: 'Name' })).getByRole('button'),
+ );
expect(heading).not.toHaveAttribute('aria-sort');
- expect(screen.getByRole('columnheader', { name: /Name/ })).toHaveAttribute('aria-sort', 'ascending');
+ expect(screen.getByRole('columnheader', { name: /Name/ })).toHaveAttribute(
+ 'aria-sort',
+ 'ascending',
+ );
expect(localStorage.getItem('accessibleHeadersSortKey')).toBe('name');
unmount();
mountTable();
- expect(screen.getByRole('columnheader', { name: 'Name' })).toHaveAttribute('aria-sort', 'ascending');
+ expect(screen.getByRole('columnheader', { name: 'Name' })).toHaveAttribute(
+ 'aria-sort',
+ 'ascending',
+ );
expect(names()).toEqual(['alpha', 'bravo', 'unknown']);
});
});
diff --git a/frontend-modern/src/features/platformPage/__tests__/PlatformWindowedRows.test.tsx b/frontend-modern/src/features/platformPage/__tests__/PlatformWindowedRows.test.tsx
index 47fef7e007..eb35b539b8 100644
--- a/frontend-modern/src/features/platformPage/__tests__/PlatformWindowedRows.test.tsx
+++ b/frontend-modern/src/features/platformPage/__tests__/PlatformWindowedRows.test.tsx
@@ -68,7 +68,11 @@ describe('PlatformWindowedRows', () => {
}
body={
<PlatformWindowedRows items={() => sort.sortRows(items, (item) => item.id)}>
- {(item) => <tr data-row-id={item.id}><td>{item.id}</td></tr>}
+ {(item) => (
+ <tr data-row-id={item.id}>
+ <td>{item.id}</td>
+ </tr>
+ )}
</PlatformWindowedRows>
}
/>
@@ -80,7 +84,10 @@ describe('PlatformWindowedRows', () => {
await fireEvent.click(button);
await fireEvent.click(button);
expect(screen.getByRole('columnheader', { name: 'ID' })).toHaveAttribute('scope', 'col');
- expect(screen.getByRole('columnheader', { name: 'ID' })).toHaveAttribute('aria-sort', 'descending');
+ expect(screen.getByRole('columnheader', { name: 'ID' })).toHaveAttribute(
+ 'aria-sort',
+ 'descending',
+ );
expect(button).toHaveFocus();
expect(container.querySelector('[data-row-id]')).toHaveAttribute('data-row-id', '999');
expect(container.querySelectorAll('[data-row-id]')).toHaveLength(140);
diff --git a/frontend-modern/src/features/platformPage/sharedPlatformPage.tsx b/frontend-modern/src/features/platformPage/sharedPlatformPage.tsx
index d24804fb92..ce51f1d8ee 100644
--- a/frontend-modern/src/features/platformPage/sharedPlatformPage.tsx
+++ b/frontend-modern/src/features/platformPage/sharedPlatformPage.tsx
@@ -669,8 +669,7 @@ export function PlatformSortableTableHead<SortKey extends string>(props: {
<Show when={props.sortKey !== undefined} fallback={label()}>
<button
type="button"
- class="min-h-6 w-full min-w-0 cursor-pointer rounded-sm text-inherit focus-visible:outline-hidden focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-sky-400/70"
- style={{ 'text-align': 'inherit' }}
+ class="min-h-6 w-full min-w-0 cursor-pointer rounded-sm text-inherit [text-align:inherit] focus-visible:outline-hidden focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-sky-400/70"
>
{label()}
<span aria-hidden="true">