Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Complete the retained report-intake safety contract and proof

pulse-triage[bot]89b8151f19bd
diff --git a/docs/release-control/v6/internal/subsystems/deployment-installability.md b/docs/release-control/v6/internal/subsystems/deployment-installability.md
index 4fca768883..d2c44168bd 100644
--- a/docs/release-control/v6/internal/subsystems/deployment-installability.md
+++ b/docs/release-control/v6/internal/subsystems/deployment-installability.md
@@ -15,6 +15,25 @@
## Purpose
+### Report intake remains safe without unreleased documentation
+
+The bug and prerelease report forms carry their collection and attachment
+precautions in the form itself. A branch-tip troubleshooting link must not be
+needed to understand the advice for an installed release. Keep live API and
+guest-agent checks distinct from downloading an already displayed result;
+never request another run during backup freeze/thaw or an unresponsive-host
+incident merely to file a report. Existing observations and the original
+sequence remain valid evidence.
+
+Both forms require local privacy review even for exports labelled sanitized,
+and warn against attaching credentials, session cookies, secret URLs, private
+host/network or personal details, configuration files and raw request exports.
+Removing or pinning a documentation link must not remove those precautions or
+turn evidence fields into mandatory live checks. The form parsing controls in
+`scripts/release_control/release_promotion_policy_test.py` and the existing
+community intake tests preserve this installed-version-safe behaviour; they
+are source checks, not native diagnostic, guest-thaw or release acceptance.
+
### Update History consent does not infer the backup's restore scope
The confirmation names the observed running server separately from the selected
diff --git a/scripts/release_control/release_promotion_policy_test.py b/scripts/release_control/release_promotion_policy_test.py
index 1bb96bed8f..30ad279d10 100644
--- a/scripts/release_control/release_promotion_policy_test.py
+++ b/scripts/release_control/release_promotion_policy_test.py
@@ -1756,6 +1756,40 @@ class ReleasePromotionPolicyTest(unittest.TestCase):
self.assertIn("I upgraded to the current v6 RC build", template)
self.assertNotIn("v6.0.0-rc.1", template)
+ def test_report_intake_safety_is_self_contained_for_installed_releases(self) -> None:
+ for name in ("bug_report.yml", "v6_rc_feedback.yml"):
+ with self.subTest(form=name):
+ template = read(f".github/ISSUE_TEMPLATE/{name}")
+ form = yaml.safe_load(template)
+ introduction = form["body"][0]
+ self.assertEqual(introduction["type"], "markdown")
+ prose = introduction["attributes"]["value"]
+ self.assertNotRegex(
+ template,
+ r"https://github\.com/[^/\s)]+/[^/\s)]+/(?:blob|tree)/(?:main|master)/",
+ )
+ # The precautions must survive without following any link;
+ # putting them only in a link label is insufficient.
+ standalone = re.sub(r"\[[^\]]+\]\([^)]*\)", "", prose)
+ for precaution in (
+ "only collect diagnostics if Pulse is running and collection is safe",
+ "live API and guest-agent requests",
+ "do not run it during backups, freeze/thaw or an unresponsive-host incident",
+ "Prefer existing observations",
+ "downloads that result without running checks again",
+ "Review files and screenshots locally before posting",
+ "even when an export is labelled",
+ "session cookies",
+ "secret URLs",
+ "personal details",
+ "private keys",
+ "Copy as cURL",
+ "full network exports",
+ ):
+ self.assertIn(precaution, standalone)
+ evidence = next(field for field in form["body"] if field.get("id") == "evidence")
+ self.assertFalse(evidence.get("validations", {}).get("required", False))
+
def test_demo_site_copy_points_at_current_release_packet_index(self) -> None:
demo_copy = read("docs/releases/V6_RC_DEMO_SITE_COPY.md")
self.assertIn("docs/RELEASE_NOTES.md", demo_copy)