Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Avoid redundant wrappers in Coverage point rendering

pulse-triage[bot]8dfc1c2e3985
diff --git a/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx b/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx
index b8b0d896eb..f8be7ee734 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxCoverageTable.tsx
@@ -466,18 +466,14 @@ const buildCoverageDetailSections = (row: WorkloadCoverageRow): DetailSection[]
// Several points can share a reader, location and rounded age. Preserve the
// point's own identifier and full metadata in the open evidence at every width;
// a hidden Details column or hover-only volume cannot identify it on a phone.
-function CoverageRestorePointDetails(props: { artifact: RecoverableArtifact }) {
+function coverageRestorePointDetails(artifact: RecoverableArtifact) {
return (
<div
class="block whitespace-normal text-muted leading-snug wrap-anywhere"
data-coverage-evidence-detail
>
- <span class="block" data-coverage-evidence-identifier>
- Identifier: {props.artifact.nativeId}
- </span>
- <span class="mt-1 block" data-coverage-evidence-metadata>
- Metadata: {props.artifact.detailTitle || props.artifact.detail}
- </span>
+ <span class="block">Identifier: {artifact.nativeId}</span>
+ <span class="mt-1 block">Metadata: {artifact.detailTitle || artifact.detail}</span>
</div>
);
}
@@ -1065,7 +1061,7 @@ export function ProxmoxCoverageTable(props: {
)
}
>
- <CoverageRestorePointDetails artifact={artifact} />
+ {coverageRestorePointDetails(artifact)}
</Show>
</TableCell>
<Show
@@ -1128,7 +1124,7 @@ export function ProxmoxCoverageTable(props: {
<TableCell
class={`${getPlatformTableCellClassForKind('text')} text-base-content`}
>
- <CoverageRestorePointDetails artifact={artifact} />
+ {coverageRestorePointDetails(artifact)}
</TableCell>
</Show>
</TableRow>
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxCoverageTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxCoverageTable.test.tsx
index ab2f212fa4..302c8514e3 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxCoverageTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxCoverageTable.test.tsx
@@ -620,10 +620,10 @@ describe('ProxmoxCoverageTable column visibility', () => {
);
// An age/source pair is not the point's identity. The open evidence keeps
// the full identifier and metadata readable rather than only on hover.
- expect(panel.querySelector('[data-coverage-evidence-identifier]')).toHaveTextContent(
+ expect(panel.querySelector('[data-coverage-evidence-detail] > :first-child')).toHaveTextContent(
'Identifier: pbs-1',
);
- expect(panel.querySelector('[data-coverage-evidence-metadata]')).toHaveTextContent(
+ expect(panel.querySelector('[data-coverage-evidence-detail] > :last-child')).toHaveTextContent(
'Metadata: vm/100/2026-07-18T23:00:00Z',
);
// The source label wraps in the drawer too; a long snapshot name is not cut.
diff --git a/frontend-modern/src/features/proxmox/__tests__/coverageRestorePointIdentity.test.tsx b/frontend-modern/src/features/proxmox/__tests__/coverageRestorePointIdentity.test.tsx
index cf6bae08ee..cfb361872d 100644
--- a/frontend-modern/src/features/proxmox/__tests__/coverageRestorePointIdentity.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/coverageRestorePointIdentity.test.tsx
@@ -121,15 +121,17 @@ describe('Coverage restore-point identity through parsed inventory', () => {
];
for (const [id, metadata] of expected) {
const row = rows.find((candidate) =>
- candidate.querySelector('[data-coverage-evidence-identifier]')?.textContent?.includes(id),
+ candidate
+ .querySelector('[data-coverage-evidence-detail] > :first-child')
+ ?.textContent?.includes(id),
)!;
expect(row).toBeDefined();
- expect(row.querySelector('[data-coverage-evidence-identifier]')).toHaveTextContent(
- `Identifier: ${id}`,
- );
- expect(row.querySelector('[data-coverage-evidence-metadata]')).toHaveTextContent(
- `Metadata: ${metadata}`,
- );
+ expect(
+ row.querySelector('[data-coverage-evidence-detail] > :first-child'),
+ ).toHaveTextContent(`Identifier: ${id}`);
+ expect(
+ row.querySelector('[data-coverage-evidence-detail] > :last-child'),
+ ).toHaveTextContent(`Metadata: ${metadata}`);
expect(row.querySelector('[data-coverage-evidence-detail]')).toHaveClass(
'whitespace-normal',
'wrap-anywhere',