Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.
Go aialertsdashboarddockerdocker-monitoringgohomelabinfrastructure-monitoringkubernetesmonitoringmspproxmoxproxmox-backup-serverproxmox-mail-gatewayproxmox-veself-hostedtruenastypescriptvspherewebhooks
Keep the real ZIP extraction limit without expensive fixture compression
pulse-triage[bot]8e203020412f
diff --git a/internal/api/unified_agent_zip_branchcov0723am_test.go b/internal/api/unified_agent_zip_branchcov0723am_test.goindex df64937f0a..4475b575b9 100644--- a/internal/api/unified_agent_zip_branchcov0723am_test.go+++ b/internal/api/unified_agent_zip_branchcov0723am_test.go@@ -4,6 +4,7 @@ import ("archive/zip""bytes""encoding/binary"+ "io""strings""testing")@@ -36,6 +37,33 @@ func buildZipBytes0723Am(t *testing.T, entries ...zipEntry0723Am) []byte {return buf.Bytes()}+type zeroReader0723Am struct{}++func (zeroReader0723Am) Read(p []byte) (int, error) {+ clear(p)+ return len(p), nil+}++// Keep the real extraction boundary without spending the race suite's budget+// deflating 100 MiB of identical bytes. Other fixtures still cover Deflate.+// Streaming the stored entry also avoids allocating a second full-size input.+func buildStoredSizeZip0723Am(t *testing.T, name string, size int64) []byte {+ t.Helper()+ var buf bytes.Buffer+ zw := zip.NewWriter(&buf)+ w, err := zw.CreateHeader(&zip.FileHeader{Name: name, Method: zip.Store})+ if err != nil {+ t.Fatalf("create stored zip entry: %v", err)+ }+ if n, err := io.CopyN(w, zeroReader0723Am{}, size); err != nil || n != size {+ t.Fatalf("write stored zip entry: wrote %d, want %d, error %v", n, size, err)+ }+ if err := zw.Close(); err != nil {+ t.Fatalf("close stored zip: %v", err)+ }+ return buf.Bytes()+}+// zipLocalHeaderDataOffset0723Am parses the first local file header of archive// and returns the byte offset where that entry's compressed data begins.func zipLocalHeaderDataOffset0723Am(t *testing.T, archive []byte) int {@@ -192,10 +220,7 @@ func TestBranchcov0723AmExtractFromZip(t *testing.T) {})t.Run("oversized_entry_returns_size_limit_error", func(t *testing.T) {- // Deflate compresses all-zero content to a few KB, so the archive stays- // small while the decompressed entry exceeds maxAgentBinarySize.- big := bytes.Repeat([]byte{0}, maxAgentBinarySize+1)- archive := buildZipBytes0723Am(t, zipEntry0723Am{name: "pulse-agent.exe", content: big})+ archive := buildStoredSizeZip0723Am(t, "pulse-agent.exe", maxAgentBinarySize+1)got, err := extractFromZip(archive, "pulse-agent.exe")if err == nil {t.Fatalf("expected size-limit error, got %d bytes", len(got))