Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep unread PBS backup counts legible at intermediate widths

pulse-triage[bot]9091994283d1
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index f6c90af88a..27a8bcc734 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -20,6 +20,24 @@
## Purpose
+### Backup-server read states remain legible at intermediate widths
+
+The existing PBS server table reserves enough count-column width for the full
+Loading and Unavailable labels, not only numeric counts, at basic, operational
+and expanded container widths. The shared 30% basic identity anchor, visible
+columns, 32px scan rhythm, independent connection/capacity evidence and full
+layout remain unchanged. Datastore names keep their existing truncation, title
+and detail access; no identity, count, polling, read/retry or protection rule
+changes. An unread inventory still never establishes a real zero.
+
+Normal-suite `proxmoxBackupsTablePresentation.test.ts` verifies width allocation
+and complete column totals; the registered `ProxmoxBackupsTable.test.tsx`
+exercises actual loading/failure/accepted-empty cells with independent healthy
+capacity. Browser proof must inspect the consuming table at desktop, phone and
+intermediate container boundaries, including loading, failure, retry, real zero,
+ordinary polling and native detail interactions. This is readable inspection,
+not installed or original guest recovery.
+
### PBS server counts belong to the exact backup reader and datastore
The existing Backups server count matches `PBSBackup.instance` to the resource's
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index dd54ea71ab..84d6fd037b 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -21,6 +21,24 @@
## Purpose
+### Backup-server read states remain legible at intermediate widths
+
+The existing PBS server table reserves enough count-column width for the full
+Loading and Unavailable labels, not only numeric counts, at basic, operational
+and expanded container widths. The shared 30% basic identity anchor, visible
+columns, 32px scan rhythm, independent connection/capacity evidence and full
+layout remain unchanged. Datastore names keep their existing truncation, title
+and detail access; no identity, count, polling, read/retry or protection rule
+changes. An unread inventory still never establishes a real zero.
+
+Normal-suite `proxmoxBackupsTablePresentation.test.ts` verifies width allocation
+and complete column totals; the registered `ProxmoxBackupsTable.test.tsx`
+exercises actual loading/failure/accepted-empty cells with independent healthy
+capacity. Browser proof must inspect the consuming table at desktop, phone and
+intermediate container boundaries, including loading, failure, retry, real zero,
+ordinary polling and native detail interactions. This is readable inspection,
+not installed or original guest recovery.
+
### PBS server counts belong to the exact backup reader and datastore
The existing Backups server count matches `PBSBackup.instance` to the resource's
diff --git a/docs/release-control/v6/internal/subsystems/unified-resources.md b/docs/release-control/v6/internal/subsystems/unified-resources.md
index 102a1d9d72..cff99d07d2 100644
--- a/docs/release-control/v6/internal/subsystems/unified-resources.md
+++ b/docs/release-control/v6/internal/subsystems/unified-resources.md
@@ -23,6 +23,24 @@ and sort the complete canonical change table while startup and ingestion wait.
## Purpose
+### Backup-server read states remain legible at intermediate widths
+
+The existing PBS server table reserves enough count-column width for the full
+Loading and Unavailable labels, not only numeric counts, at basic, operational
+and expanded container widths. The shared 30% basic identity anchor, visible
+columns, 32px scan rhythm, independent connection/capacity evidence and full
+layout remain unchanged. Datastore names keep their existing truncation, title
+and detail access; no identity, count, polling, read/retry or protection rule
+changes. An unread inventory still never establishes a real zero.
+
+Normal-suite `proxmoxBackupsTablePresentation.test.ts` verifies width allocation
+and complete column totals; the registered `ProxmoxBackupsTable.test.tsx`
+exercises actual loading/failure/accepted-empty cells with independent healthy
+capacity. Browser proof must inspect the consuming table at desktop, phone and
+intermediate container boundaries, including loading, failure, retry, real zero,
+ordinary polling and native detail interactions. This is readable inspection,
+not installed or original guest recovery.
+
### PBS server counts belong to the exact backup reader and datastore
The existing Backups server count matches `PBSBackup.instance` to the resource's
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
index 26fe7b840a..6258f808ad 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
@@ -12,7 +12,7 @@ import {
identitySnapshot,
identityTask,
} from '../__fixtures__/backupIdentity';
-import { buildBackupServerRows } from '../ProxmoxBackupServersTable';
+import { buildBackupServerRows, ProxmoxBackupServersTable } from '../ProxmoxBackupServersTable';
import proxmoxBackupServersTableSource from '../ProxmoxBackupServersTable.tsx?raw';
import proxmoxBackupsTableSource from '../ProxmoxBackupsTable.tsx?raw';
import proxmoxPageSurfaceSource from '../ProxmoxPageSurface.tsx?raw';
@@ -3340,3 +3340,49 @@ describe('By date recovery evidence limits', () => {
expect(apiFetchMock).toHaveBeenCalledTimes(10);
});
});
+
+describe('PBS inventory state column', () => {
+ it('reserves readable count space without changing loading, failure or real zero', () => {
+ const [state, setState] = createSignal<'loading' | 'unavailable' | 'available'>('loading');
+ const { container } = render(() => (
+ <ProxmoxBackupServersTable
+ servers={[
+ {
+ id: 'pbs-readable',
+ name: 'main',
+ displayName: 'main',
+ type: 'pbs',
+ status: 'online',
+ lastSeen: BACKUP_IDENTITY_NOW,
+ platformId: 'proxmox-pbs',
+ platformType: 'proxmox-pbs',
+ sourceType: 'api',
+ pbs: {
+ instanceId: 'pbs-main',
+ connectionHealth: 'healthy',
+ datastores: [{ name: 'tank', total: 1000, used: 400 }],
+ },
+ },
+ ]}
+ backups={[]}
+ backupInventoryState={state()}
+ layoutWidth={() => 520}
+ />
+ ));
+ const table = container.querySelector('table')!;
+ const countColumn = table.querySelector<HTMLElement>(
+ 'col[data-proxmox-backups-column="backups"]',
+ )!;
+ const cells = table.querySelector('tbody tr')!.querySelectorAll('td');
+ expect(countColumn.style.width).toBe('15.5%');
+ expect(cells[4]).toHaveTextContent(/^Loading$/);
+ setState('unavailable');
+ expect(cells[4]).toHaveTextContent(/^Unavailable$/);
+ expect(cells[1]).toHaveTextContent('Healthy');
+ expect(cells[3]).toHaveTextContent('40.0%');
+ expect(cells[3]).toHaveTextContent('400 B / 1000 B');
+ setState('available');
+ expect(cells[4]).toHaveTextContent(/^0$/);
+ expect(countColumn.style.width).toBe('15.5%');
+ });
+});
diff --git a/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupsTablePresentation.test.ts b/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupsTablePresentation.test.ts
index bf281fc88b..7f60245720 100644
--- a/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupsTablePresentation.test.ts
+++ b/frontend-modern/src/features/proxmox/__tests__/proxmoxBackupsTablePresentation.test.ts
@@ -70,6 +70,25 @@ describe('Proxmox backups responsive table presentation', () => {
expect(ids(getBackupServerColumns('full'))).toHaveLength(10);
});
+ it.each([
+ ['basic', '15.5%'],
+ ['operational', '12%'],
+ ['expanded', '10.5%'],
+ ['full', '8%'],
+ ] as const)(
+ 'reserves room for nonnumeric inventory states in %s count cells',
+ (layout, width) => {
+ expect(getBackupServerColumnWidthStyle('backups', layout)).toEqual({ width });
+ const total = getBackupServerColumns(layout).reduce(
+ (sum, column) =>
+ sum +
+ Number.parseFloat(getBackupServerColumnWidthStyle(column.id, layout).width as string),
+ 0,
+ );
+ expect(total).toBeCloseTo(100, 3);
+ },
+ );
+
it('prioritizes workload posture, restore freshness, and task failures in coverage', () => {
const withTasks = { task: true };
expect(ids(getCoverageColumns('compact', withTasks))).toEqual([
diff --git a/frontend-modern/src/features/proxmox/proxmoxBackupsTablePresentation.ts b/frontend-modern/src/features/proxmox/proxmoxBackupsTablePresentation.ts
index b1a159535a..17224da68e 100644
--- a/frontend-modern/src/features/proxmox/proxmoxBackupsTablePresentation.ts
+++ b/frontend-modern/src/features/proxmox/proxmoxBackupsTablePresentation.ts
@@ -101,17 +101,19 @@ const BACKUP_SERVER_WEIGHTS: Record<
// Capacity must fit "Unavailable", not just a short percentage. Keep the
// shared 40% identity anchor; the compact status omits its redundant dot.
compact: { server: 40, status: 18, datastore: 17, used: 25 },
- // Just above the phone projection the used cell carries its used/total
- // pair again, the longest value in the row, so it takes the most room.
- basic: { server: 24, status: 13.6, datastore: 18.2, used: 28.4, backups: 9.8 },
+ // Count must fit Loading and Unavailable, not just a short number. Keep
+ // reachability and the used/total pair; datastore names already disclose
+ // their full value on hover and in the existing detail. The 30% identity
+ // anchor below still owns the server column in this band.
+ basic: { server: 30, status: 13.6, datastore: 14, used: 26.9, backups: 15.5 },
operational: {
server: 20,
status: 12,
cpu: 10,
memory: 12,
- datastore: 16,
+ datastore: 14,
used: 20,
- backups: 10,
+ backups: 12,
},
expanded: {
server: 18,
@@ -119,9 +121,9 @@ const BACKUP_SERVER_WEIGHTS: Record<
cpu: 8,
memory: 11,
uptime: 9,
- datastore: 16,
+ datastore: 14.5,
used: 18,
- backups: 9,
+ backups: 10.5,
},
// Memory and Used carry a percentage plus a used/total pair, the longest
// values in the row, so they take the slack from the one-word status and