Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Merge remote-tracking branch 'origin/fix/alert-handover-resolution' into fix/moved-alert-in-app

rcourtman91575a285e8f
diff --cc docs/release-control/v6/internal/subsystems/notifications.md
index 68bb4dcd5c,0afc28d582..ea89a97ca6
--- a/docs/release-control/v6/internal/subsystems/notifications.md
+++ b/docs/release-control/v6/internal/subsystems/notifications.md
@@@ -1229,20 -1229,19 +1229,25 @@@ receives `resolve` for the alert's dedu
agent for the current reading.") in place of "<resource> on <node> is now
healthy" for every templated webhook `.Message`. Grouped lists append the
short outcome ("moved to pve1 (Host Agent)") to the moved entry. ntfy titles a
- single moved alert `MOVED: <resource>` and swaps the green check tag for
- `arrow_right`. Email and Apprise title it `Pulse alert moved: <resource>` and
- add the summary after the breach message. The resolution rides the Alert JSON,
- so it survives the delivery queue round trip and appears in the default JSON
- payload's `alerts` array. Built-in template titles still say Resolved, which is
- accurate for the closed alert, and a custom template that hard-codes recovery
- text keeps it. Issue #1682 is the precedent: a recipient called "is now
- healthy" a false factual claim when an alert closed without recovering.
+ single moved alert `MOVED: <resource>`. Email and Apprise title it `Pulse alert
+ moved: <resource>` and add the summary after the breach message. Recovery
+ visuals follow the same rule: when any close in a resolved delivery was not a
+ recovery, `WebhookPayloadData.NotRecovered` is set and the built-in templates
+ drop them (Discord's green embed becomes the neutral blue, both Teams cards
+ lose recovery green, Mattermost's check emoji becomes `:arrow_right:`), and
+ ntfy swaps its green check tag for `arrow_right`, for a single alert or a batch.
+ Built-in titles still say Resolved, which is accurate for the closed alert;
+ custom templates can read `.NotRecovered`, and one that hard-codes recovery
+ text keeps it. The resolution rides the Alert JSON, so it survives the delivery
+ queue round trip and appears in the default JSON payload's `alerts` array.
+ Issue #1682 is the precedent: a recipient called "is now healthy" a false
+ factual claim when an alert closed without recovering.
+The resolve transition such a close links to has cause `ownership_transferred`
+in `internal/operationaltrust/contracts.go`, not `recovery_evidence`. A
+notification link records the transition ID and lifecycle state, never the
+cause, so delivery, receipts and recovery admission treat it exactly like a
+recovery's resolve transition. `TestOwnershipTransferOnlyClosesWithEvidence`
+pins that the cause may only enter `resolved` and only with evidence.
Verification: `resolved_handover_test.go` drives the firing, its receipt and
the queued close through the normal entry points for ntfy, and renders Discord,