Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Declare the Kubernetes documentation YAML parser directly

pulse-triage[bot]91d5ff81da8c
diff --git a/frontend-modern/package-lock.json b/frontend-modern/package-lock.json
index 1cd4038f16..fd3c186895 100644
--- a/frontend-modern/package-lock.json
+++ b/frontend-modern/package-lock.json
@@ -31,6 +31,7 @@
"eslint-config-prettier": "^10.0.0",
"eslint-plugin-solid": "^0.18.1",
"globals": "^17.13.0",
+ "js-yaml": "^4.3.2",
"jscpd": "^5.4.2",
"jsdom": "^24.1.0",
"prettier": "3.9.10",
@@ -2496,6 +2497,13 @@
"url": "https://github.com/chalk/ansi-styles?sponsor=1"
}
},
+ "node_modules/argparse": {
+ "version": "2.0.1",
+ "resolved": "https://registry.npmjs.org/argparse/-/argparse-2.0.1.tgz",
+ "integrity": "sha512-8+9WqebbFzpX9OR+Wa6O29asIogeRMzcGtAINdpMHHyAg10f05aSFVBbcEqGf/PXw1EjAZ+q2/bEBg3DvurK3Q==",
+ "dev": true,
+ "license": "Python-2.0"
+ },
"node_modules/aria-query": {
"version": "5.3.0",
"resolved": "https://registry.npmjs.org/aria-query/-/aria-query-5.3.0.tgz",
@@ -3873,6 +3881,29 @@
"dev": true,
"license": "MIT"
},
+ "node_modules/js-yaml": {
+ "version": "4.3.2",
+ "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-4.3.2.tgz",
+ "integrity": "sha512-SFNOvSJ+Dgf/9An904Yx+CgSlIPCkIpao4qo51lpee25TIRejdH3rhR4EZMGoNx3/TP3O+wzWuiTFl4sqbltzA==",
+ "dev": true,
+ "funding": [
+ {
+ "type": "github",
+ "url": "https://github.com/sponsors/puzrin"
+ },
+ {
+ "type": "github",
+ "url": "https://github.com/sponsors/nodeca"
+ }
+ ],
+ "license": "MIT",
+ "dependencies": {
+ "argparse": "^2.0.1"
+ },
+ "bin": {
+ "js-yaml": "bin/js-yaml.js"
+ }
+ },
"node_modules/jscpd": {
"version": "5.4.2",
"resolved": "https://registry.npmjs.org/jscpd/-/jscpd-5.4.2.tgz",
diff --git a/frontend-modern/package.json b/frontend-modern/package.json
index b1ad0be936..ade27d635f 100644
--- a/frontend-modern/package.json
+++ b/frontend-modern/package.json
@@ -85,6 +85,7 @@
"eslint-config-prettier": "^10.0.0",
"eslint-plugin-solid": "^0.18.1",
"globals": "^17.13.0",
+ "js-yaml": "^4.3.2",
"jscpd": "^5.4.2",
"jsdom": "^24.1.0",
"prettier": "3.9.10",
diff --git a/frontend-modern/src/features/docs/__tests__/kubernetesSetupDocs.test.ts b/frontend-modern/src/features/docs/__tests__/kubernetesSetupDocs.test.ts
index c78c7bd208..07a84d52ab 100644
--- a/frontend-modern/src/features/docs/__tests__/kubernetesSetupDocs.test.ts
+++ b/frontend-modern/src/features/docs/__tests__/kubernetesSetupDocs.test.ts
@@ -9,8 +9,8 @@ const frontendRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)),
const repoRoot = path.resolve(frontendRoot, '..');
const readDoc = (name: string) => readFileSync(path.join(repoRoot, 'docs', `${name}.md`), 'utf8');
const guide = readDoc('KUBERNETES');
-// js-yaml is already in the committed lint/build graph. Parse the copied YAML,
-// rather than accepting a permissions sentence elsewhere in the guide.
+// js-yaml is an explicit test dependency, not an incidental ESLint dependency.
+// Parse the copied YAML rather than accepting a permissions sentence elsewhere.
const yaml = createRequire(import.meta.url)('js-yaml') as {
loadAll: (text: string) => unknown[];
};
diff --git a/frontend-modern/src/security/__tests__/dependencySecurity.test.ts b/frontend-modern/src/security/__tests__/dependencySecurity.test.ts
index 8a1d3bd7fb..7b64047950 100644
--- a/frontend-modern/src/security/__tests__/dependencySecurity.test.ts
+++ b/frontend-modern/src/security/__tests__/dependencySecurity.test.ts
@@ -150,10 +150,12 @@ describe('frontend dependency security floors', () => {
it('keeps every js-yaml copy above the empty-merge CPU exhaustion floor', () => {
// GHSA-2883-xcg3-v3hh: our override keeps every transitive copy on patched 4.x.
- // ESLint's flat-config graph no longer needs the legacy YAML consumer.
- // Removing that dependency is safe; any copy that returns still needs the fix.
+ // The Kubernetes docs tests parse the actual copied RBAC YAML. Declare that
+ // consumer directly instead of relying on legacy ESLint's transitive copy.
+ expect(manifest.devDependencies['js-yaml']).toBe('^4.3.2');
expect(manifest.overrides['js-yaml']).toBe('^4.3.2');
const versions = lockedVersions('js-yaml');
+ expect(versions, 'the Kubernetes docs parser must be installed').not.toHaveLength(0);
for (const version of versions) {
expect(version).not.toContain('-');
expect(atLeast(version, [4, 3, 2]), `js-yaml ${version} is vulnerable`).toBe(true);