Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Compose published Overview charts with reviewed reading safeguards

pulse-triage[bot]920ff6102a0b
diff --cc docs/VM_DISK_MONITORING.md
index fe61cdf2a2,03cdde5b61..fbcf8323e3
--- a/docs/VM_DISK_MONITORING.md
+++ b/docs/VM_DISK_MONITORING.md
@@@ -313,15 -313,12 +313,16 @@@ custom monitoring role if the required
### Current, retained and unavailable disk readings
- In **Workloads**, select the disk reading indicator for its explanation, or
-In **Workloads**, hover the disk cell for its explanation or open the guest's
-details and look under **Filesystems → Status**. A retained reading is labelled
-**Last known** (**Prior** in compact rows). A reading Pulse could not take shows
-a dash; only a read you can fix is labelled, **No permission** or **Agent error**
-(**Denied** or **Error** in compact rows). Where an observation time is shown,
-keep it with the reading; an unavailable time leaves freshness unknown.
++In **Workloads**, select a visible disk reading indicator for its explanation, or
+open the same guest's details and look under **Filesystems → Status**. Use the
+details on a phone or with a keyboard rather than relying on a hover tooltip.
+Retained readings use **Prior** in compact rows and **Last known** in wider rows.
- An unavailable reading may show a dash or an unavailable label: the presence or
- absence of a caption does not establish freshness or explain the cause. Read
++Unavailable readings show a dash; fixable errors also show **No permission** or
++**Agent error** (**Denied** or **Error** in compact rows). A missing caption does
++not establish freshness or explain the cause. Read
+the same guest's explanation before treating it as an agent setup problem.
+Where an observation time is shown, keep it with the reading; an unavailable
+time leaves freshness unknown.
| Reading | What it establishes |
| --- | --- |
diff --cc docs/release-control/v6/internal/subsystems/frontend-primitives.md
index 1c832b3192,3cf539efc4..decd8a73d7
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@@ -8817,32 -8799,33 +8857,47 @@@ return, active state, badges, and narro
The Proxmox node drawer presents checked zero, current positive, stale,
unavailable, and not-checked package evidence as a labelled detail row with
bounded copy and checked time. The compact table badge remains reserved for a
-current positive observation. Provider errors are never rendered. An
-unavailable check whose reason is `permission_denied` reads neutral, so the
-node Overview keeps it in Details rather than Worth checking: Proxmox gates the
-package list on `Sys.Modify`, and `docs/TROUBLESHOOTING.md` calls keeping the
-narrower monitoring role a valid choice. Other unavailable reasons stay warnings.
-Node Details rows wrap their values (`wrap: true`) rather than truncating them,
-because Details is where a reader goes for the full value: the update reason,
-the linked agent ID and the CPU model read whole at desktop and phone widths. Component
-and browser evidence covers both 1440px and 390px layouts in
-`NodeDrawerOverview.updateEvidence.test.tsx`, `ProxmoxNodesTable.test.tsx`, and
-`frontend-modern/browser-verification.json`.
+current positive observation. Provider errors are never rendered. Component
+evidence is covered by `NodeDrawerOverview.updateEvidence.test.tsx`,
+`proxmoxUpdateEvidence.test.ts`, and `ProxmoxNodesTable.test.tsx`.
+
+Denied update-list access exposes visible guidance beside that status through
+the shared HelpIcon and help-content registry. It explains that inventory and
+metrics use separate permission checks, preserves the choice to monitor with
+read-only access, and describes Sys.Modify as broader access that also permits
+refreshing package indexes. A denied response does not establish the exact
+missing privilege or an empty update list. Status text wraps through the shared
+detail-row contract at phone widths, including retained counts and checked time.
+The operator-context section and its help control retain their identity while
+readings and relative timestamps update. The shared help dialog remains inside
+the viewport with scrollable content, keyboard dismissal and focus return.
+Current-source browser receipts under `frontend-modern/browser-verification/`
+cover desktop, intermediate, phone and short landscape layouts. These checks
+establish presentation and interaction, not installed Proxmox permissions or
+released acceptance.
+
+An unavailable update check whose reason is `permission_denied` reads neutral,
+so it remains in Details rather than Worth checking. Other unavailable reasons
+stay warnings. Node Details values wrap rather than truncate. This preserves
+full reasons, agent IDs and CPU models at desktop and phone widths.
+
+
+ Denied update-list access exposes visible guidance beside that status through
+ the shared HelpIcon and help-content registry. It explains that inventory and
+ metrics use separate permission checks, preserves the choice to monitor with
+ read-only access, and describes Sys.Modify as broader access that also permits
+ refreshing package indexes. A denied response does not establish the exact
+ missing privilege or an empty update list. Status text wraps through the shared
+ detail-row contract at phone widths, including retained counts and checked time.
+ The Summary section owns its help control while
+ readings and relative timestamps update. The shared help dialog remains inside
+ the viewport with scrollable content, keyboard dismissal and focus return.
+ Current-source browser receipts under `frontend-modern/browser-verification/`
+ cover desktop, intermediate, phone and short landscape layouts. These checks
+ establish presentation and interaction, not installed Proxmox permissions or
+ released acceptance.
+
### Docker drawers expose reduced helper coverage without actions
The Docker host drawer consumes the canonical optional `collectionMode` field.
diff --cc docs/release-control/v6/internal/subsystems/performance-and-scalability.md
index a96ea0c2b9,bb7beb15bb..2751a73111
--- a/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
+++ b/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
@@@ -364,11 -327,11 +370,13 @@@ proof, not a native CPU improvement, QG
### Guest filesystem provenance preserves dense row geometry
- Visible retained/unavailable filesystem cues must fit the existing dense row
+ Visible retained and fixable-read filesystem cues must fit the existing dense row
-rhythm (an unavailable setup-gap read adds no visible cue at all), including canonical phone/narrow column weights, without adding a new
-collector, history request, layout observer, focus target or event path. Keep
-compact copy on narrow rows and the full safe reason in assistive text and the
-existing drawer. Inline sparkline plots may shrink to preserve their numeric
+rhythm, including canonical phone/narrow column weights, without adding a new
+collector, history request or layout observer. Keep compact copy on narrow rows
+and the full safe reason in assistive text, the existing drawer and the
- read-only reading disclosure described below. Inline sparkline plots may shrink to preserve their numeric
++read-only reading disclosure described below. Setup-gap and stopped-guest reads
++keep their explanation in the cell title, assistive text and drawer rather than
++repeating the empty reading with another visible caption. Inline sparkline plots may shrink to preserve their numeric
value within the already assigned column; do not add forced minimum widths,
observers or a larger row to compensate. The cue stays outside the
bars/sparkline/history-lens branch, so changing display mode cannot discard freshness information; removing it
diff --cc frontend-modern/public/docs/VM_DISK_MONITORING.md
index fe61cdf2a2,03cdde5b61..fbcf8323e3
--- a/frontend-modern/public/docs/VM_DISK_MONITORING.md
+++ b/frontend-modern/public/docs/VM_DISK_MONITORING.md
@@@ -313,15 -313,12 +313,16 @@@ custom monitoring role if the required
### Current, retained and unavailable disk readings
- In **Workloads**, select the disk reading indicator for its explanation, or
-In **Workloads**, hover the disk cell for its explanation or open the guest's
-details and look under **Filesystems → Status**. A retained reading is labelled
-**Last known** (**Prior** in compact rows). A reading Pulse could not take shows
-a dash; only a read you can fix is labelled, **No permission** or **Agent error**
-(**Denied** or **Error** in compact rows). Where an observation time is shown,
-keep it with the reading; an unavailable time leaves freshness unknown.
++In **Workloads**, select a visible disk reading indicator for its explanation, or
+open the same guest's details and look under **Filesystems → Status**. Use the
+details on a phone or with a keyboard rather than relying on a hover tooltip.
+Retained readings use **Prior** in compact rows and **Last known** in wider rows.
- An unavailable reading may show a dash or an unavailable label: the presence or
- absence of a caption does not establish freshness or explain the cause. Read
++Unavailable readings show a dash; fixable errors also show **No permission** or
++**Agent error** (**Denied** or **Error** in compact rows). A missing caption does
++not establish freshness or explain the cause. Read
+the same guest's explanation before treating it as an agent setup problem.
+Where an observation time is shown, keep it with the reading; an unavailable
+time leaves freshness unknown.
| Reading | What it establishes |
| --- | --- |
diff --cc frontend-modern/src/components/Workloads/GuestRow.tsx
index d0c3c2637c,3a723c4732..0ef546b08e
--- a/frontend-modern/src/components/Workloads/GuestRow.tsx
+++ b/frontend-modern/src/components/Workloads/GuestRow.tsx
@@@ -659,13 -721,25 +723,24 @@@ export function GuestRow(props: GuestRo
</Show>
<Show when={memoryReadStatus()}>
{(status) => (
- <WorkloadReadingStatus
- metric="Memory"
- guestId={guestId()}
- guestName={props.guest.name}
- label={status().label}
- message={status().message}
- />
+ <Show
+ when={status().label}
+ fallback={
+ <span data-workload-memory-read-status class="sr-only">
+ {status().message}
+ </span>
+ }
+ >
+ {(label) => (
- <p
- data-workload-memory-read-status
- class="mt-0.5 text-center text-[10px] leading-none text-muted"
- title={status().message}
- >
- <span aria-hidden="true">{label()}</span>
- <span class="sr-only">{status().message}</span>
- </p>
++ <WorkloadReadingStatus
++ metric="Memory"
++ guestId={guestId()}
++ guestName={props.guest.name}
++ label={label()}
++ message={status().message}
++ />
+ )}
+ </Show>
)}
</Show>
</td>
@@@ -713,14 -787,27 +788,25 @@@
</Show>
<Show when={diskReadStatus()}>
{(status) => (
- <WorkloadReadingStatus
- metric="Disk"
- guestId={guestId()}
- guestName={props.guest.name}
- label={status().label}
- message={status().message}
- needsAction={status().needsAction}
- />
+ <Show
+ when={status().label}
+ fallback={
+ <span data-workload-disk-read-status class="sr-only">
+ {status().message}
+ </span>
+ }
+ >
+ {(label) => (
- <p
- data-workload-disk-read-status
- class={`mt-0.5 text-center text-[10px] leading-none ${
- status().needsAction ? 'text-amber-700 dark:text-amber-300' : 'text-muted'
- }`}
- title={status().message}
- >
- <span aria-hidden="true">{label()}</span>
- <span class="sr-only">{status().message}</span>
- </p>
++ <WorkloadReadingStatus
++ metric="Disk"
++ guestId={guestId()}
++ guestName={props.guest.name}
++ label={label()}
++ message={status().message}
++ needsAction={status().needsAction}
++ />
+ )}
+ </Show>
)}
</Show>
</td>
diff --cc frontend-modern/src/components/Workloads/NodeDrawerOverview.tsx
index 4f7912d10c,56cc5031f0..e8732517e7
--- a/frontend-modern/src/components/Workloads/NodeDrawerOverview.tsx
+++ b/frontend-modern/src/components/Workloads/NodeDrawerOverview.tsx
@@@ -405,43 -417,45 +412,42 @@@ export function NodeDrawerOverview(prop
</Show>
);
- // Inventory may move into Details, but denied-update guidance stays visible
- // and owned by the drawer so readings do not recreate an open help dialog.
- const overviewSections = () => {
- const primaryTemperature = getCpuTemperature(props.node.temperature);
- const updates = updateEvidence();
- const temperatureClass =
- typeof primaryTemperature === 'number'
- ? getTemperatureTextClass(primaryTemperature, props.temperatureThresholds)
- : '';
- return compactDetailSections([
- {
- label: 'Summary',
- rows: compactDetailRows([
- makeDetailRow('Platform', versionLabel() ? `PVE ${versionLabel()}` : null),
- makeDetailRow(
- 'Pulse coverage',
- linkedAgentId() ? `Agent ${stripAgentPrefix(linkedAgentId())}` : 'PVE API only',
- { wrap: true },
- ),
- updates
- ? makeDetailRow('Updates', updates.value, {
- tone: updates.tone,
- title: updates.title,
- wrap: true,
- })
- : null,
- typeof primaryTemperature === 'number' &&
- (temperatureClass.includes('yellow') || temperatureClass.includes('red'))
- ? makeDetailRow('Temperature', formatTemperature(primaryTemperature), {
- tone: temperatureClass.includes('red') ? 'danger' : 'warning',
- })
- : null,
- ]),
- },
- ]);
+ // The drawer owns the interactive help across reading and age updates.
+ const summarySection: DetailSection = {
+ label: 'Summary',
+ get rows() {
+ const primaryTemperature = props.node.cpuTemperature;
+ const updates = updateEvidence();
+ const temperatureClass =
+ typeof primaryTemperature === 'number'
+ ? getTemperatureTextClass(primaryTemperature, props.temperatureThresholds)
+ : '';
+ return compactDetailRows([
+ makeDetailRow('Platform', versionLabel() ? `PVE ${versionLabel()}` : null),
+ makeDetailRow(
+ 'Pulse coverage',
+ linkedAgentId() ? `Agent ${stripAgentPrefix(linkedAgentId())}` : 'PVE API only',
+ { wrap: true },
+ ),
+ updates
+ ? makeDetailRow('Updates', updates.value, {
+ tone: updates.tone,
+ title: updates.title,
+ wrap: true,
+ })
+ : null,
+ typeof primaryTemperature === 'number' &&
+ (temperatureClass.includes('yellow') || temperatureClass.includes('red'))
+ ? makeDetailRow('Temperature', formatTemperature(primaryTemperature), {
+ tone: temperatureClass.includes('red') ? 'danger' : 'warning',
+ })
+ : null,
+ ]);
+ },
- get footerContent() {
- return updateEvidence()?.helpContentId ? updateAccessGuidance : undefined;
- },
};
+ const overviewSections = () => [summarySection];
+
const exceptionRows = createMemo(() =>
collectDrawerExceptionRows([...overviewSections(), ...technicalSections()]),
);
diff --cc frontend-modern/src/utils/memoryObservation.ts
index a497e10ecc,9646c54211..4fb8b8942e
--- a/frontend-modern/src/utils/memoryObservation.ts
+++ b/frontend-modern/src/utils/memoryObservation.ts
@@@ -188,14 -180,27 +188,31 @@@ export const getMemoryObservationPresen
: 'Unknown source';
const time = observed ? `Observed: ${observed}.` : 'Observation time unknown.';
const cacheNote = mayIncludeCache ? getCacheNote(options.guestKind) : undefined;
+ if (state === 'unavailable') {
+ // No number is shown, so say why when the producer knows (the guest is
+ // off) and otherwise name only what is known, never "Unknown source".
+ const poweredOff = observation?.source === 'powered-off';
+ const knownSource = source !== 'Unknown source';
+ return {
+ state,
+ summary: poweredOff
+ ? 'Unavailable · guest powered off'
+ : `Unavailable${knownSource ? ` · ${source}` : ''}${observed ? ` · ${observed}` : ''}`,
+ // Consumers prefix their own metric name ("Memory reading: ...").
+ message: poweredOff
+ ? 'Unavailable while the guest is powered off.'
+ : `Unavailable.${knownSource ? ` Source: ${source}.` : ''}${observed ? ` ${time}` : ''}`,
+ mayIncludeCache,
+ };
+ }
+ const sourceStatus =
- state !== 'unavailable' && options.agentStale && observation?.source === 'agent'
++ options.agentStale && observation?.source === 'agent'
+ ? ' The Pulse Agent that supplied this reading stopped reporting.'
+ : '';
return {
state,
- summary: `${label} · ${source}${mayIncludeCache ? ' (may include cache)' : ''}${observed ? ` · ${observed}` : ' · time unknown'}`,
- message: `${label}. Source: ${source}. ${time}${state === 'last-known' || state === 'unknown' ? ' Not a current measurement.' : ''}${cacheNote ? ` ${cacheNote}` : ''}`,
+ summary: `${label} · ${source}${sourceStatus ? ' (stopped reporting)' : ''}${mayIncludeCache ? ' (may include cache)' : ''}${observed ? ` · ${observed}` : ' · time unknown'}`,
+ message: `${label}. Source: ${source}. ${time}${state === 'last-known' || state === 'unknown' ? ' Not a current measurement.' : ''}${sourceStatus}${cacheNote ? ` ${cacheNote}` : ''}`,
mayIncludeCache,
...(cacheNote ? { cacheNote } : {}),
};