Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Open drawer History on the week below the 24h trend cards

rcourtman921ebceaa973
diff --git a/docs/release-control/v6/internal/subsystems/performance-and-scalability.md b/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
index 24fa10a6fd..75ec05834f 100644
--- a/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
+++ b/docs/release-control/v6/internal/subsystems/performance-and-scalability.md
@@ -2890,7 +2890,12 @@ rather than as a `Tags` detail section. The Overview's 24h trend cards
(`DrawerTrendCards.tsx`, lazy-loaded out of the WorkloadsSurface chunk) and
the History tab read one query from `guestDrawerHistoryQuery.ts` with one cache
key, and each mounts only while its tab is visible: the node drawer's History
-no longer stays mounted and polling while hidden.
+no longer stays mounted and polling while hidden. Because those cards already
+cover the last 24 hours, the guest and node drawers open History on
+`TRENDED_DRAWER_HISTORY_DEFAULT_RANGE` (7 days, within the free plan's
+retention) rather than repeating them; a 24h History selection reuses the
+cards' cached read. Drawers without trend cards (Docker host, resource
+detail) keep the 24h `GUEST_DRAWER_HISTORY_DEFAULT_RANGE`.
Panel width alone does not make mount paths readable. Filesystem disk rows must
opt into the shared `layout: 'stacked'` presentation so their full mount path
wraps above usage and progress at desktop and phone widths. Shared-prefix paths
diff --git a/frontend-modern/browser-verification/35be0a628ecb3f94.json b/frontend-modern/browser-verification/35be0a628ecb3f94.json
new file mode 100644
index 0000000000..b8df4d1752
--- /dev/null
+++ b/frontend-modern/browser-verification/35be0a628ecb3f94.json
@@ -0,0 +1,42 @@
+{
+ "version": 1,
+ "base_sha": "0a44d276db4bdb53c7187f6074ee4b005c1d4872",
+ "verified_at": "2026-10-13T14:06:59Z",
+ "result": "passed",
+ "changed_paths": [
+ "frontend-modern/src/components/Workloads/DrawerTrendCards.tsx",
+ "frontend-modern/src/components/Workloads/NodeDrawer.tsx",
+ "frontend-modern/src/components/Workloads/guestDrawerHistoryQuery.ts",
+ "frontend-modern/src/components/Workloads/guestDrawerModel.ts",
+ "frontend-modern/src/components/Workloads/useGuestDrawerState.ts"
+ ],
+ "content_sha256": {
+ "frontend-modern/src/components/Workloads/DrawerTrendCards.tsx": "4761f86943587f997b99fc5be572f24038003926123702722d4d63dd68e6bd2f",
+ "frontend-modern/src/components/Workloads/NodeDrawer.tsx": "236e7520d3461e36a8223e4c3abca6c09b4a359796c236271501fba7e375e5c2",
+ "frontend-modern/src/components/Workloads/guestDrawerHistoryQuery.ts": "480828c88b3a7a957d9a908f125324ca301ba586d2f0fe21e00c6ce16717b4d7",
+ "frontend-modern/src/components/Workloads/guestDrawerModel.ts": "5b2692573a15459652a4feaea31703eb22af3056ed599a551d1a5e23577c5639",
+ "frontend-modern/src/components/Workloads/useGuestDrawerState.ts": "93cf7b37056e5397704106b2edb65441fec75ace95ef9c9b410c4e8bb4427ccb"
+ },
+ "routes": [
+ "/proxmox/overview"
+ ],
+ "viewports": [
+ {
+ "width": 1280,
+ "height": 800
+ },
+ {
+ "width": 390,
+ "height": 844
+ }
+ ],
+ "states": [
+ "private preview: origin/main 0a44d276db plus these frontend files, built with the frontend embedded and run locally in mock mode with a seeded metrics store (demo auto sign-in)",
+ "guest artifact-cache-310 and node Analytics A: Overview trend cards render; History tab opens with the range control on 7 days and three or four panels across a 7-day axis (mock history only spans about a day, so it fills the right end)",
+ "390px phone: node History at 7 days, no element extends past the viewport, page scrollWidth equals the viewport"
+ ],
+ "interactions": [
+ "expanded the guest, opened History: metrics-store reads were range=24h (Overview cards) then range=7d (History), range control value 7d",
+ "collapsed it, expanded the node, opened History: reads 24h then 7d, range control value 7d"
+ ]
+}
diff --git a/frontend-modern/src/components/Workloads/DrawerTrendCards.tsx b/frontend-modern/src/components/Workloads/DrawerTrendCards.tsx
index 6686055301..e60832f4fb 100644
--- a/frontend-modern/src/components/Workloads/DrawerTrendCards.tsx
+++ b/frontend-modern/src/components/Workloads/DrawerTrendCards.tsx
@@ -4,7 +4,7 @@ import type { AggregatedMetricPoint } from '@/api/charts';
import { formatHistoryChartTooltipValue } from '@/components/shared/historyChartModel';
import {
- GUEST_DRAWER_HISTORY_DEFAULT_RANGE,
+ DRAWER_TREND_RANGE,
getGuestDrawerHistoryScale,
normalizeGuestDrawerHistoryPoints,
type GuestDrawerHistoryDeferredMetric,
@@ -89,7 +89,7 @@ const valueToneClass = (severity: DrawerTrendCardConfig['alertSeverity']): strin
const DrawerTrendCards: Component<DrawerTrendCardsProps> = (props) => {
const source = createGuestDrawerHistorySource(
() => props.target,
- () => GUEST_DRAWER_HISTORY_DEFAULT_RANGE,
+ () => DRAWER_TREND_RANGE,
() => props.enabled,
);
const query = createGuestDrawerHistoryQuery(source);
diff --git a/frontend-modern/src/components/Workloads/GuestDrawer.test.tsx b/frontend-modern/src/components/Workloads/GuestDrawer.test.tsx
index ab4891ad26..2a6e0f9be8 100644
--- a/frontend-modern/src/components/Workloads/GuestDrawer.test.tsx
+++ b/frontend-modern/src/components/Workloads/GuestDrawer.test.tsx
@@ -267,7 +267,7 @@ describe('GuestDrawer', () => {
expect(chartsApiMocks.getMetricsHistory.mock.calls[0][0]).toMatchObject({
resourceType: 'vm',
resourceId: 'inst1:node1:100',
- range: '24h',
+ range: '7d',
maxPoints: 240,
});
chartsApiMocks.getMetricsHistory.mockResolvedValue({
@@ -389,7 +389,7 @@ describe('GuestDrawer', () => {
expect(request).toMatchObject({
resourceType: 'vm',
resourceId: 'inst1:node1:100',
- range: '24h',
+ range: '7d',
});
}
});
@@ -617,7 +617,7 @@ describe('GuestDrawer', () => {
expect.objectContaining({
resourceType: 'vm',
resourceId: 'inst1:node1:100',
- range: '24h',
+ range: '7d',
}),
);
});
diff --git a/frontend-modern/src/components/Workloads/NodeDrawer.test.tsx b/frontend-modern/src/components/Workloads/NodeDrawer.test.tsx
index aa10444ca8..34f297f84b 100644
--- a/frontend-modern/src/components/Workloads/NodeDrawer.test.tsx
+++ b/frontend-modern/src/components/Workloads/NodeDrawer.test.tsx
@@ -324,7 +324,7 @@ describe('NodeDrawer', () => {
expect.objectContaining({
resourceType: 'node',
resourceId: 'cluster-pve-native',
- range: '24h',
+ range: '7d',
}),
),
);
@@ -351,7 +351,7 @@ describe('NodeDrawer', () => {
expect.objectContaining({
resourceType: 'node',
resourceId: 'homelab-pve-node-1',
- range: '24h',
+ range: '7d',
}),
);
});
@@ -380,7 +380,7 @@ describe('NodeDrawer', () => {
expect.objectContaining({
resourceType: 'agent',
resourceId: 'pve-node-1',
- range: '24h',
+ range: '7d',
}),
);
});
@@ -487,6 +487,19 @@ describe('NodeDrawer Overview trends', () => {
expect(within(disk).getByText('—')).toBeInTheDocument();
});
+ it('opens History on the week, since the Overview cards already cover 24 hours', async () => {
+ render(() => <NodeDrawer node={makeNode()} />);
+ await screen.findByTestId('drawer-trend-card-cpu');
+ fireEvent.click(screen.getByRole('tab', { name: 'History' }));
+ await waitFor(() =>
+ expect(chartsApiMocks.getMetricsHistory.mock.calls.map(([params]) => params.range)).toEqual([
+ '24h',
+ '7d',
+ ]),
+ );
+ expect(screen.getByTestId('guest-history-range-control')).toHaveValue('7d');
+ });
+
it('reads the 24h trend once while Overview shows and mounts History only on demand', async () => {
render(() => <NodeDrawer node={makeNode()} />);
await screen.findByTestId('drawer-trend-card-cpu');
diff --git a/frontend-modern/src/components/Workloads/NodeDrawer.tsx b/frontend-modern/src/components/Workloads/NodeDrawer.tsx
index 8419c79414..2a10007705 100644
--- a/frontend-modern/src/components/Workloads/NodeDrawer.tsx
+++ b/frontend-modern/src/components/Workloads/NodeDrawer.tsx
@@ -13,7 +13,7 @@ import { getNodeDisplayName } from '@/utils/nodes';
import { getSimpleStatusIndicator } from '@/utils/status';
import { GuestDrawerHistory, GuestDrawerHistoryRangeSelect } from './GuestDrawerHistory';
-import { GUEST_DRAWER_HISTORY_DEFAULT_RANGE } from './guestDrawerModel';
+import { TRENDED_DRAWER_HISTORY_DEFAULT_RANGE } from './guestDrawerModel';
import { NodeDrawerOverview } from './NodeDrawerOverview';
import {
getNodeDrawerCurrentMetrics,
@@ -39,7 +39,7 @@ type NodeDrawerTab = 'overview' | 'history' | 'manage';
export const NodeDrawer: Component<NodeDrawerProps> = (props) => {
const [activeTab, setActiveTab] = createSignal<NodeDrawerTab>('overview');
const [historyRange, setHistoryRange] = createSignal<HistoryTimeRange>(
- GUEST_DRAWER_HISTORY_DEFAULT_RANGE,
+ TRENDED_DRAWER_HISTORY_DEFAULT_RANGE,
);
const alertsActivation = useAlertsActivation();
diff --git a/frontend-modern/src/components/Workloads/__tests__/useWorkloadSelectionState.test.ts b/frontend-modern/src/components/Workloads/__tests__/useWorkloadSelectionState.test.ts
index 23645edf1f..6f344eebe2 100644
--- a/frontend-modern/src/components/Workloads/__tests__/useWorkloadSelectionState.test.ts
+++ b/frontend-modern/src/components/Workloads/__tests__/useWorkloadSelectionState.test.ts
@@ -540,7 +540,7 @@ describe('useWorkloadSelectionState', () => {
expect(result.selectedGuestDrawerState.historyRange()).toBe('12h');
result.setSelectedGuestId('independent-clone');
expect(result.selectedGuestDrawerState.activeTab()).toBe('overview');
- expect(result.selectedGuestDrawerState.historyRange()).toBe('24h');
+ expect(result.selectedGuestDrawerState.historyRange()).toBe('7d');
result.selectedGuestDrawerState.setActiveTab('manage');
result.clearPinnedSummaryScope();
expect(result.selectedGuestDrawerState.activeTab()).toBe('overview');
diff --git a/frontend-modern/src/components/Workloads/guestDrawerHistoryQuery.ts b/frontend-modern/src/components/Workloads/guestDrawerHistoryQuery.ts
index 05a8068735..dddfd10ede 100644
--- a/frontend-modern/src/components/Workloads/guestDrawerHistoryQuery.ts
+++ b/frontend-modern/src/components/Workloads/guestDrawerHistoryQuery.ts
@@ -80,8 +80,8 @@ export const createGuestDrawerHistorySource = (
);
// The drawer's Overview trends and its History tab read one resource's
-// metrics-store history through this query. The shared cache key lets the
-// History tab open on the Overview's 24h read instead of starting another.
+// metrics-store history through this query. The shared cache key lets a 24h
+// History view reuse the Overview's read instead of starting another.
export const createGuestDrawerHistoryQuery = (
source: Accessor<GuestDrawerHistoryQueryKey | null>,
) =>
diff --git a/frontend-modern/src/components/Workloads/guestDrawerModel.ts b/frontend-modern/src/components/Workloads/guestDrawerModel.ts
index 9bd1305996..c54a43f1f2 100644
--- a/frontend-modern/src/components/Workloads/guestDrawerModel.ts
+++ b/frontend-modern/src/components/Workloads/guestDrawerModel.ts
@@ -195,6 +195,14 @@ export const getGuestDrawerCurrentMetrics = (guest: Guest): Record<string, numbe
export const GUEST_DRAWER_HISTORY_DEFAULT_RANGE: HistoryTimeRange = '24h';
+// The Overview's trend cards cover the last 24 hours.
+export const DRAWER_TREND_RANGE: HistoryTimeRange = '24h';
+
+// Drawers whose Overview already shows those 24h trend cards open History on
+// the week, so the tab adds context instead of repeating them. The free plan
+// keeps 7 days, so this range is never locked.
+export const TRENDED_DRAWER_HISTORY_DEFAULT_RANGE: HistoryTimeRange = '7d';
+
export const GUEST_DRAWER_HISTORY_GROUPS: GuestDrawerHistoryGroupConfig[] = [
{
id: 'utilization',
diff --git a/frontend-modern/src/components/Workloads/useGuestDrawerState.ts b/frontend-modern/src/components/Workloads/useGuestDrawerState.ts
index 0aa0205914..30f9086c39 100644
--- a/frontend-modern/src/components/Workloads/useGuestDrawerState.ts
+++ b/frontend-modern/src/components/Workloads/useGuestDrawerState.ts
@@ -25,7 +25,7 @@ import {
hasGuestDrawerFilesystemDetails,
hasGuestDrawerOsInfo,
normalizeGuestDrawerTags,
- GUEST_DRAWER_HISTORY_DEFAULT_RANGE,
+ TRENDED_DRAWER_HISTORY_DEFAULT_RANGE,
type GuestDrawerViewState,
type GuestDrawerProps,
type GuestDrawerTab,
@@ -39,7 +39,7 @@ import {
export function createGuestDrawerViewState(): GuestDrawerViewState {
const [activeTab, setActiveTab] = createSignal<GuestDrawerTab>('overview');
const [historyRange, setHistoryRange] = createSignal<HistoryTimeRange>(
- GUEST_DRAWER_HISTORY_DEFAULT_RANGE,
+ TRENDED_DRAWER_HISTORY_DEFAULT_RANGE,
);
return {
activeTab,
@@ -48,7 +48,7 @@ export function createGuestDrawerViewState(): GuestDrawerViewState {
setHistoryRange,
reset: () => {
setActiveTab('overview');
- setHistoryRange(GUEST_DRAWER_HISTORY_DEFAULT_RANGE);
+ setHistoryRange(TRENDED_DRAWER_HISTORY_DEFAULT_RANGE);
},
};
}