Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Describe service recovery without claiming binary rollback

pulse-triage[bot]9225b8b8ac01
diff --git a/docs/release-control/v6/internal/subsystems/deployment-installability.md b/docs/release-control/v6/internal/subsystems/deployment-installability.md
index 797494b49f..bf33acde6c 100644
--- a/docs/release-control/v6/internal/subsystems/deployment-installability.md
+++ b/docs/release-control/v6/internal/subsystems/deployment-installability.md
@@ -45,7 +45,9 @@ between the two directory renames while the server is stopped.
Ordinary preparation failures and successful bundle restoration can use only
the existing prior-active recovery-start path. The binary at the replacement
destination has already changed; starting the existing unit is not a binary
-rollback or proof of its running executable's identity. Configuration, keys
+rollback or proof of its running executable's identity. Recovery messages
+must not claim that the previous binary was restored;
+messages report only the observed service liveness. Configuration, keys
and identity are not restored or deleted, and the install still returns failure.
Native recovery, sustained health, full-runtime rollback and historical stopped
updates remain separate.
diff --git a/install.sh b/install.sh
index 923a36e4c5..a39b633f91 100644
--- a/install.sh
+++ b/install.sh
@@ -830,9 +830,9 @@ recover_pulse_after_failed_replacement() {
[[ "$PULSE_WAS_ACTIVE" == "true" ]] || return 0
if safe_systemctl start "$service_name" && wait_for_service_active "$service_name" 20; then
PULSE_WAS_ACTIVE="false"
- print_info "Previous Pulse binary is running again; the update failed"
+ print_info "Pulse service is running again; the update failed"
else
- print_error "The update failed and the previous Pulse service could not be confirmed running. Check systemctl status $service_name before retrying."
+ print_error "The update failed and the Pulse service could not be confirmed running. Check systemctl status $service_name before retrying."
return 1
fi
}
diff --git a/scripts/installtests/root_install_sh_test.go b/scripts/installtests/root_install_sh_test.go
index 35e7c7b7e0..82a4280ca9 100644
--- a/scripts/installtests/root_install_sh_test.go
+++ b/scripts/installtests/root_install_sh_test.go
@@ -1522,6 +1522,7 @@ func TestRootInstallAgentScriptPublicationPreservesPreviousBundle(t *testing.T)
"test_success_publishes_scripts_and_both_sidecars_preserving_other_files",
"test_unsigned_source_scripts_do_not_inherit_stale_release_sidecars",
"test_archive_and_source_consumers_fail_and_only_recover_prior_active_service",
+ "test_recovery_message_does_not_claim_previous_binary",
"test_uncertain_bundle_restore_does_not_restart_the_server",
"test_every_main_consumer_stops_before_markers_or_completion",
"test_archive_source_and_main_consumers_complete_with_a_whole_bundle",
diff --git a/scripts/tests/test_server_installer_stop.py b/scripts/tests/test_server_installer_stop.py
index 2435b64c02..83f8608bb0 100644
--- a/scripts/tests/test_server_installer_stop.py
+++ b/scripts/tests/test_server_installer_stop.py
@@ -313,7 +313,7 @@ class ServerInstallerStopTest(unittest.TestCase):
self.assertNotIn("SCRIPTS", observation["calls"])
if state == "active":
if fault == "rename":
- self.assertIn("Previous Pulse binary is running again; the update failed", result.stdout)
+ self.assertIn("Pulse service is running again; the update failed", result.stdout)
else:
self.assertIn("could not be confirmed running", result.stderr)
self.assertEqual(observation["stage_paths"], [])
diff --git a/scripts/tests/test_server_script_publication.py b/scripts/tests/test_server_script_publication.py
index cfb252c4ad..4ec720aaf4 100644
--- a/scripts/tests/test_server_script_publication.py
+++ b/scripts/tests/test_server_script_publication.py
@@ -237,6 +237,7 @@ class ServerScriptPublication(unittest.TestCase):
events = (f / "events").read_text().splitlines() if (f / "events").exists() else []
return dict(result=result, original=original, contents=contents, modes=modes,
stages=list(install.glob(".pulse-scripts-*")), retained=retained,
+ installed_binary=(install / "bin/pulse").read_bytes(),
events=events, restarted=(f / "restarted").exists())
def test_preparation_failures_preserve_the_complete_old_bundle(self):
@@ -326,6 +327,17 @@ class ServerScriptPublication(unittest.TestCase):
self.assertNotIn("Version verified:", e["result"].stdout)
self.assertNotIn("Successfully built and installed", e["result"].stdout)
+ def test_recovery_message_does_not_claim_previous_binary(self):
+ for flow in ("archive", "source"):
+ with self.subTest(flow=flow):
+ e = self.exercise("copy", flow)
+ self.assertNotEqual(e["result"].returncode, 0)
+ self.assertEqual(e["contents"], e["original"])
+ self.assertEqual(e["installed_binary"], b"#!/bin/sh\necho 'Pulse v6.6.0'\n")
+ self.assertTrue(e["restarted"])
+ self.assertIn("Pulse service is running again; the update failed", e["result"].stdout)
+ self.assertNotIn("Previous Pulse binary", e["result"].stdout)
+
def test_uncertain_bundle_restore_does_not_restart_the_server(self):
for flow in ("archive", "source"):
for fault in ("rollback", "conflict", "reserve-conflict"):