Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Require reviewed snapshots for mechanical patch dispatch

pulse-triage[bot]926ce8c45cd4
diff --git a/scripts/release_control/release_snapshot.py b/scripts/release_control/release_snapshot.py
index 8af5c72cb9..79c8c6c236 100644
--- a/scripts/release_control/release_snapshot.py
+++ b/scripts/release_control/release_snapshot.py
@@ -41,6 +41,11 @@ def source_branch(ref: str, requested: str, pull_request: str) -> str:
raise ValueError("snapshot provenance inputs require a reserved release-candidate or release-dispatch ref")
if not SOURCE_BRANCH.fullmatch(branch):
raise ValueError("release dispatch is outside a governed source branch")
+ patch = re.fullmatch(r"release/v(\d+)\.(\d+)\.([1-9]\d*)", branch)
+ if patch and tuple(map(int, patch.groups())) >= (6, 5, 1):
+ # A new patch target is not protected main. Its execution must identify
+ # the reviewed immutable preparation, not just a caller-controlled ref.
+ raise ValueError("mechanical patches require a reviewed immutable snapshot")
return branch
diff --git a/scripts/release_control/release_snapshot_test.py b/scripts/release_control/release_snapshot_test.py
index 73989c4f7d..63d550f5c9 100644
--- a/scripts/release_control/release_snapshot_test.py
+++ b/scripts/release_control/release_snapshot_test.py
@@ -72,6 +72,10 @@ class SnapshotIdentityTest(unittest.TestCase):
ref = 'refs/heads/release-dispatch/v6.6.1-rc.1-stamp'
branch = 'release/v6.6.1'
self.assertEqual(branch, snapshot.source_branch(ref, branch, '42'))
+ with self.assertRaisesRegex(ValueError, 'reviewed immutable snapshot'):
+ snapshot.source_branch('refs/heads/' + branch, '', '')
+ # Preserve direct dispatch on pre-train historical source lines.
+ self.assertEqual('release/v6.3.2', snapshot.source_branch('refs/heads/release/v6.3.2', '', ''))
pr = deepcopy(self.pr)
pr['head']['ref'] = 'release-candidate/v6.6.1-rc.1-stamp'
pr['base']['ref'] = branch