Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Name each time window on the Backup jobs card where it is shown

rcourtman9563a1b3bc9c
diff --git a/docs/release-control/v6/internal/subsystems/frontend-primitives.md b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
index bc9b254354..c82b1057bd 100644
--- a/docs/release-control/v6/internal/subsystems/frontend-primitives.md
+++ b/docs/release-control/v6/internal/subsystems/frontend-primitives.md
@@ -639,6 +639,13 @@ Backup health reasons "No backup history" and "Backup source reported a
failure" become "Backup status unknown" and "Last backup failed"; each still
shares one 32px row with its count and bar at phone width.
+### Backup jobs header names the pills' window at every width (3 November 2026)
+
+`ProxmoxBackupJobsCard` drops the "14 days" title suffix and always labels the
+header pills with their window: "Last 24h" from `sm` up, "24h" below, so a
+375px header stays one 21px line with three pills. The incomplete-window tag
+reads "incomplete data".
+
### Backup jobs card composes the overview primitives (2 November 2026)
`ProxmoxBackupJobsCard` is a `TableCard` with a `TableCardHeader` strip, like
diff --git a/docs/release-control/v6/internal/subsystems/storage-recovery.md b/docs/release-control/v6/internal/subsystems/storage-recovery.md
index 0809d000f6..9a82b8be2b 100644
--- a/docs/release-control/v6/internal/subsystems/storage-recovery.md
+++ b/docs/release-control/v6/internal/subsystems/storage-recovery.md
@@ -5210,6 +5210,17 @@ and leaves the page where it is when the list already shows; clearing a filter
never scrolls. `ProxmoxBackupsTable.test.tsx` pins the section order and both
scroll cases.
+### Backup jobs names each time window where it is shown (3 November 2026)
+
+The card's title read "Backup jobs 14 days" while its outcome pills counted
+the last 24 hours, and the pills' "24h" prefix was hidden on phones, so the
+pills read as the chart's totals. The title is now "Backup jobs", the pills
+are prefixed "Last 24h" ("24h" on phones, keeping the header on one line),
+and the chart's own axis, first day to Today, gives its span. When Pulse did
+not see the whole last 24 hours the pills carry "incomplete data" (was
+"partial") with the hover "Pulse did not see the whole last 24 hours, so
+these counts may be low". Counts, windows and history states are unchanged.
+
### Backup jobs show 14 days of retained outcomes beside Backup health (2 November 2026)
A Backup jobs card answers "did last night's backups run, and is that
diff --git a/frontend-modern/browser-verification/7c94ad7944ee413d.json b/frontend-modern/browser-verification/7c94ad7944ee413d.json
new file mode 100644
index 0000000000..4ab9d74b6a
--- /dev/null
+++ b/frontend-modern/browser-verification/7c94ad7944ee413d.json
@@ -0,0 +1,35 @@
+{
+ "version": 1,
+ "base_sha": "8c248d45a0eca4037812c60cb9491125a0a846bd",
+ "verified_at": "2026-11-03T16:31:05Z",
+ "result": "passed",
+ "changed_paths": [
+ "frontend-modern/src/features/proxmox/ProxmoxBackupJobsCard.tsx"
+ ],
+ "content_sha256": {
+ "frontend-modern/src/features/proxmox/ProxmoxBackupJobsCard.tsx": "215c4f49cddafdf677ac89f96660e11f922bd85a0f1649103d79702d0bdf376d"
+ },
+ "routes": [
+ "/proxmox/backups",
+ "/proxmox/backups/coverage"
+ ],
+ "viewports": [
+ {
+ "width": 1024,
+ "height": 607
+ },
+ {
+ "width": 375,
+ "height": 812
+ }
+ ],
+ "states": [
+ "mock mode built from this change on pulse-dev: a complete last-24-hour window with ok, running and failed jobs and a 14-day chart",
+ "desktop and phone layouts, dark theme"
+ ],
+ "interactions": [
+ "at 1024px the card title reads BACKUP JOBS with no 14 days suffix; the header reads Last 24h 619 ok, 33 running, 35 failed on one 21px line; the chart axis reads Wed 21 Oct to Today",
+ "at 375x812 the header reads 24h 619 ok, 33 running, 35 failed on one 21px line with no horizontal overflow",
+ "the incomplete-window tag (incomplete data, with its hover) is not reachable in mock data; ProxmoxBackupJobsCard.test.tsx renders it from a partial last-24-hour payload"
+ ]
+}
diff --git a/frontend-modern/src/features/proxmox/ProxmoxBackupJobsCard.tsx b/frontend-modern/src/features/proxmox/ProxmoxBackupJobsCard.tsx
index 7c4f14f417..8d78087b7a 100644
--- a/frontend-modern/src/features/proxmox/ProxmoxBackupJobsCard.tsx
+++ b/frontend-modern/src/features/proxmox/ProxmoxBackupJobsCard.tsx
@@ -17,7 +17,9 @@ import {
// "Did last night's backups run, and is that normal?" in the platform
// overview's vocabulary: last-24-hour outcome pills in the header strip and
// one stacked bar per day for the last 14 days. Days Pulse did not fully
-// observe are outlined, never drawn as clean empty days.
+// observe are outlined, never drawn as clean empty days. Each window is named
+// where it is shown, so the pills never read as the chart's totals: the pills
+// say "Last 24h", and the chart's axis runs from its first day to Today.
type Outcome = keyof BackupJobsCounts;
@@ -102,12 +104,7 @@ export const ProxmoxBackupJobsCard: Component<{ jobs: BackupJobsPayload }> = (pr
return (
<TableCard class="flex h-full flex-col" data-backup-jobs={props.jobs.historyState}>
<TableCardHeader
- title={
- <span class="inline-flex items-center gap-2 whitespace-nowrap">
- Backup jobs
- <span class="hidden font-medium normal-case tracking-normal sm:inline">14 days</span>
- </span>
- }
+ title={<span class="whitespace-nowrap">Backup jobs</span>}
actions={
<Show
when={!unavailable()}
@@ -117,7 +114,11 @@ export const ProxmoxBackupJobsCard: Component<{ jobs: BackupJobsPayload }> = (pr
class="inline-flex flex-wrap items-center justify-end gap-1.5"
data-backup-jobs-last24h
>
- <span class="hidden text-[10px] font-medium text-muted sm:inline">24h</span>
+ {/* The window is named at every width; phones get the short form. */}
+ <span class="text-[10px] font-medium text-muted">
+ <span class="sm:hidden">24h</span>
+ <span class="hidden sm:inline">Last 24h</span>
+ </span>
<For each={pills()}>
{(outcome) => (
<span
@@ -138,9 +139,10 @@ export const ProxmoxBackupJobsCard: Component<{ jobs: BackupJobsPayload }> = (pr
<Show when={last().historyState !== 'complete'}>
<span
class="text-[10px] font-medium text-muted"
- title="Pulse did not observe the whole window"
+ title="Pulse did not see the whole last 24 hours, so these counts may be low"
+ data-backup-jobs-incomplete
>
- partial
+ incomplete data
</span>
</Show>
</span>
diff --git a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupJobsCard.test.tsx b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupJobsCard.test.tsx
index af81e8246a..5c90b8a608 100644
--- a/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupJobsCard.test.tsx
+++ b/frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupJobsCard.test.tsx
@@ -73,6 +73,32 @@ describe('ProxmoxBackupJobsCard', () => {
expect(items[0]).toHaveTextContent('no backups (not fully observed)');
});
+ it("names the pills' window, and only that window, in the header", () => {
+ const { container } = render(() => <ProxmoxBackupJobsCard jobs={payload()} />);
+ const header = container.querySelector('[data-backup-jobs-last24h]')!;
+ expect(header).toHaveTextContent(/^24hLast 24h/);
+ // The chart's span is on its axis; a "14 days" title beside the 24-hour
+ // pills read as if they were the chart's totals.
+ expect(container).not.toHaveTextContent('14 days');
+ expect(container.querySelector('[data-backup-jobs-incomplete]')).toBeNull();
+ });
+
+ it('says plainly when Pulse saw only part of the last 24 hours', () => {
+ const { container } = render(() => (
+ <ProxmoxBackupJobsCard
+ jobs={payload({
+ last24h: { historyState: 'partial', counts: counts(12), failures: [] },
+ })}
+ />
+ ));
+ const tag = container.querySelector('[data-backup-jobs-incomplete]');
+ expect(tag).toHaveTextContent(/^incomplete data$/);
+ expect(tag).toHaveAttribute(
+ 'title',
+ 'Pulse did not see the whole last 24 hours, so these counts may be low',
+ );
+ });
+
it('says so when no backup ran in the last 24 hours', () => {
const { container } = render(() => (
<ProxmoxBackupJobsCard