Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Reject malformed UTF-8 backup-lock evidence before guest reads

pulse-triage[bot]96653f81c4dd
diff --git a/pkg/proxmox/guest_agent_lock.go b/pkg/proxmox/guest_agent_lock.go
index f0e11e8c68..2a08867103 100644
--- a/pkg/proxmox/guest_agent_lock.go
+++ b/pkg/proxmox/guest_agent_lock.go
@@ -3,12 +3,18 @@ package proxmox
import (
"encoding/json"
"strings"
+ "unicode/utf8"
)
// guestAgentConfigLock accepts only one complete, unambiguous config envelope.
// In particular, encoding/json's last-key-wins and case-insensitive struct
// matching must not erase a backup lock. Ordinary config decoding is unchanged.
func guestAgentConfigLock(body []byte) (string, bool) {
+ // encoding/json replaces malformed UTF-8 within strings instead of rejecting
+ // it. A repaired config is not authoritative evidence of an absent lock.
+ if !utf8.Valid(body) {
+ return "", false
+ }
envelope, ok := guestAgentResponseFields(body, "data")
if !ok {
return "", false
diff --git a/pkg/proxmox/guest_agent_lock_evidence_test.go b/pkg/proxmox/guest_agent_lock_evidence_test.go
index 9231ea6cf6..23e29dec04 100644
--- a/pkg/proxmox/guest_agent_lock_evidence_test.go
+++ b/pkg/proxmox/guest_agent_lock_evidence_test.go
@@ -28,6 +28,11 @@ func TestGuestAgentLockEvidenceRejectsAmbiguity(t *testing.T) {
{"null-lock", `{"data":{"lock": null }}`},
{"number-lock", `{"data":{"lock":0}}`},
{"object-lock", `{"data":{"lock":{}}}`},
+ {"invalid-utf8-config-key", "{\"data\":{\"na\xffme\":\"fixture\"}}"},
+ {"invalid-utf8-config-value", "{\"data\":{\"name\":\"fixture\xff\"}}"},
+ {"invalid-utf8-lock-key", "{\"data\":{\"lo\xffck\":\"backup\"}}"},
+ {"invalid-utf8-nested-value", "{\"data\":{\"lock\":\"\",\"nested\":{\"name\":\"fixture\xff\"}}}"},
+ {"invalid-utf8-overlong", "{\"data\":{\"name\":\"fixture\xc0\xaf\"}}"},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
@@ -147,6 +152,8 @@ func TestGuestAgentLockEvidenceHealthyConfigAndSessionRecovery(t *testing.T) {
`{"data":{"lock":"","agent":1,"digest":"fixture","name":"fixture"}}`,
`{"data":{"lock":" ","description":"backup; lock","scsi0":"fixture:disk","tags":"backup;ha"}}`,
`{"data":{"\u006cock":"","nested":{"data":"fixture","lock":"backup"}}}`, // Only the actual operation lock is authoritative.
+ `{"data":{"name":"café-東京-🖥","description":"backup; lock"}}`,
+ `{"data":{"lock":"","name":"replacement-�"}}`, // A real U+FFFD is valid UTF-8, not malformed wire bytes.
} {
t.Run(fmt.Sprintf("config-%d", len(body)), func(t *testing.T) {
var configs, commands, authentications atomic.Int32